braintree 3.0.1 → 4.0.0

data/spec/unit/braintree/disbursement_spec.rb

@@ -28,18 +28,18 @@ describe Braintree::Disbursement do
         :exception_message => "invalid_account_number",
         :follow_up_action => "update",
         :retry => false,
-        :success => false
+        :success => false,
       )
 
       disbursement.inspect.should include('id: "123456"')
       disbursement.inspect.should include('amount: "100.0"')
       disbursement.inspect.should include('exception_message: "invalid_account_number"')
-      disbursement.inspect.should include('disbursement_date: 2013-04-10')
+      disbursement.inspect.should include("disbursement_date: 2013-04-10")
       disbursement.inspect.should include('follow_up_action: "update"')
-      disbursement.inspect.should include('merchant_account: #<Braintree::MerchantAccount: ')
+      disbursement.inspect.should include("merchant_account: #<Braintree::MerchantAccount: ")
       disbursement.inspect.should include('transaction_ids: ["sub_merchant_transaction"]')
-      disbursement.inspect.should include('retry: false')
-      disbursement.inspect.should include('success: false')
+      disbursement.inspect.should include("retry: false")
+      disbursement.inspect.should include("success: false")
     end
   end
 
@@ -56,7 +56,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => false,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == false
 
@@ -71,7 +71,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => true,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == true
     end

data/spec/unit/braintree/dispute_search_spec.rb

@@ -41,6 +41,7 @@ describe Braintree::DisputeSearch do
   end
 
   [
+    :chargeback_protection_level,
     :kind,
     :reason,
     :status,

data/spec/unit/braintree/dispute_spec.rb

@@ -46,7 +46,14 @@ describe Braintree::Dispute do
         :order_id => nil,
         :purchase_order_number => "po",
         :payment_instrument_subtype => "Visa",
-      }
+      },
+      :paypal_messages => [
+        {
+          :message => "message",
+          :sender => "seller",
+          :sent_at => Time.utc(2009, 3, 9, 10, 50, 39),
+        }
+      ]
     }
   end
 
@@ -137,13 +144,13 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: "GENERAL", document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: "GENERAL", document_id: "document_id"})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
@@ -151,7 +158,7 @@ describe Braintree::Dispute do
         Braintree::Http.stub(:new).and_return double.as_null_object
 
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: 3, document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: 3, document_id: "document_id"})
         end.to raise_error(ArgumentError)
       end
     end
@@ -200,31 +207,31 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", category: "", sequence_number: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {content: "a", category: "", sequence_number: 3})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if sequence_number is provided and not an integer" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { sequence_number: "abc" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {sequence_number: "abc"})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param tag is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { tag: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {tag: 3})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param category is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { category: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {category: 3})
         end.to raise_error(ArgumentError)
       end
     end
@@ -348,6 +355,16 @@ describe Braintree::Dispute do
       evidence2.url.should == nil
     end
 
+    it "converts paypal_messages hash into an array of Dispute::PayPalMessage objects" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.paypal_messages.length.should == 1
+      paypal_message_1 = dispute.paypal_messages.first
+      paypal_message_1.message.should == "message"
+      paypal_message_1.sender.should == "seller"
+      paypal_message_1.sent_at.should == Time.utc(2009, 3, 9, 10, 50, 39)
+    end
+
     it "handles nil evidence" do
       attributes.delete(:evidence)
 
@@ -356,6 +373,14 @@ describe Braintree::Dispute do
       dispute.evidence.should == nil
     end
 
+    it "handles nil paypal_messages" do
+      attributes.delete(:paypal_messages)
+
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.paypal_messages.should == nil
+    end
+
     it "sets the older webhook fields for backwards compatibility" do
       dispute = Braintree::Dispute._new(attributes)
 

data/spec/unit/braintree/error_result_spec.rb

@@ -10,7 +10,7 @@ describe Braintree::ErrorResult do
           :params => "params",
           :errors => {:errors => []},
           :extra => "is ignored",
-          :message => "foo bar"
+          :message => "foo bar",
         )
       end.to_not raise_error
     end
@@ -36,7 +36,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => {},
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should include("credit_card_verification: #<Braintree::CreditCardVerification status: ")
     end
@@ -47,7 +47,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("credit_card_verification")
     end
@@ -58,7 +58,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => {}
+        :transaction => {},
       )
       result.inspect.should include("transaction: #<Braintree::Transaction id: ")
     end
@@ -69,7 +69,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("transaction")
     end

data/spec/unit/braintree/errors_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::Errors do
   describe "for" do
     it "accesses errors for the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:level1).size.should == 1
       errors.for(:level1)[0].code.should == "code1"
@@ -12,7 +12,7 @@ describe Braintree::Errors do
 
     it "returns nil if there are no errors at the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:no_errors_here).should == nil
     end
@@ -21,7 +21,7 @@ describe Braintree::Errors do
   describe "inspect" do
     it "is better than the default inspect" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message]>"
     end
@@ -33,7 +33,7 @@ describe Braintree::Errors do
           :level2 => {
             :errors => [{:code => "code2", :attribute => "attr2", :message => "message2"}],
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2]>"
     end
@@ -48,7 +48,7 @@ describe Braintree::Errors do
               :errors => [{:code => "code3", :attribute => "attr3", :message => "message3"}],
             }
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2], level1/level2/level3:[(code3) message3]>"
     end
@@ -65,7 +65,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.map { |e| e.code }.sort.should == %w[1 2 3]
     end
@@ -74,7 +74,7 @@ describe Braintree::Errors do
   describe "size" do
     it "returns the number of validation errors at the first level if only has one level" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]},
       )
       errors.size.should == 1
     end
@@ -89,7 +89,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.size.should == 3
     end

data/spec/unit/braintree/http_spec.rb

@@ -67,7 +67,7 @@ END
         :proxy_address => "localhost",
         :proxy_port => 8080,
         :proxy_user => "user",
-        :proxy_pass => "test"
+        :proxy_pass => "test",
       )
 
       http = Braintree::Http.new(config)
@@ -75,7 +75,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, "user", "test").and_return(net_http_instance)
@@ -86,7 +86,7 @@ END
     it "accepts a partially specified proxy" do
       config = Braintree::Configuration.new(
         :proxy_address => "localhost",
-        :proxy_port => 8080
+        :proxy_port => 8080,
       )
 
       http = Braintree::Http.new(config)
@@ -94,7 +94,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, nil, nil).and_return(net_http_instance)
@@ -109,7 +109,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil).and_return(net_http_instance)

data/spec/unit/braintree/merchant_account_spec.rb

@@ -13,7 +13,7 @@ describe Braintree::MerchantAccount do
         nil,
         :id => "merchant_account",
         :status => "active",
-        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil}
+        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil},
       )
 
       master_merchant_account = "#<Braintree::MerchantAccount: id: \"master_merchant_account\", status: \"active\", master_merchant_account: nil>"

data/spec/unit/braintree/payment_method_nonce_details_payer_info_spec.rb

@@ -0,0 +1,31 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+
+describe Braintree::PaymentMethodNonceDetailsPayerInfo do
+  let(:payment_method_nonce_details_payer_info) {
+    Braintree::PaymentMethodNonceDetailsPayerInfo.new(
+      :billing_agreement_id => "billing-agreement-id",
+      :country_code => "US",
+      :email => "test@example.com",
+      :first_name => "First",
+      :last_name => "Last",
+      :payer_id => "payer-id",
+    )
+  }
+
+  describe "#initialize" do
+    it "sets attributes" do
+      payment_method_nonce_details_payer_info.billing_agreement_id.should == "billing-agreement-id"
+      payment_method_nonce_details_payer_info.country_code.should == "US"
+      payment_method_nonce_details_payer_info.email.should == "test@example.com"
+      payment_method_nonce_details_payer_info.first_name.should == "First"
+      payment_method_nonce_details_payer_info.last_name.should == "Last"
+      payment_method_nonce_details_payer_info.payer_id.should == "payer-id"
+    end
+  end
+
+  describe "inspect" do
+    it "prints the attributes" do
+      payment_method_nonce_details_payer_info.inspect.should == %(#<PaymentMethodNonceDetailsPayerInfo billing_agreement_id: \"billing-agreement-id\", country_code: \"US\", email: \"test@example.com\", first_name: \"First\", last_name: \"Last\", payer_id: \"payer-id\">)
+    end
+  end
+end

data/spec/unit/braintree/payment_method_nonce_details_spec.rb

@@ -0,0 +1,43 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+
+describe Braintree::PaymentMethodNonceDetails do
+  let(:payment_method_nonce_details) {
+    Braintree::PaymentMethodNonceDetails.new(
+      :bin => "bin",
+      :card_type => "American Express",
+      :expiration_month => "12",
+      :expiration_year => "2025",
+      :is_network_tokenized => true,
+      :last_two => "11",
+      :payer_info => {
+        :billing_agreement_id => "1234",
+        :country_code => "US",
+      },
+    )
+  }
+
+  describe "#initialize" do
+    it "sets attributes" do
+      payment_method_nonce_details.bin.should == "bin"
+      payment_method_nonce_details.card_type.should == "American Express"
+      payment_method_nonce_details.expiration_month.should == "12"
+      payment_method_nonce_details.expiration_year.should == "2025"
+      payment_method_nonce_details.is_network_tokenized.should == true
+      payment_method_nonce_details.last_two.should == "11"
+      payment_method_nonce_details.payer_info.billing_agreement_id.should == "1234"
+      payment_method_nonce_details.payer_info.country_code.should == "US"
+    end
+  end
+
+  describe "inspect" do
+    it "prints the attributes" do
+      payment_method_nonce_details.inspect.should == %(#<PaymentMethodNonceDetails bin: "bin", card_type: "American Express", expiration_month: "12", expiration_year: "2025", is_network_tokenized: true, last_two: "11", payer_info: #<PaymentMethodNonceDetailsPayerInfo billing_agreement_id: "1234", country_code: "US", email: nil, first_name: nil, last_name: nil, payer_id: nil>>)
+    end
+  end
+
+  describe "is_network_tokenized" do
+    it "is aliased to is_network_tokenized?" do
+      payment_method_nonce_details.is_network_tokenized?.should == true
+    end
+  end
+end

data/spec/unit/braintree/payment_method_spec.rb

@@ -28,7 +28,7 @@ describe Braintree::PaymentMethod do
   end
 
   describe "delete" do
-    let(:http_stub) { double('http_stub').as_null_object }
+    let(:http_stub) { double("http_stub").as_null_object }
     it "accepts revoke_all_grants option with value true" do
       Braintree::Http.stub(:new).and_return http_stub
       http_stub.should_receive(:delete).with("/merchants/integration_merchant_id/payment_methods/any/some_token?revoke_all_grants=true")

data/spec/unit/braintree/paypal_account_spec.rb

@@ -8,7 +8,7 @@ describe Braintree::PayPalAccount do
           :invalid_key => "bad stuff",
           :options => {
             :invalid_option => "bad option",
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: invalid_key, options[invalid_option]")
     end
@@ -17,7 +17,7 @@ describe Braintree::PayPalAccount do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::PayPalAccount.update("some_token", :invalid_key => 'val')
+        Braintree::PayPalAccount.update("some_token", :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end

data/spec/unit/braintree/resource_collection_spec.rb

@@ -5,7 +5,7 @@ describe "Braintree::ResourceCollection" do
     it "iterates over the elements, yielding to the block in pages" do
       values = %w(a b c d e)
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
-        ids.map {|id| values[id] }
+        ids.map { |id| values[id] }
       end
 
       count = 0
@@ -18,6 +18,35 @@ describe "Braintree::ResourceCollection" do
     end
   end
 
+  describe "#first" do
+    it "returns nil with no results" do
+      values = %w(a b c d e)
+      collection = Braintree::ResourceCollection.new(:search_results => {:ids => [], :page_size => 2}) do |ids|
+        ids.map { |id| values[id] }
+      end
+
+      collection.first.should == nil
+    end
+
+    context "with results" do
+      let(:collection) do
+        values = %w(a b c d e)
+
+        Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
+          ids.map { |id| values[id] }
+        end
+      end
+
+      it "returns the first occourence" do
+        collection.first.should == "a"
+      end
+
+      it "returns the first N occourences" do
+        collection.first(4).should == ["a","b","c","d"]
+      end
+    end
+  end
+
   describe "#ids" do
     it "returns a list of the resource collection ids" do
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2})