braintree 2.98.0 → 4.23.0

data/spec/integration/braintree/test/transaction_amounts_spec.rb

@@ -8,9 +8,9 @@ describe Braintree::Test::TransactionAmounts do
         :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "12/2012"
-        }
+        },
       )
-      transaction.status.should == Braintree::Transaction::Status::Authorized
+      expect(transaction.status).to eq(Braintree::Transaction::Status::Authorized)
     end
   end
 
@@ -21,9 +21,9 @@ describe Braintree::Test::TransactionAmounts do
         :credit_card => {
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_date => "12/2012"
-        }
+        },
       )
-      result.transaction.status.should == Braintree::Transaction::Status::ProcessorDeclined
+      expect(result.transaction.status).to eq(Braintree::Transaction::Status::ProcessorDeclined)
     end
   end
 end

data/spec/integration/braintree/test_transaction_spec.rb

@@ -9,14 +9,14 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
         :submit_for_settlement => true
-      }
+      },
       )
-      sale_result.success?.should == true
-      sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
+      expect(sale_result.success?).to eq(true)
+      expect(sale_result.transaction.status).to eq(Braintree::Transaction::Status::SubmittedForSettlement)
 
       settle_result = Braintree::TestTransaction.settle(sale_result.transaction.id)
-      settle_result.transaction.status.should == Braintree::Transaction::Status::Settled
-      settle_result.success?.should == true
+      expect(settle_result.transaction.status).to eq(Braintree::Transaction::Status::Settled)
+      expect(settle_result.success?).to eq(true)
     end
 
     it "changes transaction status to settlement_confirmed" do
@@ -25,14 +25,14 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
-      sale_result.success?.should == true
-      sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
+      expect(sale_result.success?).to eq(true)
+      expect(sale_result.transaction.status).to eq(Braintree::Transaction::Status::SubmittedForSettlement)
 
       settle_result = Braintree::TestTransaction.settlement_confirm(sale_result.transaction.id)
-      settle_result.transaction.status.should == Braintree::Transaction::Status::SettlementConfirmed
-      settle_result.success?.should == true
+      expect(settle_result.transaction.status).to eq(Braintree::Transaction::Status::SettlementConfirmed)
+      expect(settle_result.success?).to eq(true)
     end
 
     it "changes transaction status to settlement_declined" do
@@ -41,14 +41,14 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
-      sale_result.success?.should == true
-      sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
+      expect(sale_result.success?).to eq(true)
+      expect(sale_result.transaction.status).to eq(Braintree::Transaction::Status::SubmittedForSettlement)
 
       settle_result = Braintree::TestTransaction.settlement_decline(sale_result.transaction.id)
-      settle_result.transaction.status.should == Braintree::Transaction::Status::SettlementDeclined
-      settle_result.success?.should == true
+      expect(settle_result.transaction.status).to eq(Braintree::Transaction::Status::SettlementDeclined)
+      expect(settle_result.success?).to eq(true)
     end
 
     it "changes transaction status to settlement_pending" do
@@ -57,26 +57,26 @@ describe Braintree::TestTransaction do
         :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
         :options => {
           :submit_for_settlement => true
-        }
+        },
       )
-      sale_result.success?.should == true
-      sale_result.transaction.status.should == Braintree::Transaction::Status::SubmittedForSettlement
+      expect(sale_result.success?).to eq(true)
+      expect(sale_result.transaction.status).to eq(Braintree::Transaction::Status::SubmittedForSettlement)
 
       settle_result = Braintree::TestTransaction.settlement_pending(sale_result.transaction.id)
-      settle_result.transaction.status.should == Braintree::Transaction::Status::SettlementPending
-      settle_result.success?.should == true
+      expect(settle_result.transaction.status).to eq(Braintree::Transaction::Status::SettlementPending)
+      expect(settle_result.success?).to eq(true)
     end
 
     it "returns a validation error when invalid transition is specified" do
       sale_result = Braintree::Transaction.sale(
         :amount => "100",
-        :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa
+        :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
       )
-      sale_result.success?.should == true
+      expect(sale_result.success?).to eq(true)
 
       settle_result = Braintree::TestTransaction.settlement_decline(sale_result.transaction.id)
-      settle_result.success?.should be(false)
-      settle_result.errors.for(:transaction).on(:base).first.code.should == Braintree::ErrorCodes::Transaction::CannotSimulateTransactionSettlement
+      expect(settle_result.success?).to be(false)
+      expect(settle_result.errors.for(:transaction).on(:base).first.code).to eq(Braintree::ErrorCodes::Transaction::CannotSimulateTransactionSettlement)
     end
   end
 
@@ -97,10 +97,10 @@ describe Braintree::TestTransaction do
         in_prod do
           config = Braintree::Configuration.new(
             :environment => (original_env == :production ? :development : original_env),
-            :merchant_id => 'integration_merchant_id',
-            :public_key => 'integration_public_key',
-            :private_key => 'integration_private_key',
-            :logger => Logger.new(StringIO.new)
+            :merchant_id => "integration_merchant_id",
+            :public_key => "integration_public_key",
+            :private_key => "integration_private_key",
+            :logger => Logger.new(StringIO.new),
           )
 
           gateway = Braintree::Gateway.new(config)
@@ -110,7 +110,7 @@ describe Braintree::TestTransaction do
 
           sale_result = transaction_gateway.sale(
             :amount => "100",
-            :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa
+            :payment_method_nonce => Braintree::Test::Nonce::VisaCheckoutVisa,
           )
           testing_gateway.settle(sale_result.transaction.id)
         end

data/spec/integration/braintree/transaction_line_item_spec.rb

@@ -18,20 +18,26 @@ describe Braintree::TransactionLineItem do
             :kind => "debit",
             :unit_amount => "45.1232",
             :total_amount => "45.15",
+            :upc_code => "11223344556677889",
+            :upc_type => "UPC-A",
+            :image_url => "https://google.com/image.png",
           },
         ],
       )
-      result.success?.should == true
+      expect(result.success?).to eq(true)
       transaction = result.transaction
 
       line_items = Braintree::TransactionLineItem.find_all(transaction.id)
 
       line_item = line_items[0]
-      line_item.quantity.should == BigDecimal("1.0232")
-      line_item.name.should == "Name #1"
-      line_item.kind.should == "debit"
-      line_item.unit_amount.should == BigDecimal("45.1232")
-      line_item.total_amount.should == BigDecimal("45.15")
+      expect(line_item.quantity).to eq(BigDecimal("1.0232"))
+      expect(line_item.name).to eq("Name #1")
+      expect(line_item.kind).to eq("debit")
+      expect(line_item.unit_amount).to eq(BigDecimal("45.1232"))
+      expect(line_item.total_amount).to eq(BigDecimal("45.15"))
+      expect(line_item.upc_type).to eq("UPC-A")
+      expect(line_item.upc_code).to eq("11223344556677889")
+      expect(line_item.image_url).to eq("https://google.com/image.png")
     end
   end
 end