braintree 2.95.0 → 2.96.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6885baaa1cf0362ea29a6c57834122bfef5ef5e4f022527e7d8d25fa4c748b6
-  data.tar.gz: b2bff8e8cc234fcab9ee20a37c53f5977da827ab74b3634f4ac1e7f044423ca3
+  metadata.gz: 05a36d5ea5b0870293e17db6baa85393f97e0a8aa8ba495ee34ec2f30d64f29a
+  data.tar.gz: d7291802e13bfdecf5e3258b0f9cac7bb15654fd4f6249faf0e96444de55576e
 SHA512:
-  metadata.gz: f79c7a60e1eeb0ad4ae677d8402eb0aa1538f55d6a29e2b324acb0db6506b8ec43e04e32ca8a5b3de20ced19f383c99038435d9a1a525fad3d8cf2b7aeb5d6df
-  data.tar.gz: 109bbdea462fddac547448a411f1d99a020ef46833313608846cb1d04c49eca0aa508a4221ac044cde8bb8a03251dcdf26002050d1499b857fe83b90f74a3a03
+  metadata.gz: d5bee8dcbe48df9d0c752d150dd3c18ae3c4232a31aa3e850ac5ab1a8ef4a85f292515b96489dbf736a2bde1d4780bb1f5f1edfb4eeaeacde6b983e8c72d4825
+  data.tar.gz: 5065e4ad5cde4db02b5bfdee866425a8d837604ff50b69d4c1f721915e6483cec41ef8ff9e53f03c3ce2290d1e27f13a346c01bb9a277ffd0b179284ed4fba9d

data/lib/braintree.rb

@@ -76,6 +76,7 @@ require "braintree/ideal_payment"
 require "braintree/ideal_payment_gateway"
 require "braintree/transaction/ideal_payment_details"
 require "braintree/local_payment_completed"
+require "braintree/transaction/local_payment_details"
 require "braintree/merchant"
 require "braintree/merchant_gateway"
 require "braintree/merchant_account"

data/lib/braintree/gateway.rb

@@ -72,6 +72,8 @@ module Braintree
       UsBankAccountGateway.new(self)
     end
 
+    # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+    # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
     def ideal_payment
       IdealPaymentGateway.new(self)
     end

data/lib/braintree/ideal_payment.rb

@@ -1,4 +1,6 @@
 module Braintree
+  # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+  # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
   class IdealPayment
     include BaseModule
 

data/lib/braintree/ideal_payment_gateway.rb

@@ -1,4 +1,6 @@
 module Braintree
+  # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+  # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
   class IdealPaymentGateway
     def initialize(gateway)
       @gateway = gateway

data/lib/braintree/local_payment_completed.rb

@@ -4,9 +4,12 @@ module Braintree
 
     attr_reader :payment_id
     attr_reader :payer_id
+    attr_reader :payment_method_nonce
+    attr_reader :transaction
 
     def initialize(attributes) # :nodoc:
       set_instance_variables_from_hash(attributes)
+      @transaction = Transaction._new(Configuration.gateway, transaction)
     end
 
     class << self

data/lib/braintree/payment_instrument_type.rb

@@ -8,9 +8,9 @@ module Braintree
     AndroidPayCard = 'android_pay_card'
     VenmoAccount = 'venmo_account'
     UsBankAccount = 'us_bank_account'
-    IdealPayment = 'ideal_payment'
     VisaCheckoutCard = 'visa_checkout_card'
     MasterpassCard = 'masterpass_card'
     SamsungPayCard = 'samsung_pay_card'
+    LocalPayment = 'local_payment'
   end
 end

data/lib/braintree/paypal_account.rb

@@ -8,6 +8,7 @@ module Braintree
     attr_reader :email
     attr_reader :image_url
     attr_reader :payer_id
+    attr_reader :revoked_at
     attr_reader :subscriptions
     attr_reader :token
     attr_reader :updated_at

data/lib/braintree/test/nonce.rb

@@ -6,6 +6,7 @@ module Braintree
       PayPalOneTimePayment = "fake-paypal-one-time-nonce"
       PayPalFuturePayment = "fake-paypal-future-nonce"
       PayPalBillingAgreement = "fake-paypal-billing-agreement-nonce"
+      LocalPayment = "fake-local-payment-nonce"
       ApplePayVisa = "fake-apple-pay-visa-nonce"
       ApplePayMasterCard = "fake-apple-pay-mastercard-nonce"
       ApplePayAmEx = "fake-apple-pay-amex-nonce"
@@ -18,6 +19,7 @@ module Braintree
       AndroidPayAmEx = "fake-android-pay-amex-nonce"
       AmexExpressCheckout = "fake-amex-express-checkout-nonce"
       VenmoAccount = "fake-venmo-account-nonce"
+      VenmoAccountTokenIssuanceError = "fake-token-issuance-error-venmo-account-nonce"
       TransactableVisa = "fake-valid-visa-nonce"
       TransactableAmEx = "fake-valid-amex-nonce"
       TransactableMasterCard = "fake-valid-mastercard-nonce"

data/lib/braintree/transaction.rb

@@ -26,6 +26,7 @@ module Braintree
       Duplicate    = "duplicate"
       Fraud        = "fraud"
       ThreeDSecure = "three_d_secure"
+      TokenIssuance = "token_issuance"
       Unrecognized = "unrecognized"
     end
 
@@ -108,7 +109,10 @@ module Braintree
     attr_reader :facilitator_details
     attr_reader :gateway_rejection_reason
     attr_reader :id
+    # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+    # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
     attr_reader :ideal_payment_details
+    attr_reader :local_payment_details
     attr_reader :masterpass_card_details
     attr_reader :merchant_account_id
     attr_reader :network_transaction_id
@@ -282,6 +286,7 @@ module Braintree
       @status_history = attributes[:status_history] ? attributes[:status_history].map { |s| StatusDetails.new(s) } : []
       @tax_amount = Util.to_big_decimal(tax_amount)
       @descriptor = Descriptor.new(@descriptor)
+      @local_payment_details = LocalPaymentDetails.new(@local_payment)
       @paypal_details = PayPalDetails.new(@paypal)
       @apple_pay_details = ApplePayDetails.new(@apple_pay)
       @android_pay_details = AndroidPayDetails.new(@android_pay_card)

data/lib/braintree/transaction/android_pay_details.rb

@@ -15,6 +15,16 @@ module Braintree
       attr_reader :token
       attr_reader :virtual_card_last_4
       attr_reader :virtual_card_type
+      attr_reader :prepaid
+      attr_reader :healthcare
+      attr_reader :debit
+      attr_reader :durbin_regulated
+      attr_reader :commercial
+      attr_reader :payroll
+      attr_reader :issuing_bank
+      attr_reader :country_of_issuance
+      attr_reader :product_id
+      attr_reader :global_id
 
       def initialize(attributes)
         set_instance_variables_from_hash attributes unless attributes.nil?

data/lib/braintree/transaction/apple_pay_details.rb

@@ -12,6 +12,16 @@ module Braintree
       attr_reader :payment_instrument_name
       attr_reader :source_description
       attr_reader :token
+      attr_reader :prepaid
+      attr_reader :healthcare
+      attr_reader :debit
+      attr_reader :durbin_regulated
+      attr_reader :commercial
+      attr_reader :payroll
+      attr_reader :issuing_bank
+      attr_reader :country_of_issuance
+      attr_reader :product_id
+      attr_reader :global_id
 
       def initialize(attributes)
         set_instance_variables_from_hash attributes unless attributes.nil?

data/lib/braintree/transaction/ideal_payment_details.rb

@@ -1,4 +1,6 @@
 module Braintree
+  # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+  # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
   class Transaction
     class IdealPaymentDetails # :nodoc:
       include BaseModule

data/lib/braintree/transaction/local_payment_details.rb

@@ -0,0 +1,17 @@
+module Braintree
+  class Transaction
+    class LocalPaymentDetails
+      include BaseModule
+
+      attr_reader :custom_field
+      attr_reader :description
+      attr_reader :funding_source
+      attr_reader :payer_id
+      attr_reader :payment_id
+
+      def initialize(attributes)
+        set_instance_variables_from_hash attributes unless attributes.nil?
+      end
+    end
+  end
+end

data/lib/braintree/transaction/paypal_details.rb

@@ -9,14 +9,16 @@ module Braintree
       attr_reader :debug_id
       attr_reader :description
       attr_reader :image_url
-      attr_reader :payee_id
       attr_reader :payee_email
+      attr_reader :payee_id
       attr_reader :payer_email
       attr_reader :payer_first_name
       attr_reader :payer_id
       attr_reader :payer_last_name
       attr_reader :payer_status
       attr_reader :payment_id
+      attr_reader :refund_from_transaction_fee_amount
+      attr_reader :refund_from_transaction_fee_currency_iso_code
       attr_reader :refund_id
       attr_reader :seller_protection_status
       attr_reader :token

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 95
+    Minor = 96
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification.rb

@@ -33,6 +33,8 @@ module Braintree
 
       AccountUpdaterDailyReport = "account_updater_daily_report"
 
+      # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+      # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
       IdealPaymentComplete = "ideal_payment_complete"
       IdealPaymentFailed = "ideal_payment_failed"
 
@@ -46,6 +48,7 @@ module Braintree
       GrantorUpdatedGrantedPaymentMethod = "grantor_updated_granted_payment_method"
       RecipientUpdatedGrantedPaymentMethod = "recipient_updated_granted_payment_method"
       GrantedPaymentInstrumentRevoked = "granted_payment_instrument_revoked"
+      PaymentMethodRevokedByCustomer = "payment_method_revoked_by_customer"
 
       LocalPaymentCompleted = "local_payment_completed"
     end
@@ -91,7 +94,7 @@ module Braintree
       @connected_merchant_status_transitioned = ConnectedMerchantStatusTransitioned._new(@subject[:connected_merchant_status_transitioned]) if @subject.has_key?(:connected_merchant_status_transitioned)
       @connected_merchant_paypal_status_changed = ConnectedMerchantPayPalStatusChanged._new(@subject[:connected_merchant_paypal_status_changed]) if @subject.has_key?(:connected_merchant_paypal_status_changed)
       @granted_payment_instrument_update = GrantedPaymentInstrumentUpdate._new(@subject[:granted_payment_instrument_update]) if @subject.has_key?(:granted_payment_instrument_update)
-      @revoked_payment_method_metadata = RevokedPaymentMethodMetadata._new(gateway, @subject) if @kind == Kind::GrantedPaymentInstrumentRevoked
+      @revoked_payment_method_metadata = RevokedPaymentMethodMetadata._new(gateway, @subject) if [Kind::GrantedPaymentInstrumentRevoked, Kind::PaymentMethodRevokedByCustomer].include?(@kind)
       @local_payment_completed = LocalPaymentCompleted._new(@subject[:local_payment]) if @subject.has_key?(:local_payment)
     end
 

data/lib/braintree/webhook_testing_gateway.rb

@@ -72,8 +72,12 @@ module Braintree
         _auth_status_transitioned_sample_xml(id)
       when Braintree::WebhookNotification::Kind::ConnectedMerchantPayPalStatusChanged
         _auth_paypal_status_changed_sample_xml(id)
+        # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+        # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
       when Braintree::WebhookNotification::Kind::IdealPaymentComplete
         _ideal_payment_complete_sample_xml(id)
+        # NEXT_MAJOR_VERSION Remove this class as legacy Ideal has been removed/disabled in the Braintree Gateway
+        # DEPRECATED If you're looking to accept iDEAL as a payment method contact accounts@braintreepayments.com for a solution.
       when Braintree::WebhookNotification::Kind::IdealPaymentFailed
         _ideal_payment_failed_sample_xml(id)
       # NEXT_MAJOR_VERSION remove GrantedPaymentInstrumentUpdate
@@ -83,6 +87,8 @@ module Braintree
         _granted_payment_instrument_update_sample_xml(id)
       when Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod
         _granted_payment_instrument_update_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::PaymentMethodRevokedByCustomer
+        _payment_method_revoked_by_customer_sample_xml(id)
       when Braintree::WebhookNotification::Kind::LocalPaymentCompleted
         _local_payment_completed_sample_xml(id)
       else
@@ -669,11 +675,40 @@ module Braintree
       XML
     end
 
+    def _payment_method_revoked_by_customer_sample_xml(id)
+      <<-XML
+        <paypal-account>
+          <billing-agreement-id>a-billing-agreement-id</billing-agreement-id>
+          <created-at type="datetime">2019-01-01T12:00:00Z</created-at>
+          <customer-id>a-customer-id</customer-id>
+          <default type="boolean">true</default>
+          <email>name@email.com</email>
+          <global-id>cGF5bWVudG1ldGhvZF9jaDZieXNz</global-id>
+          <image-url>https://assets.braintreegateway.com/payment_method_logo/paypal.png?environment=test</image-url>
+          <subscriptions type="array"/>
+          <token>#{id}</token>
+          <updated-at type="datetime">2019-01-02T12:00:00Z</updated-at>
+          <is-channel-initiated nil="true"/>
+          <payer-id>a-payer-id</payer-id>
+          <payer-info nil="true"/>
+          <limited-use-order-id nil="true"/>
+          <revoked-at type="datetime">2019-01-02T12:00:00Z</revoked-at>
+        </paypal-account>
+      XML
+    end
+
     def _local_payment_completed_sample_xml(id)
       <<-XML
         <local-payment>
           <payment-id>PAY-XYZ123</payment-id>
           <payer-id>ABCPAYER</payer-id>
+          <payment-method-nonce>ee257d98-de40-47e8-96b3-a6954ea7a9a4</payment-method-nonce>
+          <transaction>
+            <id>#{id}</id>
+            <status>authorized</status>
+            <amount>49.99</amount>
+            <order-id>order4567</order-id>
+          </transaction>
         </local-payment>
       XML
     end

data/spec/integration/braintree/paypal_account_spec.rb

@@ -25,6 +25,7 @@ describe Braintree::PayPalAccount do
       paypal_account.created_at.should_not be_nil
       paypal_account.updated_at.should_not be_nil
       paypal_account.customer_id.should == customer.id
+      paypal_account.revoked_at.should be_nil
     end
 
     it "returns a PayPalAccount with a billing agreement id" do

data/spec/integration/braintree/transaction_search_spec.rb

@@ -345,6 +345,21 @@ describe Braintree::Transaction, "search" do
         collection.first.payment_instrument_type.should == Braintree::PaymentInstrumentType::PayPalAccount
       end
 
+      it "searches by payment instrument type LocalPaymentDetail" do
+        transaction = Braintree::Transaction.sale!(
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :payment_method_nonce => Braintree::Test::Nonce::LocalPayment
+        )
+
+        collection = Braintree::Transaction.search do |search|
+          search.id.is transaction.id
+          search.payment_instrument_type.in ["LocalPaymentDetail"]
+        end
+
+        collection.first.id.should == transaction.id
+        collection.first.payment_instrument_type.should == Braintree::PaymentInstrumentType::LocalPayment
+      end
+
       it "searches by payment instrument type ApplePay" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,

data/spec/integration/braintree/transaction_spec.rb

@@ -201,7 +201,7 @@ describe Braintree::Transaction do
           result.success?.should be(false)
           invalid_folio = Braintree::ErrorCodes::Transaction::Industry::Lodging::FolioNumberIsInvalid
           check_out_date_must_follow_check_in_date = Braintree::ErrorCodes::Transaction::Industry::Lodging::CheckOutDateMustFollowCheckInDate
-          result.errors.for(:transaction).for(:industry).map { |e| e.code }.sort.should == [invalid_folio, check_out_date_must_follow_check_in_date]
+          result.errors.for(:transaction).for(:industry).map { |e| e.code }.sort.should include *[invalid_folio, check_out_date_must_follow_check_in_date]
         end
       end
 
@@ -766,6 +766,16 @@ describe Braintree::Transaction do
         result.success?.should == false
         result.transaction.gateway_rejection_reason.should == Braintree::Transaction::GatewayRejectionReason::Fraud
       end
+
+      it "exposes the token issuance gateway rejection reason" do
+        result = Braintree::Transaction.sale(
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :merchant_account_id => SpecHelper::FakeVenmoAccountMerchantAccountId,
+          :payment_method_nonce => Braintree::Test::Nonce::VenmoAccountTokenIssuanceError,
+        )
+        result.success?.should == false
+        result.transaction.gateway_rejection_reason.should == Braintree::Transaction::GatewayRejectionReason::TokenIssuance
+      end
     end
 
     it "accepts credit card expiration month and expiration year" do
@@ -1575,6 +1585,13 @@ describe Braintree::Transaction do
         apple_pay_details.cardholder_name.should_not be_nil
         apple_pay_details.image_url.should_not be_nil
         apple_pay_details.token.should be_nil
+        apple_pay_details.prepaid.should_not be_nil
+        apple_pay_details.healthcare.should_not be_nil
+        apple_pay_details.debit.should_not be_nil
+        apple_pay_details.durbin_regulated.should_not be_nil
+        apple_pay_details.commercial.should_not be_nil
+        apple_pay_details.payroll.should_not be_nil
+        apple_pay_details.product_id.should_not be_nil
       end
 
       it "can create a vaulted transaction with a fake apple pay nonce" do
@@ -1620,6 +1637,13 @@ describe Braintree::Transaction do
         android_pay_details.google_transaction_id.should == "google_transaction_id"
         android_pay_details.image_url.should_not be_nil
         android_pay_details.token.should be_nil
+        android_pay_details.prepaid.should_not be_nil
+        android_pay_details.healthcare.should_not be_nil
+        android_pay_details.debit.should_not be_nil
+        android_pay_details.durbin_regulated.should_not be_nil
+        android_pay_details.commercial.should_not be_nil
+        android_pay_details.payroll.should_not be_nil
+        android_pay_details.product_id.should_not be_nil
       end
 
       it "can create a vaulted transaction with a fake android pay proxy card nonce" do
@@ -2098,7 +2122,7 @@ describe Braintree::Transaction do
 
       it "returns an error for transaction with three_d_secure_pass_thru when processor settings do not support 3DS for card type" do
         result = Braintree::Transaction.create(
-          :merchant_account_id => "adyen_ma",
+          :merchant_account_id => "heartland_ma",
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
           :credit_card => {
@@ -2239,6 +2263,21 @@ describe Braintree::Transaction do
         end
       end
 
+      context "local payments" do
+        it "can create a local payment transaction with a nonce" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => Braintree::Test::TransactionAmounts::Authorize,
+            :payment_method_nonce => Braintree::Test::Nonce::LocalPayment
+          )
+
+          result.should be_success
+          result.transaction.local_payment_details.should_not be_nil
+          result.transaction.local_payment_details.funding_source.should_not be_nil
+          result.transaction.local_payment_details.payment_id.should_not be_nil
+        end
+      end
+
       context "onetime" do
         it "can create a paypal transaction with a nonce" do
           result = Braintree::Transaction.create(
@@ -2439,53 +2478,6 @@ describe Braintree::Transaction do
       end
     end
 
-    context "ideal payment nonce" do
-      it "returns a successful result for tansacting on an ideal payment nonce" do
-        valid_ideal_payment_id = generate_valid_ideal_payment_nonce
-        result = Braintree::Transaction.create(
-          :type => "sale",
-          :order_id => SpecHelper::DefaultOrderId,
-          :amount => Braintree::Test::TransactionAmounts::Authorize,
-          :merchant_account_id => SpecHelper::IdealMerchantAccountId,
-          :payment_method_nonce => valid_ideal_payment_id,
-          :options => {
-            :submit_for_settlement => true,
-          }
-        )
-        result.success?.should == true
-        result.transaction.id.should =~ /^\w{6,}$/
-        result.transaction.type.should == "sale"
-        result.transaction.payment_instrument_type.should == Braintree::PaymentInstrumentType::IdealPayment
-        result.transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
-        result.transaction.status.should == Braintree::Transaction::Status::Settled
-        result.transaction.ideal_payment_details.ideal_payment_id.should =~ /^idealpayment_\w{6,}$/
-        result.transaction.ideal_payment_details.ideal_transaction_id.should =~ /^\d{16,}$/
-        result.transaction.ideal_payment_details.image_url.should start_with("https://")
-        result.transaction.ideal_payment_details.masked_iban.should_not be_empty
-        result.transaction.ideal_payment_details.bic.should_not be_empty
-      end
-
-      it "returns a failure if ideal payment is not complete" do
-        expired_payment_amount = "3.00"
-
-        incomplete_payment_id = generate_valid_ideal_payment_nonce(expired_payment_amount)
-
-        result = Braintree::Transaction.create(
-          :type => "sale",
-          :order_id => SpecHelper::DefaultOrderId,
-          :amount => expired_payment_amount,
-          :merchant_account_id => SpecHelper::IdealMerchantAccountId,
-          :payment_method_nonce => incomplete_payment_id,
-          :options => {
-            :submit_for_settlement => true,
-          }
-        )
-
-        result.success?.should == false
-        result.errors.for(:transaction).on(:payment_method_nonce)[0].code.should == Braintree::ErrorCodes::Transaction::IdealPaymentNotComplete
-      end
-    end
-
     context "line items" do
       it "allows creation with empty line items and returns none" do
         result = Braintree::Transaction.create(
@@ -5863,6 +5855,8 @@ describe Braintree::Transaction do
         transaction.paypal_details.refund_id.should_not be_nil
         transaction.paypal_details.transaction_fee_amount.should_not be_nil
         transaction.paypal_details.transaction_fee_currency_iso_code.should_not be_nil
+        transaction.paypal_details.refund_from_transaction_fee_amount.should_not be_nil
+        transaction.paypal_details.refund_from_transaction_fee_currency_iso_code.should_not be_nil
       end
     end
   end

data/spec/spec_helper.rb

@@ -41,7 +41,6 @@ unless defined?(SPEC_HELPER_LOADED)
     FakeVenmoAccountMerchantAccountId = "fake_first_data_venmo_account"
     UsBankMerchantAccountId = "us_bank_merchant_account"
     AnotherUsBankMerchantAccountId = "another_us_bank_merchant_account"
-    IdealMerchantAccountId = "ideal_merchant_account"
     AdyenMerchantAccountId = "adyen_ma"
     HiperBRLMerchantAccountId = "hiper_brl"
 

data/spec/unit/braintree/local_payment_completed_spec.rb

@@ -14,11 +14,23 @@ describe Braintree::LocalPaymentCompleted do
       params = {
         payment_id: "a-payment-id",
         payer_id: "a-payer-id",
+        payment_method_nonce: "a-nonce",
+        transaction: {
+          id: "a-transaction-id",
+          amount: "31.00",
+          order_id: "an-order-id",
+          status: Braintree::Transaction::Status::Authorized,
+        },
       }
       local_payment_completed = Braintree::LocalPaymentCompleted._new(params)
 
       local_payment_completed.payment_id.should eq("a-payment-id")
       local_payment_completed.payer_id.should eq("a-payer-id")
+      local_payment_completed.payment_method_nonce.should eq("a-nonce")
+      local_payment_completed.transaction.id.should eq("a-transaction-id")
+      local_payment_completed.transaction.amount.should eq(31.0)
+      local_payment_completed.transaction.order_id.should eq("an-order-id")
+      local_payment_completed.transaction.status.should eq(Braintree::Transaction::Status::Authorized)
     end
   end
 end

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -305,44 +305,6 @@ describe Braintree::WebhookNotification do
       end
     end
 
-    context "ideal payments" do
-      it "builds a sample notification for a ideal_payment_complete complete webhook" do
-        sample_notification = Braintree::WebhookTesting.sample_notification(
-          Braintree::WebhookNotification::Kind::IdealPaymentComplete,
-          "my_id"
-        )
-
-        notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
-        notification.kind.should == Braintree::WebhookNotification::Kind::IdealPaymentComplete
-        ideal_payment = notification.ideal_payment
-
-        ideal_payment.id.should == "my_id"
-        ideal_payment.status.should == "COMPLETE"
-        ideal_payment.order_id.should == "ORDERABC"
-        ideal_payment.amount.should == "10.00"
-        ideal_payment.approval_url.should == "https://example.com"
-        ideal_payment.ideal_transaction_id.should == "1234567890"
-      end
-
-      it "builds a sample notification for a ideal_payment_failed webhook" do
-        sample_notification = Braintree::WebhookTesting.sample_notification(
-          Braintree::WebhookNotification::Kind::IdealPaymentFailed,
-          "my_id"
-        )
-
-        notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
-        notification.kind.should == Braintree::WebhookNotification::Kind::IdealPaymentFailed
-        ideal_payment = notification.ideal_payment
-
-        ideal_payment.id.should == "my_id"
-        ideal_payment.status.should == "FAILED"
-        ideal_payment.order_id.should == "ORDERABC"
-        ideal_payment.amount.should == "10.00"
-        ideal_payment.approval_url.should == "https://example.com"
-        ideal_payment.ideal_transaction_id.should == "1234567890"
-      end
-    end
-
     context "merchant account" do
       it "builds a sample notification for a merchant account approved webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
@@ -604,6 +566,23 @@ describe Braintree::WebhookNotification do
     end
   end
 
+  context "payment_method_revoked_by_customer" do
+    it "builds a sample notification for a payment_method_revoked_by_customer webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::PaymentMethodRevokedByCustomer,
+        "my_payment_method_token"
+      )
+
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      notification.kind.should == Braintree::WebhookNotification::Kind::PaymentMethodRevokedByCustomer
+
+      metadata = notification.revoked_payment_method_metadata
+      metadata.token.should == "my_payment_method_token"
+      metadata.revoked_payment_method.class.should == Braintree::PayPalAccount
+      metadata.revoked_payment_method.revoked_at.should_not be_nil
+    end
+  end
+
   context "local_payment_completed" do
     it "builds a sample notification for a local_payment webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
@@ -615,8 +594,13 @@ describe Braintree::WebhookNotification do
       notification.kind.should == Braintree::WebhookNotification::Kind::LocalPaymentCompleted
 
       local_payment_completed = notification.local_payment_completed
-      local_payment_completed.payment_id.should == 'PAY-XYZ123'
-      local_payment_completed.payer_id.should == 'ABCPAYER'
+      local_payment_completed.payment_id.should == "PAY-XYZ123"
+      local_payment_completed.payer_id.should == "ABCPAYER"
+      local_payment_completed.payment_method_nonce.should == "ee257d98-de40-47e8-96b3-a6954ea7a9a4"
+      local_payment_completed.transaction.id.should == "my_id"
+      local_payment_completed.transaction.status.should == Braintree::Transaction::Status::Authorized
+      local_payment_completed.transaction.amount.should == 49.99
+      local_payment_completed.transaction.order_id.should == "order4567"
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.95.0
+  version: 2.96.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-28 00:00:00.000000000 Z
+date: 2019-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -151,6 +151,7 @@ files:
 - lib/braintree/transaction/customer_details.rb
 - lib/braintree/transaction/disbursement_details.rb
 - lib/braintree/transaction/ideal_payment_details.rb
+- lib/braintree/transaction/local_payment_details.rb
 - lib/braintree/transaction/masterpass_card_details.rb
 - lib/braintree/transaction/paypal_details.rb
 - lib/braintree/transaction/samsung_pay_card_details.rb
@@ -213,7 +214,6 @@ files:
 - spec/integration/braintree/error_codes_spec.rb
 - spec/integration/braintree/graphql_client_spec.rb
 - spec/integration/braintree/http_spec.rb
-- spec/integration/braintree/ideal_payment_spec.rb
 - spec/integration/braintree/masterpass_card_spec.rb
 - spec/integration/braintree/merchant_account_spec.rb
 - spec/integration/braintree/merchant_spec.rb
@@ -318,8 +318,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: braintree
-rubygems_version: 2.7.9
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Braintree Gateway Ruby Client Library

data/spec/integration/braintree/ideal_payment_spec.rb

@@ -1,87 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
-require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
-
-describe Braintree::IdealPayment do
-  context "self.sale" do
-    it "creates a transaction using an Ideal payment token and returns a result object" do
-      ideal_payment_id = generate_valid_ideal_payment_nonce
-
-      result = Braintree::IdealPayment.sale(
-        ideal_payment_id,
-        :order_id => SpecHelper::DefaultOrderId,
-        :merchant_account_id => "ideal_merchant_account",
-        :amount => Braintree::Test::TransactionAmounts::Authorize
-      )
-
-      result.success?.should == true
-      result.transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
-      result.transaction.type.should == "sale"
-      ideal_payment_details = result.transaction.ideal_payment_details
-      ideal_payment_details.ideal_payment_id.should =~ /^idealpayment_\w{6,}$/
-      ideal_payment_details.ideal_transaction_id.should =~ /^\d{16,}$/
-      ideal_payment_details.image_url.should start_with("https://")
-      ideal_payment_details.masked_iban.should_not be_empty
-      ideal_payment_details.bic.should_not be_empty
-    end
-  end
-
-  context "self.sale!" do
-    it "creates a transaction using an ideal payment and returns a result object" do
-      ideal_payment_id = generate_valid_ideal_payment_nonce
-
-      transaction = Braintree::IdealPayment.sale!(
-        ideal_payment_id,
-        :order_id => SpecHelper::DefaultOrderId,
-        :merchant_account_id => "ideal_merchant_account",
-        :amount => Braintree::Test::TransactionAmounts::Authorize
-      )
-
-      transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
-      transaction.type.should == "sale"
-      ideal_payment_details = transaction.ideal_payment_details
-      ideal_payment_details.ideal_payment_id.should =~ /^idealpayment_\w{6,}$/
-      ideal_payment_details.ideal_transaction_id.should =~ /^\d{16,}$/
-      ideal_payment_details.image_url.should start_with("https://")
-      ideal_payment_details.masked_iban.should_not be_empty
-      ideal_payment_details.bic.should_not be_empty
-    end
-
-    it "does not create a transaction using an ideal payment and returns raises an exception" do
-      expect do
-        Braintree::IdealPayment.sale!(
-          "invalid_nonce",
-          :merchant_account_id => "ideal_merchant_account",
-          :amount => Braintree::Test::TransactionAmounts::Authorize
-        )
-      end.to raise_error(Braintree::ValidationsFailed)
-    end
-  end
-
-  context "self.find" do
-    it "finds the Ideal payment with an id" do
-      ideal_payment_id = generate_valid_ideal_payment_nonce
-      ideal_payment = Braintree::IdealPayment.find(ideal_payment_id)
-
-      ideal_payment.id.should =~ /^idealpayment_\w{6,}$/
-      ideal_payment.ideal_transaction_id.should =~ /^\d{16,}$/
-      ideal_payment.currency.should_not be_empty
-      ideal_payment.amount.should_not be_empty
-      ideal_payment.status.should_not be_empty
-      ideal_payment.order_id.should_not be_empty
-      ideal_payment.issuer.should_not be_empty
-      ideal_payment.approval_url.should start_with("https://")
-      ideal_payment.iban_bank_account.account_holder_name.should_not be_empty
-      ideal_payment.iban_bank_account.bic.should_not be_empty
-      ideal_payment.iban_bank_account.masked_iban.should_not be_empty
-      ideal_payment.iban_bank_account.iban_account_number_last_4.should =~ /^\d{4}$/
-      ideal_payment.iban_bank_account.iban_country.should_not be_empty
-      ideal_payment.iban_bank_account.description.should_not be_empty
-    end
-
-    it "raises if the Ideal payment is not found" do
-      expect do
-        Braintree::IdealPayment.find("idealpayment_nxyqkq_s654wq_92jr64_mnr4kr_yjz")
-      end.to raise_error(Braintree::NotFoundError)
-    end
-  end
-end