braintree 2.93.0 → 2.94.0

data/spec/integration/braintree/transaction_us_bank_account_spec.rb

@@ -28,7 +28,7 @@ describe Braintree::Transaction do
             result.transaction.id.should =~ /^\w{6,}$/
             result.transaction.type.should == "sale"
             result.transaction.payment_instrument_type.should == Braintree::PaymentInstrumentType::UsBankAccount
-            result.transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            result.transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             result.transaction.status.should == Braintree::Transaction::Status::SettlementPending
             result.transaction.us_bank_account_details.routing_number.should == "011000015"
             result.transaction.us_bank_account_details.last_4.should == "0000"
@@ -73,7 +73,7 @@ describe Braintree::Transaction do
 
             transaction.id.should =~ /^\w{6,}$/
             transaction.type.should == "sale"
-            transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             transaction.status.should == Braintree::Transaction::Status::SettlementPending
             transaction.us_bank_account_details.routing_number.should == "011000015"
             transaction.us_bank_account_details.last_4.should == "0000"
@@ -114,7 +114,7 @@ describe Braintree::Transaction do
 
             transaction.id.should =~ /^\w{6,}$/
             transaction.type.should == "sale"
-            transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             transaction.status.should == Braintree::Transaction::Status::SettlementPending
             transaction.us_bank_account_details.routing_number.should == "011000015"
             transaction.us_bank_account_details.last_4.should == "0000"
@@ -247,7 +247,7 @@ describe Braintree::Transaction do
             result.transaction.id.should =~ /^\w{6,}$/
             result.transaction.type.should == "sale"
             result.transaction.payment_instrument_type.should == Braintree::PaymentInstrumentType::UsBankAccount
-            result.transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            result.transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             result.transaction.status.should == Braintree::Transaction::Status::SettlementPending
             result.transaction.us_bank_account_details.routing_number.should == "011000015"
             result.transaction.us_bank_account_details.last_4.should == "0000"
@@ -294,7 +294,7 @@ describe Braintree::Transaction do
 
             transaction.id.should =~ /^\w{6,}$/
             transaction.type.should == "sale"
-            transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             transaction.status.should == Braintree::Transaction::Status::SettlementPending
             transaction.us_bank_account_details.routing_number.should == "011000015"
             transaction.us_bank_account_details.last_4.should == "0000"
@@ -335,7 +335,7 @@ describe Braintree::Transaction do
 
             transaction.id.should =~ /^\w{6,}$/
             transaction.type.should == "sale"
-            transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             transaction.status.should == Braintree::Transaction::Status::SettlementPending
             transaction.us_bank_account_details.routing_number.should == "011000015"
             transaction.us_bank_account_details.last_4.should == "0000"
@@ -369,7 +369,7 @@ describe Braintree::Transaction do
 
             transaction.id.should =~ /^\w{6,}$/
             transaction.type.should == "sale"
-            transaction.amount.should == BigDecimal.new(Braintree::Test::TransactionAmounts::Authorize)
+            transaction.amount.should == BigDecimal(Braintree::Test::TransactionAmounts::Authorize)
             transaction.status.should == Braintree::Transaction::Status::SettlementPending
             transaction.us_bank_account_details.routing_number.should == "021000021"
             transaction.us_bank_account_details.last_4.should == "0000"

data/spec/integration/braintree/transparent_redirect_spec.rb

@@ -51,7 +51,7 @@ describe Braintree::TransparentRedirect do
         result.success?.should == true
         transaction = result.transaction
         transaction.type.should == "sale"
-        transaction.amount.should == BigDecimal.new("1000.00")
+        transaction.amount.should == BigDecimal("1000.00")
         transaction.credit_card_details.bin.should == Braintree::Test::CreditCardNumbers::Visa[0, 6]
         transaction.credit_card_details.last_4.should == Braintree::Test::CreditCardNumbers::Visa[-4..-1]
         transaction.credit_card_details.expiration_date.should == "05/2009"
@@ -78,7 +78,7 @@ describe Braintree::TransparentRedirect do
         query_string_response = SpecHelper.simulate_form_post_for_tr(tr_data, params)
         result = Braintree::TransparentRedirect.confirm(query_string_response)
         result.success?.should == true
-        result.transaction.service_fee_amount.should == BigDecimal.new("1.00")
+        result.transaction.service_fee_amount.should == BigDecimal("1.00")
       end
 
       it "returns an error when there's an error" do

data/spec/integration/braintree/us_bank_account_spec.rb

@@ -55,7 +55,7 @@ describe Braintree::UsBankAccount do
       )
 
       result.success?.should == true
-      result.transaction.amount.should == BigDecimal.new("100.00")
+      result.transaction.amount.should == BigDecimal("100.00")
       result.transaction.type.should == "sale"
       us_bank_account = result.transaction.us_bank_account_details
       us_bank_account.routing_number.should == "021000021"
@@ -88,7 +88,7 @@ describe Braintree::UsBankAccount do
         :amount => "100.00"
       )
 
-      transaction.amount.should == BigDecimal.new("100.00")
+      transaction.amount.should == BigDecimal("100.00")
       transaction.type.should == "sale"
       us_bank_account = transaction.us_bank_account_details
       us_bank_account.routing_number.should == "021000021"

data/spec/spec_helper.rb

@@ -47,7 +47,7 @@ unless defined?(SPEC_HELPER_LOADED)
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",
       :id => "integration_trial_plan",
-      :price => BigDecimal.new("43.21"),
+      :price => BigDecimal("43.21"),
       :trial_period => true,
       :trial_duration => 2,
       :trial_duration_unit => Braintree::Subscription::TrialDurationUnit::Day
@@ -56,14 +56,14 @@ unless defined?(SPEC_HELPER_LOADED)
     TriallessPlan = {
       :description => "Plan for integration tests -- without a trial",
       :id => "integration_trialless_plan",
-      :price => BigDecimal.new("12.34"),
+      :price => BigDecimal("12.34"),
       :trial_period => false
     }
 
     AddOnDiscountPlan = {
       :description => "Plan for integration tests -- with add-ons and discounts",
       :id => "integration_plan_with_add_ons_and_discounts",
-      :price => BigDecimal.new("9.99"),
+      :price => BigDecimal("9.99"),
       :trial_period => true,
       :trial_duration => 2,
       :trial_duration_unit => Braintree::Subscription::TrialDurationUnit::Day
@@ -72,7 +72,7 @@ unless defined?(SPEC_HELPER_LOADED)
     BillingDayOfMonthPlan = {
       :description => "Plan for integration tests -- with billing day of month",
       :id => "integration_plan_with_billing_day_of_month",
-      :price => BigDecimal.new("8.88"),
+      :price => BigDecimal("8.88"),
       :billing_day_of_month => 5
     }
 

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -36,8 +36,8 @@ describe Braintree::CreditCardVerification do
   end
 
   it "accepts amount as either a String or BigDecimal" do
-    Braintree::CreditCardVerification._new(:amount => "12.34").amount.should == BigDecimal.new("12.34")
-    Braintree::CreditCardVerification._new(:amount => BigDecimal.new("12.34")).amount.should == BigDecimal.new("12.34")
+    Braintree::CreditCardVerification._new(:amount => "12.34").amount.should == BigDecimal("12.34")
+    Braintree::CreditCardVerification._new(:amount => BigDecimal("12.34")).amount.should == BigDecimal("12.34")
   end
 
   describe "self.create" do

data/spec/unit/braintree/modification_spec.rb

@@ -2,6 +2,6 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Braintree::Modification do
   it "converts string amount" do
-    Braintree::Modification._new(:amount => "100.00").amount.should == BigDecimal.new("100.00")
+    Braintree::Modification._new(:amount => "100.00").amount.should == BigDecimal("100.00")
   end
 end

data/spec/unit/braintree/subscription_spec.rb

@@ -11,8 +11,8 @@ describe Braintree::Subscription do
 
   context "price" do
     it "accepts price as either a String or a BigDecimal" do
-      Braintree::Subscription._new(:gateway, default_params.merge(:price => "12.34")).price.should == BigDecimal.new("12.34")
-      Braintree::Subscription._new(:gateway, default_params.merge(:price => BigDecimal.new("12.34"))).price.should == BigDecimal.new("12.34")
+      Braintree::Subscription._new(:gateway, default_params.merge(:price => "12.34")).price.should == BigDecimal("12.34")
+      Braintree::Subscription._new(:gateway, default_params.merge(:price => BigDecimal("12.34"))).price.should == BigDecimal("12.34")
     end
 
     it "blows up if price is not a string or BigDecimal" do

data/spec/unit/braintree/transaction_spec.rb

@@ -238,8 +238,8 @@ describe Braintree::Transaction do
     end
 
     it "accepts amount as either a String or a BigDecimal" do
-      Braintree::Transaction._new(:gateway, :amount => "12.34").amount.should == BigDecimal.new("12.34")
-      Braintree::Transaction._new(:gateway, :amount => BigDecimal.new("12.34")).amount.should == BigDecimal.new("12.34")
+      Braintree::Transaction._new(:gateway, :amount => "12.34").amount.should == BigDecimal("12.34")
+      Braintree::Transaction._new(:gateway, :amount => BigDecimal("12.34")).amount.should == BigDecimal("12.34")
     end
 
     it "blows up if amount is not a string or BigDecimal" do

data/spec/unit/braintree/util_spec.rb

@@ -354,11 +354,11 @@ describe Braintree::Util do
 
   describe "self.to_big_decimal" do
     it "returns the BigDecimal when given a BigDecimal" do
-      Braintree::Util.to_big_decimal(BigDecimal.new("12.34")).should == BigDecimal.new("12.34")
+      Braintree::Util.to_big_decimal(BigDecimal("12.34")).should == BigDecimal("12.34")
     end
 
     it "returns a BigDecimal when given a string" do
-      Braintree::Util.to_big_decimal("12.34").should == BigDecimal.new("12.34")
+      Braintree::Util.to_big_decimal("12.34").should == BigDecimal("12.34")
     end
 
     it "returns nil when given nil" do

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -454,6 +454,139 @@ describe Braintree::WebhookNotification do
     end
   end
 
+  context "granted_payment_instrument_revoked" do
+    let(:gateway) do
+      config = Braintree::Configuration.new(
+        :merchant_id => 'merchant_id',
+        :public_key => 'wrong_public_key',
+        :private_key => 'wrong_private_key'
+      )
+      Braintree::Gateway.new(config)
+    end
+
+    describe "credit cards" do
+      it "builds a webhook notification for a granted_payment_instrument_revoked webhook" do
+        webhook_xml_response = <<-XML
+        <notification>
+          <source-merchant-id>12345</source-merchant-id>
+          <timestamp type="datetime">2018-10-10T22:46:41Z</timestamp>
+          <kind>granted_payment_instrument_revoked</kind>
+          <subject>
+            <credit-card>
+              <bin>555555</bin>
+              <card-type>MasterCard</card-type>
+              <cardholder-name>Amber Ankunding</cardholder-name>
+              <commercial>Unknown</commercial>
+              <country-of-issuance>Unknown</country-of-issuance>
+              <created-at type="datetime">2018-10-10T22:46:41Z</created-at>
+              <customer-id>credit_card_customer_id</customer-id>
+              <customer-location>US</customer-location>
+              <debit>Unknown</debit>
+              <default type="boolean">true</default>
+              <durbin-regulated>Unknown</durbin-regulated>
+              <expiration-month>06</expiration-month>
+              <expiration-year>2020</expiration-year>
+              <expired type="boolean">false</expired>
+              <global-id>cGF5bWVudG1ldGhvZF8zcHQ2d2hz</global-id>
+              <healthcare>Unknown</healthcare>
+              <image-url>https://assets.braintreegateway.com/payment_method_logo/mastercard.png?environment=test</image-url>
+              <issuing-bank>Unknown</issuing-bank>
+              <last-4>4444</last-4>
+              <payroll>Unknown</payroll>
+              <prepaid>Unknown</prepaid>
+              <product-id>Unknown</product-id>
+              <subscriptions type="array"/>
+              <token>credit_card_token</token>
+              <unique-number-identifier>08199d188e37460163207f714faf074a</unique-number-identifier>
+              <updated-at type="datetime">2018-10-10T22:46:41Z</updated-at>
+              <venmo-sdk type="boolean">false</venmo-sdk>
+              <verifications type="array"/>
+            </credit-card>
+          </subject>
+        </notification>
+        XML
+        attributes = Braintree::Xml.hash_from_xml(webhook_xml_response)
+        notification = Braintree::WebhookNotification._new(gateway, attributes[:notification])
+        metadata = notification.revoked_payment_method_metadata
+
+        notification.kind.should == Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentRevoked
+        metadata.customer_id.should == "credit_card_customer_id"
+        metadata.token.should == "credit_card_token"
+        metadata.revoked_payment_method.class.should == Braintree::CreditCard
+      end
+    end
+
+    describe "paypal accounts" do
+      it "builds a webhook notification for a granted_payment_instrument_revoked webhook" do
+        webhook_xml_response = <<-XML
+        <notification>
+          <source-merchant-id>12345</source-merchant-id>
+          <timestamp type="datetime">2018-10-10T22:46:41Z</timestamp>
+          <kind>granted_payment_instrument_revoked</kind>
+          <subject>
+            <paypal-account>
+              <billing-agreement-id>billing_agreement_id</billing-agreement-id>
+              <created-at type="dateTime">2018-10-11T21:10:33Z</created-at>
+              <customer-id>paypal_customer_id</customer-id>
+              <default type="boolean">true</default>
+              <email>johndoe@example.com</email>
+              <global-id>cGF5bWVudG1ldGhvZF9wYXlwYWxfdG9rZW4</global-id>
+              <image-url>https://jsdk.bt.local:9000/payment_method_logo/paypal.png?environment=test://assets.braintreegateway.com/payment_method_logo/paypal.png?environment=test</image-url>
+              <subscriptions type="array"></subscriptions>
+              <token>paypal_token</token>
+              <updated-at type="dateTime">2018-10-11T21:10:33Z</updated-at>
+              <payer-id>a6a8e1a4</payer-id>
+            </paypal-account>
+          </subject>
+        </notification>
+        XML
+        attributes = Braintree::Xml.hash_from_xml(webhook_xml_response)
+        notification = Braintree::WebhookNotification._new(gateway, attributes[:notification])
+        metadata = notification.revoked_payment_method_metadata
+
+        notification.kind.should == Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentRevoked
+        metadata.customer_id.should == "paypal_customer_id"
+        metadata.token.should == "paypal_token"
+        metadata.revoked_payment_method.class.should == Braintree::PayPalAccount
+      end
+    end
+
+    describe "venmo accounts" do
+      it "builds a webhook notification for a granted_payment_instrument_revoked webhook" do
+        webhook_xml_response = <<-XML
+        <notification>
+          <source-merchant-id>12345</source-merchant-id>
+          <timestamp type="datetime">2018-10-10T22:46:41Z</timestamp>
+          <kind>granted_payment_instrument_revoked</kind>
+          <subject>
+            <venmo-account>
+              <created-at type="dateTime">2018-10-11T21:28:37Z</created-at>
+              <updated-at type="dateTime">2018-10-11T21:28:37Z</updated-at>
+              <default type="boolean">true</default>
+              <image-url>https://assets.braintreegateway.com/payment_method_logo/venmo.png?environment=test</image-url>
+              <token>venmo_token</token>
+              <source-description>Venmo Account: venmojoe</source-description>
+              <username>venmojoe</username>
+              <venmo-user-id>456</venmo-user-id>
+              <subscriptions type="array"/>
+              <customer-id>venmo_customer_id</customer-id>
+              <global-id>cGF5bWVudG1ldGhvZF92ZW5tb2FjY291bnQ</global-id>
+            </venmo-account>
+          </subject>
+        </notification>
+        XML
+        attributes = Braintree::Xml.hash_from_xml(webhook_xml_response)
+        notification = Braintree::WebhookNotification._new(gateway, attributes[:notification])
+        metadata = notification.revoked_payment_method_metadata
+
+        notification.kind.should == Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentRevoked
+        metadata.customer_id.should == "venmo_customer_id"
+        metadata.token.should == "venmo_token"
+        metadata.revoked_payment_method.class.should == Braintree::VenmoAccount
+      end
+    end
+  end
+
   context "local_payment_completed" do
     it "builds a sample notification for a local_payment webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(

data/spec/unit/braintree/xml_spec.rb

@@ -108,17 +108,17 @@ describe Braintree::Xml do
 
 		context "BigDecimal" do
 			it "works for BigDecimals" do
-				hash = {:root => {:foo => BigDecimal.new("123.45")}}
+				hash = {:root => {:foo => BigDecimal("123.45")}}
 				Braintree::Xml.hash_to_xml(hash).should include("<foo>123.45</foo>")
 			end
 
 			it "works for BigDecimals with fewer than 2 digits" do
-				hash = {:root => {:foo => BigDecimal.new("1000.0")}}
+				hash = {:root => {:foo => BigDecimal("1000.0")}}
 				Braintree::Xml.hash_to_xml(hash).should include("<foo>1000.00</foo>")
 			end
 
 			it "works for BigDecimals with more than 2 digits" do
-				hash = {:root => {:foo => BigDecimal.new("12.345")}}
+				hash = {:root => {:foo => BigDecimal("12.345")}}
 				Braintree::Xml.hash_to_xml(hash).should include("<foo>12.345</foo>")
 			end
 		end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.93.0
+  version: 2.94.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-12 00:00:00.000000000 Z
+date: 2019-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -113,12 +113,14 @@ files:
 - lib/braintree/payment_method_gateway.rb
 - lib/braintree/payment_method_nonce.rb
 - lib/braintree/payment_method_nonce_gateway.rb
+- lib/braintree/payment_method_parser.rb
 - lib/braintree/paypal_account.rb
 - lib/braintree/paypal_account_gateway.rb
 - lib/braintree/plan.rb
 - lib/braintree/plan_gateway.rb
 - lib/braintree/processor_response_types.rb
 - lib/braintree/resource_collection.rb
+- lib/braintree/revoked_payment_method_metadata.rb
 - lib/braintree/risk_data.rb
 - lib/braintree/samsung_pay_card.rb
 - lib/braintree/settlement_batch.rb
@@ -189,6 +191,7 @@ files:
 - spec/fixtures/files/bt_logo.png
 - spec/fixtures/files/gif_extension_bt_logo.gif
 - spec/fixtures/files/malformed_pdf.pdf
+- spec/fixtures/files/too_long.pdf
 - spec/hacks/tcp_socket.rb
 - spec/integration/braintree/add_on_spec.rb
 - spec/integration/braintree/address_spec.rb