braintree 2.9.1 → 2.10.0

data/lib/braintree.rb

@@ -52,6 +52,7 @@ require File.dirname(__FILE__) + "/braintree/transaction"
 require File.dirname(__FILE__) + "/braintree/transaction/address_details"
 require File.dirname(__FILE__) + "/braintree/transaction/credit_card_details"
 require File.dirname(__FILE__) + "/braintree/transaction/customer_details"
+require File.dirname(__FILE__) + "/braintree/transaction/subscription_details"
 require File.dirname(__FILE__) + "/braintree/transaction_gateway"
 require File.dirname(__FILE__) + "/braintree/transaction_search"
 require File.dirname(__FILE__) + "/braintree/transaction/status_details"

data/lib/braintree/error_codes.rb

@@ -7,10 +7,10 @@ module Braintree
     module Address
       CannotBeBlank = "81801"
       CompanyIsTooLong = "81802"
-      CountryNameIsNotAccepted = "91803"
       CountryCodeAlpha2IsNotAccepted  = "91814"
       CountryCodeAlpha3IsNotAccepted  = "91816"
       CountryCodeNumericIsNotAccepted = "91817"
+      CountryNameIsNotAccepted = "91803"
       ExtendedAddressIsTooLong = "81804"
       FirstNameIsTooLong = "81805"
       InconsistentCountry = "91815"
@@ -22,6 +22,7 @@ module Braintree
       RegionIsTooLong = "81810"
       StreetAddressIsRequired = "81811"
       StreetAddressIsTooLong = "81812"
+      TooManyAddressesPerCustomer = "91818"
     end
 
     # See http://www.braintreepaymentsolutions.com/docs/ruby/credit_cards/validations

data/lib/braintree/transaction.rb

@@ -42,7 +42,7 @@ module Braintree
     end
 
     attr_reader :avs_error_response_code, :avs_postal_code_response_code, :avs_street_address_response_code
-    attr_reader :amount, :created_at, :credit_card_details, :customer_details, :id
+    attr_reader :amount, :created_at, :credit_card_details, :customer_details, :subscription_details, :id
     attr_reader :currency_iso_code
     attr_reader :custom_fields
     attr_reader :cvv_response_code
@@ -155,6 +155,7 @@ module Braintree
       set_instance_variables_from_hash(attributes)
       @amount = Util.to_big_decimal(amount)
       @credit_card_details = CreditCardDetails.new(@credit_card)
+      @subscription_details = SubscriptionDetails.new(@subscription)
       @customer_details = CustomerDetails.new(@customer)
       @billing_details = AddressDetails.new(@billing)
       @shipping_details = AddressDetails.new(@shipping)
@@ -292,7 +293,7 @@ module Braintree
     end
 
     def self._attributes # :nodoc:
-      [:amount, :created_at, :credit_card_details, :customer_details, :id, :status, :type, :updated_at]
+      [:amount, :created_at, :credit_card_details, :customer_details, :id, :status, :subscription_details, :type, :updated_at]
     end
   end
 end

data/lib/braintree/transaction/subscription_details.rb

@@ -0,0 +1,13 @@
+module Braintree
+  class Transaction
+    class SubscriptionDetails # :nodoc:
+      include BaseModule
+
+      attr_reader :billing_period_start_date, :billing_period_end_date
+
+      def initialize(attributes)
+        set_instance_variables_from_hash attributes unless attributes.nil?
+      end
+    end
+  end
+end

data/lib/braintree/transaction_gateway.rb

@@ -99,7 +99,7 @@ module Braintree
         {
           :shipping => AddressGateway._shared_signature
         },
-        {:options => [:store_in_vault, :submit_for_settlement, :add_billing_address_to_payment_method, :store_shipping_address_in_vault]},
+        {:options => [:store_in_vault, :store_in_vault_on_success, :submit_for_settlement, :add_billing_address_to_payment_method, :store_shipping_address_in_vault]},
         {:custom_fields => :_any_key_},
         {:descriptor => [:name, :phone]}
       ]

data/lib/braintree/version.rb

@@ -1,8 +1,8 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 9
-    Tiny = 1
+    Minor = 10
+    Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"
   end

data/spec/integration/braintree/credit_card_spec.rb

@@ -947,6 +947,28 @@ describe Braintree::CreditCard do
       result.transaction.credit_card_details.last_4.should == Braintree::Test::CreditCardNumbers::Visa[-4..-1]
       result.transaction.credit_card_details.expiration_date.should == "05/2010"
     end
+
+    it "allows passing a cvv in addition to the token" do
+      customer = Braintree::Customer.create!(
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2010"
+        }
+      )
+      result = Braintree::CreditCard.sale(customer.credit_cards[0].token,
+        :amount => "100.00",
+        :credit_card => {
+          :cvv => "301"
+        }
+      )
+
+      result.success?.should == true
+      result.transaction.amount.should == BigDecimal.new("100.00")
+      result.transaction.type.should == "sale"
+      result.transaction.customer_details.id.should == customer.id
+      result.transaction.credit_card_details.token.should == customer.credit_cards[0].token
+      result.transaction.cvv_response_code.should == "S"
+    end
   end
 
   describe "self.sale!" do

data/spec/integration/braintree/subscription_spec.rb

@@ -36,6 +36,20 @@ describe Braintree::Subscription do
       result.subscription.payment_method_token.should == @credit_card.token
     end
 
+    it "returns a transaction with billing period populated" do
+      result = Braintree::Subscription.create(
+        :payment_method_token => @credit_card.token,
+        :plan_id => SpecHelper::TriallessPlan[:id]
+      )
+
+      result.success?.should == true
+      subscription = result.subscription
+      transaction = subscription.transactions.first
+
+      transaction.subscription_details.billing_period_start_date.should == subscription.billing_period_start_date
+      transaction.subscription_details.billing_period_end_date.should == subscription.billing_period_end_date
+    end
+
     it "can set the id" do
       new_id = rand(36**9).to_s(36)
       result = Braintree::Subscription.create(

data/spec/integration/braintree/transaction_spec.rb

@@ -598,6 +598,84 @@ describe Braintree::Transaction do
         result.errors.for(:transaction).on(:purchase_order_number)[0].code.should == Braintree::ErrorCodes::Transaction::PurchaseOrderNumberIsTooLong
       end
     end
+
+    context "store_in_vault_on_success" do
+      context "passed as true" do
+        it "stores vault records when transaction succeeds" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => Braintree::Test::TransactionAmounts::Authorize,
+            :customer => {
+              :last_name => "Doe"
+            },
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "12/12",
+            },
+            :options => { :store_in_vault_on_success => true }
+          )
+          result.success?.should == true
+          result.transaction.vault_customer.last_name.should == "Doe"
+          result.transaction.vault_credit_card.masked_number.should == "401288******1881"
+        end
+
+        it "does not store vault records when true and transaction fails" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => Braintree::Test::TransactionAmounts::Decline,
+            :customer => {
+              :last_name => "Doe"
+            },
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "12/12",
+            },
+            :options => { :store_in_vault_on_success => true }
+          )
+          result.success?.should == false
+          result.transaction.vault_customer.should be_nil
+          result.transaction.vault_credit_card.should be_nil
+        end
+      end
+
+      context "passed as false" do
+        it "does not store vault records when transaction succeeds" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => Braintree::Test::TransactionAmounts::Authorize,
+            :customer => {
+              :last_name => "Doe"
+            },
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "12/12",
+            },
+            :options => { :store_in_vault_on_success => false }
+          )
+          result.success?.should == true
+          result.transaction.vault_customer.should be_nil
+          result.transaction.vault_credit_card.should be_nil
+        end
+
+        it "does not store vault records when transaction fails" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => Braintree::Test::TransactionAmounts::Decline,
+            :customer => {
+              :last_name => "Doe"
+            },
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "12/12",
+            },
+            :options => { :store_in_vault_on_success => false }
+          )
+          result.success?.should == false
+          result.transaction.vault_customer.should be_nil
+          result.transaction.vault_credit_card.should be_nil
+        end
+      end
+    end
   end
 
   describe "self.create!" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: braintree
 version: !ruby/object:Gem::Version 
-  hash: 41
+  hash: 39
   prerelease: false
   segments: 
   - 2
-  - 9
-  - 1
-  version: 2.9.1
+  - 10
+  - 0
+  version: 2.10.0
 platform: ruby
 authors: 
 - Braintree Payment Solutions
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-25 00:00:00 -05:00
+date: 2011-04-26 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -77,6 +77,7 @@ files:
 - lib/braintree/transaction/credit_card_details.rb
 - lib/braintree/transaction/customer_details.rb
 - lib/braintree/transaction/status_details.rb
+- lib/braintree/transaction/subscription_details.rb
 - lib/braintree/transaction.rb
 - lib/braintree/transaction_gateway.rb
 - lib/braintree/transaction_search.rb