braintree 2.76.0 → 2.77.0

data/spec/integration/braintree/http_spec.rb

@@ -69,6 +69,14 @@ describe Braintree::Http do
       end
     end
 
+    it "posts multipart for file uploads" do
+      config = Braintree::Configuration.instantiate
+      file = File.new("#{File.dirname(__FILE__)}/../../fixtures/files/bt_logo.png", "r")
+      response = config.http.post("#{config.base_merchant_path}/document_uploads", {"document_upload[kind]" => "evidence_document"}, file)
+      response[:document_upload][:content_type].should == "image/png"
+      response[:document_upload][:id].should_not be_nil
+    end
+
     describe "user_agent" do
       after do
         Braintree::Configuration.custom_user_agent = nil

data/spec/integration/braintree/payment_method_spec.rb

@@ -1223,29 +1223,18 @@ describe Braintree::PaymentMethod do
     end
 
     context "coinbase accounts" do
-      it "can make a coinbase account the default payment method" do
+      it "cannot create a payment method token with Coinbase" do
         customer = Braintree::Customer.create!
-        result = Braintree::CreditCard.create(
-          :customer_id => customer.id,
-          :number => Braintree::Test::CreditCardNumbers::Visa,
-          :expiration_date => "05/2009",
-          :options => {:make_default => true}
-        )
-        result.should be_success
 
         nonce = Braintree::Test::Nonce::Coinbase
-        original_token = Braintree::PaymentMethod.create(
+        result = Braintree::PaymentMethod.create(
           :payment_method_nonce => nonce,
           :customer_id => customer.id
-        ).payment_method.token
-
-        updated_result = Braintree::PaymentMethod.update(
-          original_token,
-          :options => {:make_default => true}
         )
 
-        updated_customer = Braintree::Customer.find(customer.id)
-        updated_customer.default_payment_method.token.should == original_token
+        result.should_not be_success
+
+        result.errors.for(:coinbase_account).first.code.should == Braintree::ErrorCodes::PaymentMethod::PaymentMethodNoLongerSupported
       end
     end
 

data/spec/integration/braintree/transaction_spec.rb

@@ -4329,6 +4329,19 @@ describe Braintree::Transaction do
     end
   end
 
+  describe "authorization_adjustments" do
+    it "includes authorization adjustments on found transactions" do
+      found_transaction = Braintree::Transaction.find("authadjustmenttransaction")
+
+      found_transaction.authorization_adjustments.count.should == 1
+
+      authorization_adjustment = found_transaction.authorization_adjustments.first
+      authorization_adjustment.amount.should == "-20.00"
+      authorization_adjustment.success.should == true
+      authorization_adjustment.timestamp.should be_a Time
+    end
+  end
+
   describe "vault_credit_card" do
     it "returns the Braintree::CreditCard if the transaction credit card is stored in the vault" do
       customer = Braintree::Customer.create!(
@@ -4700,6 +4713,9 @@ describe Braintree::Transaction do
         :payment_method_nonce => grant_result.payment_method_nonce.nonce,
         :amount => Braintree::Test::TransactionAmounts::Authorize
       )
+      result.transaction.facilitated_details.merchant_id.should == "integration_merchant_id"
+      result.transaction.facilitated_details.merchant_name.should == "14ladders"
+      result.transaction.facilitated_details.payment_method_nonce.should == grant_result.payment_method_nonce.nonce
       result.transaction.facilitator_details.should_not == nil
       result.transaction.facilitator_details.oauth_application_client_id.should == "client_id$#{Braintree::Configuration.environment}$integration_client_id"
       result.transaction.facilitator_details.oauth_application_name.should == "PseudoShop"
@@ -4715,9 +4731,7 @@ describe Braintree::Transaction do
       )
 
       result.transaction.billing_details.postal_code == "95131"
-   end
-
-
+    end
 
     it "allows transactions to be created with a shared payment method, customer, billing and shipping addresses" do
       result = @granting_gateway.transaction.sale(
@@ -4732,11 +4746,14 @@ describe Braintree::Transaction do
       result.transaction.billing_details.first_name.should == @address.first_name
     end
 
-    it "oauth app details are returned on transaction created via a shared_payment_method_token" do
+    it "facilitated details are returned on transaction created via a shared_payment_method_token" do
       result = @granting_gateway.transaction.sale(
         :shared_payment_method_token => @credit_card.token,
         :amount => Braintree::Test::TransactionAmounts::Authorize
       )
+      result.transaction.facilitated_details.merchant_id.should == "integration_merchant_id"
+      result.transaction.facilitated_details.merchant_name.should == "14ladders"
+      result.transaction.facilitated_details.payment_method_nonce.should == nil
       result.transaction.facilitator_details.should_not == nil
       result.transaction.facilitator_details.oauth_application_client_id.should == "client_id$#{Braintree::Configuration.environment}$integration_client_id"
       result.transaction.facilitator_details.oauth_application_name.should == "PseudoShop"

data/spec/spec_helper.rb

@@ -145,8 +145,9 @@ unless defined?(SPEC_HELPER_LOADED)
     def self.simulate_form_post_for_tr(tr_data_string, form_data_hash, url = Braintree::TransparentRedirect.url)
       response = nil
       config = Braintree::Configuration.instantiate
-      Net::HTTP.start(config.server, config.port) do |http|
-        http.use_ssl = config.ssl?
+      http = Net::HTTP.new(config.server, config.port)
+      http.use_ssl = config.ssl?
+      http.start do |http|
         request = Net::HTTP::Post.new("/" + url.split("/", 4)[3])
         request.add_field "Content-Type", "application/x-www-form-urlencoded"
         request.body = Braintree::Util.hash_to_query_string({:tr_data => tr_data_string}.merge(form_data_hash))

data/spec/unit/braintree/apple_pay_card_spec.rb

@@ -1,6 +1,12 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Braintree::ApplePayCard do
+  describe "bin" do
+    it "returns Apple pay card bin" do
+      Braintree::ApplePayCard._new(:gateway, bin: '411111').bin.should == '411111'
+    end
+  end
+
   describe "default?" do
     it "is true if the Apple pay card is the default payment method for the customer" do
       Braintree::ApplePayCard._new(:gateway, :default => true).default?.should == true

data/spec/unit/braintree/dispute_search_spec.rb

@@ -0,0 +1,59 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Braintree::DisputeSearch do
+  it "overrides previous 'is' with new 'is' for the same field" do
+    search = Braintree::DisputeSearch.new
+    search.id.is "dispute1"
+    search.id.is "dispute2"
+    search.to_hash.should == {:id => {:is => "dispute2"}}
+  end
+
+  it "overrides previous 'in' with new 'in' for the same field" do
+    search = Braintree::DisputeSearch.new
+    search.status.in Braintree::Dispute::Status::Open
+    search.status.in Braintree::Dispute::Status::Won
+    search.to_hash.should == {:status => [Braintree::Dispute::Status::Won]}
+  end
+
+  [
+    :amount_disputed,
+    :amount_won,
+    :case_number,
+    :id,
+    :merchant_account_id,
+    :reason_code,
+    :received_date,
+    :reference_number,
+    :reply_by_date,
+    :transaction_id,
+  ].each do |field|
+    it "allows searching on #{field}" do
+      search = Braintree::DisputeSearch.new
+
+      expect do
+        search.send(field).is "hello"
+      end.not_to raise_error
+    end
+  end
+
+  [
+    :kind,
+    :reason,
+    :status,
+    :transaction_source,
+  ].each do |field|
+    it "raises if provided an unknown #{field} value" do
+      search = Braintree::DisputeSearch.new
+      expect do
+        search.send(field).is "unknown value"
+      end.to raise_error(/Invalid argument/)
+    end
+  end
+
+  it "raises if no operator is provided" do
+    search = Braintree::DisputeSearch.new
+    expect do
+      search.id "one"
+    end.to raise_error(RuntimeError, "An operator is required")
+  end
+end

data/spec/unit/braintree/dispute_spec.rb

@@ -1,15 +1,338 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Braintree::Dispute do
+  let(:attributes) do
+    {
+      :id => "open_dispute",
+      :amount => "31.00",
+      :amount_disputed => "500.00",
+      :amount_won => "0.00",
+      :created_at => Time.utc(2009, 3, 9, 10, 50, 39),
+      :date_opened => "2009-03-09",
+      :date_won => "2009-04-15",
+      :original_dispute_id => "original_dispute_id",
+      :received_date => "2009-03-09",
+      :reply_by_date => nil,
+      :updated_at => Time.utc(2009, 3, 9, 10, 50, 39),
+      :evidence => [
+        {
+          comment: nil,
+          created_at: Time.utc(2009, 3, 10, 12, 5, 20),
+          id: "evidence1",
+          sent_to_processor_at: nil,
+          url: "url_of_file_evidence",
+        },
+        {
+          comment: "text evidence",
+          created_at: Time.utc(2009, 3, 10, 12, 5, 21),
+          id: "evidence2",
+          sent_to_processor_at: "2009-03-13",
+          url: nil,
+        }
+      ],
+      :status_history => [
+        {
+          :effective_date => "2009-03-09",
+          :status => "open",
+          :timestamp => Time.utc(2009, 3, 9, 10, 50, 39),
+        }
+      ],
+      :transaction => {
+        :amount => "31.00",
+        :id => "open_disputed_transaction",
+        :created_at => Time.utc(2009, 2, 9, 12, 59, 59),
+        :order_id => nil,
+        :purchase_order_number => "po",
+        :payment_instrument_subtype => "Visa",
+      }
+    }
+  end
+
+  [
+    :accept,
+    :finalize,
+    :find
+  ].each do |method_name|
+    describe "self.#{method_name}" do
+      it "raises an exception if the id is blank" do
+        expect do
+          Braintree::Dispute.public_send(method_name, "  ")
+        end.to raise_error(ArgumentError)
+      end
+
+      it "raises an exception if the id is nil" do
+        expect do
+          Braintree::Dispute.public_send(method_name, nil)
+        end.to raise_error(ArgumentError)
+      end
+
+      it "does not raise an exception if the id is a fixnum" do
+        Braintree::Http.stub(:new).and_return double.as_null_object
+        Braintree::Dispute.stub(:_new).and_return nil
+        Braintree::ErrorResult.stub(:new).and_return nil
+
+        expect do
+          Braintree::Dispute.public_send(method_name, 8675309)
+        end.to_not raise_error
+      end
+    end
+  end
+
+  describe "self.add_file_evidence" do
+    it "raises an exception if the dispute_id is blank" do
+      expect do
+        Braintree::Dispute.add_file_evidence("  ", "doc_upload_id")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the dispute_id is nil" do
+      expect do
+        Braintree::Dispute.add_file_evidence(nil, "doc_upload_id")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the dispute_id contains invalid characters" do
+      expect do
+        Braintree::Dispute.add_file_evidence("@#$%", "doc_upload_id")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "does not raise an exception if the dispute_id is a fixnum" do
+      Braintree::Http.stub(:new).and_return double.as_null_object
+      Braintree::Dispute.stub(:_new).and_return nil
+      expect do
+        Braintree::Dispute.add_file_evidence(8675309, "doc_upload_id")
+      end.to_not raise_error
+    end
+
+    it "raises an exception if the document_upload_id is blank" do
+      expect do
+        Braintree::Dispute.add_file_evidence("dispute_id", "  ")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the document_upload_id is nil" do
+      expect do
+        Braintree::Dispute.add_file_evidence("dispute_id", nil)
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the document_upload_id contains invalid characters" do
+      expect do
+        Braintree::Dispute.add_file_evidence("dispute_id", "@#$%")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "does not raise an exception if the document_upload_id is a fixnum" do
+      Braintree::Http.stub(:new).and_return double.as_null_object
+      Braintree::Dispute.stub(:_new).and_return nil
+      expect do
+        Braintree::Dispute.add_file_evidence("dispute_id", 8675309)
+      end.to_not raise_error
+    end
+  end
+
+  describe "self.add_text_evidence" do
+    it "raises an exception if the id is blank" do
+      expect do
+        Braintree::Dispute.add_text_evidence("  ", "text evidence")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the id is nil" do
+      expect do
+        Braintree::Dispute.add_text_evidence(nil, "text evidence")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the id contains invalid characters" do
+      expect do
+        Braintree::Dispute.add_text_evidence("@#$%", "text evidence")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "does not raise an exception if the id is a fixnum" do
+      Braintree::Http.stub(:new).and_return double.as_null_object
+      Braintree::Dispute.stub(:_new).and_return nil
+      expect do
+        Braintree::Dispute.add_text_evidence(8675309, "text evidence")
+      end.to_not raise_error
+    end
+
+    it "raises an exception if the content is blank" do
+      expect do
+        Braintree::Dispute.add_text_evidence("dispute_id", " ")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the content is nil" do
+      expect do
+        Braintree::Dispute.add_text_evidence("dispute_id", nil)
+      end.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "self.remove_evidence" do
+    it "raises an exception if the dispute_id is blank" do
+      expect do
+        Braintree::Dispute.remove_evidence("  ")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the dispute_id is nil" do
+      expect do
+        Braintree::Dispute.remove_evidence(nil)
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the content is blank" do
+      expect do
+        Braintree::Dispute.remove_evidence("dispute_id", " ")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the content is nil" do
+      expect do
+        Braintree::Dispute.remove_evidence("dispute_id", nil)
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the dispute_id contains invalid characters" do
+      expect do
+        Braintree::Dispute.remove_evidence("@#$%", "evidence_id")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises an exception if the evidence_id contains invalid characters" do
+      expect do
+        Braintree::Dispute.remove_evidence("dispute_id", "@#$%")
+      end.to raise_error(ArgumentError)
+    end
+  end
+
   describe "initialize" do
-    it "handles nil reply_by_date" do
-      dispute = Braintree::Dispute._new(
-        :amount => "500.00",
-        :received_date => "2014-03-01",
-        :reply_by_date => nil
-      )
-
-      dispute.reply_by_date.should == nil
+    it "converts string amount_dispute and amount_won" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.amount_disputed.should == 500.0
+      dispute.amount_won.should == 0.0
+    end
+
+    [
+      :reply_by_date,
+      :amount,
+      :date_opened,
+      :date_won,
+      :status_history,
+    ].each do |field|
+      it "handles nil #{field}" do
+        attributes.delete(field)
+
+        dispute = Braintree::Dispute._new(attributes)
+
+        dispute.send(field).should == nil
+      end
+    end
+
+    it "converts date_opened, date_won, reply_by_date, received_date from String to Date" do
+      dispute = Braintree::Dispute._new(attributes.merge(:reply_by_date => "2009-03-14"))
+
+      dispute.date_opened.should == Date.new(2009, 3, 9)
+      dispute.date_won.should == Date.new(2009, 4, 15)
+      dispute.received_date.should == Date.new(2009, 3, 9)
+      dispute.reply_by_date.should == Date.new(2009, 3, 14)
+    end
+
+    it "converts transaction hash into a Dispute::TransactionDetails object first" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.transaction_details.id.should == "open_disputed_transaction"
+      dispute.transaction_details.amount.should == 31.00
+    end
+
+    it "converts transaction hash into a Dispute::Transaction object" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.transaction.amount.should == 31.00
+      dispute.transaction.id.should == "open_disputed_transaction"
+      dispute.transaction.order_id.should == nil
+      dispute.transaction.purchase_order_number.should == "po"
+      dispute.transaction.payment_instrument_subtype.should == "Visa"
+    end
+
+    it "converts status_history hash into an array of Dispute::HistoryEvent objects" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.status_history.length.should == 1
+      status_history_1 = dispute.status_history.first
+      status_history_1.status.should == Braintree::Dispute::Status::Open
+      status_history_1.timestamp.should == Time.utc(2009, 3, 9, 10, 50, 39)
+    end
+
+    it "converts evidence hash into an array of Dispute::Evidence objects" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.evidence.length.should ==2
+      evidence1 = dispute.evidence.first
+      evidence1.comment.should == nil
+      evidence1.created_at.should == Time.utc(2009, 3, 10, 12, 5, 20)
+      evidence1.id.should == "evidence1"
+      evidence1.sent_to_processor_at.should == nil
+      evidence1.url.should == "url_of_file_evidence"
+
+      evidence2 = dispute.evidence.last
+      evidence2.comment.should == "text evidence"
+      evidence2.created_at.should == Time.utc(2009, 3, 10, 12, 5, 21)
+      evidence2.id.should == "evidence2"
+      evidence2.sent_to_processor_at.should == Date.new(2009, 3, 13)
+      evidence2.url.should == nil
+    end
+
+    it "handles nil evidence" do
+      attributes.delete(:evidence)
+
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.evidence.should == nil
+    end
+
+    it "sets the older webhook fields for backwards compatibility" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.amount.should == 31.00
+      dispute.date_opened.should == Date.new(2009, 3, 9)
+      dispute.date_won.should == Date.new(2009, 4, 15)
+    end
+  end
+
+  describe "==" do
+    it "returns true when given a dispute with the same id" do
+      first = Braintree::Dispute._new(attributes)
+      second = Braintree::Dispute._new(attributes)
+
+      first.should == second
+      second.should == first
+    end
+
+    it "returns false when given a dispute with a different id" do
+      first = Braintree::Dispute._new(attributes)
+      second = Braintree::Dispute._new(attributes.merge(:id => "1234"))
+
+      first.should_not == second
+      second.should_not == first
+    end
+
+    it "returns false when not given a dispute" do
+      dispute = Braintree::Dispute._new(attributes)
+      dispute.should_not == "not a dispute"
+    end
+  end
+
+  describe "new" do
+    it "is protected" do
+      expect do
+        Braintree::Dispute.new
+      end.to raise_error(NoMethodError, /protected method .new/)
     end
   end
 end