braintree 2.74.0 → 4.12.0

data/spec/integration/braintree/exchange_rate_quote_spec.rb

@@ -0,0 +1,97 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
+
+describe Braintree::ExchangeRateQuoteGateway do
+  let(:gateway) do
+    Braintree::Gateway.new(
+      :environment => :development,
+      :merchant_id => "integration_merchant_id",
+      :public_key => "integration_public_key",
+      :private_key => "integration_private_key",
+    )
+  end
+
+  describe "generate" do
+    def quote_input_request
+      gateway.exchange_rate_quote.generate({quotes: [quote_input]})
+    end
+
+    let(:quote_input) do
+      {
+        :baseCurrency => "EUR",
+        :quoteCurrency => "GBP",
+        :baseAmount => "20.00",
+        :markup => "4.00"
+      }
+    end
+
+    it "generates exchange rate quotes" do
+      result = quote_input_request
+      quotes = result[:quotes]
+
+      expect(quotes[0][:id]).not_to be_nil
+      expect(quotes[0][:baseAmount]).not_to be_nil
+      expect(quotes[0][:quoteAmount]).not_to be_nil
+      expect(quotes[0][:exchangeRate]).not_to be_nil
+      expect(quotes[0][:expiresAt]).not_to be_nil
+      expect(quotes[0][:refreshesAt]).not_to be_nil
+
+      expect(quotes[1][:id]).not_to be_nil
+      expect(quotes[1][:baseAmount]).not_to be_nil
+      expect(quotes[1][:quoteAmount]).not_to be_nil
+      expect(quotes[1][:exchangeRate]).not_to be_nil
+      expect(quotes[1][:expiresAt]).not_to be_nil
+      expect(quotes[1][:refreshesAt]).not_to be_nil
+    end
+
+    context "when base currency input param is not passed" do
+      let(:quote_input) do
+        {
+          :quoteCurrency => "GBP",
+          :baseAmount => "20.00",
+          :markup => "4.00"
+        }
+      end
+      let(:error_message) { "baseCurrency" }
+
+      it "raises an UnexpectedError" do
+        expect do
+          quote_input_request
+        end.to raise_error(Braintree::UnexpectedError, /#{error_message}/)
+      end
+    end
+
+    context "when quote currency input param is not passed" do
+      let(:quote_input) do
+        {
+          :baseCurrency => "GBP",
+          :baseAmount => "20.00",
+          :markup => "4.00"
+        }
+      end
+      let(:error_message) { "quoteCurrency" }
+
+      it "raises an UnexpectedError" do
+        expect do
+          quote_input_request
+        end.to raise_error(Braintree::UnexpectedError, /#{error_message}/)
+      end
+    end
+
+    context "when base and quote currency input params are not passed" do
+      let(:quote_input) do
+        {
+          :baseAmount => "20.00",
+          :markup => "4.00"
+        }
+      end
+      let(:error_message) { "baseCurrency" }
+
+      it "raises an UnexpectedError" do
+        expect do
+          quote_input_request
+        end.to raise_error(Braintree::UnexpectedError, /#{error_message}/)
+      end
+    end
+  end
+end

data/spec/integration/braintree/graphql_client_spec.rb

@@ -0,0 +1,72 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Braintree::GraphQLClient do
+  before :each do
+      @config = Braintree::Configuration.instantiate
+  end
+
+  describe "initialize" do
+    it "assigns overriding graphql headers" do
+      expect(@config.graphql_client.instance_variable_get("@graphql_headers")).to be_kind_of(Hash)
+    end
+  end
+
+  describe "query" do
+    it "makes valid GraphQL queries when given a definition" do
+      definition = <<-GRAPHQL
+      query {
+        ping
+      }
+      GRAPHQL
+
+      response = Braintree::GraphQLClient.new(@config).query(definition)
+
+      expect(response[:data]).to eq({:ping=>"pong"})
+    end
+
+    it "makes valid GraphQL requests when given a definitiona and variable" do
+      definition = <<-GRAPHQL
+mutation CreateClientToken($input: CreateClientTokenInput!) {
+  createClientToken(input: $input) {
+    clientToken
+  }
+}
+      GRAPHQL
+
+      variables = {
+        input: {
+          clientToken: {
+            merchantAccountId: "ABC123"
+          }
+        }
+      }
+
+      response = Braintree::GraphQLClient.new(@config).query(definition, variables)
+
+      expect(response[:data][:createClientToken][:clientToken]).to be_a(String)
+    end
+
+    it "returns results parsable into validation errors" do
+      definition = <<-GRAPHQL
+query TransactionLevelFeeReport($date: Date!, $merchantAccountId: ID) {
+  report {
+    transactionLevelFees(date: $date, merchantAccountId: $merchantAccountId) {
+      url
+    }
+  }
+}
+      GRAPHQL
+
+      variables = {
+        date: "2018-01-01",
+        merchantAccountId: "some_merchant"
+      }
+
+      response = Braintree::GraphQLClient.new(@config).query(definition, variables)
+      errors = Braintree::ValidationErrorCollection.new(response)
+
+      expect(errors.size).to eq(1)
+      expect(errors.first.message).to eq("Invalid merchant account id: some_merchant")
+    end
+  end
+end

data/spec/integration/braintree/http_spec.rb

@@ -18,7 +18,7 @@ describe Braintree::Http do
     it "raises an AuthorizationError if authorization fails" do
       expect do
         config = Braintree::Configuration.instantiate
-        config.http.get("#{config.base_merchant_path}/users")
+        config.http.get("#{config.base_merchant_path}/home")
       end.to raise_error(Braintree::AuthorizationError)
     end
   end
@@ -54,7 +54,7 @@ describe Braintree::Http do
             :customer_id => customer.id,
             :cardholder_name => "Sam Jones",
             :number => Braintree::Test::CreditCardNumbers::Visa,
-            :expiration_date => "05/2009"
+            :expiration_date => "05/2009",
           )
           result.success?.should == true
           utc_or_gmt = Time.now.utc.strftime("%Z")
@@ -69,6 +69,14 @@ describe Braintree::Http do
       end
     end
 
+    it "posts multipart for file uploads" do
+      config = Braintree::Configuration.instantiate
+      file = File.new("#{File.dirname(__FILE__)}/../../fixtures/files/bt_logo.png", "r")
+      response = config.http.post("#{config.base_merchant_path}/document_uploads", {"document_upload[kind]" => "evidence_document"}, file)
+      response[:document_upload][:content_type].should == "image/png"
+      response[:document_upload][:id].should_not be_nil
+    end
+
     describe "user_agent" do
       after do
         Braintree::Configuration.custom_user_agent = nil
@@ -89,7 +97,7 @@ describe Braintree::Http do
     end
 
     describe "ssl_version" do
-      it "causes failed requests to sandbox with incompatible SSL version" do
+      xit "causes failed requests to sandbox with incompatible SSL version" do
         begin
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox
@@ -148,7 +156,7 @@ describe Braintree::Http do
           # Random CA root file from a different certificate authority
           config = Braintree::Configuration.instantiate
           config.stub(:ca_file).and_return(
-            File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "ssl", "geotrust_global.crt"))
+            File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "ssl", "geotrust_global.crt")),
           )
           config.stub(:ssl?).and_return(true)
           config.stub(:port).and_return(SSL_TEST_PORT)

data/spec/integration/braintree/merchant_account_spec.rb

@@ -41,7 +41,7 @@ VALID_APPLICATION_PARAMS = {
   :business => {
     :legal_name => "Joe's Bloggs",
     :dba_name => "Joe's Junkyard",
-    :tax_id => "123456789",
+    :tax_id => "423456789",
     :address => {
       :street_address => "456 Fake St",
       :postal_code => "48104",
@@ -65,7 +65,7 @@ describe Braintree::MerchantAccount do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       code = Braintree::OAuthTestHelper.create_grant(gateway, {
@@ -75,12 +75,12 @@ describe Braintree::MerchantAccount do
 
       result = gateway.oauth.create_token_from_code(
         :code => code,
-        :scope => "read_write"
+        :scope => "read_write",
       )
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.all
@@ -92,18 +92,18 @@ describe Braintree::MerchantAccount do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.all
@@ -113,6 +113,33 @@ describe Braintree::MerchantAccount do
       result.merchant_accounts.first.status.should == "active"
       result.merchant_accounts.first.default.should == true
     end
+
+    it "returns all merchant accounts for read_only scoped grants" do
+      gateway = Braintree::Gateway.new(
+        :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
+        :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
+        :logger => Logger.new("/dev/null"),
+      )
+
+      code = Braintree::OAuthTestHelper.create_grant(gateway, {
+        :merchant_public_id => "integration_merchant_id",
+        :scope => "read_only"
+      })
+
+      result = gateway.oauth.create_token_from_code(
+        :code => code,
+        :scope => "read_only",
+      )
+
+      gateway = Braintree::Gateway.new(
+        :access_token => result.credentials.access_token,
+        :logger => Logger.new("/dev/null"),
+      )
+
+      result = gateway.merchant_account.all
+      result.should be_success
+      result.merchant_accounts.count.should > 20
+    end
   end
 
   describe "create" do
@@ -137,8 +164,8 @@ describe Braintree::MerchantAccount do
       sub_merchant_account_id = "sub_merchant_account_id#{random_number}"
       result = Braintree::MerchantAccount.create(
         VALID_APPLICATION_PARAMS.merge(
-          :id => sub_merchant_account_id
-        )
+          :id => sub_merchant_account_id,
+        ),
       )
 
       result.should be_success
@@ -155,7 +182,7 @@ describe Braintree::MerchantAccount do
 
     it "requires all fields" do
       result = Braintree::MerchantAccount.create(
-        :master_merchant_account_id => "sandbox_master_merchant_account"
+        :master_merchant_account_id => "sandbox_master_merchant_account",
       )
       result.should_not be_success
       result.errors.for(:merchant_account).on(:tos_accepted).first.code.should == Braintree::ErrorCodes::MerchantAccount::TosAcceptedIsRequired
@@ -190,6 +217,15 @@ describe Braintree::MerchantAccount do
     end
   end
 
+  describe "create!" do
+    it "creates a merchant account with the new parameters and doesn't require an id" do
+      merchant_account = Braintree::MerchantAccount.create!(VALID_APPLICATION_PARAMS)
+
+      merchant_account.status.should == Braintree::MerchantAccount::Status::Pending
+      merchant_account.master_merchant_account.id.should == "sandbox_master_merchant_account"
+    end
+  end
+
   describe "create_for_currency" do
     it "creates a new merchant account for currency" do
       result = SpecHelper::create_merchant
@@ -197,11 +233,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "JPY"
+        :currency => "JPY",
       )
       result.should be_success
       result.merchant_account.currency_iso_code.should == "JPY"
@@ -213,16 +249,16 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "USD"
+        :currency => "USD",
       )
       result.should be_success
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "USD"
+        :currency => "USD",
       )
       result.should_not be_success
 
@@ -236,11 +272,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => nil
+        :currency => nil,
       )
       result.should_not be_success
 
@@ -260,11 +296,11 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant_account.create_for_currency(
-        :currency => "FAKE_CURRENCY"
+        :currency => "FAKE_CURRENCY",
       )
       result.should_not be_success
 
@@ -278,13 +314,13 @@ describe Braintree::MerchantAccount do
 
       gateway = Braintree::Gateway.new(
         :access_token => result.credentials.access_token,
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       merchant = result.merchant
       result = gateway.merchant_account.create_for_currency(
         :currency => "USD",
-        :id => merchant.merchant_accounts.first.id
+        :id => merchant.merchant_accounts.first.id,
       )
       result.should_not be_success
 
@@ -302,7 +338,6 @@ describe Braintree::MerchantAccount do
       id = result.merchant_account.id
       merchant_account = Braintree::MerchantAccount.find(id)
 
-      merchant_account.status.should == Braintree::MerchantAccount::Status::Active
       merchant_account.individual_details.first_name.should == VALID_APPLICATION_PARAMS[:individual][:first_name]
       merchant_account.individual_details.last_name.should == VALID_APPLICATION_PARAMS[:individual][:last_name]
     end
@@ -316,7 +351,7 @@ describe Braintree::MerchantAccount do
     it "raises a NotFoundError exception if merchant account cannot be found" do
       expect do
         Braintree::MerchantAccount.find("non-existant")
-      end.to raise_error(Braintree::NotFoundError, 'Merchant account with id non-existant not found')
+      end.to raise_error(Braintree::NotFoundError, "Merchant account with id non-existant not found")
     end
   end
 
@@ -336,7 +371,7 @@ describe Braintree::MerchantAccount do
       params[:individual][:address][:postal_code] = "60622"
       params[:business][:dba_name] = "James's Bloggs"
       params[:business][:legal_name] = "James's Bloggs Inc"
-      params[:business][:tax_id] = "123456789"
+      params[:business][:tax_id] = "423456789"
       params[:business][:address][:street_address] = "999 Fake St"
       params[:business][:address][:locality] = "Miami"
       params[:business][:address][:region] = "FL"
@@ -362,7 +397,7 @@ describe Braintree::MerchantAccount do
       result.merchant_account.individual_details.address_details.postal_code.should == "60622"
       result.merchant_account.business_details.dba_name.should == "James's Bloggs"
       result.merchant_account.business_details.legal_name.should == "James's Bloggs Inc"
-      result.merchant_account.business_details.tax_id.should == "123456789"
+      result.merchant_account.business_details.tax_id.should == "423456789"
       result.merchant_account.business_details.address_details.street_address.should == "999 Fake St"
       result.merchant_account.business_details.address_details.locality.should == "Miami"
       result.merchant_account.business_details.address_details.region.should == "FL"
@@ -376,7 +411,7 @@ describe Braintree::MerchantAccount do
     end
 
     it "does not require all fields" do
-      result = Braintree::MerchantAccount.update("sandbox_sub_merchant_account", { :individual => { :first_name => "Jose" } })
+      result = Braintree::MerchantAccount.update("sandbox_sub_merchant_account", {:individual => {:first_name => "Jose"}})
       result.should be_success
     end
 
@@ -552,4 +587,17 @@ describe Braintree::MerchantAccount do
       result.errors.for(:merchant_account).for(:funding).on(:mobile_phone).map(&:code).should == [Braintree::ErrorCodes::MerchantAccount::Funding::MobilePhoneIsRequired]
     end
   end
+
+  describe "update!" do
+    it "updates the Merchant Account info" do
+      params = VALID_APPLICATION_PARAMS.clone
+      params.delete(:tos_accepted)
+      params.delete(:master_merchant_account_id)
+      params[:individual][:first_name] = "John"
+      params[:individual][:last_name] = "Doe"
+      merchant_account = Braintree::MerchantAccount.update!("sandbox_sub_merchant_account", params)
+      merchant_account.individual_details.first_name.should == "John"
+      merchant_account.individual_details.last_name.should == "Doe"
+    end
+  end
 end

data/spec/integration/braintree/merchant_spec.rb

@@ -6,13 +6,13 @@ describe Braintree::MerchantGateway do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["credit_card", "paypal"]
+        :payment_methods => ["credit_card", "paypal"],
       )
 
       result.should be_success
@@ -37,13 +37,13 @@ describe Braintree::MerchantGateway do
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       result = gateway.merchant.create(
         :email => "name@email.com",
         :country_code_alpha3 => "USA",
-        :payment_methods => ["fake_money"]
+        :payment_methods => ["fake_money"],
       )
 
       result.should_not be_success
@@ -52,12 +52,38 @@ describe Braintree::MerchantGateway do
       errors[0].code.should == Braintree::ErrorCodes::Merchant::PaymentMethodsAreInvalid
     end
 
+    context "credentials" do
+      around(:each) do |example|
+        old_merchant_id_value = Braintree::Configuration.merchant_id
+        example.run
+        Braintree::Configuration.merchant_id = old_merchant_id_value
+      end
+
+      it "allows using a merchant_id passed in through Gateway" do
+        Braintree::Configuration.merchant_id = nil
+
+        gateway = Braintree::Gateway.new(
+          :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
+          :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
+          :merchant_id => "integration_merchant_id",
+          :logger => Logger.new("/dev/null"),
+        )
+        result = gateway.merchant.create(
+          :email => "name@email.com",
+          :country_code_alpha3 => "USA",
+          :payment_methods => ["credit_card", "paypal"],
+        )
+
+        result.should be_success
+      end
+    end
+
     context "multiple currencies" do
       before(:each) do
         @gateway = Braintree::Gateway.new(
           :client_id => "client_id$development$signup_client_id",
           :client_secret => "client_secret$development$signup_client_secret",
-          :logger => Logger.new("/dev/null")
+          :logger => Logger.new("/dev/null"),
         )
       end
 
@@ -66,7 +92,7 @@ describe Braintree::MerchantGateway do
           :email => "name@email.com",
           :country_code_alpha3 => "USA",
           :payment_methods => ["credit_card", "paypal"],
-          :currencies => ["GBP", "USD"]
+          :currencies => ["GBP", "USD"],
         )
 
         merchant = result.merchant
@@ -101,7 +127,7 @@ describe Braintree::MerchantGateway do
           :email => "name@email.com",
           :country_code_alpha3 => "GBR",
           :payment_methods => ["credit_card", "paypal"],
-          :currencies => ["GBP", "USD"]
+          :currencies => ["GBP", "USD"],
         )
 
         merchant = result.merchant
@@ -141,7 +167,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -181,7 +207,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -217,7 +243,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should be_success
@@ -254,7 +280,7 @@ describe Braintree::MerchantGateway do
           :paypal_account => {
             :client_id => "paypal_client_id",
             :client_secret => "paypal_client_secret",
-          }
+          },
         )
 
         result.should_not be_success
@@ -279,7 +305,7 @@ describe Braintree::MerchantGateway do
       it "succeeds" do
         result = Braintree::Merchant.provision_raw_apple_pay
         result.should be_success
-        result.supported_networks.should == ["visa", "mastercard", "amex", "discover"]
+        result.supported_networks.should == ["visa", "mastercard", "amex", "discover", "maestro", "elo"]
       end
 
       it "is repeatable" do
@@ -287,7 +313,7 @@ describe Braintree::MerchantGateway do
         result.should be_success
         result = Braintree::Merchant.provision_raw_apple_pay
         result.should be_success
-        result.supported_networks.should == ["visa", "mastercard", "amex", "discover"]
+        result.supported_networks.should == ["visa", "mastercard", "amex", "discover", "maestro", "elo"]
       end
     end