braintree 2.30.0 → 2.30.2

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -0,0 +1,80 @@
+require 'json'
+
+def nonce_for_new_credit_card(options)
+  client_token_options = options.delete(:client_token_options) || {}
+  client_token = Braintree::ClientToken.generate(client_token_options)
+  client = ClientApiHttp.new(Braintree::Configuration.instantiate,
+    :authorization_fingerprint => JSON.parse(client_token)["authorizationFingerprint"],
+    :shared_customer_identifier => "fake_identifier",
+    :shared_customer_identifier_type => "testing"
+  )
+
+  response = client.add_card(options)
+  body = JSON.parse(response.body)
+
+  if body["errors"] != nil
+    raise body["errors"].inspect
+  end
+
+  body["nonce"]
+end
+
+class ClientApiHttp
+  attr_reader :config, :options
+
+  def initialize(config, options)
+    @config = config
+    @options = options
+  end
+
+  def get(path)
+    _http_do(Net::HTTP::Get, path)
+  end
+
+  def post(path, params)
+    _http_do(Net::HTTP::Post, path, params.to_json)
+  end
+
+  def fingerprint=(fingerprint)
+    @options[:authorization_fingerprint] = fingerprint
+  end
+
+  def _http_do(http_verb, path, body = nil)
+    connection = Net::HTTP.new(@config.server, @config.port)
+    connection.read_timeout = 60
+    if @config.ssl?
+      connection.use_ssl = true
+      connection.verify_mode = OpenSSL::SSL::VERIFY_PEER
+      connection.ca_file = @config.ca_file
+      connection.verify_callback = proc { |preverify_ok, ssl_context| _verify_ssl_certificate(preverify_ok, ssl_context) }
+    end
+    connection.start do |http|
+      request = http_verb.new(path)
+      request["X-ApiVersion"] = @config.api_version
+      request["Content-Type"] = "application/json"
+      request.body = body if body
+      http.request(request)
+    end
+  rescue OpenSSL::SSL::SSLError
+    raise Braintree::SSLCertificateError
+  end
+
+  def get_cards
+    encoded_fingerprint = Braintree::Util.url_encode(@options[:authorization_fingerprint])
+    url = "/merchants/#{@config.merchant_id}/client_api/nonces.json?"
+    url += "authorizationFingerprint=#{encoded_fingerprint}"
+    url += "&sharedCustomerIdentifier=#{@options[:shared_customer_identifier]}"
+    url += "&sharedCustomerIdentifierType=#{@options[:shared_customer_identifier_type]}"
+
+    get(url)
+  end
+
+  def add_card(params)
+    fingerprint = @options[:authorization_fingerprint]
+    params[:authorizationFingerprint] = fingerprint
+    params[:sharedCustomerIdentifier] = @options[:shared_customer_identifier]
+    params[:sharedCustomerIdentifierType] = @options[:shared_customer_identifier_type]
+
+    post("/merchants/#{@config.merchant_id}/client_api/nonces.json", params)
+  end
+end

data/spec/integration/braintree/credit_card_spec.rb

@@ -1,4 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 describe Braintree::CreditCard do
   describe "self.create" do
@@ -452,6 +453,30 @@ describe Braintree::CreditCard do
         end
       end
     end
+
+    context "client API" do
+      it "adds credit card to an existing customer using a payment method nonce" do
+        nonce = nonce_for_new_credit_card(
+          :credit_card => {
+            :number => "4111111111111111",
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          },
+          :share => true
+        )
+        customer = Braintree::Customer.create!
+        result = Braintree::CreditCard.create(
+          :customer_id => customer.id,
+          :payment_method_nonce => nonce
+        )
+
+        result.success?.should == true
+        credit_card = result.credit_card
+        credit_card.bin.should == "411111"
+        credit_card.last_4.should == "1111"
+        credit_card.expiration_date.should == "11/2099"
+      end
+    end
   end
 
   describe "self.create!" do
@@ -1138,6 +1163,80 @@ describe Braintree::CreditCard do
     end
   end
 
+  describe "self.from_nonce" do
+    it "finds the payment method with the given nonce" do
+      customer = Braintree::Customer.create!
+      nonce = nonce_for_new_credit_card(
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_month => "11",
+          :expiration_year => "2099",
+        },
+        :client_token_options => {:customer_id => customer.id}
+      )
+
+      credit_card = Braintree::CreditCard.from_nonce(nonce)
+      customer = Braintree::Customer.find(customer.id)
+      credit_card.should == customer.credit_cards.first
+    end
+
+    it "does not find a payment method for an unlocked nonce that points to a shared credit card" do
+      nonce = nonce_for_new_credit_card(
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_month => "11",
+          :expiration_year => "2099",
+        }
+      )
+      expect do
+        Braintree::CreditCard.from_nonce(nonce)
+      end.to raise_error(Braintree::NotFoundError)
+    end
+
+    it "does not find the payment method for a locked nonce" do
+      client_token = Braintree::ClientToken.generate
+      client = ClientApiHttp.new(Braintree::Configuration.instantiate,
+        :authorization_fingerprint => JSON.parse(client_token)["authorizationFingerprint"],
+        :shared_customer_identifier => "fake_identifier",
+        :shared_customer_identifier_type => "testing"
+      )
+
+      client.add_card(
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_month => "11",
+          :expiration_year => "2099",
+        },
+        :share => true
+      )
+
+      response = client.get_cards
+      body = JSON.parse(response.body)
+      nonce = body["creditCards"].first["nonce"]
+
+      expect do
+        Braintree::CreditCard.from_nonce(nonce)
+      end.to raise_error(Braintree::NotFoundError, /locked/)
+    end
+
+    it "does not find the payment method for a consumednonce" do
+      customer = Braintree::Customer.create!
+      nonce = nonce_for_new_credit_card(
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_month => "11",
+          :expiration_year => "2099",
+        },
+        :client_token_options => {:customer_id => customer.id}
+      )
+
+      Braintree::CreditCard.from_nonce(nonce)
+      expect do
+        Braintree::CreditCard.from_nonce(nonce)
+      end.to raise_error(Braintree::NotFoundError, /consumed/)
+    end
+  end
+
   describe "self.sale" do
     it "creates a sale transaction using the credit card, returning a result object" do
       customer = Braintree::Customer.create!(

data/spec/integration/braintree/customer_spec.rb

@@ -1,5 +1,6 @@
 # encoding: utf-8
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 describe Braintree::Customer do
   describe "self.all" do
@@ -379,6 +380,29 @@ describe Braintree::Customer do
         result.customer.credit_cards.first.venmo_sdk?.should == true
       end
     end
+
+    context "client API" do
+      it "can create a customer with a payment method nonce" do
+        nonce = nonce_for_new_credit_card(
+          :credit_card => {
+            :number => "4111111111111111",
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          },
+          :share => true
+        )
+
+        result = Braintree::Customer.create(
+          :credit_card => {
+            :payment_method_nonce => nonce
+          }
+        )
+
+        result.success?.should == true
+        result.customer.credit_cards.first.bin.should == "411111"
+        result.customer.credit_cards.first.last_4.should == "1111"
+      end
+    end
   end
 
   describe "self.create!" do

data/spec/integration/braintree/subscription_spec.rb

@@ -1,4 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 describe Braintree::Subscription do
 
@@ -63,6 +64,28 @@ describe Braintree::Subscription do
       result.subscription.id.should == new_id
     end
 
+    it "creates a subscription when given a payment_method_nonce" do
+      nonce = nonce_for_new_credit_card(
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_month => "11",
+          :expiration_year => "2099",
+        },
+        :client_token_options => {
+          :customer_id => @credit_card.customer_id
+        }
+      )
+      result = Braintree::Subscription.create(
+        :payment_method_nonce => nonce,
+        :plan_id => SpecHelper::TriallessPlan[:id]
+      )
+
+      result.success?.should == true
+      transaction = result.subscription.transactions[0]
+      transaction.credit_card_details.bin.should == Braintree::Test::CreditCardNumbers::Visa[0, 6]
+      transaction.credit_card_details.last_4.should == Braintree::Test::CreditCardNumbers::Visa[-4, 4]
+    end
+
     context "billing_day_of_month" do
       it "inherits from the plan if not provided" do
         result = Braintree::Subscription.create(
@@ -653,7 +676,7 @@ describe Braintree::Subscription do
       result.subscription.merchant_account_id.should == SpecHelper::NonDefaultMerchantAccountId
     end
 
-    it "allows changing the payment_method_token" do
+    it "allows changing the payment method by payment_method_token" do
       new_credit_card = Braintree::CreditCard.create!(
         :customer_id => @credit_card.customer_id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
@@ -667,6 +690,22 @@ describe Braintree::Subscription do
       result.subscription.payment_method_token.should == new_credit_card.token
     end
 
+    it "allows changing the payment_method by payment_method_nonce" do
+      nonce = nonce_for_new_credit_card(
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::MasterCard,
+          :expiration_date => "05/2010"
+        },
+        :client_token_options => {
+          :customer_id => @credit_card.customer_id,
+        }
+      )
+
+      result = Braintree::Subscription.update(@subscription.id, :payment_method_nonce => nonce)
+      result.subscription.transactions[0].credit_card_details.token.should == @credit_card.token
+      result.subscription.payment_method_token.should_not == @credit_card.token
+    end
+
     it "allows chaning the descriptors" do
       result = Braintree::Subscription.update(@subscription.id,
         :descriptor => {

data/spec/integration/braintree/transaction_search_spec.rb

@@ -696,7 +696,7 @@ describe Braintree::Transaction, "search" do
       context "dispute_date" do
         it "searches on dispute_date in UTC" do
           disputed_time = Time.parse("2014-03-01 00:00:00 UTC")
-          transaction_id = "disputedtransaction"
+          transaction_id = "2disputetransaction"
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction_id
@@ -746,7 +746,7 @@ describe Braintree::Transaction, "search" do
 
         it "searches on dispute_date in local time" do
           now = Time.parse("2014-03-01 18:00:00 CST")
-          transaction_id = "disputedtransaction"
+          transaction_id = "2disputetransaction"
 
           collection = Braintree::Transaction.search do |search|
             search.id.is transaction_id

data/spec/integration/braintree/transaction_spec.rb

@@ -1,4 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 describe Braintree::Transaction do
   describe "self.clone_transaction" do
@@ -1053,6 +1054,27 @@ describe Braintree::Transaction do
         result.transaction.credit_card_details.venmo_sdk?.should == true
       end
     end
+
+    context "client API" do
+      it "can create a transaction with a nonce" do
+        nonce = nonce_for_new_credit_card(
+          :credit_card => {
+            :number => "4111111111111111",
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          },
+          :share => true
+        )
+
+        result = Braintree::Transaction.create(
+          :type => "sale",
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :payment_method_nonce => nonce
+        )
+
+        result.success?.should == true
+      end
+    end
   end
 
   describe "self.create!" do
@@ -1207,7 +1229,7 @@ describe Braintree::Transaction do
         :customer => {
           :first_name => "Dan",
           :last_name => "Smith",
-          :company => "Braintree Payment Solutions",
+          :company => "Braintree",
           :email => "dan@example.com",
           :phone => "419-555-1234",
           :fax => "419-555-1235",
@@ -1259,7 +1281,7 @@ describe Braintree::Transaction do
       transaction.cvv_response_code.should == "M"
       transaction.customer_details.first_name.should == "Dan"
       transaction.customer_details.last_name.should == "Smith"
-      transaction.customer_details.company.should == "Braintree Payment Solutions"
+      transaction.customer_details.company.should == "Braintree"
       transaction.customer_details.email.should == "dan@example.com"
       transaction.customer_details.phone.should == "419-555-1234"
       transaction.customer_details.fax.should == "419-555-1235"
@@ -1917,7 +1939,7 @@ describe Braintree::Transaction do
           :customer => {
             :first_name => "Dan",
             :last_name => "Smith",
-            :company => "Braintree Payment Solutions",
+            :company => "Braintree",
             :email => "dan@example.com",
             :phone => "419-555-1234",
             :fax => "419-555-1235",
@@ -1972,7 +1994,7 @@ describe Braintree::Transaction do
       transaction.cvv_response_code.should == "M"
       transaction.customer_details.first_name.should == "Dan"
       transaction.customer_details.last_name.should == "Smith"
-      transaction.customer_details.company.should == "Braintree Payment Solutions"
+      transaction.customer_details.company.should == "Braintree"
       transaction.customer_details.email.should == "dan@example.com"
       transaction.customer_details.phone.should == "419-555-1234"
       transaction.customer_details.fax.should == "419-555-1235"
@@ -2079,7 +2101,7 @@ describe Braintree::Transaction do
       it "includes disputes on found transactions" do
         found_transaction = Braintree::Transaction.find("disputedtransaction")
 
-        found_transaction.disputes.count.should == 2
+        found_transaction.disputes.count.should == 1
 
         dispute = found_transaction.disputes.first
         dispute.received_date.should == Date.new(2014, 3, 1)

data/spec/unit/braintree/client_token_spec.rb

@@ -0,0 +1,37 @@
+
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+module Braintree
+  describe ClientToken do
+    describe "self.generate" do
+      it "delegates to ClientTokenGateway#generate" do
+        options = {:foo => :bar}
+        client_token_gateway = double(:client_token_gateway)
+        client_token_gateway.should_receive(:generate).with(options).once
+        ClientTokenGateway.stub(:new).and_return(client_token_gateway)
+        ClientToken.generate(options)
+      end
+
+      it "can't overwrite public_key, or created_at" do
+        expect {
+          client_token = Braintree::ClientToken.generate(
+            :public_key => "bad_key",
+            :created_at => "bad_time"
+          )
+        }.to raise_error(ArgumentError, /created_at, public_key/)
+      end
+    end
+
+    context "adding credit_card options with no customer ID" do
+      %w(verify_card fail_on_duplicate_payment_method make_default).each do |option_name|
+        it "raises an ArgumentError if #{option_name} is present" do
+          expect do
+            Braintree::ClientToken.generate(
+              option_name.to_sym => true
+            )
+          end.to raise_error(ArgumentError, /#{option_name}/)
+        end
+      end
+    end
+  end
+end

data/spec/unit/braintree/configuration_spec.rb

@@ -235,6 +235,28 @@ describe Braintree::Configuration do
     end
   end
 
+  describe "auth_url" do
+    it "is http://auth.venmo.dev for development" do
+      Braintree::Configuration.environment = :development
+      Braintree::Configuration.instantiate.auth_url.should == "http://auth.venmo.dev:9292"
+    end
+
+    it "is https://auth.venmo.com for production" do
+      Braintree::Configuration.environment = :production
+      Braintree::Configuration.instantiate.auth_url.should == "https://auth.venmo.com"
+    end
+
+    it "is https://auth.sandbox.venmo.com for sandbox" do
+      Braintree::Configuration.environment = :sandbox
+      Braintree::Configuration.instantiate.auth_url.should == "https://auth.venmo.sandbox.braintreegateway.com"
+    end
+
+    it "is https://auth.qa.venmo.com for qa" do
+      Braintree::Configuration.environment = :qa
+      Braintree::Configuration.instantiate.auth_url.should == "https://auth.venmo.qa2.braintreegateway.com"
+    end
+  end
+
   describe "ssl?" do
     it "returns false for development" do
       Braintree::Configuration.environment = :development
@@ -275,4 +297,12 @@ describe Braintree::Configuration do
       config.inspect.should_not include('secret_key')
     end
   end
+
+  describe "signature_service" do
+    it "has a signature service initialized with the private key" do
+      config = Braintree::Configuration.new(:private_key => "secret_key")
+
+      config.signature_service.key.should == "secret_key"
+    end
+  end
 end