braintree 2.19.0 → 2.20.0

data/lib/braintree.rb

@@ -53,7 +53,7 @@ require "braintree/subscription"
 require "braintree/subscription_gateway"
 require "braintree/subscription_search"
 require "braintree/successful_result"
-require "braintree/test/credit_card_numbers"
+require "braintree/test/credit_card"
 require "braintree/test/transaction_amounts"
 require "braintree/transaction"
 require "braintree/transaction/address_details"

data/lib/braintree/credit_card.rb

@@ -26,45 +26,18 @@ module Braintree
       US = "us"
     end
 
-    module Commercial
+    module CardTypeIndicator
       Yes = "Yes"
       No = "No"
       Unknown = "Unknown"
     end
 
-    module Debit
-      Yes = "Yes"
-      No = "No"
-      Unknown = "Unknown"
-    end
-
-    module DurbinRegulated
-      Yes = "Yes"
-      No = "No"
-      Unknown = "Unknown"
-    end
-
-    module Healthcare
-      Yes = "Yes"
-      No = "No"
-      Unknown = "Unknown"
-    end
-
-    module Payroll
-      Yes = "Yes"
-      No = "No"
-      Unknown = "Unknown"
-    end
-
-    module Prepaid
-      Yes = "Yes"
-      No = "No"
-      Unknown = "Unknown"
-    end
+    Commercial = Debit = DurbinRegulated = Healthcare = Payroll = Prepaid =
+      IssuingBank = CountryOfIssuance = CardTypeIndicator
 
-    attr_reader :billing_address, :bin, :card_type, :cardholder_name, :commercial, :created_at,
-      :customer_id, :debit, :durbin_regulated, :expiration_month, :expiration_year, :healthcare,
-      :last_4, :payroll, :prepaid, :subscriptions, :token, :unique_number_identifier, :updated_at
+    attr_reader :billing_address, :bin, :card_type, :cardholder_name, :commercial, :country_of_issuance,
+      :created_at, :customer_id, :debit, :durbin_regulated, :expiration_month, :expiration_year, :healthcare,
+      :issuing_bank, :last_4, :payroll, :prepaid, :subscriptions, :token, :unique_number_identifier, :updated_at
 
     # See http://www.braintreepayments.com/docs/ruby/credit_cards/create
     def self.create(attributes)
@@ -265,7 +238,7 @@ module Braintree
       [
         :billing_address, :bin, :card_type, :cardholder_name, :created_at, :customer_id, :expiration_month,
         :expiration_year, :last_4, :token, :updated_at, :prepaid, :payroll, :commercial, :debit, :durbin_regulated,
-        :healthcare
+        :healthcare, :country_of_issuance, :issuing_bank
       ]
     end
 

data/lib/braintree/credit_card_gateway.rb

@@ -76,10 +76,10 @@ module Braintree
 
     def self._signature(type) # :nodoc:
       billing_address_params = AddressGateway._shared_signature
-      options = [:make_default, :verification_merchant_account_id, :verify_card]
+      options = [:make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session]
       signature = [
         :billing_address_id, :cardholder_name, :cvv, :expiration_date,
-        :expiration_month, :expiration_year, :number, :token,
+        :expiration_month, :expiration_year, :number, :token, :venmo_sdk_payment_method_code,
         {:options => options},
         {:billing_address => billing_address_params}
       ]

data/lib/braintree/test/{credit_card_numbers.rb → credit_card.rb}

@@ -7,14 +7,16 @@ module Braintree
     # See http://www.braintreepayments.com/docs/ruby/reference/sandbox
     module CreditCardNumbers
       module CardTypeIndicators
-        Prepaid         = "4111111111111210"
-        Commercial      = "4111111111131010"
-        Payroll         = "4111111114101010"
-        Healthcare      = "4111111510101010"
-        DurbinRegulated = "4111161010101010"
-        Debit           = "4117101010101010"
-        Unknown         = "4111111111112101"
-        No              = "4111111111310101"
+        Prepaid           = "4111111111111210"
+        Commercial        = "4111111111131010"
+        Payroll           = "4111111114101010"
+        Healthcare        = "4111111510101010"
+        DurbinRegulated   = "4111161010101010"
+        Debit             = "4117101010101010"
+        Unknown           = "4111111111112101"
+        No                = "4111111111310101"
+        IssuingBank       = "4111111141010101"
+        CountryOfIssuance = "4111111111121102"
       end
 
       AmExes = %w[378282246310005 371449635398431 378734493671000]
@@ -47,5 +49,10 @@ module Braintree
 
       All = AmExes + Discovers + MasterCards + Visas
     end
+
+    module CreditCardDefaults
+      CountryOfIssuance = "USA"
+      IssuingBank = "NETWORK ONLY"
+    end
   end
 end

data/lib/braintree/transaction_gateway.rb

@@ -100,7 +100,7 @@ module Braintree
     def self._create_signature # :nodoc:
       [
         :amount, :customer_id, :merchant_account_id, :order_id, :payment_method_token,
-        :purchase_order_number, :recurring, :shipping_address_id, :type, :tax_amount, :tax_exempt,
+        :purchase_order_number, :recurring, :shipping_address_id, :type, :tax_amount, :tax_exempt, :venmo_sdk_payment_method_code,
         {:credit_card => [:token, :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number]},
         {:customer => [:id, :company, :email, :fax, :first_name, :last_name, :phone, :website]},
         {
@@ -109,7 +109,7 @@ module Braintree
         {
           :shipping => AddressGateway._shared_signature
         },
-        {:options => [:store_in_vault, :store_in_vault_on_success, :submit_for_settlement, :add_billing_address_to_payment_method, :store_shipping_address_in_vault]},
+        {:options => [:store_in_vault, :store_in_vault_on_success, :submit_for_settlement, :add_billing_address_to_payment_method, :store_shipping_address_in_vault, :venmo_sdk_session]},
         {:custom_fields => :_any_key_},
         {:descriptor => [:name, :phone]}
       ]

data/lib/braintree/util.rb

@@ -20,7 +20,7 @@ module Braintree
     def self.parse_query_string(qs)
       qs.split('&').inject({}) do |result, couplet|
         pair = couplet.split('=')
-        result[CGI.unescape(pair[0]).to_sym] = CGI.unescape(pair[1])
+        result[CGI.unescape(pair[0]).to_sym] = CGI.unescape(pair[1] || '')
         result
       end
     end

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 19
+    Minor = 20
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/spec/httpsd.pid

@@ -1 +1 @@
-19512
+54061

data/spec/integration/braintree/credit_card_spec.rb

@@ -281,6 +281,30 @@ describe Braintree::CreditCard do
         credit_card.durbin_regulated.should == Braintree::CreditCard::DurbinRegulated::Yes
       end
 
+      it "sets the country of issuance field" do
+        customer = Braintree::Customer.create!
+        result = Braintree::CreditCard.create(
+          :customer_id => customer.id,
+          :number => Braintree::Test::CreditCardNumbers::CardTypeIndicators::CountryOfIssuance,
+          :expiration_date => "05/2014",
+          :options => {:verify_card => true}
+        )
+        credit_card = result.credit_card
+        credit_card.country_of_issuance.should == Braintree::Test::CreditCardDefaults::CountryOfIssuance
+      end
+
+    it "sets the issuing bank field" do
+        customer = Braintree::Customer.create!
+        result = Braintree::CreditCard.create(
+          :customer_id => customer.id,
+          :number => Braintree::Test::CreditCardNumbers::CardTypeIndicators::IssuingBank,
+          :expiration_date => "05/2014",
+          :options => {:verify_card => true}
+        )
+        credit_card = result.credit_card
+        credit_card.issuing_bank.should == Braintree::Test::CreditCardDefaults::IssuingBank
+      end
+
       it "sets the payroll field if the card is payroll" do
         customer = Braintree::Customer.create!
         result = Braintree::CreditCard.create(
@@ -349,6 +373,8 @@ describe Braintree::CreditCard do
         credit_card.debit.should == Braintree::CreditCard::Prepaid::Unknown
         credit_card.durbin_regulated.should == Braintree::CreditCard::Prepaid::Unknown
         credit_card.healthcare.should == Braintree::CreditCard::Prepaid::Unknown
+        credit_card.country_of_issuance == Braintree::CreditCard::CountryOfIssuance::Unknown
+        credit_card.issuing_bank == Braintree::CreditCard::IssuingBank::Unknown
       end
     end
 

data/spec/unit/braintree/credit_card_spec.rb

@@ -20,7 +20,8 @@ describe Braintree::CreditCard do
         :expiration_year,
         :number,
         :token,
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :fail_on_duplicate_payment_method]},
+        :venmo_sdk_payment_method_code,
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session, :fail_on_duplicate_payment_method]},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -51,7 +52,8 @@ describe Braintree::CreditCard do
         :expiration_year,
         :number,
         :token,
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card]},
+        :venmo_sdk_payment_method_code,
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session]},
         {:billing_address => [
           :company,
           :country_code_alpha2,

data/spec/unit/braintree/customer_spec.rb

@@ -90,7 +90,8 @@ describe Braintree::Customer do
           :expiration_year,
           :number,
           :token,
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :fail_on_duplicate_payment_method]},
+          :venmo_sdk_payment_method_code,
+          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session, :fail_on_duplicate_payment_method]},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -131,10 +132,12 @@ describe Braintree::Customer do
           :expiration_year,
           :number,
           :token,
+          :venmo_sdk_payment_method_code,
           {:options => [
             :make_default,
             :verification_merchant_account_id,
             :verify_card,
+            :venmo_sdk_session,
             :update_existing_token
           ]},
           {:billing_address => [

data/spec/unit/braintree/util_spec.rb

@@ -192,6 +192,11 @@ describe Braintree::Util do
       query_string = "foo=bar%20baz&hash=a1b2c3"
       Braintree::Util.parse_query_string(query_string).should == {:foo => "bar baz", :hash => "a1b2c3"}
     end
+
+    it "parses the query string when a key has an empty value" do
+      query_string = "foo=bar%20baz&hash=a1b2c3&vat_number="
+      Braintree::Util.parse_query_string(query_string).should == {:foo => "bar baz", :hash => "a1b2c3", :vat_number => ""}
+    end
   end
 
   describe "self.raise_exception_for_status_code" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: braintree
 version: !ruby/object:Gem::Version 
-  hash: 67
+  hash: 95
   prerelease: false
   segments: 
   - 2
-  - 19
+  - 20
   - 0
-  version: 2.19.0
+  version: 2.20.0
 platform: ruby
 authors: 
 - Braintree
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-10-25 00:00:00 +00:00
+date: 2012-11-09 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -45,130 +45,130 @@ extra_rdoc_files: []
 files: 
 - README.rdoc
 - LICENSE
-- lib/braintree.rb
-- lib/braintree/subscription_search.rb
-- lib/braintree/modification.rb
-- lib/braintree/errors.rb
-- lib/braintree/test/credit_card_numbers.rb
-- lib/braintree/test/transaction_amounts.rb
-- lib/braintree/webhook_testing.rb
-- lib/braintree/webhook_testing_gateway.rb
-- lib/braintree/advanced_search.rb
-- lib/braintree/version.rb
 - lib/braintree/add_on.rb
+- lib/braintree/add_on_gateway.rb
+- lib/braintree/address/country_names.rb
 - lib/braintree/address.rb
-- lib/braintree/digest.rb
-- lib/braintree/settlement_batch_summary.rb
-- lib/braintree/error_codes.rb
-- lib/braintree/discount.rb
-- lib/braintree/webhook_notification.rb
-- lib/braintree/settlement_batch_summary_gateway.rb
-- lib/braintree/validation_error_collection.rb
-- lib/braintree/credit_card_verification_gateway.rb
+- lib/braintree/address_gateway.rb
+- lib/braintree/advanced_search.rb
+- lib/braintree/base_module.rb
+- lib/braintree/configuration.rb
 - lib/braintree/credit_card.rb
+- lib/braintree/credit_card_gateway.rb
+- lib/braintree/credit_card_verification.rb
+- lib/braintree/credit_card_verification_gateway.rb
+- lib/braintree/credit_card_verification_search.rb
+- lib/braintree/customer.rb
+- lib/braintree/customer_gateway.rb
 - lib/braintree/customer_search.rb
-- lib/braintree/util.rb
-- lib/braintree/transparent_redirect.rb
-- lib/braintree/xml/generator.rb
-- lib/braintree/xml/rexml.rb
-- lib/braintree/xml/libxml.rb
-- lib/braintree/xml/parser.rb
+- lib/braintree/descriptor.rb
+- lib/braintree/digest.rb
+- lib/braintree/discount.rb
+- lib/braintree/discount_gateway.rb
+- lib/braintree/error_codes.rb
+- lib/braintree/error_result.rb
+- lib/braintree/errors.rb
 - lib/braintree/exceptions.rb
-- lib/braintree/validation_error.rb
-- lib/braintree/resource_collection.rb
-- lib/braintree/xml.rb
-- lib/braintree/credit_card_verification.rb
-- lib/braintree/configuration.rb
-- lib/braintree/transaction.rb
+- lib/braintree/gateway.rb
 - lib/braintree/http.rb
-- lib/braintree/address_gateway.rb
-- lib/braintree/subscription_gateway.rb
-- lib/braintree/customer_gateway.rb
+- lib/braintree/modification.rb
+- lib/braintree/plan.rb
 - lib/braintree/plan_gateway.rb
-- lib/braintree/credit_card_verification_search.rb
-- lib/braintree/successful_result.rb
+- lib/braintree/resource_collection.rb
 - lib/braintree/settlement_batch.rb
-- lib/braintree/plan.rb
-- lib/braintree/gateway.rb
-- lib/braintree/transparent_redirect_gateway.rb
-- lib/braintree/base_module.rb
-- lib/braintree/add_on_gateway.rb
-- lib/braintree/transaction/subscription_details.rb
-- lib/braintree/transaction/customer_details.rb
+- lib/braintree/settlement_batch_summary.rb
+- lib/braintree/settlement_batch_summary_gateway.rb
+- lib/braintree/subscription.rb
+- lib/braintree/subscription_gateway.rb
+- lib/braintree/subscription_search.rb
+- lib/braintree/successful_result.rb
+- lib/braintree/test/credit_card.rb
+- lib/braintree/test/transaction_amounts.rb
+- lib/braintree/transaction/address_details.rb
 - lib/braintree/transaction/credit_card_details.rb
+- lib/braintree/transaction/customer_details.rb
 - lib/braintree/transaction/status_details.rb
-- lib/braintree/transaction/address_details.rb
-- lib/braintree/transaction_search.rb
-- lib/braintree/error_result.rb
-- lib/braintree/credit_card_gateway.rb
-- lib/braintree/descriptor.rb
+- lib/braintree/transaction/subscription_details.rb
+- lib/braintree/transaction.rb
 - lib/braintree/transaction_gateway.rb
-- lib/braintree/subscription.rb
-- lib/braintree/address/country_names.rb
+- lib/braintree/transaction_search.rb
+- lib/braintree/transparent_redirect.rb
+- lib/braintree/transparent_redirect_gateway.rb
+- lib/braintree/util.rb
+- lib/braintree/validation_error.rb
+- lib/braintree/validation_error_collection.rb
+- lib/braintree/version.rb
+- lib/braintree/webhook_notification.rb
 - lib/braintree/webhook_notification_gateway.rb
-- lib/braintree/customer.rb
-- lib/braintree/discount_gateway.rb
-- lib/ssl/www_braintreegateway_com.ca.crt
+- lib/braintree/webhook_testing.rb
+- lib/braintree/webhook_testing_gateway.rb
+- lib/braintree/xml/generator.rb
+- lib/braintree/xml/libxml.rb
+- lib/braintree/xml/parser.rb
+- lib/braintree/xml/rexml.rb
+- lib/braintree/xml.rb
+- lib/braintree.rb
 - lib/ssl/sandbox_braintreegateway_com.ca.crt
 - lib/ssl/securetrust_ca.crt
-- spec/script/httpsd.rb
-- spec/spec_helper.rb
-- spec/unit/spec_helper.rb
-- spec/unit/braintree/transaction_search_spec.rb
-- spec/unit/braintree/error_result_spec.rb
-- spec/unit/braintree/xml_spec.rb
-- spec/unit/braintree/customer_spec.rb
-- spec/unit/braintree/transaction_spec.rb
-- spec/unit/braintree/webhook_notification_spec.rb
-- spec/unit/braintree/http_spec.rb
-- spec/unit/braintree/subscription_spec.rb
-- spec/unit/braintree/credit_card_verification_search_spec.rb
-- spec/unit/braintree/subscription_search_spec.rb
-- spec/unit/braintree/successful_result_spec.rb
-- spec/unit/braintree/credit_card_verification_spec.rb
-- spec/unit/braintree/validation_error_spec.rb
-- spec/unit/braintree/resource_collection_spec.rb
-- spec/unit/braintree/xml/libxml_spec.rb
-- spec/unit/braintree/xml/parser_spec.rb
-- spec/unit/braintree/xml/rexml_spec.rb
-- spec/unit/braintree/configuration_spec.rb
-- spec/unit/braintree/validation_error_collection_spec.rb
-- spec/unit/braintree/errors_spec.rb
-- spec/unit/braintree/modification_spec.rb
-- spec/unit/braintree/util_spec.rb
-- spec/unit/braintree/base_module_spec.rb
-- spec/unit/braintree/address_spec.rb
-- spec/unit/braintree/transparent_redirect_spec.rb
-- spec/unit/braintree/transaction/credit_card_details_spec.rb
-- spec/unit/braintree/transaction/customer_details_spec.rb
-- spec/unit/braintree/credit_card_spec.rb
-- spec/unit/braintree/digest_spec.rb
-- spec/unit/braintree_spec.rb
+- lib/ssl/www_braintreegateway_com.ca.crt
 - spec/hacks/tcp_socket.rb
 - spec/httpsd.pid
-- spec/integration/spec_helper.rb
-- spec/integration/braintree/settlement_batch_summary_spec.rb
-- spec/integration/braintree/transaction_search_spec.rb
-- spec/integration/braintree/test/transaction_amounts_spec.rb
-- spec/integration/braintree/customer_spec.rb
-- spec/integration/braintree/transaction_spec.rb
 - spec/integration/braintree/add_on_spec.rb
-- spec/integration/braintree/http_spec.rb
-- spec/integration/braintree/subscription_spec.rb
+- spec/integration/braintree/address_spec.rb
+- spec/integration/braintree/advanced_search_spec.rb
+- spec/integration/braintree/credit_card_spec.rb
 - spec/integration/braintree/credit_card_verification_search_spec.rb
 - spec/integration/braintree/credit_card_verification_spec.rb
-- spec/integration/braintree/advanced_search_spec.rb
 - spec/integration/braintree/customer_search_spec.rb
-- spec/integration/braintree/plan_spec.rb
+- spec/integration/braintree/customer_spec.rb
+- spec/integration/braintree/discount_spec.rb
 - spec/integration/braintree/error_codes_spec.rb
-- spec/integration/braintree/address_spec.rb
+- spec/integration/braintree/http_spec.rb
+- spec/integration/braintree/plan_spec.rb
+- spec/integration/braintree/settlement_batch_summary_spec.rb
+- spec/integration/braintree/subscription_spec.rb
+- spec/integration/braintree/test/transaction_amounts_spec.rb
+- spec/integration/braintree/transaction_search_spec.rb
+- spec/integration/braintree/transaction_spec.rb
 - spec/integration/braintree/transparent_redirect_spec.rb
-- spec/integration/braintree/credit_card_spec.rb
-- spec/integration/braintree/discount_spec.rb
+- spec/integration/spec_helper.rb
+- spec/script/httpsd.rb
 - spec/spec.opts
-- spec/ssl/geotrust_global.crt
+- spec/spec_helper.rb
 - spec/ssl/certificate.crt
+- spec/ssl/geotrust_global.crt
 - spec/ssl/privateKey.key
+- spec/unit/braintree/address_spec.rb
+- spec/unit/braintree/base_module_spec.rb
+- spec/unit/braintree/configuration_spec.rb
+- spec/unit/braintree/credit_card_spec.rb
+- spec/unit/braintree/credit_card_verification_search_spec.rb
+- spec/unit/braintree/credit_card_verification_spec.rb
+- spec/unit/braintree/customer_spec.rb
+- spec/unit/braintree/digest_spec.rb
+- spec/unit/braintree/error_result_spec.rb
+- spec/unit/braintree/errors_spec.rb
+- spec/unit/braintree/http_spec.rb
+- spec/unit/braintree/modification_spec.rb
+- spec/unit/braintree/resource_collection_spec.rb
+- spec/unit/braintree/subscription_search_spec.rb
+- spec/unit/braintree/subscription_spec.rb
+- spec/unit/braintree/successful_result_spec.rb
+- spec/unit/braintree/transaction/credit_card_details_spec.rb
+- spec/unit/braintree/transaction/customer_details_spec.rb
+- spec/unit/braintree/transaction_search_spec.rb
+- spec/unit/braintree/transaction_spec.rb
+- spec/unit/braintree/transparent_redirect_spec.rb
+- spec/unit/braintree/util_spec.rb
+- spec/unit/braintree/validation_error_collection_spec.rb
+- spec/unit/braintree/validation_error_spec.rb
+- spec/unit/braintree/webhook_notification_spec.rb
+- spec/unit/braintree/xml/libxml_spec.rb
+- spec/unit/braintree/xml/parser_spec.rb
+- spec/unit/braintree/xml/rexml_spec.rb
+- spec/unit/braintree/xml_spec.rb
+- spec/unit/braintree_spec.rb
+- spec/unit/spec_helper.rb
 - braintree.gemspec
 has_rdoc: true
 homepage: http://www.braintreepayments.com/