braintree 2.104.0 → 4.9.0

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification and signature given an identifier and kind" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -18,7 +18,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a partner merchant connected webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::PartnerMerchantConnected,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -35,7 +35,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a partner merchant disconnected webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::PartnerMerchantDisconnected,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -48,7 +48,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a partner merchant declined webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::PartnerMerchantDeclined,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -62,7 +62,7 @@ describe Braintree::WebhookNotification do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
         "my_id",
-        "my_source_merchant_id"
+        "my_source_merchant_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -73,7 +73,7 @@ describe Braintree::WebhookNotification do
     it "doesn't include source merchant IDs if not supplied" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::PartnerMerchantDeclined,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -85,7 +85,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a status transitioned webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::ConnectedMerchantStatusTransitioned,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -102,7 +102,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a paypal status changed webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::ConnectedMerchantPayPalStatusChanged,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -116,10 +116,10 @@ describe Braintree::WebhookNotification do
         paypal_status_changed.action.should == "link"
       end
 
-      it 'builds a sample notification for OAuth application revocation' do
+      it "builds a sample notification for OAuth application revocation" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::OAuthAccessRevoked,
-          'my_id'
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -139,7 +139,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute opened webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeOpened,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -155,7 +155,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute lost webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeLost,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -171,7 +171,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute won webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeWon,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -187,7 +187,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute accepted webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeAccepted,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -203,7 +203,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute disputed webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeDisputed,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -219,7 +219,7 @@ describe Braintree::WebhookNotification do
         it "builds a sample notification for a dispute expired webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeExpired,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -235,7 +235,7 @@ describe Braintree::WebhookNotification do
         it "is compatible with the previous dispute won webhook interface" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeWon,
-            dispute_id
+            dispute_id,
           )
 
           notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -267,7 +267,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a transaction disbursed webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::TransactionDisbursed,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -275,13 +275,13 @@ describe Braintree::WebhookNotification do
         notification.kind.should == Braintree::WebhookNotification::Kind::TransactionDisbursed
         notification.transaction.id.should == "my_id"
         notification.transaction.amount.should == 1_00
-        notification.transaction.disbursement_details.disbursement_date.should == "2013-07-09"
+        notification.transaction.disbursement_details.disbursement_date.should == Date.parse("2013-07-09")
       end
 
       it "builds a sample notification for a disbursement_exception webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::DisbursementException,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -300,7 +300,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a disbursement webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::Disbursement,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -317,11 +317,29 @@ describe Braintree::WebhookNotification do
       end
     end
 
+    context "transaction review" do
+      it " builds a sample notification for a transaction reviewed webhook" do
+        sample_notification = Braintree::WebhookTesting.sample_notification(
+          Braintree::WebhookNotification::Kind::TransactionReviewed,
+          "my_id",
+        )
+
+        notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+
+        expect(notification.kind).to eq(Braintree::WebhookNotification::Kind::TransactionReviewed)
+        expect(notification.transaction_review.transaction_id).to eq("my_id")
+        expect(notification.transaction_review.decision).to eq("decision")
+        expect(notification.transaction_review.reviewer_email).to eq("hey@girl.com")
+        expect(notification.transaction_review.reviewer_note).to eq("i reviewed this")
+        expect(notification.transaction_review.reviewed_time).to_not be_nil
+      end
+    end
+
     context "us bank account transactions" do
       it "builds a sample notification for a settlement webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::TransactionSettled,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -338,7 +356,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a settlement declined webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::TransactionSettlementDeclined,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -357,7 +375,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a merchant account approved webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::SubMerchantAccountApproved,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -372,7 +390,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a merchant account declined webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::SubMerchantAccountDeclined,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -391,7 +409,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a subscription charged successfully webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::SubscriptionChargedSuccessfully,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -406,7 +424,7 @@ describe Braintree::WebhookNotification do
       it "builds a sample notification for a subscription charged unsuccessfully webhook" do
         sample_notification = Braintree::WebhookTesting.sample_notification(
           Braintree::WebhookNotification::Kind::SubscriptionChargedUnsuccessfully,
-          "my_id"
+          "my_id",
         )
 
         notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -422,7 +440,7 @@ describe Braintree::WebhookNotification do
     it "includes a valid signature" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
       expected_signature = Braintree::Digest.hexdigest(Braintree::Configuration.private_key, sample_notification[:bt_payload])
 
@@ -434,7 +452,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for an account_updater_daily_report webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::AccountUpdaterDailyReport,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -449,44 +467,44 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a GrantorUpdatedGrantedPaymentMethod webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::GrantorUpdatedGrantedPaymentMethod,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
       update = notification.granted_payment_instrument_update
 
       notification.kind.should == Braintree::WebhookNotification::Kind::GrantorUpdatedGrantedPaymentMethod
-      update.grant_owner_merchant_id.should == 'vczo7jqrpwrsi2px'
-      update.grant_recipient_merchant_id.should == 'cf0i8wgarszuy6hc'
-      update.payment_method_nonce.should == 'ee257d98-de40-47e8-96b3-a6954ea7a9a4'
-      update.token.should == 'abc123z'
-      update.updated_fields.should == ['expiration-month', 'expiration-year']
+      update.grant_owner_merchant_id.should == "vczo7jqrpwrsi2px"
+      update.grant_recipient_merchant_id.should == "cf0i8wgarszuy6hc"
+      update.payment_method_nonce.should == "ee257d98-de40-47e8-96b3-a6954ea7a9a4"
+      update.token.should == "abc123z"
+      update.updated_fields.should == ["expiration-month", "expiration-year"]
     end
 
     it "builds a sample notification for a RecipientUpdatedGrantedPaymentMethod webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
       update = notification.granted_payment_instrument_update
 
       notification.kind.should == Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod
-      update.grant_owner_merchant_id.should == 'vczo7jqrpwrsi2px'
-      update.grant_recipient_merchant_id.should == 'cf0i8wgarszuy6hc'
-      update.payment_method_nonce.should == 'ee257d98-de40-47e8-96b3-a6954ea7a9a4'
-      update.token.should == 'abc123z'
-      update.updated_fields.should == ['expiration-month', 'expiration-year']
+      update.grant_owner_merchant_id.should == "vczo7jqrpwrsi2px"
+      update.grant_recipient_merchant_id.should == "cf0i8wgarszuy6hc"
+      update.payment_method_nonce.should == "ee257d98-de40-47e8-96b3-a6954ea7a9a4"
+      update.token.should == "abc123z"
+      update.updated_fields.should == ["expiration-month", "expiration-year"]
     end
   end
 
   context "granted_payment_instrument_revoked" do
     let(:gateway) do
       config = Braintree::Configuration.new(
-        :merchant_id => 'merchant_id',
-        :public_key => 'wrong_public_key',
-        :private_key => 'wrong_private_key'
+        :merchant_id => "merchant_id",
+        :public_key => "wrong_public_key",
+        :private_key => "wrong_private_key",
       )
       Braintree::Gateway.new(config)
     end
@@ -611,6 +629,22 @@ describe Braintree::WebhookNotification do
         metadata.token.should == "venmo_token"
         metadata.revoked_payment_method.class.should == Braintree::VenmoAccount
       end
+
+      it "builds a sample notification for a GrantedPaymentMethodRevoked webhook" do
+        sample_notification = Braintree::WebhookTesting.sample_notification(
+          Braintree::WebhookNotification::Kind::GrantedPaymentMethodRevoked,
+          "my_id",
+        )
+
+        notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+        expect(notification.kind).to eq Braintree::WebhookNotification::Kind::GrantedPaymentMethodRevoked
+
+        metadata = notification.revoked_payment_method_metadata
+
+        expect(metadata.customer_id).to eq "venmo_customer_id"
+        expect(metadata.token).to eq "my_id"
+        expect(metadata.revoked_payment_method.class).to eq Braintree::VenmoAccount
+      end
     end
   end
 
@@ -618,7 +652,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a payment_method_revoked_by_customer webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::PaymentMethodRevokedByCustomer,
-        "my_payment_method_token"
+        "my_payment_method_token",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -635,7 +669,7 @@ describe Braintree::WebhookNotification do
     it "builds a sample notification for a local_payment webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::LocalPaymentCompleted,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
@@ -652,6 +686,81 @@ describe Braintree::WebhookNotification do
     end
   end
 
+  context "local_payment_expired" do
+    it "builds a sample notification for a local_payment_expired webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::LocalPaymentExpired,
+        "my_id",
+      )
+
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      notification.kind.should == Braintree::WebhookNotification::Kind::LocalPaymentExpired
+
+      local_payment_expired = notification.local_payment_expired
+      local_payment_expired.payment_id.should == "PAY-XYZ123"
+      local_payment_expired.payment_context_id.should == "cG5b="
+    end
+  end
+
+  context "local_payment_funded" do
+    it "builds a sample notification for a local_payment_funded webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::LocalPaymentFunded,
+        "my_id",
+      )
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      notification.kind.should == Braintree::WebhookNotification::Kind::LocalPaymentFunded
+
+      local_payment_funded = notification.local_payment_funded
+      local_payment_funded.payment_id.should == "PAY-XYZ123"
+      local_payment_funded.payment_context_id.should == "cG5b="
+      local_payment_funded.transaction.id.should == "my_id"
+      local_payment_funded.transaction.status.should == Braintree::Transaction::Status::Settled
+      local_payment_funded.transaction.amount.should == 49.99
+      local_payment_funded.transaction.order_id.should == "order4567"
+    end
+  end
+
+  context "local_payment_reversed" do
+    it "builds a sample notification for a local_payment webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::LocalPaymentReversed,
+        "my_id",
+      )
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      notification.kind.should == Braintree::WebhookNotification::Kind::LocalPaymentReversed
+
+      local_payment_reversed = notification.local_payment_reversed
+      local_payment_reversed.payment_id.should == "PAY-XYZ123"
+    end
+  end
+
+  context "payment_method_customer_data_updated" do
+    it "builds a sample notification for a payment_method_customer_data_updated webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::PaymentMethodCustomerDataUpdated,
+        "my_id",
+      )
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      notification.kind.should == Braintree::WebhookNotification::Kind::PaymentMethodCustomerDataUpdated
+
+      payment_method_customer_data_updated = notification.payment_method_customer_data_updated_metadata
+
+      payment_method_customer_data_updated.token.should eq("TOKEN-12345")
+      payment_method_customer_data_updated.datetime_updated.should eq("2022-01-01T21:28:37Z")
+
+      enriched_customer_data = payment_method_customer_data_updated.enriched_customer_data
+      enriched_customer_data.fields_updated.should eq(["username"])
+
+      profile_data = enriched_customer_data.profile_data
+      profile_data.first_name.should eq("John")
+      profile_data.last_name.should eq("Doe")
+      profile_data.username.should eq("venmo_username")
+      profile_data.phone_number.should eq("1231231234")
+      profile_data.email.should eq("john.doe@paypal.com")
+    end
+  end
+
   describe "parse" do
     it "raises InvalidSignature error when the signature is nil" do
       expect do
@@ -668,7 +777,7 @@ describe Braintree::WebhookNotification do
     it "raises InvalidSignature error when the signature is completely invalid" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       expect do
@@ -679,13 +788,13 @@ describe Braintree::WebhookNotification do
     it "raises InvalidSignature error with a message when the public key is not found" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       config = Braintree::Configuration.new(
-        :merchant_id => 'merchant_id',
-        :public_key => 'wrong_public_key',
-        :private_key => 'wrong_private_key'
+        :merchant_id => "merchant_id",
+        :public_key => "wrong_public_key",
+        :private_key => "wrong_private_key",
       )
       gateway = Braintree::Gateway.new(config)
 
@@ -697,7 +806,7 @@ describe Braintree::WebhookNotification do
     it "raises InvalidSignature error if the payload has been changed" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       expect do
@@ -708,7 +817,7 @@ describe Braintree::WebhookNotification do
     it "raises InvalidSignature error with a message complaining about invalid characters" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       expect do
@@ -719,7 +828,7 @@ describe Braintree::WebhookNotification do
     it "allows all valid characters" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       sample_notification[:bt_payload] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+=/\n"
@@ -736,7 +845,7 @@ describe Braintree::WebhookNotification do
     it "retries a payload with a newline" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        "my_id"
+        "my_id",
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload].rstrip)
@@ -751,7 +860,7 @@ describe Braintree::WebhookNotification do
     it "returns true for check webhook kinds" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::Check,
-        nil
+        nil,
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload].rstrip)
@@ -762,7 +871,7 @@ describe Braintree::WebhookNotification do
     it "returns false for non-check webhook kinds" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
         Braintree::WebhookNotification::Kind::SubscriptionWentPastDue,
-        nil
+        nil,
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload].rstrip)

data/spec/unit/braintree/xml/parser_spec.rb

@@ -57,24 +57,29 @@ describe Braintree::Xml::Parser do
       xml.should parse_to(:root => {:customers => [{:name => "Adam"}, {:name => "Ben"}]})
     end
 
-    it "parses using libxml when not using ruby 2.0" do
-      xml = "<root><foo type=\"integer\">123</foo></root>"
-      stub_const("RUBY_VERSION", "2.1.1")
-      ::Braintree::Xml::Libxml.should_receive(:parse).and_call_original
-
-      Braintree::Xml::Parser.hash_from_xml(xml)
+    it "parses an array" do
+      xml = <<-END
+        <root>
+          <customers type="array">
+            <customer><name>Adam</name><customer-id>1</customer-id></customer>
+            <customer><name>Ben</name><customer-id>2</customer-id></customer>
+          </customers>
+        </root>
+      END
+      xml.should parse_to(:root => {:customers => [{:name => "Adam", :customer_id => "1"}, {:name => "Ben", :customer_id => "2"}]})
     end
 
-    it "parses using rexml when using ruby 2.0 to avoid Libxml segfault" do
-      segfault_prone_library_in_ruby_2_0 = ::Braintree::Xml::Libxml
-
-      xml = "<root><foo type=\"integer\">123</foo></root>"
-      stub_const("RUBY_VERSION", "2.0.0")
-
-      ::Braintree::Xml::Rexml.should_receive(:parse).and_call_original
-      segfault_prone_library_in_ruby_2_0.should_not_receive(:parse)
-
-      Braintree::Xml::Parser.hash_from_xml(xml)
+    it "parses nested objects" do
+      xml = <<-END
+        <root>
+          <paypal-details>
+            <deets type="array"><super-secrets><secret-code>1234</secret-code></super-secrets></deets>
+            <payer-email>abc@test.com</payer-email>
+            <payment-id>1234567890</payment-id>
+          </paypal-details>
+        </root>
+      END
+      xml.should parse_to(:root => {:paypal_details => {:deets => [{:secret_code => "1234"}], :payer_email => "abc@test.com", :payment_id => "1234567890"}})
     end
   end
 end

data/spec/unit/braintree/xml_spec.rb

@@ -99,34 +99,34 @@ describe Braintree::Xml do
       verify_to_xml_and_back hash
     end
 
-		context "Integer" do
-			it "works for integers" do
-				hash = { :root => {:foo => 1 } }
-				Braintree::Xml.hash_to_xml(hash).should include("<foo type=\"integer\">1</foo>")
-			end
-		end
-
-		context "BigDecimal" do
-			it "works for BigDecimals" do
-				hash = {:root => {:foo => BigDecimal("123.45")}}
-				Braintree::Xml.hash_to_xml(hash).should include("<foo>123.45</foo>")
-			end
-
-			it "works for BigDecimals with fewer than 2 digits" do
-				hash = {:root => {:foo => BigDecimal("1000.0")}}
-				Braintree::Xml.hash_to_xml(hash).should include("<foo>1000.00</foo>")
-			end
-
-			it "works for BigDecimals with more than 2 digits" do
-				hash = {:root => {:foo => BigDecimal("12.345")}}
-				Braintree::Xml.hash_to_xml(hash).should include("<foo>12.345</foo>")
-			end
-		end
-
-		it "works for symbols" do
-			hash = {:root => {:foo => :bar}}
-			Braintree::Xml.hash_to_xml(hash).should include("<foo>bar</foo>")
-		end
+    context "Integer" do
+      it "works for integers" do
+        hash = {:root => {:foo => 1}}
+        Braintree::Xml.hash_to_xml(hash).should include("<foo type=\"integer\">1</foo>")
+      end
+    end
+
+    context "BigDecimal" do
+      it "works for BigDecimals" do
+        hash = {:root => {:foo => BigDecimal("123.45")}}
+        Braintree::Xml.hash_to_xml(hash).should include("<foo>123.45</foo>")
+      end
+
+      it "works for BigDecimals with fewer than 2 digits" do
+        hash = {:root => {:foo => BigDecimal("1000.0")}}
+        Braintree::Xml.hash_to_xml(hash).should include("<foo>1000.00</foo>")
+      end
+
+      it "works for BigDecimals with more than 2 digits" do
+        hash = {:root => {:foo => BigDecimal("12.345")}}
+        Braintree::Xml.hash_to_xml(hash).should include("<foo>12.345</foo>")
+      end
+    end
+
+    it "works for symbols" do
+      hash = {:root => {:foo => :bar}}
+      Braintree::Xml.hash_to_xml(hash).should include("<foo>bar</foo>")
+    end
 
     it "type casts booleans" do
       hash = {:root => {:string_true => "true", :bool_true => true, :bool_false => false, :string_false => "false"}}
@@ -154,13 +154,13 @@ describe Braintree::Xml do
     end
 
     it "escapes keys and values" do
-      hash = { "ke<y" => "val>ue" }
+      hash = {"ke<y" => "val>ue"}
       Braintree::Xml.hash_to_xml(hash).should include("<ke&lt;y>val&gt;ue</ke&lt;y>")
     end
 
     it "escapes nested keys and values" do
-      hash = { "top<" => { "ke<y" => "val>ue" } }
-      Braintree::Xml.hash_to_xml(hash).gsub(/\s/, '').should include("<top&lt;><ke&lt;y>val&gt;ue</ke&lt;y></top&lt;>")
+      hash = {"top<" => {"ke<y" => "val>ue"}}
+      Braintree::Xml.hash_to_xml(hash).gsub(/\s/, "").should include("<top&lt;><ke&lt;y>val&gt;ue</ke&lt;y></top&lt;>")
     end
   end
 end