braintree 2.104.0 → 3.3.0

data/spec/integration/braintree/transaction_us_bank_account_spec.rb

@@ -14,7 +14,8 @@ describe Braintree::Transaction do
         let(:plaid_nonce) { generate_valid_plaid_us_bank_account_nonce }
 
         context "nonce" do
-          it "sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -41,7 +42,8 @@ describe Braintree::Transaction do
         end
 
         context "token" do
-          it "payment_method#create then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "payment_method#create then sale succeeds" do
             payment_method = Braintree::PaymentMethod.create(
               :payment_method_nonce => plaid_nonce,
               :customer_id => Braintree::Customer.create.customer.id,
@@ -84,7 +86,8 @@ describe Braintree::Transaction do
             transaction.us_bank_account_details.ach_mandate.accepted_at.should be_a Time
           end
 
-          it "transaction#create store_in_vault then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "transaction#create store_in_vault then sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -233,7 +236,8 @@ describe Braintree::Transaction do
         let(:plaid_nonce) { generate_valid_plaid_us_bank_account_nonce }
 
         context "nonce" do
-          it "sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -260,7 +264,8 @@ describe Braintree::Transaction do
         end
 
         context "token" do
-          it "payment_method#create then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "payment_method#create then sale succeeds" do
             result = Braintree::PaymentMethod.create(
               :payment_method_nonce => plaid_nonce,
               :customer_id => Braintree::Customer.create.customer.id,
@@ -305,7 +310,8 @@ describe Braintree::Transaction do
             transaction.us_bank_account_details.ach_mandate.accepted_at.should be_a Time
           end
 
-          it "transaction#create store_in_vault then sale succeeds" do
+          # we are temporarily skipping this test until we have a more stable CI env
+          xit "transaction#create store_in_vault then sale succeeds" do
             result = Braintree::Transaction.create(
               :type => "sale",
               :amount => Braintree::Test::TransactionAmounts::Authorize,

data/spec/integration/spec_helper.rb

@@ -5,7 +5,6 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
   SSL_TEST_PORT = ENV['SSL_TEST_PORT'] || 8444
 
   require File.dirname(__FILE__) + "/../spec_helper"
-  require File.dirname(__FILE__) + "/../hacks/tcp_socket"
 
   def start_ssl_server
     web_server_pid_file = File.expand_path(File.join(File.dirname(__FILE__), "..", "httpsd.pid"))
@@ -13,9 +12,7 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
     FileUtils.rm(web_server_pid_file) if File.exist?(web_server_pid_file)
     command = File.expand_path(File.join(File.dirname(__FILE__), "..", "script", "httpsd.rb"))
     `#{command} #{web_server_pid_file}`
-    TCPSocket.wait_for_service :host => "127.0.0.1", :port => SSL_TEST_PORT
-
-    yield
+    TCPSocket.new("127.0.0.1",SSL_TEST_PORT)
 
     10.times { unless File.exists?(web_server_pid_file); sleep 1; end }
   ensure
@@ -45,12 +42,18 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
     end
   end
 
-  def with_advanced_fraud_integration_merchant(&block)
+  def with_advanced_fraud_kount_integration_merchant(&block)
     with_other_merchant("advanced_fraud_integration_merchant_id", "advanced_fraud_integration_public_key", "advanced_fraud_integration_private_key") do
       block.call
     end
   end
 
+  def with_fraud_protection_enterprise_merchant(&block)
+    with_other_merchant("fraud_protection_enterprise_integration_merchant_id", "fraud_protection_enterprise_integration_public_key", "fraud_protection_enterprise_integration_private_key") do
+      block.call
+    end
+  end
+
   def with_altpay_merchant(&block)
     with_other_merchant("altpay_merchant", "altpay_merchant_public_key", "altpay_merchant_private_key", &block)
   end

data/spec/spec_helper.rb

@@ -4,7 +4,6 @@ unless defined?(SPEC_HELPER_LOADED)
   require "rubygems"
   require "bundler/setup"
   require "rspec"
-  require "libxml"
   require "pry"
 
   braintree_lib = "#{project_root}/lib"
@@ -28,10 +27,6 @@ unless defined?(SPEC_HELPER_LOADED)
     end
   end
 
-  def now_in_eastern
-    (Time.now.utc - 5*60*60).strftime("%Y-%m-%d")
-  end
-
   module SpecHelper
 
     DefaultMerchantAccountId = "sandbox_credit_card"
@@ -44,6 +39,7 @@ unless defined?(SPEC_HELPER_LOADED)
     AnotherUsBankMerchantAccountId = "another_us_bank_merchant_account"
     AdyenMerchantAccountId = "adyen_ma"
     HiperBRLMerchantAccountId = "hiper_brl"
+    CardProcessorBRLMerchantAccountId = "card_processor_brl"
 
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",
@@ -188,16 +184,11 @@ unless defined?(SPEC_HELPER_LOADED)
       end
 
       def matches?(xml_string)
-        @libxml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string, Braintree::Xml::Libxml)
-        @rexml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string, Braintree::Xml::Rexml)
+        @libxml_parse = Braintree::Xml::Parser.hash_from_xml(xml_string)
         if @libxml_parse != @expected_hash
           @results = @libxml_parse
           @failed_parser = "libxml"
           false
-        elsif @rexml_parse != @expected_hash
-          @results = @rexml_parse
-          @failed_parser = "rexml"
-          false
         else
           true
         end

data/spec/unit/braintree/address_spec.rb

@@ -94,12 +94,4 @@ describe Braintree::Address do
       end.to raise_error(NoMethodError, /protected method .new/)
     end
   end
-
-  describe "update" do
-    it "raises an exception if hash includes an invalid key" do
-      expect do
-        Braintree::Address._new(Braintree::Configuration.gateway, {}).update(:street_address => "456 E Main", :invalid_key2 => "foo")
-      end.to raise_error(ArgumentError, "invalid keys: invalid_key2")
-    end
-  end
 end

data/spec/unit/braintree/credit_card_spec.rb

@@ -15,7 +15,6 @@ describe Braintree::CreditCard do
         :billing_address_id,
         :cardholder_name,
         :cvv,
-        :device_session_id,
         :expiration_date,
         :expiration_month,
         :expiration_year,
@@ -23,10 +22,9 @@ describe Braintree::CreditCard do
         :token,
         :venmo_sdk_payment_method_code,
         :device_data,
-        :fraud_merchant_id,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -63,7 +61,6 @@ describe Braintree::CreditCard do
         :billing_address_id,
         :cardholder_name,
         :cvv,
-        :device_session_id,
         :expiration_date,
         :expiration_month,
         :expiration_year,
@@ -71,10 +68,9 @@ describe Braintree::CreditCard do
         :token,
         :venmo_sdk_payment_method_code,
         :device_data,
-        :fraud_merchant_id,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -105,21 +101,6 @@ describe Braintree::CreditCard do
     end
   end
 
-  describe "self.create_from_transparent_redirect" do
-    it "raises an exception if the query string is forged" do
-      expect do
-        Braintree::CreditCard.create_from_transparent_redirect("http_status=200&forged=query_string")
-      end.to raise_error(Braintree::ForgedQueryString)
-    end
-  end
-
-  describe "self.create_credit_card_url" do
-    it "returns the url" do
-      config = Braintree::Configuration.instantiate
-      Braintree::CreditCard.create_credit_card_url.should == "http#{config.ssl? ? 's' : ''}://#{config.server}:#{config.port}/merchants/integration_merchant_id/payment_methods/all/create_via_transparent_redirect_request"
-    end
-  end
-
   describe "==" do
     it "returns true if given a credit card with the same token" do
       first = Braintree::CreditCard._new(:gateway, :token => 123)
@@ -253,7 +234,7 @@ describe Braintree::CreditCard do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard._new(Braintree::Configuration.gateway, {}).update(:invalid_key => 'val')
+        Braintree::CreditCard.update(:gateway, :invalid_key => 'val')
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -117,14 +117,18 @@ describe Braintree::CreditCardVerification do
       verification = Braintree::CreditCardVerification._new(:risk_data => {
         :id => "123",
         :decision => "WOO YOU WON $1000 dollars",
+        :decision_reasons => ["reason"],
         :device_data_captured => true,
-        :fraud_service_provider => "kount"
+        :fraud_service_provider => "paypal_fraud_protection",
+        :transaction_risk_score => "12",
       })
 
       verification.risk_data.id.should == "123"
       verification.risk_data.decision.should == "WOO YOU WON $1000 dollars"
+      verification.risk_data.decision_reasons.should == ["reason"]
       verification.risk_data.device_data_captured.should == true
-      verification.risk_data.fraud_service_provider.should == "kount"
+      verification.risk_data.fraud_service_provider.should == "paypal_fraud_protection"
+      verification.risk_data.transaction_risk_score.should == "12"
     end
 
     it "handles a nil risk_data" do

data/spec/unit/braintree/customer_spec.rb

@@ -91,7 +91,6 @@ describe Braintree::Customer do
           :billing_address_id,
           :cardholder_name,
           :cvv,
-          :device_session_id,
           :expiration_date,
           :expiration_month,
           :expiration_year,
@@ -99,10 +98,9 @@ describe Braintree::Customer do
           :token,
           :venmo_sdk_payment_method_code,
           :device_data,
-          :fraud_merchant_id,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -182,7 +180,6 @@ describe Braintree::Customer do
           :billing_address_id,
           :cardholder_name,
           :cvv,
-          :device_session_id,
           :expiration_date,
           :expiration_month,
           :expiration_year,
@@ -190,7 +187,6 @@ describe Braintree::Customer do
           :token,
           :venmo_sdk_payment_method_code,
           :device_data,
-          :fraud_merchant_id,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
           {:options => [
@@ -201,6 +197,7 @@ describe Braintree::Customer do
             :venmo_sdk_session,
             :fail_on_duplicate_payment_method,
             :verification_account_type,
+            :verification_currency_iso_code,
             :update_existing_token
           ]},
           {:billing_address => [
@@ -259,14 +256,6 @@ describe Braintree::Customer do
     end
   end
 
-  describe "self.create_from_transparent_redirect" do
-    it "raises an exception if the query string is forged" do
-      expect do
-        Braintree::Customer.create_from_transparent_redirect("http_status=200&forged=query_string")
-      end.to raise_error(Braintree::ForgedQueryString)
-    end
-  end
-
   describe "==" do
     it "returns true when given a customer with the same id" do
       first = Braintree::Customer._new(:gateway, :id => 123)

data/spec/unit/braintree/dispute_spec.rb

@@ -198,13 +198,6 @@ describe Braintree::Dispute do
 
     describe "with optional params" do
       it "does not raise an exception if the optional parameters are valid" do
-        Braintree::Http.stub(:new).and_return double.as_null_object
-        expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", tag: "", sequence_number: 3 })
-        end.to_not raise_error
-      end
-
-      it "does not raise an exception if the category parameter is provided" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
           Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", category: "", sequence_number: 3 })
@@ -327,7 +320,7 @@ describe Braintree::Dispute do
       dispute.transaction.payment_instrument_subtype.should == "Visa"
     end
 
-    it "converts status_history hash into an array of Dispute::HistoryEvent objects" do
+    it "converts status_history hash into an array of Dispute::StatusHistory objects" do
       dispute = Braintree::Dispute._new(attributes)
 
       dispute.status_history.length.should == 1
@@ -398,10 +391,6 @@ describe Braintree::Dispute do
   describe "comments" do
     let(:dispute) { Braintree::Dispute._new(attributes) }
 
-    it "#forwarded_comments returns `processor_comments`" do
-      expect(dispute.forwarded_comments).to eq(dispute.processor_comments)
-    end
-
     it "#processor_comments" do
       expect(dispute.processor_comments).to eq(attributes[:processor_comments])
     end

data/spec/unit/braintree/http_spec.rb

@@ -130,7 +130,7 @@ END
       expect(default_headers["Accept-Encoding"]).to eq("gzip")
       expect(default_headers["Content-Type"]).to eq("application/xml")
       expect(default_headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(default_headers["X-ApiVersion"]).to eq("5")
+      expect(default_headers["X-ApiVersion"]).to eq("6")
     end
 
     it "overwrites defaults with override headers" do
@@ -144,7 +144,7 @@ END
       expect(headers["Authorization"]).to eq("token")
       expect(headers["Content-Type"]).to eq("application/xml")
       expect(headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(headers["X-ApiVersion"]).to eq("5")
+      expect(headers["X-ApiVersion"]).to eq("6")
     end
 
     it "extends default headers when new headers are specified" do
@@ -156,7 +156,7 @@ END
       expect(headers["Accept-Encoding"]).to eq("gzip")
       expect(headers["Content-Type"]).to eq("application/xml")
       expect(headers["User-Agent"]).to match(/Braintree Ruby Gem .*/)
-      expect(headers["X-ApiVersion"]).to eq("5")
+      expect(headers["X-ApiVersion"]).to eq("6")
       expect(headers["New-Header"]).to eq("New Value")
     end
   end

data/spec/unit/braintree/local_payment_completed_spec.rb

@@ -32,5 +32,19 @@ describe Braintree::LocalPaymentCompleted do
       local_payment_completed.transaction.order_id.should eq("an-order-id")
       local_payment_completed.transaction.status.should eq(Braintree::Transaction::Status::Authorized)
     end
+
+    it "initializes the object with the appropriate attributes set if no transaction is provided" do
+      params = {
+        payment_id: "a-payment-id",
+        payer_id: "a-payer-id",
+        payment_method_nonce: "a-nonce",
+      }
+      local_payment_completed = Braintree::LocalPaymentCompleted._new(params)
+
+      local_payment_completed.payment_id.should eq("a-payment-id")
+      local_payment_completed.payer_id.should eq("a-payer-id")
+      local_payment_completed.payment_method_nonce.should eq("a-nonce")
+      local_payment_completed.transaction.should be_nil
+    end
   end
 end

data/spec/unit/braintree/resource_collection_spec.rb

@@ -18,6 +18,35 @@ describe "Braintree::ResourceCollection" do
     end
   end
 
+  describe "#first" do
+    it 'returns nil with no results' do
+      values = %w(a b c d e)
+      collection = Braintree::ResourceCollection.new(:search_results => {:ids => [], :page_size => 2}) do |ids|
+        ids.map {|id| values[id] }
+      end
+
+      collection.first.should == nil
+    end
+
+    context 'with results' do
+      let(:collection) do
+        values = %w(a b c d e)
+
+        Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
+          ids.map {|id| values[id] }
+        end
+      end
+
+      it 'returns the first occourence' do
+        collection.first.should == 'a'
+      end
+
+      it 'returns the first N occourences' do
+        collection.first(4).should == ['a','b','c','d']
+      end
+    end
+  end
+
   describe "#ids" do
     it "returns a list of the resource collection ids" do
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2})

data/spec/unit/braintree/risk_data_spec.rb

@@ -2,12 +2,14 @@ require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
 
 describe Braintree::RiskData do
   describe "#initialize" do
-    it "sets id, decision and device_data_captured" do
-      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true, :fraud_service_provider => "kount")
+    it "sets id, decision, device_data_captured, decision_reasons and transaction_risk_score" do
+      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true, :fraud_service_provider => "fraud_protection", :decision_reasons => ["reason"], :transaction_risk_score => "12")
       risk_data.id.should == "123"
       risk_data.decision.should == "YOU WON $1000 DOLLARS"
       risk_data.device_data_captured.should be_truthy
-      risk_data.fraud_service_provider.should == "kount"
+      risk_data.fraud_service_provider.should == "fraud_protection"
+      risk_data.decision_reasons.should == ["reason"]
+      risk_data.transaction_risk_score.should == "12"
     end
   end
 
@@ -16,10 +18,12 @@ describe Braintree::RiskData do
       details = Braintree::RiskData.new(
         :id => "123",
         :decision => "YOU WON $1000 DOLLARS",
+        :decision_reasons => ["reason"],
         :device_data_captured => true,
-        :fraud_service_provider => "kount",
+        :fraud_service_provider => "fraud_protection",
+        :transaction_risk_score => "12",
       )
-      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", device_data_captured: true, fraud_service_provider: "kount">)
+      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", decision_reasons: ["reason"], device_data_captured: true, fraud_service_provider: "fraud_protection", transaction_risk_score: "12">)
     end
   end
 end