braintree 1.1.3 → 1.2.0

data/spec/integration/braintree/transaction_spec.rb

@@ -706,8 +706,10 @@ describe Braintree::Transaction do
           :type => "sale"
         }
       }
-      query_string_response = create_transaction_via_tr(params, tr_data_params)
+      tr_data = Braintree::TransparentRedirect.transaction_data({:redirect_url => "http://example.com"}.merge(tr_data_params))
+      query_string_response = SpecHelper.simulate_form_post_for_tr(Braintree::Transaction.create_transaction_url, tr_data, params)
       result = Braintree::Transaction.create_from_transparent_redirect(query_string_response)
+
       result.success?.should == true
       transaction = result.transaction
       transaction.type.should == "sale"
@@ -764,8 +766,10 @@ describe Braintree::Transaction do
           }
         }
       }
-      query_string_response = create_transaction_via_tr(params, tr_data_params)
+      tr_data = Braintree::TransparentRedirect.transaction_data({:redirect_url => "http://example.com"}.merge(tr_data_params))
+      query_string_response = SpecHelper.simulate_form_post_for_tr(Braintree::Transaction.create_transaction_url, tr_data, params)
       result = Braintree::Transaction.create_from_transparent_redirect(query_string_response)
+
       transaction = result.transaction
       transaction.id.should =~ /\A\w{6}\z/
       transaction.type.should == "sale"
@@ -825,8 +829,10 @@ describe Braintree::Transaction do
           :type => "sale"
         }
       }
-      query_string_response = create_transaction_via_tr(params, tr_data_params)
+      tr_data = Braintree::TransparentRedirect.transaction_data({:redirect_url => "http://example.com"}.merge(tr_data_params))
+      query_string_response = SpecHelper.simulate_form_post_for_tr(Braintree::Transaction.create_transaction_url, tr_data, params)
       result = Braintree::Transaction.create_from_transparent_redirect(query_string_response)
+
       result.success?.should == false
       result.params[:transaction].should == {:amount => "", :type => "sale", :credit_card => {:expiration_date => "05/2009"}}
       result.errors.for(:transaction).on(:amount)[0].code.should == Braintree::ErrorCodes::Transaction::AmountIsRequired
@@ -1260,21 +1266,6 @@ describe Braintree::Transaction do
     end
   end
 
-  def create_transaction_via_tr(params, tr_data_params)
-    response = nil
-    Net::HTTP.start(Braintree::Configuration.server, Braintree::Configuration.port) do |http|
-      request = Net::HTTP::Post.new("/" + Braintree::Transaction.create_transaction_url.split("/", 4)[3])
-      request.add_field "Content-Type", "application/x-www-form-urlencoded"
-      params = {
-        :tr_data => Braintree::TransparentRedirect.transaction_data({:redirect_url => "http://testing.com"}.merge(tr_data_params))
-      }.merge(params)
-      request.body = Braintree::Util.hash_to_query_string(params)
-      response = http.request(request)
-    end
-    query_string = response["Location"].split("?", 2).last
-    query_string
-  end
-
   def create_transaction_to_refund
     transaction = Braintree::Transaction.sale!(
       :amount => Braintree::Test::TransactionAmounts::Authorize,

data/spec/integration/braintree/transparent_redirect_spec.rb

@@ -0,0 +1,21 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe Braintree::TransparentRedirect do
+  it "raises a DownForMaintenanceError when app is in maintenance mode on TR requests" do
+    tr_data = Braintree::TransparentRedirect.create_customer_data({:redirect_url => "http://example.com"}.merge({}))
+    query_string_response = SpecHelper.simulate_form_post_for_tr(Braintree::Configuration.base_merchant_url + "/test/maintenance", tr_data, {})
+    expect do
+      Braintree::Customer.create_from_transparent_redirect(query_string_response)
+    end.to raise_error(Braintree::DownForMaintenanceError)
+  end
+
+  it "raises an AuthenticationError when authentication fails on TR requests" do
+    SpecHelper.using_configuration(:private_key => "incorrect") do
+      tr_data = Braintree::TransparentRedirect.create_customer_data({:redirect_url => "http://example.com"}.merge({}))
+      query_string_response = SpecHelper.simulate_form_post_for_tr(Braintree::Customer.create_customer_url, tr_data, {})
+      expect do
+        Braintree::Customer.create_from_transparent_redirect(query_string_response)
+      end.to raise_error(Braintree::AuthenticationError)
+    end
+  end
+end

data/spec/integration/spec_helper.rb

@@ -4,29 +4,6 @@ unless defined?(INTEGRATION_SPEC_HELPER_LOADED)
   require File.dirname(__FILE__) + "/../spec_helper"
   require File.dirname(__FILE__) + "/../hacks/tcp_socket"
 
-  Spec::Runner.configure do |config|
-    CLIENT_LIB_ROOT = File.expand_path(File.dirname(__FILE__) + "/../..")
-    GATEWAY_ROOT = File.expand_path("#{CLIENT_LIB_ROOT}/../gateway")
-    GATEWAY_PID_FILE = "/tmp/gateway_server_#{Braintree::Configuration.port}.pid"
-    SPHINX_PID_FILE = "#{GATEWAY_ROOT}/log/searchd.integration.pid"
-
-    gateway_already_started = File.exist?(GATEWAY_PID_FILE)
-    sphinx_already_started = File.exist?(SPHINX_PID_FILE)
-    config.before(:suite) do
-       Dir.chdir(CLIENT_LIB_ROOT) do
-        system "rake start_gateway" or raise "rake start_gateway failed" unless gateway_already_started
-        system "rake start_sphinx" or raise "rake start_sphinx failed" unless sphinx_already_started
-      end
-    end
-
-    config.after(:suite) do
-      Dir.chdir(CLIENT_LIB_ROOT) do
-        system "rake stop_gateway" or raise "rake stop_gateway failed" unless gateway_already_started
-        system "rake stop_sphinx" or raise "rake stop_sphinx failed" unless sphinx_already_started
-      end
-    end
-  end
-
   def start_ssl_server
     web_server_pid_file = File.expand_path(File.join(File.dirname(__FILE__), "..", "httpsd.pid"))
 

data/spec/spec_helper.rb

@@ -34,5 +34,39 @@ unless defined?(SPEC_HELPER_LOADED)
         end
       end
     end
+
+    def self.simulate_form_post_for_tr(url, tr_data_string, form_data_hash)
+      response = nil
+      Net::HTTP.start("localhost", Braintree::Configuration.port) do |http|
+        request = Net::HTTP::Post.new("/" + url.split("/", 4)[3])
+        request.add_field "Content-Type", "application/x-www-form-urlencoded"
+        request.body = Braintree::Util.hash_to_query_string({:tr_data => tr_data_string}.merge(form_data_hash))
+        response = http.request(request)
+      end
+      if response.code.to_i == 303
+        response["Location"].split("?", 2).last
+      else
+        raise "did not receive a valid tr response: #{response.body[0,1000].inspect}"
+      end
+    end
+
+    def self.using_configuration(config = {}, &block)
+      original_values = {}
+      [:merchant_id, :public_key, :private_key].each do |key|
+        if config[key]
+          original_values[key] = Braintree::Configuration.send(key)
+          Braintree::Configuration.send("#{key}=", config[key])
+        end
+      end
+      begin
+        yield
+      ensure
+        original_values.each do |key, value|
+          Braintree::Configuration.send("#{key}=", value)
+        end
+      end
+    end
   end
 end
+
+Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f}

data/spec/support/matchers/include_on_any_page.rb

@@ -0,0 +1,24 @@
+Spec::Matchers.define :include_on_any_page do |expected|
+  match do |collection|
+    on_any_page?(collection, expected)
+  end
+
+  def on_any_page?(collection, expected)
+    return true if collection.any? { |item| item.id == expected.id }
+    return false if collection.last_page?
+
+    on_any_page?(collection.next_page, expected)
+  end
+
+  failure_message_for_should do |collection|
+    "expected that the paged collection would include an item with id #{expected.id}"
+  end
+
+  failure_message_for_should_not do |collection|
+    "expected that the paged collection would not include an item with id #{expected.id}"
+  end
+
+  description do
+    "include the given subsription in the paged collection"
+  end
+end

data/spec/unit/braintree/configuration_spec.rb

@@ -44,21 +44,21 @@ describe Braintree::Configuration do
     it "qa" do
       Braintree::Configuration.environment = :qa
       ca_file = Braintree::Configuration.ca_file
-      ca_file.should match(/valicert_ca.crt$/)
+      ca_file.should match(/sandbox_braintreegateway_com.ca.crt$/)
       File.exists?(ca_file).should == true
     end
 
     it "sandbox" do
       Braintree::Configuration.environment = :sandbox
       ca_file = Braintree::Configuration.ca_file
-      ca_file.should match(/valicert_ca.crt$/)
+      ca_file.should match(/sandbox_braintreegateway_com.ca.crt$/)
       File.exists?(ca_file).should == true
     end
 
     it "production" do
       Braintree::Configuration.environment = :production
       ca_file = Braintree::Configuration.ca_file
-      ca_file.should match(/securetrust_ca.crt$/)
+      ca_file.should match(/www_braintreegateway_com.ca.crt$/)
       File.exists?(ca_file).should == true
     end
   end

data/spec/unit/braintree/credit_card_spec.rb

@@ -24,7 +24,7 @@ describe Braintree::CreditCard do
   describe "self.create_from_transparent_redirect" do
     it "raises an exception if the query string is forged" do
       expect do
-        Braintree::CreditCard.create_from_transparent_redirect("forged=query_string")
+        Braintree::CreditCard.create_from_transparent_redirect("http_status=200&forged=query_string")
       end.to raise_error(Braintree::ForgedQueryString)
     end
   end

data/spec/unit/braintree/customer_spec.rb

@@ -51,7 +51,7 @@ describe Braintree::Customer do
   describe "self.create_from_transparent_redirect" do
     it "raises an exception if the query string is forged" do
       expect do
-        Braintree::Customer.create_from_transparent_redirect("forged=query_string")
+        Braintree::Customer.create_from_transparent_redirect("http_status=200&forged=query_string")
       end.to raise_error(Braintree::ForgedQueryString)
     end
   end

data/spec/unit/braintree/paged_collection_spec.rb

@@ -125,4 +125,54 @@ describe "Braintree::PagedCollection" do
     end
   end
 
+  context "custom matchers" do
+    require 'enumerator'
+
+    DummyItem = Struct.new(:id)
+
+    def paged_collection(items, page_size)
+      pages = []
+      items.each_slice(page_size) do |slice|
+        pages << slice
+      end
+
+      _build_collection(pages, page_size, items.size, 1)
+    end
+
+    def _build_collection(paged_items, page_size, total_size, current_page)
+      Braintree::PagedCollection.new(:items => paged_items[current_page - 1], :total_items => total_size, :page_size => page_size, :current_page_number => current_page) do |page|
+        _build_collection(paged_items, page_size, total_size, page)
+      end
+    end
+
+    describe "include_on_any_page" do
+      it "finds a match in a simple collection" do
+        element = DummyItem.new(123)
+        collection = paged_collection([element], 10)
+
+        collection.should include_on_any_page(element)
+      end
+
+      it "does not find a match in a simple collection" do
+        element = DummyItem.new(1)
+        collection = paged_collection([DummyItem.new(2)], 10)
+
+        collection.should_not include_on_any_page(element)
+      end
+
+      it "finds a match on a subsequent page" do
+        element = DummyItem.new(1)
+        collection = paged_collection([DummyItem.new(2), element], 1)
+
+        collection.should include_on_any_page(element)
+      end
+
+      it "does not find a match on a subsequent page" do
+        element = DummyItem.new(1)
+        collection = paged_collection([DummyItem.new(2), DummyItem.new(3)], 1)
+
+        collection.should_not include_on_any_page(element)
+      end
+    end
+  end
 end

data/spec/unit/braintree/subscription_search_spec.rb

@@ -0,0 +1,35 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+module Braintree
+  describe SubscriptionSearch do
+    context "status" do
+      it "allows Active, Canceled and PastDue" do
+        search = SubscriptionSearch.new
+
+        lambda do
+          search.status.in(
+            Subscription::Status::Active,
+            Subscription::Status::Canceled,
+            Subscription::Status::PastDue
+          )
+        end.should_not raise_error
+      end
+    end
+
+    context "days_past_due" do
+      it "correctly builds a hash with the criteria" do
+        search = SubscriptionSearch.new
+        search.days_past_due.is "30"
+
+        search.to_hash.should == {:days_past_due => {:is => "30"}}
+      end
+
+      it "coverts ints to strings" do
+        search = SubscriptionSearch.new
+        search.days_past_due.is 30
+
+        search.to_hash.should == {:days_past_due => {:is => "30"}}
+      end
+    end
+  end
+end

data/spec/unit/braintree/subscription_spec.rb

@@ -13,4 +13,14 @@ describe Braintree::Subscription do
       }.to raise_error(/Argument must be a String or BigDecimal/)
     end
   end
+
+  describe "self.search" do
+    it "only allows specified values for status" do
+      lambda do
+        Braintree::Subscription.search do |search|
+          search.status.in "Hammer"
+        end
+      end.should raise_error(ArgumentError)
+    end
+  end
 end

data/spec/unit/braintree/transaction_spec.rb

@@ -12,7 +12,7 @@ describe Braintree::Transaction do
   describe "self.create_from_transparent_redirect" do
     it "raises an exception if the query string is forged" do
       expect do
-        Braintree::Transaction.create_from_transparent_redirect("forged=query_string")
+        Braintree::Transaction.create_from_transparent_redirect("http_status=200&forged=query_string")
       end.to raise_error(Braintree::ForgedQueryString)
     end
   end

data/spec/unit/braintree/transparent_redirect_spec.rb

@@ -32,7 +32,7 @@ describe Braintree::TransparentRedirect do
     end
 
     it "raises Braintree::ForgedQueryString if the hash param is not valid" do
-      query_string_without_hash = "one=1&two=2"
+      query_string_without_hash = "http_status=200&one=1&two=2"
       hash = Digest::SHA1.hexdigest("invalid#{query_string_without_hash}")
 
       query_string_with_hash = "#{query_string_without_hash}&hash=#{hash}"
@@ -43,7 +43,7 @@ describe Braintree::TransparentRedirect do
 
     it "raises Braintree::ForgedQueryString if hash is missing from the query string" do
       expect do
-        Braintree::TransparentRedirect.parse_and_validate_query_string "query_string=without_a_hash"
+        Braintree::TransparentRedirect.parse_and_validate_query_string "http_status=200&query_string=without_a_hash"
       end.to raise_error(Braintree::ForgedQueryString)
     end
 
@@ -59,6 +59,12 @@ describe Braintree::TransparentRedirect do
       end.to raise_error(Braintree::AuthorizationError)
     end
 
+    it "raises an UnexpectedError if http_status is not in query string" do
+      expect do
+        Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("no_http_status=x")
+      end.to raise_error(Braintree::UnexpectedError, "expected query string to have an http_status param")
+    end
+
     it "raises a ServerError if the server 500's" do
       expect do
         Braintree::TransparentRedirect.parse_and_validate_query_string add_hash_to_query_string("http_status=500")

data/spec/unit/braintree/xml_spec.rb

@@ -94,6 +94,11 @@ describe Braintree::Xml do
       verify_to_xml_and_back hash
     end
 
+    it "works for arrays of strings" do
+      hash = {:root => {:items => ["first", "second"]}}
+      verify_to_xml_and_back hash
+    end
+
     it "type casts booleans" do
       hash = {:root => {:string_true => "true", :bool_true => true, :bool_false => false, :string_false => "false"}}
       verify_to_xml_and_back hash

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 1
-  - 1
-  - 3
-  version: 1.1.3
+  - 2
+  - 0
+  version: 1.2.0
 platform: ruby
 authors: 
 - Braintree Payment Solutions
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-01 00:00:00 -05:00
+date: 2010-04-09 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -30,6 +30,7 @@ files:
 - README.rdoc
 - LICENSE
 - lib/braintree/address.rb
+- lib/braintree/advanced_search.rb
 - lib/braintree/base_module.rb
 - lib/braintree/configuration.rb
 - lib/braintree/credit_card.rb
@@ -44,6 +45,7 @@ files:
 - lib/braintree/paged_collection.rb
 - lib/braintree/ssl_expiration_check.rb
 - lib/braintree/subscription.rb
+- lib/braintree/subscription_search.rb
 - lib/braintree/successful_result.rb
 - lib/braintree/test/credit_card_numbers.rb
 - lib/braintree/test/transaction_amounts.rb
@@ -71,9 +73,11 @@ files:
 - spec/integration/braintree/subscription_spec.rb
 - spec/integration/braintree/test/transaction_amounts_spec.rb
 - spec/integration/braintree/transaction_spec.rb
+- spec/integration/braintree/transparent_redirect_spec.rb
 - spec/integration/spec_helper.rb
 - spec/script/httpsd.rb
 - spec/spec_helper.rb
+- spec/support/matchers/include_on_any_page.rb
 - spec/unit/braintree/address_spec.rb
 - spec/unit/braintree/base_module_spec.rb
 - spec/unit/braintree/configuration_spec.rb
@@ -86,6 +90,7 @@ files:
 - spec/unit/braintree/http_spec.rb
 - spec/unit/braintree/paged_collection_spec.rb
 - spec/unit/braintree/ssl_expiration_check_spec.rb
+- spec/unit/braintree/subscription_search_spec.rb
 - spec/unit/braintree/subscription_spec.rb
 - spec/unit/braintree/successful_result_spec.rb
 - spec/unit/braintree/transaction/credit_card_details_spec.rb
@@ -99,8 +104,9 @@ files:
 - spec/unit/braintree/xml_spec.rb
 - spec/unit/braintree_spec.rb
 - spec/unit/spec_helper.rb
+- lib/ssl/sandbox_braintreegateway_com.ca.crt
 - lib/ssl/securetrust_ca.crt
-- lib/ssl/valicert_ca.crt
+- lib/ssl/www_braintreegateway_com.ca.crt
 has_rdoc: true
 homepage: http://www.braintreepaymentsolutions.com/gateway
 licenses: []