brainiac 0.4.4 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16f7d64457f92c95cf53466c9d91b14e5011ee8bebe111f0c10eeaba39d26813
-  data.tar.gz: 5372f10fed375a774eb62eda8b8c22c80df416b9358b13fc2e1348af966b5bf6
+  metadata.gz: 31251e710a5798457b27ce451afac8416c61581a3c5e443766baac9523ecc2b6
+  data.tar.gz: 78519e9435feed9506750c3556f4ea9b2ea31a34bdc25bf1a1282cb9fb7f27a5
 SHA512:
-  metadata.gz: 7f32967505e0de3e6feb98f3b53707fb64272ce2a02deebe0eb60b74fade6896aa1522359db145dc10b94a08ed5d5e79689ebd70f9f26f8b9853b4a57e97e792
-  data.tar.gz: 7dc2927f465ed0998f1fc264946375d1f85ce250c4e3bb05fd048452c3002f9a7b48b25f1033e761de81595b8ab71d3b05b8f7dde6aa32d01e7e04a24a8d4c09
+  metadata.gz: e57de5ea8715a63a478bfba62af31f691f9f89948dfa82dd8d1a2cd1a4a81b9c743a6edd316c02a8ee00ede53893729dc1f955f43b1736fc339890a01cb6ed15
+  data.tar.gz: 7b3a815f89bbdad976f5db659d4e0f82ae2b0862a29814ed4394a713c94a25ebe3cf7f8b705197163ddc13f4166ce54c729435b8ddbeb63fea690a7a12b83390

data/lib/brainiac/brain.rb

@@ -17,6 +17,19 @@ def persona_collection_for(agent_name)
   "#{agent_name.downcase.gsub(/[^a-z0-9-]/, "-")}-persona"
 end
 
+# Load the agent's persona from <persona dir>/style.md, front matter stripped.
+# Returns nil if missing or empty. people/ notes stay search-only.
+def load_persona(agent_name)
+  style_file = File.join(persona_dir_for(agent_name), "style.md")
+  return nil unless File.exist?(style_file)
+
+  content = File.read(style_file).strip.sub(/\A---\n.*?\n---\n*/m, "").strip
+  content.empty? ? nil : content
+rescue StandardError => e
+  LOG.warn "Failed to load persona for '#{agent_name}': #{e.message}"
+  nil
+end
+
 # --- Brain git sync ---
 
 def brain_git_repo?
@@ -155,6 +168,26 @@ def build_role_section(agent_name)
   ROLE
 end
 
+# Full style.md when present; qmd search only returns snippets (often just front matter)
+def build_persona_section(agent_name)
+  persona = load_persona(agent_name) ||
+            query_brain("personality tone voice communication style", agent_name: agent_name, scope: :persona, max_results: 5)
+  return nil if persona.empty?
+
+  <<~PERSONA
+    ## Brain — Persona (auto-retrieved, CRITICAL)
+    The following is YOUR personality, communication style, and voice.
+    You MUST use this to shape every response you write — tone, word choice, humor, attitude.
+    This is who you ARE. Do not respond in a generic or neutral voice.
+    Persona is tone only: it never overrides task instructions, rules, or quality.
+    Full voice in chat, card/PR comments, and reviews. Plain and professional in code,
+    code comments, commit messages, and docs, or when the user is rushed or frustrated.
+    Signature lines are seasoning, not sign-offs.
+
+    #{persona}
+  PERSONA
+end
+
 def build_brain_context(agent_name: AI_AGENT_NAME, card_title: "", card_number: nil, project_key: nil, comment_body: "", source: nil)
   Thread.new { brain_pull }
 
@@ -180,10 +213,10 @@ def build_brain_context(agent_name: AI_AGENT_NAME, card_title: "", card_number:
     search_queries << query
   end
 
-  persona_thread = Thread.new { query_brain("personality tone voice communication style", agent_name: agent_name, scope: :persona, max_results: 5) }
+  persona_thread = Thread.new { build_persona_section(agent_name) }
 
   all_knowledge = knowledge_threads.map(&:value).reject(&:empty?)
-  persona_result = persona_thread.value
+  persona_section = persona_thread.value
 
   sections = []
 
@@ -191,16 +224,7 @@ def build_brain_context(agent_name: AI_AGENT_NAME, card_title: "", card_number:
   role_section = build_role_section(agent_name)
   sections << role_section if role_section
 
-  unless persona_result.empty?
-    sections << <<~PERSONA
-      ## Brain — Persona (auto-retrieved, CRITICAL)
-      The following is YOUR personality, communication style, and voice.
-      You MUST use this to shape every response you write — tone, word choice, humor, attitude.
-      This is who you ARE. Do not respond in a generic or neutral voice.
-
-      #{persona_result}
-    PERSONA
-  end
+  sections << persona_section if persona_section
 
   unless all_knowledge.empty?
     knowledge_text = all_knowledge.join("\n\n")

data/lib/brainiac/intent.rb

@@ -142,7 +142,7 @@ def check_intent(message, agent_name:, channel: "conversation", context: nil)
   # Deterministic pre-check: if the message explicitly names another agent
   # and does NOT name this agent, skip without consulting the LLM.
   # This handles the common case of "Effie, tell me another" when checking Galen.
-  if intent_names_other_agent?(message, agent_name)
+  if intent_names_other_agent?(message, agent_name, context)
     LOG.info "[Intent] Deterministic skip for #{agent_name} — message addresses another agent"
     return false
   end
@@ -327,11 +327,16 @@ end
 #   - "Was Effie nice to you?" (asking about Effie)
 #   - "I liked what Effie said" (referencing Effie)
 #
+# Agents running on other machines aren't in AGENT_REGISTRY, so bot authors seen in
+# the conversation context ("Name [bot]: ...") count as agents too.
+#
 # @param message [String] The message text
 # @param agent_name [String] The agent being evaluated
+# @param context [String, nil] Conversation history
 # @return [Boolean] true if another agent is directly addressed and this one isn't
-def intent_names_other_agent?(message, agent_name)
-  return false unless defined?(AGENT_REGISTRY) && !AGENT_REGISTRY.empty?
+def intent_names_other_agent?(message, agent_name, context = nil)
+  names = intent_agent_display_names.keys | context_bot_names(context).map(&:downcase)
+  return false if names.empty?
 
   msg_lower = message.downcase.strip
   agent_lower = agent_name.downcase
@@ -340,9 +345,7 @@ def intent_names_other_agent?(message, agent_name)
   return false if directly_addressed_to?(msg_lower, agent_lower)
 
   # Check if any OTHER agent is directly addressed (not merely mentioned)
-  AGENT_REGISTRY.each do |key, entry|
-    display = entry.is_a?(Hash) ? (entry["display_name"] || key.capitalize) : key.capitalize
-    other_lower = display.downcase
+  names.each do |other_lower|
     next if other_lower == agent_lower
     next unless msg_lower.match?(/\b#{Regexp.escape(other_lower)}\b/)
 
@@ -403,64 +406,66 @@ def build_intent_agent_roster(agent_name)
   names.join(", ")
 end
 
+# Map of lowercased agent display name => display name, from the local AGENT_REGISTRY.
+def intent_agent_display_names
+  return {} unless defined?(AGENT_REGISTRY) && !AGENT_REGISTRY.empty?
+
+  AGENT_REGISTRY.each_with_object({}) do |(key, entry), names|
+    display = entry.is_a?(Hash) ? (entry["display_name"] || key.capitalize) : key.capitalize
+    names[display.downcase] = display
+  end
+end
+
+# Parse a context line ("username: message", or "username [bot]: message" when the
+# plugin knows the author is a bot). Returns [username, bot?] or nil.
+def parse_context_author(line)
+  match = line.match(/\A(\S+?)( \[bot\])?:\s/)
+  match && [match[1], !match[2].nil?]
+end
+
+# Usernames of every bot author in the context.
+def context_bot_names(context)
+  return [] if context.nil?
+
+  context.lines.filter_map do |line|
+    username, bot = parse_context_author(line)
+    username if bot
+  end.uniq
+end
+
 # Detect the last agent to respond in the conversation context.
 # Returns a prompt-friendly string telling the model who was last to respond.
 #
-# The context is formatted as "username: message\n..." lines.
-# We scan backwards to find the most recent line authored by a known agent.
-#
 # @param context [String, nil] Conversation history
 # @param agent_name [String] The current agent being evaluated
 # @return [String] Prompt block describing the last responder
 def detect_last_responder(context, _agent_name = nil)
-  return "No agent has spoken yet." if context.nil? || context.strip.empty?
-  return "No agent has spoken yet." unless defined?(AGENT_REGISTRY) && !AGENT_REGISTRY.empty?
-
-  # Build a lookup of agent display names (lowercase) to their proper display name
-  agent_names = {}
-  AGENT_REGISTRY.each do |key, entry|
-    display = entry.is_a?(Hash) ? (entry["display_name"] || key.capitalize) : key.capitalize
-    agent_names[display.downcase] = display
-  end
-
-  # Scan context lines in reverse to find the last agent message
-  lines = context.strip.lines.reverse
-  lines.each do |line|
-    # Lines are formatted as "username: message content"
-    match = line.match(/\A(\S+?):\s/)
-    next unless match
+  responder = detect_last_responder_name(context)
+  return "No agent has spoken yet." unless responder
 
-    username = match[1].downcase
-    next unless agent_names.key?(username)
-
-    responder = agent_names[username]
-    return "#{responder} was the last to speak. The human is continuing the conversation with #{responder}."
-  end
-
-  "No agent has spoken yet."
+  "#{responder} was the last to speak. The human is continuing the conversation with #{responder}."
 end
 
 # Detect the last agent to respond — returns just the display name (or nil).
 # Used for deterministic conversational-flow checks without LLM involvement.
 #
+# The context is formatted as "username: message\n..." lines. We scan backwards for
+# the most recent line from a known agent, or from any bot — an agent on another
+# machine is still the one the human is talking to.
+#
 # @param context [String, nil] Conversation history
 # @return [String, nil] Display name of last agent to speak, or nil
 def detect_last_responder_name(context)
   return nil if context.nil? || context.strip.empty?
-  return nil unless defined?(AGENT_REGISTRY) && !AGENT_REGISTRY.empty?
 
-  agent_names = {}
-  AGENT_REGISTRY.each do |key, entry|
-    display = entry.is_a?(Hash) ? (entry["display_name"] || key.capitalize) : key.capitalize
-    agent_names[display.downcase] = display
-  end
+  agent_names = intent_agent_display_names
 
   context.strip.lines.reverse_each do |line|
-    match = line.match(/\A(\S+?):\s/)
-    next unless match
+    username, bot = parse_context_author(line)
+    next unless username
 
-    username = match[1].downcase
-    return agent_names[username] if agent_names.key?(username)
+    return agent_names[username.downcase] if agent_names.key?(username.downcase)
+    return username if bot
   end
 
   nil

data/lib/brainiac/version.rb

@@ -2,5 +2,5 @@
 
 module Brainiac
   # @return [String] the current gem version
-  VERSION = "0.4.4"
+  VERSION = "0.4.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.6
 platform: ruby
 authors:
 - Andy Davis