brainiac-github 0.2.8 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db8e2a2ac41b7a6fe786239a6a909aac61975a70273068c243b301eeb2407f93
-  data.tar.gz: 8427ed0cbf86df7198149a11cbf64309471dea9ce9293ad9a49db57f2d14a03d
+  metadata.gz: df22ea85b48c5fd4960ad4e8bb28c3e59f551839c2cbc900dc065edc74039ed3
+  data.tar.gz: d8708dd8352a97e01bac35eb65ddb13ab7aea6249876987d4e73fd89328f97ee
 SHA512:
-  metadata.gz: e385a16a159af98f746a0c7ada60c04802de2549d8ace8a37ee8830ad8886d9bf5fa5ba89a34d38ba69b21c4b6aa82b0a1d24114a950e19bd10b5f7a45f9877d
-  data.tar.gz: 43cc967f3aafd227715a82e2a366e289452e0136e29415a52d244b0e796b9355f72983b1b32a056c86707a820dad269f9c2cfa9324d96945580c6574f6554685
+  metadata.gz: 241be88652dfaf39203b734d212d6b91e641017a3344cd4c8cabdad2332e1262f8e848e12680ca0612d43c9e44db6c124c9d1e6e76aecc5c625a4f30b8cff499
+  data.tar.gz: 5096d8be04c2c469770b93e5c998502cd545cb78553f64ec40e621d84f8d03c0d5e3ec9263c77237db1bc92cdb7396cb2ddff4b626be6230ca279b3f91676a14

data/lib/brainiac/plugins/github/app_client.rb

@@ -61,15 +61,19 @@ module Brainiac
             post("/repos/#{repo}/issues/comments/#{comment_id}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
-          # POST a reaction on a PR review.
+          # POST a reaction on a PR (or issue) itself.
+          #
+          # GitHub's reactions API has NO endpoint for PR reviews — only for
+          # issue comments, PR review comments, issues, and PRs. Since a PR is
+          # an issue under the hood, PR reactions go through the issues path.
           #
           # @param repo [String] "owner/repo"
-          # @param review_id [Integer]
-          # @param reaction [String]
+          # @param pr_number [Integer]
+          # @param reaction [String] e.g. "eyes", "+1", "rocket"
           # @param agent_key [String, nil] agent key for per-agent app identity
           # @return [Hash] parsed response
-          def create_review_reaction(repo, review_id, reaction, agent_key: nil)
-            post("/repos/#{repo}/pulls/reviews/#{review_id}/reactions", { content: reaction }, agent_key: agent_key)
+          def create_pr_reaction(repo, pr_number, reaction, agent_key: nil)
+            post("/repos/#{repo}/issues/#{pr_number}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
           # GET request to GitHub API.

data/lib/brainiac/plugins/github/handler.rb

@@ -105,11 +105,21 @@ module Brainiac
 
             return [200, { status: "ignored", reason: "no worktree" }.to_json] unless worktree && File.directory?(worktree)
 
+            # Pull latest changes into worktree
+            system("git", "pull", "--ff-only", chdir: worktree)
+
+            # Try to redeploy to ephemeral Belt environment if one exists
+            ephemeral_redeployed = maybe_redeploy_ephemeral_belt_env(
+              card_info: card_info, card_number: card_number, worktree: worktree,
+              base_branch: pr.dig("base", "ref")
+            )
+
+            # Also emit the hook for other plugins (e.g., brainiac-fizzy persistent env redeploy)
             results = Brainiac.emit(:pr_synchronized, card_number: card_number, card_info: card_info,
                                                       worktree: worktree, pull_request: pr, branch: branch)
 
-            if results.any?
-              [200, { status: "processed", action: "pr_sync", card: card_number }.to_json]
+            if ephemeral_redeployed || results.any?
+              [200, { status: "processed", action: "pr_sync", card: card_number, ephemeral_redeployed: ephemeral_redeployed }.to_json]
             else
               [200, { status: "ignored", reason: "no deployment plugin" }.to_json]
             end
@@ -648,6 +658,12 @@ module Brainiac
 
           def process_merged_pr(card_info, card_number, branch, pull_request, pr_url, pr_title, project_key, project_config, repo_path)
             mark_work_item_merged(card_number)
+
+            # Destroy ephemeral Belt environment BEFORE worktree cleanup (infrastructure lives in worktree)
+            maybe_destroy_ephemeral_belt_env(
+              card_info: card_info, card_number: card_number, project_key: project_key
+            )
+
             cleanup_work_item_worktrees(card_number, repo_path: repo_path,
                                                      primary_worktree: card_info["worktree"], primary_branch: branch)
 
@@ -730,10 +746,12 @@ module Brainiac
             agent_name = resolve_work_item_agent(card_info, project_config)
 
             Thread.new do
+              # GitHub has no reactions endpoint for PR reviews, so react on the
+              # PR itself (PRs are issues under the hood) to signal "on it".
               if AppClient.configured?(agent_name)
-                AppClient.create_review_reaction(repo_name, review_id, "eyes", agent_key: agent_name)
+                AppClient.create_pr_reaction(repo_name, pr_number, "eyes", agent_key: agent_name)
               else
-                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/pulls/reviews/#{review_id}/reactions",
+                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/issues/#{pr_number}/reactions",
                         "-f", "content=eyes", "-H", "Accept: application/vnd.github+json", chdir: repo_path)
               end
 
@@ -862,6 +880,71 @@ module Brainiac
 
             [200, { status: "processed", action: "prod_deploy", closed_cards: closed_cards.map { |c| c[:number] }, project: project_key }.to_json]
           end
+
+          # Destroy ephemeral Belt environment on PR merge.
+          # Must be called BEFORE worktree cleanup since infrastructure lives in the worktree.
+          def maybe_destroy_ephemeral_belt_env(card_info:, card_number:, project_key:)
+            unless defined?(BeltConfig) && defined?(BeltEnvironment)
+              LOG.debug "[EphemeralEnv] Belt utilities not available — skipping env destruction"
+              return
+            end
+
+            env_name = BeltConfig.ephemeral_env_for_card(card_number)
+            worktree = card_info&.dig("worktree")
+
+            unless ephemeral_env_present?(worktree: worktree, env_name: env_name)
+              LOG.debug "[EphemeralEnv] No ephemeral env '#{env_name}' found for card ##{card_number}"
+              return
+            end
+
+            unless worktree && File.directory?(worktree)
+              LOG.warn "[EphemeralEnv] Cannot destroy '#{env_name}' — worktree not found"
+              return
+            end
+
+            LOG.info "[EphemeralEnv] Destroying ephemeral environment '#{env_name}' for card ##{card_number}"
+            BeltEnvironment.destroy_environment(worktree: worktree, env_name: env_name)
+          rescue StandardError => e
+            LOG.error "[EphemeralEnv] Error destroying ephemeral env: #{e.message}"
+          end
+
+          # Redeploy to ephemeral Belt environment on PR sync (new commits pushed).
+          # Only redeploys if an ephemeral env already exists for this card.
+          def maybe_redeploy_ephemeral_belt_env(card_info:, card_number:, worktree:, base_branch: nil)
+            return false unless defined?(BeltConfig) && defined?(BeltEnvironment)
+            return false unless belt_app_worktree?(worktree)
+
+            env_name = BeltConfig.ephemeral_env_for_card(card_number)
+
+            unless ephemeral_env_present?(worktree: worktree, env_name: env_name)
+              LOG.debug "[EphemeralEnv] No ephemeral env '#{env_name}' for card ##{card_number} — skipping redeploy"
+              return false
+            end
+
+            LOG.info "[EphemeralEnv] Redeploying to ephemeral environment '#{env_name}' (PR sync)"
+
+            frontend_only = BeltEnvironment.frontend_only_changes?(worktree: worktree, base_branch: base_branch)
+            BeltEnvironment.deploy(worktree: worktree, env_name: env_name, frontend_only: frontend_only)
+            true
+          rescue StandardError => e
+            LOG.error "[EphemeralEnv] Error redeploying ephemeral env: #{e.message}"
+            false
+          end
+
+          # belt_app? lives on BeltEnvironment (via BeltHelpers), not on this Handler module.
+          def belt_app_worktree?(worktree)
+            BeltEnvironment.respond_to?(:belt_app?) && BeltEnvironment.belt_app?(worktree)
+          end
+
+          # Worktree infrastructure/<env>/ is the source of truth; tracking JSON is a fallback.
+          def ephemeral_env_present?(worktree:, env_name:)
+            if BeltEnvironment.respond_to?(:environment_configured?) &&
+               BeltEnvironment.environment_configured?(worktree: worktree, env_name: env_name)
+              return true
+            end
+
+            BeltConfig.ephemeral_env?(env_name)
+          end
         end
       end
     end

data/lib/brainiac/plugins/github/prompts.rb

@@ -14,6 +14,19 @@ module Brainiac
           - ``` ```language ``` for code blocks
           - `- item` for lists
 
+          ### @Mentions (STRICT — read carefully)
+          On GitHub, an `@name` only works if it maps to a real GitHub account.
+          The other agents (Galen, GLaDOS, Threepio, etc.) are NOT GitHub users —
+          `@threepio` just pings some unrelated stranger who happens to own that
+          username. That's noisy and rude.
+
+          Rules for GitHub comments:
+          - The ONLY people you may @mention are **@ardavis** (Andy) and **@fladamd** (Adam).
+          - NEVER @mention any other agent or person. Refer to other agents by
+            plain name instead — write `Threepio` or `GLaDOS`, not `@threepio`.
+          - If you're unsure whether a name is a real GitHub account, don't @mention it.
+            Drop the `@` and use the plain name.
+
           ### Scope
           You are responding to activity on a GitHub PR. Focus on the code changes and review feedback.
           When posting comments, post on the PR unless specifically asked to update the card.

data/lib/brainiac/plugins/github/version.rb

@@ -3,7 +3,7 @@
 module Brainiac
   module Plugins
     module Github
-      VERSION = "0.2.8"
+      VERSION = "0.3.0"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac-github
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.3.0
 platform: ruby
 authors:
 - Andy Davis