brainiac-github 0.2.8 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db8e2a2ac41b7a6fe786239a6a909aac61975a70273068c243b301eeb2407f93
-  data.tar.gz: 8427ed0cbf86df7198149a11cbf64309471dea9ce9293ad9a49db57f2d14a03d
+  metadata.gz: ac4e54b24a8bb52bf92a37bfe86acb8d6e16f76c646811dfdb586be8921e4ad3
+  data.tar.gz: 0c31ee9574f36510100bb08094b884aa3eb81917b89c149ae8fb814fbc6aa7de
 SHA512:
-  metadata.gz: e385a16a159af98f746a0c7ada60c04802de2549d8ace8a37ee8830ad8886d9bf5fa5ba89a34d38ba69b21c4b6aa82b0a1d24114a950e19bd10b5f7a45f9877d
-  data.tar.gz: 43cc967f3aafd227715a82e2a366e289452e0136e29415a52d244b0e796b9355f72983b1b32a056c86707a820dad269f9c2cfa9324d96945580c6574f6554685
+  metadata.gz: 26615c5fd5c52574cd4a9739fa8d2179eb834ed91d805f7f02e7881cee59f3cc2952fce2751b7441ef97fe013e9db1809a026bb987ef7e5108c47b9e738d0185
+  data.tar.gz: c43852a07188be9a2ae9f8158eb15b91a3c4083dfdc0abab4a0514b1a3b7a755520f4bbde5e8be59919c1a71fc0aa1883c8334c673a7783334f8cd14766eeb19

data/lib/brainiac/plugins/github/app_client.rb

@@ -61,15 +61,19 @@ module Brainiac
             post("/repos/#{repo}/issues/comments/#{comment_id}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
-          # POST a reaction on a PR review.
+          # POST a reaction on a PR (or issue) itself.
+          #
+          # GitHub's reactions API has NO endpoint for PR reviews — only for
+          # issue comments, PR review comments, issues, and PRs. Since a PR is
+          # an issue under the hood, PR reactions go through the issues path.
           #
           # @param repo [String] "owner/repo"
-          # @param review_id [Integer]
-          # @param reaction [String]
+          # @param pr_number [Integer]
+          # @param reaction [String] e.g. "eyes", "+1", "rocket"
           # @param agent_key [String, nil] agent key for per-agent app identity
           # @return [Hash] parsed response
-          def create_review_reaction(repo, review_id, reaction, agent_key: nil)
-            post("/repos/#{repo}/pulls/reviews/#{review_id}/reactions", { content: reaction }, agent_key: agent_key)
+          def create_pr_reaction(repo, pr_number, reaction, agent_key: nil)
+            post("/repos/#{repo}/issues/#{pr_number}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
           # GET request to GitHub API.

data/lib/brainiac/plugins/github/handler.rb

@@ -730,10 +730,12 @@ module Brainiac
             agent_name = resolve_work_item_agent(card_info, project_config)
 
             Thread.new do
+              # GitHub has no reactions endpoint for PR reviews, so react on the
+              # PR itself (PRs are issues under the hood) to signal "on it".
               if AppClient.configured?(agent_name)
-                AppClient.create_review_reaction(repo_name, review_id, "eyes", agent_key: agent_name)
+                AppClient.create_pr_reaction(repo_name, pr_number, "eyes", agent_key: agent_name)
               else
-                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/pulls/reviews/#{review_id}/reactions",
+                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/issues/#{pr_number}/reactions",
                         "-f", "content=eyes", "-H", "Accept: application/vnd.github+json", chdir: repo_path)
               end
 

data/lib/brainiac/plugins/github/prompts.rb

@@ -14,6 +14,19 @@ module Brainiac
           - ``` ```language ``` for code blocks
           - `- item` for lists
 
+          ### @Mentions (STRICT — read carefully)
+          On GitHub, an `@name` only works if it maps to a real GitHub account.
+          The other agents (Galen, GLaDOS, Threepio, etc.) are NOT GitHub users —
+          `@threepio` just pings some unrelated stranger who happens to own that
+          username. That's noisy and rude.
+
+          Rules for GitHub comments:
+          - The ONLY people you may @mention are **@ardavis** (Andy) and **@fladamd** (Adam).
+          - NEVER @mention any other agent or person. Refer to other agents by
+            plain name instead — write `Threepio` or `GLaDOS`, not `@threepio`.
+          - If you're unsure whether a name is a real GitHub account, don't @mention it.
+            Drop the `@` and use the plain name.
+
           ### Scope
           You are responding to activity on a GitHub PR. Focus on the code changes and review feedback.
           When posting comments, post on the PR unless specifically asked to update the card.

data/lib/brainiac/plugins/github/version.rb

@@ -3,7 +3,7 @@
 module Brainiac
   module Plugins
     module Github
-      VERSION = "0.2.8"
+      VERSION = "0.2.9"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac-github
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors:
 - Andy Davis