brainiac-github 0.2.7 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61c06c4b2537e0c675234514c9381b0797f96669401f108a5215f5f42a70b142
-  data.tar.gz: a7e2bfd0b3bd4ec8258131e31bd251a9d816a5cedd84742c8141449d161445ae
+  metadata.gz: ac4e54b24a8bb52bf92a37bfe86acb8d6e16f76c646811dfdb586be8921e4ad3
+  data.tar.gz: 0c31ee9574f36510100bb08094b884aa3eb81917b89c149ae8fb814fbc6aa7de
 SHA512:
-  metadata.gz: e01941e3c2e97832df1683b438cd1632cee50f9d9afaa91538c53bf55e4e438992f7567b17066e555fab22603ce3c56a8831af9332c8d57bb0117354951ff7c3
-  data.tar.gz: 9b51d89a994a1a9b4d072375f9a39011ddba50adbce000c11e598ce820900e2d052c577614f730c20a589036e821508d32ed58ecb31940b48095686efaa7ca25
+  metadata.gz: 26615c5fd5c52574cd4a9739fa8d2179eb834ed91d805f7f02e7881cee59f3cc2952fce2751b7441ef97fe013e9db1809a026bb987ef7e5108c47b9e738d0185
+  data.tar.gz: c43852a07188be9a2ae9f8158eb15b91a3c4083dfdc0abab4a0514b1a3b7a755520f4bbde5e8be59919c1a71fc0aa1883c8334c673a7783334f8cd14766eeb19

data/lib/brainiac/plugins/github/app_client.rb

@@ -61,15 +61,19 @@ module Brainiac
             post("/repos/#{repo}/issues/comments/#{comment_id}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
-          # POST a reaction on a PR review.
+          # POST a reaction on a PR (or issue) itself.
+          #
+          # GitHub's reactions API has NO endpoint for PR reviews — only for
+          # issue comments, PR review comments, issues, and PRs. Since a PR is
+          # an issue under the hood, PR reactions go through the issues path.
           #
           # @param repo [String] "owner/repo"
-          # @param review_id [Integer]
-          # @param reaction [String]
+          # @param pr_number [Integer]
+          # @param reaction [String] e.g. "eyes", "+1", "rocket"
           # @param agent_key [String, nil] agent key for per-agent app identity
           # @return [Hash] parsed response
-          def create_review_reaction(repo, review_id, reaction, agent_key: nil)
-            post("/repos/#{repo}/pulls/reviews/#{review_id}/reactions", { content: reaction }, agent_key: agent_key)
+          def create_pr_reaction(repo, pr_number, reaction, agent_key: nil)
+            post("/repos/#{repo}/issues/#{pr_number}/reactions", { content: reaction }, agent_key: agent_key)
           end
 
           # GET request to GitHub API.

data/lib/brainiac/plugins/github/handler.rb

@@ -285,18 +285,22 @@ module Brainiac
             # If the work item's assigned agent is NOT local to this machine,
             # skip dispatch entirely — the other machine owns this PR's agent.
             if result && !mentioned
-              _, card_info = result
-              work_item_agent = card_info["agent"]
-              if work_item_agent
-                if local_agent_names.include?(work_item_agent)
-                  if work_item_agent.downcase != agent_name.downcase
-                    LOG.info "[GitHub] Work item agent override: #{work_item_agent} (project default: #{agent_name})"
-                    agent_name = work_item_agent
-                  end
-                else
-                  LOG.info "[GitHub] PR ##{pr_number} assigned to remote agent #{work_item_agent} — skipping dispatch"
-                  return [200, { status: "ignored", reason: "work item owned by remote agent" }.to_json]
-                end
+              override_result = resolve_comment_agent_override(result, agent_name, pr_number)
+              return override_result if override_result.is_a?(Array)
+
+              agent_name = override_result if override_result
+            end
+
+            # Fallback for human-opened PRs with no assigned agent: if there's no work item,
+            # or the work item has no agent field, both machines would dispatch because each
+            # has its own local project default agent. Use branch_exists_locally? as a
+            # tiebreaker — only the machine that has the branch as a local worktree/branch
+            # should handle the comment. Explicit mentions bypass this check.
+            unless mentioned || work_item_has_agent?(result)
+              repo_path = project_config["repo_path"]
+              unless branch_exists_locally?(repo_path, branch)
+                LOG.info "[GitHub] PR ##{pr_number} branch '#{branch}' not found locally — skipping comment dispatch"
+                return [200, { status: "ignored", reason: "branch not on this machine" }.to_json]
               end
             end
 
@@ -404,6 +408,38 @@ module Brainiac
             local_agent_names.include?(agent_from_bot)
           end
 
+          # Check if a work item result has an assigned agent.
+          # Returns true if the result exists and has a non-empty agent field.
+          def work_item_has_agent?(result)
+            return false unless result
+
+            agent = result[1]["agent"]
+            agent && !agent.empty?
+          end
+
+          # Resolve agent override from a work item for PR comment dispatch.
+          # Returns:
+          #   - A Rack response array if dispatch should be skipped (remote agent owns it)
+          #   - An agent name string if the work item agent should override the default
+          #   - nil if no override needed
+          def resolve_comment_agent_override(result, current_agent, pr_number)
+            _, card_info = result
+            work_item_agent = card_info["agent"]
+            return nil unless work_item_agent
+
+            unless local_agent_names.include?(work_item_agent)
+              LOG.info "[GitHub] PR ##{pr_number} assigned to remote agent #{work_item_agent} — skipping dispatch"
+              return [200, { status: "ignored", reason: "work item owned by remote agent" }.to_json]
+            end
+
+            if work_item_agent.downcase != current_agent.downcase
+              LOG.info "[GitHub] Work item agent override: #{work_item_agent} (project default: #{current_agent})"
+              return work_item_agent
+            end
+
+            nil
+          end
+
           # Check if a branch exists as a local worktree or local branch.
           # Used to determine if this machine should handle a PR when there's no work item.
           #
@@ -694,10 +730,12 @@ module Brainiac
             agent_name = resolve_work_item_agent(card_info, project_config)
 
             Thread.new do
+              # GitHub has no reactions endpoint for PR reviews, so react on the
+              # PR itself (PRs are issues under the hood) to signal "on it".
               if AppClient.configured?(agent_name)
-                AppClient.create_review_reaction(repo_name, review_id, "eyes", agent_key: agent_name)
+                AppClient.create_pr_reaction(repo_name, pr_number, "eyes", agent_key: agent_name)
               else
-                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/pulls/reviews/#{review_id}/reactions",
+                run_cmd("gh", "api", "-X", "POST", "/repos/#{repo_name}/issues/#{pr_number}/reactions",
                         "-f", "content=eyes", "-H", "Accept: application/vnd.github+json", chdir: repo_path)
               end
 

data/lib/brainiac/plugins/github/prompts.rb

@@ -14,6 +14,19 @@ module Brainiac
           - ``` ```language ``` for code blocks
           - `- item` for lists
 
+          ### @Mentions (STRICT — read carefully)
+          On GitHub, an `@name` only works if it maps to a real GitHub account.
+          The other agents (Galen, GLaDOS, Threepio, etc.) are NOT GitHub users —
+          `@threepio` just pings some unrelated stranger who happens to own that
+          username. That's noisy and rude.
+
+          Rules for GitHub comments:
+          - The ONLY people you may @mention are **@ardavis** (Andy) and **@fladamd** (Adam).
+          - NEVER @mention any other agent or person. Refer to other agents by
+            plain name instead — write `Threepio` or `GLaDOS`, not `@threepio`.
+          - If you're unsure whether a name is a real GitHub account, don't @mention it.
+            Drop the `@` and use the plain name.
+
           ### Scope
           You are responding to activity on a GitHub PR. Focus on the code changes and review feedback.
           When posting comments, post on the PR unless specifically asked to update the card.

data/lib/brainiac/plugins/github/version.rb

@@ -3,7 +3,7 @@
 module Brainiac
   module Plugins
     module Github
-      VERSION = "0.2.7"
+      VERSION = "0.2.9"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac-github
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.9
 platform: ruby
 authors:
 - Andy Davis