brainiac-fizzy 0.0.36 → 0.0.37

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0331a4c7b65d16f904f1881a8f91b0112231bcd454a840a6427913ee69397c6a
-  data.tar.gz: f2289e72145e88b40ec226ccaceda3446e843c7b096e48179523bf28514f3efb
+  metadata.gz: d19bae8ece38c0924c091878a1bd2a5c6583089a0b6243ac69ff0cd9adaf1ab9
+  data.tar.gz: a149679a7117ca6312e9f854024bd9f51994e813df628f56a819b5e5d7610e5c
 SHA512:
-  metadata.gz: 32d155eaa59fea6ce594917105878a306b5904acb48da08f3f074a9ce3d0f84d48941e191f3ba0c9e5c7decde2427c7d084cefacd8641cf838932ab962441256
-  data.tar.gz: 3d5929611f64d6685e7d8cb76a2cfd4a8e101a0eae52480d38656d8f1b5c7dffe70423d7b481f3c38023eeb0a48721397442070d4e9713de4ffe6969ff5fc043
+  metadata.gz: ca5ec9b110034ed0829014410cb50395b2ac23c2ee9d4ae43067ba8565626a1a148e002e9195fa07e605e9d520055df51230916780bf013097bb6a0b5ae98e5e
+  data.tar.gz: c2cdb76c0ab5622eef2edb97425b86329f68226bfbbab984ad2408fd365538f11fcc16ba4860e66d957e27bafb27f88d2c94e4b1a0088b155ccb99110b745564

data/lib/brainiac/plugins/fizzy/handlers/assignment.rb

@@ -269,12 +269,16 @@ def maybe_create_ephemeral_belt_env(worktree_path:, card_number:, project_key:,
   end
 
   LOG.info "[EphemeralEnv] Card ##{card_number} has deploy tag; #{env_name} not in worktree — creating from '#{parent_env}'"
+  # Manual setups (force: true) have a caller waiting on the result — there is
+  # no agent to unblock, so deploy synchronously and let failures surface.
+  # Agent-triggered deploys stay backgrounded so the agent isn't blocked.
   create_and_deploy_ephemeral_env(
     worktree_path: worktree_path, env_name: env_name, parent_env: parent_env,
-    card_number: card_number, project_key: project_key
+    card_number: card_number, project_key: project_key, synchronous: force
   )
 rescue StandardError => e
   LOG.error "[EphemeralEnv] Error creating ephemeral env: #{e.message}"
+  raise if force
 end
 
 def ensure_ephemeral_env_for_comment(ctx, card_number, worktree)
@@ -383,12 +387,14 @@ def track_ephemeral_env_if_needed(env_name, card_number, project_key, parent_env
                                  "worktree" => worktree_path)
 end
 
-def create_and_deploy_ephemeral_env(worktree_path:, env_name:, parent_env:, card_number:, project_key:)
+def create_and_deploy_ephemeral_env(worktree_path:, env_name:, parent_env:, card_number:, project_key:, synchronous: false)
   success = BeltEnvironment.create_environment(
     worktree: worktree_path, env_name: env_name, parent_env: parent_env
   )
   unless success
     LOG.error "[EphemeralEnv] Failed to create environment '#{env_name}'"
+    raise "Failed to create environment '#{env_name}'" if synchronous
+
     return
   end
 
@@ -397,19 +403,31 @@ def create_and_deploy_ephemeral_env(worktree_path:, env_name:, parent_env:, card
                                  "project" => project_key,
                                  "parent_env" => parent_env,
                                  "worktree" => worktree_path)
-  LOG.info "[EphemeralEnv] Configured #{env_name} in worktree, deploying in background"
 
-  Thread.new do
-    # First provisioning of a fresh env must be a full deploy — it stands up
-    # S3/CloudFront/backend. The frontend-only shortcut is only safe once the
-    # env is actually live (probe the derived public URL). Otherwise `belt
-    # deploy frontend` runs against a bucket that doesn't exist yet and fails
-    # with "Could not determine S3 bucket."
-    frontend_only =
-      ephemeral_env_live?(worktree_path, env_name) &&
-      BeltEnvironment.frontend_only_changes?(worktree: worktree_path)
-    BeltEnvironment.deploy(worktree: worktree_path, env_name: env_name, frontend_only: frontend_only)
-  rescue StandardError => e
-    LOG.error "[EphemeralEnv] Error deploying '#{env_name}': #{e.message}"
+  if synchronous
+    LOG.info "[EphemeralEnv] Configured #{env_name} in worktree, deploying synchronously"
+    deploy_ephemeral_env(worktree_path, env_name)
+  else
+    LOG.info "[EphemeralEnv] Configured #{env_name} in worktree, deploying in background"
+    Thread.new do
+      deploy_ephemeral_env(worktree_path, env_name)
+    rescue StandardError => e
+      LOG.error "[EphemeralEnv] Error deploying '#{env_name}': #{e.message}"
+    end
   end
 end
+
+# Run the actual `belt deploy` for a freshly configured ephemeral env.
+# Raises on failure so synchronous callers can surface the error; the
+# background path wraps this in its own rescue.
+def deploy_ephemeral_env(worktree_path, env_name)
+  # First provisioning of a fresh env must be a full deploy — it stands up
+  # S3/CloudFront/backend. The frontend-only shortcut is only safe once the
+  # env is actually live (probe the derived public URL). Otherwise `belt
+  # deploy frontend` runs against a bucket that doesn't exist yet and fails
+  # with "Could not determine S3 bucket."
+  frontend_only =
+    ephemeral_env_live?(worktree_path, env_name) &&
+    BeltEnvironment.frontend_only_changes?(worktree: worktree_path)
+  BeltEnvironment.deploy(worktree: worktree_path, env_name: env_name, frontend_only: frontend_only)
+end

data/lib/brainiac/plugins/fizzy/version.rb

@@ -3,7 +3,7 @@
 module Brainiac
   module Plugins
     module Fizzy
-      VERSION = "0.0.36"
+      VERSION = "0.0.37"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac-fizzy
 version: !ruby/object:Gem::Version
-  version: 0.0.36
+  version: 0.0.37
 platform: ruby
 authors:
 - Andy Davis