brainiac-discord 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 173d9471b14272a611b844fb7a12e0d728f812ab2b06cda08b05faf26329243c
-  data.tar.gz: c0658fe873c620e9b1be027d1866035b4d6bd846e13088626eefa174e77c186d
+  metadata.gz: '0867d7c12ec729c881db2a3a8dd9f02da284f677b3f7226a8771958b97da07b5'
+  data.tar.gz: 073f0bbceca7c578ea06cd888c2e333b113efeede5ebde4b02b257247df15c9d
 SHA512:
-  metadata.gz: d3997e24550bd3be11cb48942dafa1b624cdc0288410ce5388e4eca6a5145f61291d7dce56295c34544c9dad46407572c3b587e96b3c35a2c168ea4a34afa09e
-  data.tar.gz: 55a5b86aae6ce19a9d37b2e2e2d438d3c7ddc80c166367996ffaa9f1355a98613e2f10cb0582c4e171e8e135b27b507cee5317731173a8e01bec63ff795de870
+  metadata.gz: 5c103f0b92d230a5789424e41d9ea9881636a7ede849278db072c93b42c18ac42266ea264abb7128086e92e0639a042ff894460d9ee1405aabb5348d71918bda
+  data.tar.gz: 2a236d41ec8676a4e3459bcd26bf5d47019a3f4cc5e67bfa4b1d2b8027c00e0803680c5ca37166285449d4a0f2ccffd7a0b81fde785a4ea977f476994aa158d3

data/lib/brainiac/plugins/discord/gateway.rb

@@ -2,6 +2,7 @@
 
 require "websocket-client-simple"
 require "websocket"
+require "time"
 
 module Brainiac
   module Plugins
@@ -23,6 +24,12 @@ module Brainiac
         BACKOFF_HANDSHAKE_BASE = 30
         BACKOFF_CAP = 300
 
+        # How long after a message is posted an edit still counts as a real,
+        # conversational edit worth re-dispatching on. Edits that land outside
+        # this window are treated as server-side embed refreshes (Discord
+        # restamping edited_timestamp when it unfurls a link), not human intent.
+        EDIT_FRESHNESS_WINDOW = 300 # seconds (5 minutes)
+
         # Per-bot state: { agent_key => { token:, user_id:, status:, thread: } }
         @bots = {}
         @bots_mutex = Mutex.new
@@ -376,7 +383,16 @@ module Brainiac
                 LOG.error "[Discord:#{agent_display}] Error handling message: #{e.message}\n#{e.backtrace.first(3).join("\n")}" if defined?(LOG)
               end
             when "MESSAGE_UPDATE"
-              if data["edited_timestamp"]
+              # Discord emits MESSAGE_UPDATE for genuine human edits AND for
+              # server-side embed (un)furls on existing messages — e.g. lazily
+              # generating a link preview days after the message was posted. Both
+              # stamp edited_timestamp, so re-dispatching on every update means a
+              # bare URL in an old agent-mentioning message can silently wake the
+              # agent long after the fact. Only treat an update as actionable when
+              # the edit happened close to the message's own creation time, which
+              # is what a real conversational edit (typo fix, afterthought) looks
+              # like. See message.rb for the shared dispatch path.
+              if data["edited_timestamp"] && !stale_edit?(data["timestamp"], data["edited_timestamp"])
                 Thread.new do
                   Message.handle(data, agent_key, bot_token, bot_user_id)
                 rescue StandardError => e
@@ -384,6 +400,9 @@ module Brainiac
                     LOG.error "[Discord:#{agent_display}] Error handling message update: #{e.message}\n#{e.backtrace.first(3).join("\n")}"
                   end
                 end
+              elsif data["edited_timestamp"] && defined?(LOG)
+                LOG.info "[Discord:#{agent_display}] Ignoring stale MESSAGE_UPDATE " \
+                         "(likely embed refresh) on message #{data["id"]}"
               end
             when "MESSAGE_REACTION_ADD"
               Thread.new do
@@ -416,6 +435,25 @@ module Brainiac
             bot_user_id
           end
 
+          # True when a MESSAGE_UPDATE's edit happened long enough after the
+          # message was created that it's almost certainly a server-side embed
+          # refresh rather than a human edit. Guards against spurious agent
+          # dispatches from Discord lazily unfurling link previews on old
+          # messages that mention the bot.
+          #
+          # Fails open (returns false → treat as a real edit) when either
+          # timestamp is missing or unparseable, so a parsing hiccup never
+          # silently swallows a genuine edit.
+          def stale_edit?(created_at, edited_at)
+            return false if created_at.nil? || edited_at.nil?
+
+            created = Time.iso8601(created_at.to_s)
+            edited  = Time.iso8601(edited_at.to_s)
+            (edited - created) > EDIT_FRESHNESS_WINDOW
+          rescue ArgumentError
+            false
+          end
+
           def mark_bot_ready(agent_key, agent_display, bot_user_id, data)
             @bots_mutex.synchronize do
               @bots[agent_key][:user_id] = bot_user_id

data/lib/brainiac/plugins/discord/version.rb

@@ -3,7 +3,7 @@
 module Brainiac
   module Plugins
     module Discord
-      VERSION = "0.0.20"
+      VERSION = "0.0.21"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainiac-discord
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Andy Davis