brace_comb 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bfd2a6dfe32328fd413215449ec8880f0a50cba
-  data.tar.gz: d3d8f3995d6695d34cfec43ac0e1fbfd2109d65c
+  metadata.gz: c3f4a2060ab1b9507b4ec5ea18df91473e465ba3
+  data.tar.gz: 86ab140e66bc4d9432ca8f02b9a7690715b620b1
 SHA512:
-  metadata.gz: 8f4d959428312946a06ec5fc78da49a1b30b9ec9d3e08de0bf81c481e310caf64cec80db870dab19a4c1f1732cc1a761576d0e163107603f91991890764a0074
-  data.tar.gz: ce0b8b59c727609cafe7244d29e6e7020af6cbdda06a258767651f9dc5c1ba571381c23ddacc85ff5be2dc27c2de71682484e3877148b46edbf06fd73d0cf353
+  metadata.gz: 96a050f07a60bfd8c59466a56c0ee6147c8c2e72c190399f4d9b9305f0fdfbfc81c4c0fbcf85e3880c618b55437887295fe60d930c240845196f15ba91ad46ca
+  data.tar.gz: e65946dbf7044edaf1722e2ccb5fe93834b566500cb1462e03b587c1bc14652fb27acefa2607329df1c8727a0142cef2de831c108e74a491448bd0d8f456dc8b

data/README.md

@@ -61,7 +61,7 @@ Entity names for dependencies and dependents are configurable and can be set in
      include BraceComb::Helper
      enum type: { shopping: 0 }
    ```
-2. Declare a dependency by typing in the following in any ActiveRecord class:
+2. Declare a dependency by typing in the following in any ActiveRecord class. Only `resolver` is compulsory whereas `before_resolution` and `after_resolution` are optional.
 
    a. Using a method name in the resolver
    ```

data/lib/brace_comb/dependency_model.rb

@@ -27,6 +27,7 @@ module BraceComb
       end
 
       def execute_after_callbacks(after_callbacks)
+        return unless after_callbacks
         after_callbacks.each do |after_callback|
           execute_callback(after_callback)
         end
@@ -43,6 +44,7 @@ module BraceComb
       end
 
       def execute_before_callbacks(before_callbacks)
+        return unless before_callbacks
         before_callbacks.each do |before_callback|
           result = execute_callback(before_callback)
           raise BraceComb::Exceptions::CallbackFailure.new unless result

data/lib/brace_comb/version.rb

@@ -1,3 +1,3 @@
 module BraceComb
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/lib/generators/brace_comb/initializer_generator.rb

@@ -7,8 +7,8 @@ module BraceComb
       create_file(
         'config/initializers/brace_comb.rb',
         "BraceComb.setup do |config|\n"\
-          " config.dependent_table_name = '#{dependent_table_name}'\n"\
-          " config.dependency_table_name = '#{dependency_table_name}'\n"\
+          "  config.dependent_table_name = '#{dependent_table_name}'\n"\
+          "  config.dependency_table_name = '#{dependency_table_name}'\n"\
           "end"
       )
     end

data/spec/brace_comb/dependency_model_spec.rb

@@ -128,6 +128,21 @@ describe BraceComb::Model do
         expect(result).to be true
       end
     end
+
+    context 'resolve without callbacks' do
+      before do
+        dependency_class.constantize.class_eval do
+          declare_dependency type: :shopping,
+                             resolver: ->(data) { data.resolved! }
+        end
+      end
+
+      it 'resolves dependency if all before resolve hooks are satisfied' do
+        result = dependency.resolve
+        expect(dependency).to be_resolved
+        expect(result).to be true
+      end
+    end
   end
 
   context 'resolve' do

data/spec/generators/brace_comb/initializer_generator_spec.rb

@@ -15,8 +15,8 @@ describe BraceComb::InitializerGenerator, type: :generator do
 
     it 'creates brace comb initializer' do
       assert_file 'config/initializers/brace_comb.rb', "BraceComb.setup do |config|\n"\
-        " config.dependent_table_name = 'jobs'\n"\
-        " config.dependency_table_name = 'job_dependencies'\n"\
+        "  config.dependent_table_name = 'jobs'\n"\
+        "  config.dependency_table_name = 'job_dependencies'\n"\
         "end"
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brace_comb
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Ankita Gupta
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-21 00:00:00.000000000 Z
+date: 2017-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord