br_danfe 0.17.0 → 0.17.1

data/spec/br_danfe/danfe_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe BrDanfe::Danfe do
   let(:xml) do
-    <<-eos
+    <<~XML
       <nfeProc>
         <NFe>
           <infNFe>
@@ -17,7 +17,7 @@ describe BrDanfe::Danfe do
           </infNFe>
         </NFe>
       </nfeProc>
-    eos
+    XML
   end
 
   subject { described_class.new(xml) }

data/spec/br_danfe/helper_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe BrDanfe::Helper do
   describe '.no_fiscal_value?' do
     let(:xml_homologation) do
-      xml = <<-eos
+      xml = <<~XML
         <nfeProc>
           <NFe>
             <infNFe>
@@ -18,25 +18,25 @@ describe BrDanfe::Helper do
             </protNFe>
           </NFe>
         </nfeProc>
-      eos
+      XML
 
       Nokogiri::XML(xml)
     end
 
     let(:xml_unauthorized) do
-      xml = <<-eos
+      xml = <<~XML
         <nfeProc>
           <protNFe>
             <infProt></infProt>
           </protNFe>
         </nfeProc>
-      eos
+      XML
 
       Nokogiri::XML(xml)
     end
 
     let(:xml_authorized) do
-      xml = <<-eos
+      xml = <<~XML
         <nfeProc>
           <NFe>
             <infNFe>
@@ -51,7 +51,7 @@ describe BrDanfe::Helper do
             </infProt>
           </protNFe>
         </nfeProc>
-      eos
+      XML
 
       Nokogiri::XML(xml)
     end
@@ -78,13 +78,13 @@ describe BrDanfe::Helper do
   describe '.unauthorized?' do
     context 'when XML is unauthorized' do
       let(:xml_unauthorized) do
-        xml = <<-eos
+        xml = <<~XML
           <nfeProc>
             <protNFe>
               <infProt></infProt>
             </protNFe>
           </nfeProc>
-        eos
+        XML
 
         Nokogiri::XML(xml)
       end
@@ -96,7 +96,7 @@ describe BrDanfe::Helper do
 
     context 'when XML is authorized' do
       let(:xml_authorized) do
-        xml = <<-eos
+        xml = <<~XML
           <nfeProc>
             <protNFe>
               <infProt>
@@ -104,7 +104,7 @@ describe BrDanfe::Helper do
               </infProt>
             </protNFe>
           </nfeProc>
-        eos
+        XML
 
         Nokogiri::XML(xml)
       end
@@ -118,7 +118,7 @@ describe BrDanfe::Helper do
   describe '.homologation?' do
     context 'when tpAmb is equal to "2"' do
       let(:xml_homologation) do
-        xml = <<-eos
+        xml = <<~XML
           <nfeProc>
             <NFe>
               <infNFe>
@@ -128,7 +128,7 @@ describe BrDanfe::Helper do
               </infNFe>
             </NFe>
           </nfeProc>
-        eos
+        XML
 
         Nokogiri::XML(xml)
       end
@@ -140,7 +140,7 @@ describe BrDanfe::Helper do
 
     context 'when tpAmb is different to "2"' do
       let(:xml_production) do
-        xml = <<-eos
+        xml = <<~XML
           <nfeProc>
             <NFe>
               <infNFe>
@@ -150,7 +150,7 @@ describe BrDanfe::Helper do
               </infNFe>
             </NFe>
           </nfeProc>
-        eos
+        XML
 
         Nokogiri::XML(xml)
       end
@@ -214,7 +214,7 @@ describe BrDanfe::Helper do
     end
 
     describe 'when has timezone' do
-      it'returns the formated string with the timezone' do
+      it 'returns the formated string with the timezone' do
         expect(described_class.format_datetime('2013-10-18T13:54:04-03:00', with_time_zone: true)).to eql '18/10/2013 13:54:04-03:00'
       end
     end

data/spec/br_danfe/mdfe_lib/document_spec.rb

@@ -7,13 +7,13 @@ describe BrDanfe::MdfeLib::Document do
   describe '#method_missing' do
     context 'when prawn has the method' do
       it 'does not throws an error' do
-        expect { subject.text }.not_to raise_error NameError
+        expect(subject).to respond_to :text
       end
     end
 
     context 'when prawn does not have the method' do
       it 'throws an error' do
-        expect { subject.any_method }.to raise_error NameError
+        expect { subject.non_existent_method }.to raise_error NameError
       end
     end
   end

data/spec/br_danfe/mdfe_lib/fisco_control_spec.rb

@@ -27,13 +27,11 @@ describe BrDanfe::MdfeLib::FiscoControl do
   end
 
   describe '#generate' do
-    after { File.delete(output_pdf) if File.exist?(output_pdf) }
+    before { File.delete(output_pdf) if File.exist?(output_pdf) }
 
     it 'generates the title' do
-      title = 'CONTROLE DO FISCO'
-
       subject.generate
-      expect(pdf_text).to include title
+      expect(pdf_text).to include 'CONTROLE DO FISCO'
     end
 
     it 'generates the bar code' do
@@ -46,10 +44,26 @@ describe BrDanfe::MdfeLib::FiscoControl do
     end
 
     it 'generates the nfe key' do
-      nfe_key = "Chave de Acesso\n32210717781119000141580010000001211000000003"
-
       subject.generate
-      expect(pdf_text).to include nfe_key
+      expect(pdf_text).to include "Chave de Acesso\n32210717781119000141580010000001211000000003"
+    end
+
+    context 'when the XML does not have protMDFe tag' do
+      let(:xml_as_string) do
+        <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <mdfeProc xmlns="http://www.portalfiscal.inf.br/mdfe" versao="3.00"></mdfeProc>
+        XML
+      end
+
+      it 'does not generate the bar code and the nfe key' do
+        expect(File.exist?(output_pdf)).to be false
+
+        subject.generate
+        pdf.render_file output_pdf
+
+        expect("#{base_dir}fisco_control#without-barcode.pdf").to have_same_content_of file: output_pdf
+      end
     end
   end
 end

data/spec/br_danfe/mdfe_lib/header_spec.rb

@@ -1,6 +1,10 @@
 require 'spec_helper'
 
 describe BrDanfe::MdfeLib::Header do
+  let(:qr_code_mdfe) do
+    url = 'https://dfe-portal.svrs.rs.gov.br/mdfe/QRCode?chMDFe=32210717781119000141580010000001211000000003&tpAmb=1'
+    "<qrCodMDFe>#{url}</qrCodMDFe>"
+  end
   let(:xml_as_string) do
     <<~XML
       <?xml version="1.0" encoding="UTF-8"?>
@@ -32,19 +36,14 @@ describe BrDanfe::MdfeLib::Header do
             </emit>
           </infMDFe>
           <infMDFeSupl>
-            <qrCodMDFe>https://dfe-portal.svrs.rs.gov.br/mdfe/QRCode?chMDFe=32210717781119000141580010000001211000000003&amp;tpAmb=1</qrCodMDFe>
+            #{qr_code_mdfe}
           </infMDFeSupl>
         </MDFe>
       </mdfeProc>
     XML
   end
-
   let(:pdf) { BrDanfe::MdfeLib::Document.new }
   let(:xml) { BrDanfe::XML.new(xml_as_string) }
-
-  let(:base_dir) { './spec/fixtures/mdfe/lib/' }
-  let(:output_pdf) { "#{base_dir}output.pdf" }
-
   let(:logo_dimensions) { { width: 100, height: 100 } }
   let(:logo) { 'spec/fixtures/logo.png' }
 
@@ -54,9 +53,12 @@ describe BrDanfe::MdfeLib::Header do
     PDF::Inspector::Text.analyze(pdf.render).strings.join("\n")
   end
 
-  after { File.delete(output_pdf) if File.exist?(output_pdf) }
-
   describe '#generate' do
+    let(:base_dir) { './spec/fixtures/mdfe/lib/' }
+    let(:output_pdf) { "#{base_dir}output.pdf" }
+
+    before { File.delete(output_pdf) if File.exist?(output_pdf) }
+
     it 'generates the emitter informations' do
       emitter_name = 'VENTURIM AGROCRIATIVA LTDA EPP'
       emitter_address = "RODOVIA ES 473 KM 13, nº 0\nVENDA NOVA DO IMIGRANTE - ES   CEP 29.375-000"
@@ -72,15 +74,12 @@ describe BrDanfe::MdfeLib::Header do
       expect(pdf_text).to include emitter_ie
     end
 
-    it'generates the DAMDFE title' do
-      title = "DAMDFE\n - Documento Auxiliar de Manifesto Eletrônico de Documentos Fiscais"
-
+    it 'generates the DAMDFE title' do
       subject.generate
-
-      expect(pdf_text).to include title
+      expect(pdf_text).to include "DAMDFE\n - Documento Auxiliar de Manifesto Eletrônico de Documentos Fiscais"
     end
 
-    it 'generates the qr code' do
+    it 'generates the QR-code' do
       expect(File.exist?(output_pdf)).to be false
 
       subject.generate
@@ -89,12 +88,22 @@ describe BrDanfe::MdfeLib::Header do
       expect("#{base_dir}header#render-qr-code.pdf").to have_same_content_of file: output_pdf
     end
 
-    it 'generates the company CNPJ' do
-      cnpj = "CNPJ: \n17781119000141"
+    context 'if the QR-code URL is not present' do
+      let(:qr_code_mdfe) { '<qrCodMDFe></qrCodMDFe>' }
 
-      subject.generate
+      it 'does not generates the QR-code' do
+        expect(File.exist?(output_pdf)).to be false
+
+        subject.generate
+        pdf.render_file output_pdf
+
+        expect("#{base_dir}header#render-without-qr-code.pdf").to have_same_content_of file: output_pdf
+      end
+    end
 
-      expect(pdf_text).to include cnpj
+    it 'generates the company CNPJ' do
+      subject.generate
+      expect(pdf_text).to include "CNPJ: \n17781119000141"
     end
 
     describe 'logo' do

data/spec/br_danfe/mdfe_lib/notes_spec.rb

@@ -22,9 +22,6 @@ describe BrDanfe::MdfeLib::Notes do
     XML
   end
 
-  let(:base_dir) { './spec/fixtures/mdfe/lib/' }
-  let(:output_pdf) { "#{base_dir}output.pdf" }
-
   let(:pdf) { BrDanfe::MdfeLib::Document.new }
   let(:xml) { BrDanfe::XML.new(xml_as_string) }
 
@@ -37,6 +34,11 @@ describe BrDanfe::MdfeLib::Notes do
   before { pdf.move_cursor_to 345 }
 
   describe '#generate' do
+    let(:base_dir) { './spec/fixtures/mdfe/lib/' }
+    let(:output_pdf) { "#{base_dir}output.pdf" }
+
+    before { File.delete(output_pdf) if File.exist?(output_pdf) }
+
     it 'generates the title' do
       title = 'Observações'
 
@@ -76,8 +78,6 @@ describe BrDanfe::MdfeLib::Notes do
       expect(pdf_text).not_to include taxpayer_information
     end
 
-    after { File.delete(output_pdf) if File.exist?(output_pdf) }
-
     it 'creates a new page if aditional information do not fit on first page' do
       expect(File.exist?(output_pdf)).to be false
 

data/spec/br_danfe/mdfe_lib/totalizer_spec.rb

@@ -53,7 +53,7 @@ describe BrDanfe::MdfeLib::Totalizer do
       expect(pdf_text).to include total_weight
     end
 
-    it'generates the totalizer title' do
+    it 'generates the totalizer title' do
       title = 'Modelo Rodoviário de Carga'
 
       subject.generate

data/spec/br_danfe/mdfe_spec.rb

@@ -4,12 +4,11 @@ describe BrDanfe::Mdfe do
   let(:base_dir) { './spec/fixtures/mdfe/lib/' }
   let(:output_pdf) { "#{base_dir}output.pdf" }
 
-  let(:xml_as_string) { File.read('./spec/fixtures/mdfe/lib/xml-mdfe.xml') }
-
-  let(:xml) { BrDanfe::XML.new(xml_as_string) }
+  let(:xml) { File.read('./spec/fixtures/mdfe/lib/xml-mdfe.xml') }
 
   subject { described_class.new(xml) }
-  after { File.delete(output_pdf) if File.exist?(output_pdf) }
+
+  before { File.delete(output_pdf) if File.exist?(output_pdf) }
 
   before do
     subject.logo_options.logo_dimensions = { width: 100, height: 100 }
@@ -34,7 +33,7 @@ describe BrDanfe::Mdfe do
   end
 
   context 'when MDF-e has multiple pages' do
-    let(:xml_as_string) { File.read('./spec/fixtures/mdfe/lib/xml-mdfe-multiples-pages.xml') }
+    let(:xml) { File.read('./spec/fixtures/mdfe/lib/xml-mdfe-multiples-pages.xml') }
 
     it 'renders the header and the identification on each page' do
       expect(File.exist?(output_pdf)).to be false

data/spec/br_danfe/qr_code_spec.rb

@@ -11,23 +11,14 @@ describe BrDanfe::QrCode do
     )
   end
 
-  let(:xml) do
-    xml = <<-eos
-      <infNFeSupl>
-        <qrCode><![CDATA[http://sistemas.sefaz.am.gov.br/nfceweb/consultarNFCe.jsp?p=13130901144012000152651231234567891123456786|2|2|1|A604FD51E40ED8465B787B3E9CF8C1D90E61DB13]]></qrCode>
-        <urlChave>www.sefaz.am.gov.br/nfce/consulta</urlChave>
-      </infNFeSupl>
-    eos
-
-    BrDanfe::XML.new(xml)
+  let(:qr_code_url) do
+    'http://sistemas.sefaz.am.gov.br/nfceweb/consultarNFCe.jsp?p=13130901144012000152651231234567891123456786|2|2|1|A604FD51E40ED8465B787B3E9CF8C1D90E61DB13'
   end
 
-  subject { described_class.new(pdf: pdf, xml: xml, qr_code_tag: xml['qrCode'], box_size: 3.cm) }
+  subject { described_class.new(pdf: pdf, qr_code_tag: qr_code_url, box_size: 3.cm) }
 
   describe '#render' do
-    before do
-      File.delete(output_pdf) if File.exist?(output_pdf)
-    end
+    before { File.delete(output_pdf) if File.exist?(output_pdf) }
 
     it 'renders qr-code to the pdf' do
       expect(File.exist?(output_pdf)).to be_falsey

data/spec/br_danfe/xml_spec.rb

@@ -6,12 +6,12 @@ describe BrDanfe::XML do
   describe '#version_is_310_or_newer?' do
     describe "when xml's version is equal 3.10" do
       let(:xml_as_string) do
-        <<-eos
+        <<~XML
           <NFe xmlns="http://www.portalfiscal.inf.br/nfe">
             <infNFe versao="3.10" Id="NFe35150162013294000143550010000000011000000017">
             </infNFe>
           </NFe>
-        eos
+        XML
       end
 
       it 'returns true' do
@@ -21,12 +21,12 @@ describe BrDanfe::XML do
 
     describe "when xml's version is greather 3.10" do
       let(:xml_as_string) do
-        <<-eos
+        <<~XML
           <NFe xmlns="http://www.portalfiscal.inf.br/nfe">
             <infNFe versao="4.00" Id="NFe35150162013294000143550010000000011000000017">
             </infNFe>
           </NFe>
-        eos
+        XML
       end
 
       it 'returns true' do
@@ -36,12 +36,12 @@ describe BrDanfe::XML do
 
     describe "when xml's version is minor that 3.10" do
       let(:xml_as_string) do
-        <<-eos
+        <<~XML
           <NFe xmlns="http://www.portalfiscal.inf.br/nfe">
             <infNFe versao="2.00" Id="NFe35131260891033000109550010000000011000000016">
             </infNFe>
           </NFe>
-        eos
+        XML
       end
 
       it 'returns false' do

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 require 'simplecov'
-SimpleCov.start
+SimpleCov.start unless ENV["NO_COVERAGE"]
 
 require "bundler/setup"
 require "br_danfe"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: br_danfe
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.17.1
 platform: ruby
 authors:
 - ASSEINFO
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-13 00:00:00.000000000 Z
+date: 2021-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: barby
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.16.2
+        version: 2.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.16.2
+        version: 2.18.0
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -196,30 +196,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.67.0
+        version: 0.93.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.67.0
+        version: 0.93.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.10.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.10.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.44.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.44.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -250,12 +264,15 @@ dependencies:
         version: 0.10.2
 description: 
 email: asseinfo@asseinfo.com.br
-executables: []
+executables:
+- _guard-core
+- guard
 extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".codeclimate.yml"
+- ".github/dependabot.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -266,6 +283,8 @@ files:
 - Guardfile
 - README.md
 - Rakefile
+- bin/_guard-core
+- bin/guard
 - br_danfe.gemspec
 - config/locales/pt-BR.yml
 - docker-compose.yml
@@ -410,8 +429,10 @@ files:
 - spec/fixtures/mdfe/lib/document#text.size.pdf
 - spec/fixtures/mdfe/lib/document#text.style.pdf
 - spec/fixtures/mdfe/lib/fisco_control#barcode.pdf
+- spec/fixtures/mdfe/lib/fisco_control#without-barcode.pdf
 - spec/fixtures/mdfe/lib/header#render-qr-code.pdf
 - spec/fixtures/mdfe/lib/header#render-with_logo.pdf
+- spec/fixtures/mdfe/lib/header#render-without-qr-code.pdf
 - spec/fixtures/mdfe/lib/header#render-without_logo.pdf
 - spec/fixtures/mdfe/lib/mdfe-with-multiple-pages.pdf
 - spec/fixtures/mdfe/lib/mdfe.fixture.pdf
@@ -547,7 +568,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.1
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="