bps-stan 0.1.3 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd81b99b13cfa8b5be0f5d16ac87bfe1b1fadf2fbe15f7e64a35aa03b7738434
-  data.tar.gz: 981a5ffacde21e61b6e40e04d933cbc25ed684dfc8d2ed70829a088affa61890
+  metadata.gz: a3e0a906dbfb5399c6478e431f089d474c19477db1a317fcda9315212ca4eddd
+  data.tar.gz: dfc0b3d82292d7c5a222306cccf6354c63d5b681637efd8206362e52d38ac07c
 SHA512:
-  metadata.gz: 5df714f945e601d841a5bce43760b354494f83b97eb4544c8c515fecc87026de44ebb343ab657fed2910880f6beb9cf7d212e703a05ee4036b41a5d6e14f795d
-  data.tar.gz: 03cafb2a8283b7875f353f9c8ccef57752e1f5d4b18e165b85ff8e1cc4a16523c96f06c11aa1cd6ad409d1a9951b7ae700aa4bfd18661bb4aed15b921590b75b
+  metadata.gz: 8a979907c82f715c626c9dcaaeff154944e56f01c29527e5de6cc3cac10ec0f263e1b2f01553f2bed6b444aa87629ebb5f6234903391e7a9bc94f756d189c98e
+  data.tar.gz: '096d145a4db40e80dd33f65bb88420678eea66cde04e0f604f9bbdff63f5fc2c1c330586faa3de7b882ee58551fa1b5c883b175140cef6fc2195317d3cd478aa'

data/bps-stan.gemspec

@@ -18,5 +18,6 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.6.0'
 
   s.add_dependency 'bps', s.version
-  s.add_dependency 'nats-streaming', '= 0.2.2'
+  s.add_dependency 'nats-streaming', '~> 0.2.2'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/bps/publisher/stan.rb

@@ -21,44 +21,14 @@ module BPS
         end
       end
 
-      CLIENT_OPTS = {
-        nats: {
-          servers: [:string],
-          dont_randomize_servers: :bool,
-          reconnect_time_wait: :float,
-          max_reconnect_attempts: :int,
-          connect_timeout: :float,
-          # TODO: review, list all of them: https://github.com/nats-io/nats.rb (there's tls config etc)
-        },
-      }.freeze
-
-      def self.parse_url(url)
-        port = url.port&.to_s || '4222'
-        servers = CGI.unescape(url.host).split(',').map do |host|
-          addr = "nats://#{host}"
-          addr << ':' << port unless addr.match(/:\d+$/)
-          addr
-        end
-        opts = CGI.parse(url.query).transform_values {|v| v.size == 1 ? v[0] : v }
-        cluster_id = opts.delete('cluster_id')
-        client_id = opts.delete('client_id')
-        [cluster_id, client_id, { nats: { servers: servers } }]
-      end
-
-      # @return [BPS::Coercer] the options coercer.
-      def self.coercer
-        @coercer ||= BPS::Coercer.new(CLIENT_OPTS).freeze
-      end
-
       # @param [String] cluster ID.
       # @param [String] client ID.
       # @param [Hash] options.
-      def initialize(cluster_id, client_id, nats: {}, **opts)
+      def initialize(cluster_id, client_id, **opts)
         super()
 
         @topics = {}
-        @client = ::STAN::Client.new
-        @client.connect(cluster_id, client_id, nats: nats, **opts.slice(*CLIENT_OPTS.keys))
+        @client = ::BPS::STAN.connect(cluster_id, client_id, **opts)
       end
 
       def topic(name)
@@ -66,7 +36,9 @@ module BPS
       end
 
       def close
-        # NATS/STAN do not survive multi-closes, so close only once:
+        super
+
+        # NATS/STAN does not survive multi-closes, so close only once:
         @client&.close
         @client = nil
       end

data/lib/bps/stan.rb

@@ -1,12 +1,72 @@
 require 'bps'
 require 'bps/publisher/stan'
+require 'bps/subscriber/stan'
 
 module BPS
   module Publisher
     register('stan') do |url, **opts|
-      cluster_id, client_id, url_opts = STAN.parse_url(url)
+      cluster_id, client_id, url_opts = ::BPS::STAN.parse_url(url)
       url_opts.update(opts)
-      STAN.new(cluster_id, client_id, **STAN.coercer.coerce(url_opts))
+      STAN.new(cluster_id, client_id, **::BPS::STAN.coercer.coerce(url_opts))
+    end
+  end
+
+  module Subscriber
+    register('stan') do |url, **opts|
+      cluster_id, client_id, url_opts = ::BPS::STAN.parse_url(url)
+      url_opts.update(opts)
+      STAN.new(cluster_id, client_id, **::BPS::STAN.coercer.coerce(url_opts))
+    end
+  end
+
+  module STAN
+    CLIENT_OPTS = {
+      nats: {
+        servers: [:string],
+        dont_randomize_servers: :bool,
+        reconnect_time_wait: :float,
+        max_reconnect_attempts: :int,
+        connect_timeout: :float,
+        tls_ca_file: :string,
+        # TODO: review, list all of them: https://github.com/nats-io/nats.rb
+      },
+    }.freeze
+
+    # @param [String] cluster ID
+    # @param [String] client ID
+    # @param [Hash] options
+    # @return [STAN::Client] connected STAN client
+    def self.connect(cluster_id, client_id, nats: {}, **opts)
+      # handle TLS if CA file is provided:
+      if !nats[:tls] && nats[:tls_ca_file]
+        ctx = OpenSSL::SSL::SSLContext.new
+        ctx.set_params
+        ctx.ca_file = nats.delete(:tls_ca_file)
+        nats[:tls] = ctx
+      end
+
+      client = ::STAN::Client.new
+      client.connect(cluster_id, client_id, nats: nats, **opts.slice(*CLIENT_OPTS.keys))
+      client
+    end
+
+    # @return [BPS::Coercer] the options coercer
+    def self.coercer
+      @coercer ||= BPS::Coercer.new(CLIENT_OPTS).freeze
+    end
+
+    # @return [Array] arguments for connecting to STAN
+    def self.parse_url(url)
+      port = url.port&.to_s || '4222'
+      servers = CGI.unescape(url.host).split(',').map do |host|
+        addr = "nats://#{host}"
+        addr << ':' << port unless /:\d+$/.match?(addr)
+        addr
+      end
+      opts = CGI.parse(url.query || '').transform_values {|v| v.size == 1 ? v[0] : v }
+      cluster_id = opts.delete('cluster_id')
+      client_id = opts.delete('client_id')
+      [cluster_id, client_id, { nats: { servers: servers } }]
     end
   end
 end

data/lib/bps/subscriber/stan.rb

@@ -0,0 +1,37 @@
+require 'cgi'
+require 'stan/client'
+
+module BPS
+  module Subscriber
+    class STAN < Abstract
+      # @param [String] cluster ID.
+      # @param [String] client ID.
+      # @param [Hash] options.
+      def initialize(cluster_id, client_id, **opts)
+        super()
+
+        @client = ::BPS::STAN.connect(cluster_id, client_id, **opts)
+      end
+
+      # Subscribe to a topic
+      # @param topic [String] topic the topic name.
+      def subscribe(topic, **opts)
+        # important opts:
+        # - queue: 'queue-name'          # https://docs.nats.io/developing-with-nats-streaming/queues
+        # - durable_name: 'durable-name' # https://docs.nats.io/developing-with-nats-streaming/durables
+        @client.subscribe(topic, **opts) do |msg|
+          yield msg.data # TODO: maybe yielding just bytes is not too flexible? But IMO can wait till (much) later
+        end
+      end
+
+      # Close the subscriber.
+      def close
+        super
+
+        # NATS/STAN does not survive multi-closes, so close only once:
+        @client&.close
+        @client = nil
+      end
+    end
+  end
+end

data/spec/bps/{stan_spec.rb → publisher/stan_spec.rb}

@@ -2,32 +2,36 @@ require 'bps/stan'
 require 'spec_helper'
 
 RSpec.describe 'STAN', stan: true do
-  context 'resolve addrs' do
-    let(:publisher) { double('BPS::Publisher::STAN') }
+  context 'with addr resolving' do
+    let(:publisher) { instance_double('BPS::Publisher::STAN') }
+
     before          { allow(BPS::Publisher::STAN).to receive(:new).and_return(publisher) }
 
-    it 'should resolve simple URLs' do
-      expect(BPS::Publisher::STAN)
+    it 'resolves simple URLs' do
+      allow(BPS::Publisher::STAN)
         .to receive(:new)
         .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://test.host:4222'] })
         .and_return(publisher)
-      BPS::Publisher.resolve(URI.parse('stan://test.host:4222?cluster_id=CLUSTER&client_id=CLIENT'))
+      expect(BPS::Publisher.resolve(URI.parse('stan://test.host:4222?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(publisher)
     end
 
-    it 'should resolve URLs with multiple hosts' do
-      expect(BPS::Publisher::STAN)
+    it 'resolves URLs with multiple hosts' do
+      allow(BPS::Publisher::STAN)
         .to receive(:new)
         .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://foo.host:4222', 'nats://bar.host:4222'] })
         .and_return(publisher)
-      BPS::Publisher.resolve(URI.parse('stan://foo.host,bar.host:4222?cluster_id=CLUSTER&client_id=CLIENT'))
+      expect(BPS::Publisher.resolve(URI.parse('stan://foo.host,bar.host:4222?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(publisher)
     end
 
-    it 'should resolve URLs with multiple hosts/ports' do
-      expect(BPS::Publisher::STAN)
+    it 'resolves URLs with multiple hosts/ports' do
+      allow(BPS::Publisher::STAN)
         .to receive(:new)
         .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://foo.host:4223', 'nats://bar.host:4222'] })
         .and_return(publisher)
-      BPS::Publisher.resolve(URI.parse('stan://foo.host%3A4223,bar.host?cluster_id=CLUSTER&client_id=CLIENT'))
+      expect(BPS::Publisher.resolve(URI.parse('stan://foo.host%3A4223,bar.host?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(publisher)
     end
   end
 
@@ -35,7 +39,7 @@ RSpec.describe 'STAN', stan: true do
     let(:cluster_id) { 'test-cluster' } # this is a default cluster for https://hub.docker.com/_/nats-streaming
     let(:client_id)  { 'bps-test' }
 
-    let(:nats_servers) { ENV.fetch('NATS_SERVERS', '127.0.0.1:4222').split(',') }
+    let(:nats_servers) { ENV.fetch('STAN_ADDRS', '127.0.0.1:4222').split(',') }
     let(:nats_servers_with_scheme) { nats_servers.map {|s| "nats://#{s}" } }
 
     let(:publisher_url) { "stan://#{CGI.escape(nats_servers.join(','))}/?cluster_id=#{cluster_id}&client_id=#{client_id}" }

data/spec/bps/subscriber/stan_spec.rb

@@ -0,0 +1,61 @@
+require 'bps/stan'
+require 'spec_helper'
+
+RSpec.describe 'STAN', stan: true do
+  context 'with addr resolving' do
+    let(:subscriber) { instance_double('BPS::Subscriber::STAN') }
+
+    before { allow(BPS::Subscriber::STAN).to receive(:new).and_return(subscriber) }
+
+    it 'resolves simple URLs' do
+      allow(BPS::Subscriber::STAN)
+        .to receive(:new)
+        .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://test.host:4222'] })
+        .and_return(subscriber)
+      expect(BPS::Subscriber.resolve(URI.parse('stan://test.host:4222?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(subscriber)
+    end
+
+    it 'resolves URLs with multiple hosts' do
+      allow(BPS::Subscriber::STAN)
+        .to receive(:new)
+        .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://foo.host:4222', 'nats://bar.host:4222'] })
+        .and_return(subscriber)
+      expect(BPS::Subscriber.resolve(URI.parse('stan://foo.host,bar.host:4222?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(subscriber)
+    end
+
+    it 'resolves URLs with multiple hosts/ports' do
+      allow(BPS::Subscriber::STAN)
+        .to receive(:new)
+        .with('CLUSTER', 'CLIENT', nats: { servers: ['nats://foo.host:4223', 'nats://bar.host:4222'] })
+        .and_return(subscriber)
+      expect(BPS::Subscriber.resolve(URI.parse('stan://foo.host%3A4223,bar.host?cluster_id=CLUSTER&client_id=CLIENT')))
+        .to eq(subscriber)
+    end
+  end
+
+  context BPS::Subscriber::STAN do
+    let(:cluster_id) { 'test-cluster' } # this is a default cluster for https://hub.docker.com/_/nats-streaming
+    let(:client_id)  { 'bps-test' }
+
+    let(:nats_servers) { ENV.fetch('STAN_ADDRS', '127.0.0.1:4222').split(',') }
+    let(:nats_servers_with_scheme) { nats_servers.map {|s| "nats://#{s}" } }
+
+    let(:subscriber_url) { "stan://#{CGI.escape(nats_servers.join(','))}/?cluster_id=#{cluster_id}&client_id=#{client_id}" }
+
+    def produce_messages(topic_name, messages)
+      opts = {
+        servers: nats_servers_with_scheme,
+        dont_randomize_servers: true,
+      }
+      ::STAN::Client.new.connect(cluster_id, client_id, nats: opts) do |client|
+        messages.each do |message|
+          client.publish(topic_name, message)
+        end
+      end
+    end
+
+    it_behaves_like 'subscriber'
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-stan
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.3
 platform: ruby
 authors:
 - Black Square Media
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-24 00:00:00.000000000 Z
+date: 2022-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bps
@@ -16,26 +16,26 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.3
 - !ruby/object:Gem::Dependency
   name: nats-streaming
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.2
 description: https://github.com/bsm/bps
@@ -48,11 +48,14 @@ files:
 - lib/bps-stan.rb
 - lib/bps/publisher/stan.rb
 - lib/bps/stan.rb
-- spec/bps/stan_spec.rb
+- lib/bps/subscriber/stan.rb
+- spec/bps/publisher/stan_spec.rb
+- spec/bps/subscriber/stan_spec.rb
 homepage: https://github.com/bsm/bps
 licenses:
 - Apache-2.0
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -68,9 +71,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: BPS adapter for nats-streaming
 test_files:
-- spec/bps/stan_spec.rb
+- spec/bps/publisher/stan_spec.rb
+- spec/bps/subscriber/stan_spec.rb