bps-kafka 0.1.3 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5d05abc6c4a93507504408f2896d0b58bfd0e0a31b8cc1158880cd10c0f9f4d
-  data.tar.gz: dedbc0320b57dab92bdc9496dce28e8bbf0f00d49783fb63b6970adf49ca411e
+  metadata.gz: a0011da50b81535c09e800cb6ca91d37cd00a68cf127cf981cd20921bbc9a479
+  data.tar.gz: db8273a953132cd62213ec57a72f83d3ed145d8d940cd69e636ababe293f61a4
 SHA512:
-  metadata.gz: 5aefa008139667df54d170f7f7ddbce4084136885dae21565f2734a71ce4016d3d633964076b9c8b4bcf44a24c0bcc0ad260fb5925eb334599018c7d4a3817b5
-  data.tar.gz: 1bc340118cd5b21d996f78f0705f8acd60f8d13a75c1e0576a60bc99f923015d0834a26932efa19a2b05a0f6f631be33395c62f89091ad6515ef0100ad9886e8
+  metadata.gz: 850365053b425e5b41b609b228ef6b2e48ebd702c21867c827c8c714bbbb03b6e72ff6460de07f4166b62c3429572a9de4645d2e4ca4eba810435ef2f665dd38
+  data.tar.gz: 0dae8ab5423f51dd5b1cb29eb00492a68c033167c92122e8ebff1fa45b0ac307bc36d749b8af908e390d3bc852c79eae8be7143576e1e44254a12ac2a22130be

data/bps-kafka.gemspec

@@ -19,4 +19,5 @@ Gem::Specification.new do |s|
 
   s.add_dependency 'bps', s.version
   s.add_dependency 'ruby-kafka', '>= 1.1.0.beta1'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/bps/publisher/kafka.rb

@@ -93,6 +93,8 @@ module BPS
       end
 
       def close
+        super
+
         @producer.shutdown
         @client.close
       end
@@ -102,7 +104,7 @@ module BPS
       def parse_url(url)
         port = url.port&.to_s || '9092'
         CGI.unescape(url.host).split(',').map do |addr|
-          addr << ':' << port unless addr.match(/:\d+$/)
+          addr << ':' << port unless /:\d+$/.match?(addr)
           addr
         end
       end

data/spec/bps/kafka_spec.rb

@@ -2,33 +2,34 @@ require 'spec_helper'
 require 'bps/kafka'
 
 RSpec.describe 'Kafka', kafka: true do
-  context 'resolve addrs' do
-    let(:client) { double('Kafka', producer: nil) }
+  context 'with addr resolving' do
+    let(:client) { instance_double(::Kafka::Client, producer: nil) }
+
     before       { allow(::Kafka).to receive(:new).and_return(client) }
 
-    it 'should resolve simple URLs' do
+    it 'resolves simple URLs' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://test.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts' do
+    it 'resolves URLs with multiple hosts' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host,bar.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts/ports' do
+    it 'resolves URLs with multiple hosts/ports' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host%3A9093,bar.host'))
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-kafka
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.3
 platform: ruby
 authors:
 - Black Square Media
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-24 00:00:00.000000000 Z
+date: 2022-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bps
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.3
 - !ruby/object:Gem::Dependency
   name: ruby-kafka
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +53,8 @@ files:
 homepage: https://github.com/bsm/bps
 licenses:
 - Apache-2.0
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -69,7 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Kafka adapter for bps