bps-kafka 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5d05abc6c4a93507504408f2896d0b58bfd0e0a31b8cc1158880cd10c0f9f4d
-  data.tar.gz: dedbc0320b57dab92bdc9496dce28e8bbf0f00d49783fb63b6970adf49ca411e
+  metadata.gz: 332d68ff69826c69b3a32c7d343e7760f6eab8441a2264667138351e189b5a08
+  data.tar.gz: b5f753df0a51c938e2fdf0930d9f233b13fb268c2e1960809f2ffda3fda94fc7
 SHA512:
-  metadata.gz: 5aefa008139667df54d170f7f7ddbce4084136885dae21565f2734a71ce4016d3d633964076b9c8b4bcf44a24c0bcc0ad260fb5925eb334599018c7d4a3817b5
-  data.tar.gz: 1bc340118cd5b21d996f78f0705f8acd60f8d13a75c1e0576a60bc99f923015d0834a26932efa19a2b05a0f6f631be33395c62f89091ad6515ef0100ad9886e8
+  metadata.gz: 8a524f30fc1066a99be4e33ac4ada7e4c3ca39c8a705d695589ebfea89d4162b9f0b0e5792150d087b6b28a7fe7de546f13402d62c599acdc27a130295e8f2b9
+  data.tar.gz: f6aded50c6d824e192ce981c36568793714c07b9b19bbb5f9347e424ba22abd1151e7ef927eb6713dc945cfd0d512efdef86b04f204772e56b48f863e52cca4d

data/lib/bps/publisher/kafka.rb

@@ -102,7 +102,7 @@ module BPS
       def parse_url(url)
         port = url.port&.to_s || '9092'
         CGI.unescape(url.host).split(',').map do |addr|
-          addr << ':' << port unless addr.match(/:\d+$/)
+          addr << ':' << port unless /:\d+$/.match?(addr)
           addr
         end
       end

data/spec/bps/kafka_spec.rb

@@ -2,33 +2,34 @@ require 'spec_helper'
 require 'bps/kafka'
 
 RSpec.describe 'Kafka', kafka: true do
-  context 'resolve addrs' do
-    let(:client) { double('Kafka', producer: nil) }
+  context 'with addr resolving' do
+    let(:client) { instance_double(::Kafka::Client, producer: nil) }
+
     before       { allow(::Kafka).to receive(:new).and_return(client) }
 
-    it 'should resolve simple URLs' do
+    it 'resolves simple URLs' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://test.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts' do
+    it 'resolves URLs with multiple hosts' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host,bar.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts/ports' do
+    it 'resolves URLs with multiple hosts/ports' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host%3A9093,bar.host'))
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-kafka
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Black Square Media
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-24 00:00:00.000000000 Z
+date: 2021-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bps
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: ruby-kafka
   requirement: !ruby/object:Gem::Requirement
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Kafka adapter for bps