bps-kafka 0.1.2 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2947d6ee7913a2387a4300320a5fd44b4b4db096311b4da117a51f620ca44efe
-  data.tar.gz: faa0f01af5368aa0c2544a0eac7f7a5b59655b0885e3a1c3f5c623a784e2838b
+  metadata.gz: 87d68617ad58c810d307efe2f1142306a502eea59098070fa70d1b40a13f49f3
+  data.tar.gz: f3d4e4de9ed30b41b8d546c7ef885498c265104ac3ded18dc40cd1e0f45278aa
 SHA512:
-  metadata.gz: e820bed323b80633f620312a2070c33c492dda643c7308bdb8869d63cfc8772a66e6e2bfe29a2968c201c854af15eb694fb1250f17cb24c01af1cf7b1f2451f4
-  data.tar.gz: 3ae553795c664b966e347e2009ff1a0ef9741f9b6932afc79ed13677a29b355b0184a72be0b446c7bd079f9d32537bd748e12ee247291f103fa5bd8020cbdfa0
+  metadata.gz: 07bc1b7e4b2c9779489e95375a15cb84015514d25322d8dde2ac5c1a2461f0eb427ae8f53c1cb3695b03ef16fa1f592c51d77b922bc7104f8a785f36ecfa431d
+  data.tar.gz: 2b8e3aa881a745f9f9b240b27d890acd1948733080664ddabd25030bffdc4a9b25e0841a8e817be72b48c7168579c9fe0cd42f08fb81e70902e6655ea7ea862b

data/lib/bps/publisher/kafka.rb

@@ -93,6 +93,8 @@ module BPS
       end
 
       def close
+        super
+
         @producer.shutdown
         @client.close
       end
@@ -102,7 +104,7 @@ module BPS
       def parse_url(url)
         port = url.port&.to_s || '9092'
         CGI.unescape(url.host).split(',').map do |addr|
-          addr << ':' << port unless addr.match(/:\d+$/)
+          addr << ':' << port unless /:\d+$/.match?(addr)
           addr
         end
       end

data/lib/bps/publisher/kafka_async.rb

@@ -14,10 +14,10 @@ module BPS
       # @param [Hash] opts the options.
       # @option opts [Integer] :max_queue_size (defaults to: 1000)
       #                        the maximum number of messages allowed in the queue.
-      # @option opts [Integer] :delivery_threshold (defaults to: 0)
+      # @option opts [Integer] :delivery_threshold (defaults to: 1000)
       #                        if greater than zero, the number of buffered messages that will automatically
       #                        trigger a delivery.
-      # @option opts [Integer] :delivery_interval (defaults to: 0) if greater than zero, the number of
+      # @option opts [Integer] :delivery_interval (defaults to: 30) if greater than zero, the number of
       #                        seconds between automatic message deliveries.
       def initialize(broker_addrs, **opts) # rubocop:disable Lint/UselessMethodDefinition
         super
@@ -25,7 +25,7 @@ module BPS
 
       private
 
-      def init_producer(max_queue_size: 1000, delivery_threshold: 0, delivery_interval: 0)
+      def init_producer(max_queue_size: 1000, delivery_threshold: 1000, delivery_interval: 30)
         @client.async_producer(
           max_queue_size: max_queue_size,
           delivery_threshold: delivery_threshold,

data/spec/bps/kafka_spec.rb

@@ -2,33 +2,34 @@ require 'spec_helper'
 require 'bps/kafka'
 
 RSpec.describe 'Kafka', kafka: true do
-  context 'resolve addrs' do
-    let(:client) { double('Kafka', producer: nil) }
+  context 'with addr resolving' do
+    let(:client) { instance_double(::Kafka::Client, producer: nil) }
+
     before       { allow(::Kafka).to receive(:new).and_return(client) }
 
-    it 'should resolve simple URLs' do
+    it 'resolves simple URLs' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['test.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://test.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts' do
+    it 'resolves URLs with multiple hosts' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9092', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host,bar.host:9092'))
     end
 
-    it 'should resolve URLs with multiple hosts/ports' do
+    it 'resolves URLs with multiple hosts/ports' do
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092'], {}).and_return(client)
       else
-        expect(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
+        allow(::Kafka).to receive(:new).with(['foo.host:9093', 'bar.host:9092']).and_return(client)
       end
       BPS::Publisher.resolve(URI.parse('kafka+sync://foo.host%3A9093,bar.host'))
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-kafka
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.2
 platform: ruby
 authors:
 - Black Square Media
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-09 00:00:00.000000000 Z
+date: 2021-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bps
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.2
+        version: 0.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.2
+        version: 0.2.2
 - !ruby/object:Gem::Dependency
   name: ruby-kafka
   requirement: !ruby/object:Gem::Requirement
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.15
 signing_key: 
 specification_version: 4
 summary: Kafka adapter for bps