bps-kafka 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc71e376289d57e6341560ddefd86c3c44d77b5fe3963ca658bfa44c4124d31f
-  data.tar.gz: 9ac605f652d7ec7a4a2f3f6460e476d6639b705021ad064240ea8cc2ac03f51b
+  metadata.gz: 2947d6ee7913a2387a4300320a5fd44b4b4db096311b4da117a51f620ca44efe
+  data.tar.gz: faa0f01af5368aa0c2544a0eac7f7a5b59655b0885e3a1c3f5c623a784e2838b
 SHA512:
-  metadata.gz: f7d2cc289e5d7f82ce2dba5538b7f071f5259ee7fd9f9077cf0a2334d157a2bcf00d4b787a86fc733142e1ff17ce7b7f2bfcc1f4db761825de6492d53825eb51
-  data.tar.gz: dfdb6747738ed57a359e71cd4455203c3da130d8ec31516ddfaf6b4e93f08e1f1f51d74d304ca8d3dfc99a83906c9acb3be540acb83aacf81a0b2e1eefda5561
+  metadata.gz: e820bed323b80633f620312a2070c33c492dda643c7308bdb8869d63cfc8772a66e6e2bfe29a2968c201c854af15eb694fb1250f17cb24c01af1cf7b1f2451f4
+  data.tar.gz: 3ae553795c664b966e347e2009ff1a0ef9741f9b6932afc79ed13677a29b355b0184a72be0b446c7bd079f9d32537bd748e12ee247291f103fa5bd8020cbdfa0

data/spec/bps/kafka_spec.rb

@@ -1,33 +1,7 @@
 require 'spec_helper'
 require 'bps/kafka'
 
-def kafka_addrs
-  ENV.fetch('KAFKA_ADDRS', '127.0.0.1:9092').split(',').freeze
-end
-
-run_spec = \
-  begin
-    ::Kafka.new(kafka_addrs).brokers
-    true
-  rescue StandardError => e
-    warn "WARNING: unable to run #{File.basename __FILE__}: #{e.message}"
-    false
-  end
-
-helper = proc do
-  def read_messages(topic_name, num_messages)
-    client = ::Kafka.new(kafka_addrs)
-    Enumerator.new do |y|
-      client.each_message(topic: topic_name, start_from_beginning: true) do |msg|
-        y << msg.value
-      end
-    end.take(num_messages)
-  ensure
-    client&.close
-  end
-end
-
-RSpec.describe 'Kafka' do
+RSpec.describe 'Kafka', kafka: true do
   context 'resolve addrs' do
     let(:client) { double('Kafka', producer: nil) }
     before       { allow(::Kafka).to receive(:new).and_return(client) }
@@ -60,11 +34,30 @@ RSpec.describe 'Kafka' do
     end
   end
 
-  context BPS::Publisher::Kafka, if: run_spec do
-    it_behaves_like 'publisher', url: "kafka+sync://#{CGI.escape(kafka_addrs.join(','))}/", &helper
-  end
+  describe 'publishers' do
+    let(:kafka_addrs) { ENV.fetch('KAFKA_ADDRS', '127.0.0.1:9092').split(',') }
+
+    def read_messages(topic_name, num_messages)
+      client = ::Kafka.new(kafka_addrs)
+      Enumerator.new do |y|
+        client.each_message(topic: topic_name, start_from_beginning: true) do |msg|
+          y << msg.value
+        end
+      end.take(num_messages)
+    ensure
+      client&.close
+    end
 
-  context BPS::Publisher::KafkaAsync, if: run_spec do
-    it_behaves_like 'publisher', url: "kafka://#{CGI.escape(kafka_addrs.join(','))}/", &helper
+    context BPS::Publisher::Kafka do
+      let(:publisher_url) { "kafka+sync://#{CGI.escape(kafka_addrs.join(','))}/" }
+
+      it_behaves_like 'publisher'
+    end
+
+    context BPS::Publisher::KafkaAsync do
+      let(:publisher_url) { "kafka://#{CGI.escape(kafka_addrs.join(','))}/" }
+
+      it_behaves_like 'publisher'
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-kafka
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Black Square Media
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-02 00:00:00.000000000 Z
+date: 2020-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bps
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: ruby-kafka
   requirement: !ruby/object:Gem::Requirement