bps-google-api 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36e2a1cd1f252cfeef6ffd6d9876aa57edf0bdbc
-  data.tar.gz: ac11872b200429439ca3be64872cbab00fbae4e5
+  metadata.gz: 4bb3f5af2dbe6a57df4945c7d082aab5e6f68edb
+  data.tar.gz: 225fd27b21ae836d6d051bf32a81b96e17ed71f7
 SHA512:
-  metadata.gz: 2f6852acfb76d9b69d6ed8d70b93c4b84c7247cb0115cc507da4300a3504bba1e2f6a1794cf91eb5d205261a45bd08c98f5873cb666c9ba63c38c74e43126115
-  data.tar.gz: fee256d45c8795cd36e49c157bd233d697a1ffaccf684edb85274c09979541b0799847e1a94530d67c15089b7bfd97242f7fa7b99c738cc7f88a465a2d053bb5
+  metadata.gz: 031d62aac72e1de816ac5d309fed95d8886c7b205633f25c9accf6ca8e43fa389c62334943a57f9ed4a0f85c47583149daab492eff8be4db403b7018c90b09a7
+  data.tar.gz: 3e5e6374f3731ba02d763d515bf3877d35e635a0c5f1f87a465ac8fb891581aa288a42c83eed1fbf93a963dba681115269a497efe864d71c31116f0580940e45

data/.gitignore

@@ -1 +1,3 @@
-config/
+config/
+coverage/
+tmp/

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.4
   Exclude:
     - bin/**/*
     - config/**/*

data/.ruby-version

@@ -0,0 +1 @@
+2.4.4

data/.travis.yml

@@ -0,0 +1,20 @@
+language: ruby
+rvm:
+  - 2.4.4
+branches:
+  except:
+    - "/^v[0-9]+\\.[0-9]+\\.[0-9]+(?:-.*)?/"
+notifications:
+  email:
+    on_success: change
+    on_failure: always
+before_install:
+  - gem install bundler -v '< 2'
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rspec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bps-google-api (0.1.5)
+    bps-google-api (0.2.0)
       exp_retry (~> 0.0.11)
       fileutils (~> 1.2)
       google-api-client (~> 0.23.4)
@@ -14,7 +14,9 @@ GEM
       public_suffix (>= 2.0.2, < 4.0)
     declarative (0.0.10)
     declarative-option (0.1.0)
-    exp_retry (0.0.11)
+    diff-lcs (1.3)
+    docile (1.3.2)
+    exp_retry (0.0.12)
     faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
     fileutils (1.2.0)
@@ -34,6 +36,7 @@ GEM
       os (>= 0.9, < 2.0)
       signet (~> 0.7)
     httpclient (2.8.3)
+    json (2.2.0)
     jwt (2.2.1)
     memoist (0.16.0)
     mime-types (3.2.2)
@@ -48,12 +51,30 @@ GEM
       declarative-option (< 0.2.0)
       uber (< 0.2.0)
     retriable (3.1.2)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.1)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.4)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.2)
     ruby-progressbar (1.10.1)
     signet (0.11.0)
       addressable (~> 2.3)
       faraday (~> 0.9)
       jwt (>= 1.5, < 3.0)
       multi_json (~> 1.10)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
     uber (0.1.0)
 
 PLATFORMS
@@ -61,6 +82,8 @@ PLATFORMS
 
 DEPENDENCIES
   bps-google-api!
+  rspec (~> 3.8, >= 3.8.0)
+  simplecov (~> 0.16, >= 0.16.1)
 
 BUNDLED WITH
    1.17.3

data/bps-google-api.gemspec

@@ -2,8 +2,8 @@
 
 Gem::Specification.new do |s|
   s.name          = 'bps-google-api'
-  s.version       = '0.1.5'
-  s.date          = '2019-06-15'
+  s.version       = '0.2.0'
+  s.date          = '2019-06-20'
   s.summary       = 'Configured Google API'
   s.description   = 'A configured Google API wrapper.'
   s.homepage      = 'http://rubygems.org/gems/bps-google-api'
@@ -13,8 +13,13 @@ Gem::Specification.new do |s|
   s.require_paths = %w[lib]
   s.files         = `git ls-files`.split("\n")
 
+  s.required_ruby_version = '~> 2.4'
+
   s.add_runtime_dependency 'exp_retry',         '~> 0.0.11'
   s.add_runtime_dependency 'fileutils',         '~> 1.2'
   s.add_runtime_dependency 'google-api-client', '~> 0.23.4'
   s.add_runtime_dependency 'ruby-progressbar',  '~> 1.10'
+
+  s.add_development_dependency 'rspec',     '~> 3.8',  '>= 3.8.0'
+  s.add_development_dependency 'simplecov', '~> 0.16', '>= 0.16.1'
 end

data/lib/google_api.rb

@@ -7,6 +7,10 @@ module GoogleAPI
   require 'googleauth'
   require 'googleauth/stores/file_token_store'
 
+  require 'exp_retry'
+  require 'fileutils'
+  require 'ruby-progressbar'
+
   require 'google_api/base'
   require 'google_api/calendar'
   require 'google_api/group'

data/lib/google_api/calendar.rb

@@ -33,27 +33,30 @@ module GoogleAPI
       :event_not_found
     end
 
-    def permit(calendar, user)
+    def permit(calendar, user = nil, email: nil)
+      email ||= user&.email
+
       rule = Google::Apis::CalendarV3::AclRule.new(
-        scope: { type: 'user', value: user.email }, role: 'writer'
+        scope: { type: 'user', value: email }, role: 'writer'
       )
 
-      result = call(:insert_acl, calendar, rule)
-      user.update(calendar_rule_id: result.id)
+      user&.update(calendar_rule_id: call(:insert_acl, calendar, rule).id)
     end
 
-    def unpermit(calendar, user)
-      call(:delete_acl, calendar, user&.calendar_rule_id)
+    def unpermit(calendar, user = nil, calendar_rule_id: nil)
+      calendar_rule_id ||= user&.calendar_rule_id
+
+      call(:delete_acl, calendar, calendar_rule_id)
     rescue Google::Apis::ClientError
       :permission_not_found
     ensure
-      user.update(calendar_rule_id: nil)
+      user&.update(calendar_rule_id: nil)
     end
 
   private
 
     def event(event_options)
-      event_options.assert_valid_keys(VALID_EVENT_KEYS)
+      validate_event_options(event_options)
       event_options[:start] = date(event_options[:start])
       event_options[:end] = date(event_options[:end])
 
@@ -69,5 +72,11 @@ module GoogleAPI
       path = %w[tmp run last_page_token]
       defined?(Rails) ? Rails.root.join(*path) : File.join(*path)
     end
+
+    def validate_event_options(event_options)
+      return unless event_options.respond_to?(:assert_valid_keys)
+
+      event_options.assert_valid_keys(VALID_EVENT_KEYS)
+    end
   end
 end

data/lib/google_api/calendar/clear_test_calendar.rb

@@ -12,7 +12,7 @@ module GoogleAPI
       rescue Google::Apis::RateLimitError
         puts "\n\n*** Google::Apis::RateLimitError (Rate Limit Exceeded)"
       ensure
-        log_last_page_token unless @page_token.blank?
+        log_last_page_token if token?
       end
 
     private
@@ -20,18 +20,23 @@ module GoogleAPI
       def choose_page_token(page_token)
         last_token = last_token_path
         @page_token ||= File.read(last_token) if File.exist?(last_token)
-        @page_token = page_token if page_token.present?
+        @page_token = page_token if token?(page_token)
+      end
+
+      def token?(token = nil)
+        token ||= @token
+        token != ''
       end
 
       def loop_over_pages(cal_id, page_limit: 50)
-        puts "*** Starting with page token: #{@page_token}" if @verbose && @page_token.present?
+        puts "*** Starting with page token: #{@page_token}" if @verbose && token?
 
         page_limit -= 1 while (@page_token = clear_page(cal_id)) && page_limit.positive?
       end
 
       def clear_page(cal_id)
         response = list(cal_id, page_token: @page_token)
-        clear_events_from_page(cal_id, response.items) unless response.items.blank?
+        clear_events_from_page(cal_id, response.items) unless response.items.empty?
         response.next_page_token
       end
 

data/spec/.rubocop.yml

@@ -0,0 +1,4 @@
+Metrics/LineLength:
+  Max: 100
+Metrics/BlockLength:
+  Enabled: false

data/spec/lib/google_api/base_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe GoogleAPI::Base do
+  subject { described_class.new }
+
+  it 'does not have a service class' do
+    expect { subject }.to raise_error(
+      NameError, 'uninitialized constant GoogleAPI::Base::SERVICE_CLASS'
+    )
+  end
+end

data/spec/lib/google_api/calendar_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe GoogleAPI::Calendar do
+  subject { described_class.new }
+
+  it 'has a service class' do
+    expect { subject.send(:service_class) }.not_to raise_error
+  end
+
+  it 'has the correct service class' do
+    expect(subject.send(:service_class)).to eql(Google::Apis::CalendarV3::CalendarService)
+  end
+
+  describe 'list' do
+    it 'returns not found for a nonexistent calendar' do
+      expect { subject.list('not-a-calendar') }.to raise_error(
+        Google::Apis::ClientError, 'notFound: Not Found'
+      )
+    end
+  end
+
+  describe 'create' do
+    it 'returns not found for a nonexistent calendar' do
+      expect { subject.create('not-a-calendar') }.to raise_error(
+        Google::Apis::ClientError, 'notFound: Not Found'
+      )
+    end
+  end
+
+  describe 'get' do
+    it 'returns not found for a nonexistent calendar' do
+      expect { subject.get('not-a-calendar', 'not-an-event') }.to raise_error(
+        Google::Apis::ClientError, 'notFound: Not Found'
+      )
+    end
+  end
+
+  describe 'update' do
+    it 'returns not found for a nonexistent calendar' do
+      expect { subject.update('not-a-calendar', 'not-an-event') }.to raise_error(
+        Google::Apis::ClientError, 'notFound: Not Found'
+      )
+    end
+  end
+
+  describe 'delete' do
+    it 'returns event not found for a nonexistent calendar' do
+      expect(subject.delete('not-a-calendar', 'not-an-event')).to eql(
+        :event_not_found
+      )
+    end
+  end
+
+  describe 'permit' do
+    it 'returns nil for a nonexistent calendar' do
+      expect(subject.permit('not-a-calendar', email: 'not-a-user')).to be_nil
+    end
+  end
+
+  describe 'unpermit' do
+    it 'returns permission not found for a nonexistent calendar' do
+      expect(subject.unpermit('not-a-calendar', calendar_rule_id: 'not-a-user')).to eql(
+        :permission_not_found
+      )
+    end
+  end
+
+  describe 'clear test calendar' do
+    it 'does not raise any errors' do
+      expect { subject.clear_test_calendar }.not_to raise_error
+    end
+  end
+end

data/spec/lib/google_api/group_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe GoogleAPI::Group do
+  subject { described_class.new('test-group@example.com') }
+
+  it 'has a service class' do
+    expect { subject.send(:service_class) }.not_to raise_error
+  end
+
+  it 'has the correct service class' do
+    expect(subject.send(:service_class)).to eql(Google::Apis::AdminDirectoryV1::DirectoryService)
+  end
+
+  describe 'get' do
+    it 'returns not found for a nonexistent group' do
+      expect { subject.get }.to raise_error(
+        Google::Apis::ClientError, 'forbidden: Not Authorized to access this resource/api'
+      )
+    end
+  end
+
+  describe 'members' do
+    it 'returns forbidden for a nonexistent group' do
+      expect { subject.members }.to raise_error(
+        Google::Apis::ClientError, 'forbidden: Not Authorized to access this resource/api'
+      )
+    end
+  end
+
+  describe 'add' do
+    it 'returns not found for a nonexistent group' do
+      expect(subject.add('test-member@example.com')).to eql(:already_exists)
+    end
+  end
+
+  describe 'remove' do
+    it 'returns not found for a nonexistent group' do
+      expect(subject.remove('test-member@example.com')).to eql(:not_found)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'bundler/setup'
+Bundler.setup
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/spec'
+end
+
+require 'google_api'
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    FileUtils.mkdir_p('tmp/run')
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bps-google-api
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Julian Fiander
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-15 00:00:00.000000000 Z
+date: 2019-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exp_retry
@@ -66,6 +66,46 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.8.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.8.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.16.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.16.1
 description: A configured Google API wrapper.
 email: julian@fiander.one
 executables: []
@@ -74,6 +114,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - Readme.md
@@ -84,6 +126,11 @@ files:
 - lib/google_api/calendar.rb
 - lib/google_api/calendar/clear_test_calendar.rb
 - lib/google_api/group.rb
+- spec/.rubocop.yml
+- spec/lib/google_api/base_spec.rb
+- spec/lib/google_api/calendar_spec.rb
+- spec/lib/google_api/group_spec.rb
+- spec/spec_helper.rb
 homepage: http://rubygems.org/gems/bps-google-api
 licenses:
 - GPL-3.0
@@ -94,9 +141,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="