bpm 0.1.4 → 1.0.0.beta.4

data/spec/cli/init_spec.rb

@@ -1,50 +1,190 @@
 require "spec_helper"
+require 'json'
 
-describe "bpm init" do
+describe "bpm init on existing directory" do
 
   before do
-    @project_path = home("new_project")
+    goto_home
+    set_host
+    start_fake(FakeGemServer.new)
+    
+    @project_path = home("new_project").to_s
     FileUtils.mkdir @project_path
     cd @project_path
   end
 
+  # compare the generated project to a fixture template
+  def compare_to(project_name)
+    compare_contents @project_path, project_fixture(project_name)
+  end
+  
   it "should create files" do
-    bpm 'init'
-
-    files = %w(new_project.json assets assets/bpm_packages.js assets/bpm_styles.css)
-
-    output = stdout.read.gsub(/\e\[\d+m/,'') #without colors
-
-    files.each do |file|
-      output.should =~ /create\s+#{file}$/
-      File.join(@project_path, file).should exist
-    end
+    bpm 'init' and wait
+    compare_to 'init_default'
   end
-
-  it "should fetch dependencies"
-
-  it "should build"
-
-  it "should not overwrite existing files" do
+  
+  it "should create app files with --app option" do
+    bpm 'init', '--app' and wait
+    compare_to 'init_app'
+  end
+  
+  it "should not overwrite existing project file" do
     File.open("new_project.json", 'w'){|f| f.print "Valuable info!" }
-
+  
     bpm 'init', '--skip' # skip, since we can't test the prompt
-
+  
     output = stdout.read.gsub(/\e\[\d+m/,'') # without colors
-
+  
     output.should =~ /skip\s+new_project.json/
     File.read("new_project.json").should == "Valuable info!"
   end
-
+  
+  it "should update the project with app but save other settings" do
+    bpm 'init' and wait
+    
+    # write a custom property
+    project_json = File.join @project_path, 'new_project.json'
+    json = JSON.load File.read(project_json)
+    json["custom_property"] = "I haz it"
+    File.open(project_json, 'w') { |fd| fd << json.to_json }
+  
+    bpm 'init', '--app' and wait
+    
+    app_package = home 'new_project', 'assets', 'new_project', 'bpm_libs.js'
+    File.exists?(app_package).should be_true
+    
+    json = JSON.load File.read(project_json)
+    json["custom_property"].should == "I haz it"
+    json["bpm:build"]["bpm_libs.js"].should_not be_nil
+    
+  end
+  
+  it "should rebuild assets" do
+  
+    bpm 'init' and wait
+    
+    files = %w(bpm_libs.js bpm_styles.css).map do |fn| 
+      File.join(@project_path, 'assets', fn)
+    end
+    
+    files.each do |path|
+      FileUtils.mkdir_p File.dirname(path)
+      File.open(path, 'w') { |fd| fd.print "Not valuable info!" }
+    end
+    
+    bpm 'init' and wait
+    
+    files.each do |path|
+      File.read(path).should_not include("Not valuable info!")
+    end
+  end
+  
   it "should allow a name to be specified" do
     bpm 'init', '--name=DifferentName' and wait
-
+  
     File.join(@project_path, "DifferentName.json").should exist
     File.join(@project_path, "new_project.json").should_not exist
   end
 
-  it "should initialize multiple at once"
+end
+
+describe "bpm init on a non-existant directory" do
+
+  describe "normal" do
+  
+    before do
+      goto_home
+      set_host
+      start_fake(FakeGemServer.new)
+      cd home
+    end
+  
+    it "should create files" do
+      bpm 'init', 'BpmTest'
+      
+
+      files = %w(LICENSE README.md index.html app/main.js BpmTest.json)
+      generated_files = %w(assets/bpm_libs.js assets/bpm_styles.css assets/BpmTest/bpm_libs.js assets/BpmTest/bpm_styles.css)
+
+      # output without coloration
+      output = stdout.read.gsub(/\e\[\d+m/,'')
 
-  it "should not allow a name when initializing multiple"
+      files.each do |file|
+        output.should =~ /create\s+#{file}$/
+        home("bpm_test", *file.split('/')).should exist
+      end
+
+      generated_files.each do |file|
+        home('bpm_test', *file.split('/')).should exist
+      end
+    end
+   
+    it "should allow a path to be specified" do
+      bpm 'init', 'DifferentLocation', '--name=BpmTest' and wait
+  
+      home("DifferentLocation").should exist
+      home("DifferentLocation", "BpmTest.json").should exist
+      home("DifferentLocation", "DifferentLocation.json").should_not exist
+      home("bpm_test").should_not exist
+    end
+  
+  end
+   
+  describe "package templates" do
+  
+    describe "with custom generator" do
+  
+      before do
+        goto_home
+        set_host
+        start_fake(FakeGemServer.new)
+      end
+  
+      it "should create custom files" do
+        bpm 'init', 'BpmTest', '--package=custom_generator'
+  
+        files = %w(lib lib/main.js app.js BpmTest.json)
+  
+        # output without coloration
+        output = stdout.read.gsub(/\e\[\d+m/,'')
+  
+        files.each do |file|
+          output.should =~ /create\s+#{file}$/
+          home("bpm_test", file).should exist
+        end
+      end
+  
+      it "should create custom app.js with explicit generator" do
+        bpm 'init', 'BpmTest', '--package=custom_generator' and wait
+  
+        File.read(home("bpm_test", "app.js")).should == "require('BpmTest/main.js')\n"
+      end
+  
+      it "should create custom project.json without explicit generator" do
+        bpm 'init', 'BpmTest', '--package=core-test' and wait
+  
+        File.read(home("bpm_test", "BpmTest.json")).should =~ /"core-test": "0.4.9"/
+      end
+  
+    end
+  
+    describe "without custom generator" do
+  
+      before do
+        goto_home
+        set_host
+        start_fake(FakeGemServer.new)
+        cd home
+      end
+  
+      it "should add package as a dependency even if it doesn't have custom generator" do
+        bpm 'init', 'BpmTest', '--package=jquery' and wait
+  
+        File.read(home("bpm_test", "BpmTest.json")).should =~ /"dependencies": {\n\s+"jquery": "1.4.3"\n\s+}/
+      end
+  
+    end
+
+  end
 
 end

data/spec/cli/{build_spec.rb → pack_spec.rb}

@@ -10,9 +10,9 @@ describe "bpm build when logged in" do
   end
 
   it "builds a bpm from a given package.json" do
-    FileUtils.cp_r fixtures("core-test"), "."
+    FileUtils.cp_r package_fixture("core-test"), "."
     cd "core-test"
-    bpm "build"
+    bpm "pack"
 
     exit_status.should be_success
     output = stdout.read
@@ -31,9 +31,9 @@ describe "bpm build without logging in" do
   end
 
   it "builds a bpm from a given package.json" do
-    FileUtils.cp_r fixtures("core-test"), "."
+    FileUtils.cp_r package_fixture("core-test"), "."
     cd "core-test"
-    bpm "build", "-e", "joe@example.com"
+    bpm "pack", "-e", "joe@example.com"
 
     exit_status.should be_success
   
@@ -43,8 +43,8 @@ describe "bpm build without logging in" do
   end
 
   it "builds a bpm when given a path to a package" do
-    FileUtils.cp_r fixtures("core-test"), "."
-    bpm "build", "core-test", "-e", "joe@example.com"
+    FileUtils.cp_r package_fixture("core-test"), "."
+    bpm "pack", "core-test", "-e", "joe@example.com"
 
     exit_status.should be_success
     
@@ -55,9 +55,9 @@ describe "bpm build without logging in" do
   end
 
   it "sets the email address if one is given" do
-    FileUtils.cp_r fixtures("core-test"), "."
+    FileUtils.cp_r package_fixture("core-test"), "."
     cd "core-test"
-    bpm "build", "-e", "lucy@allen.com"
+    bpm "pack", "-e", "lucy@allen.com"
 
     exit_status.should be_success
     output = stdout.read
@@ -77,11 +77,10 @@ describe "bpm build with an invalid package.json" do
 
   it "reports error messages" do
     FileUtils.touch "package.json"
-    bpm "build", :track_stderr => true
+    bpm "pack", :track_stderr => true
 
     exit_status.should_not be_success
     output = stderr.read
-    output.should include("BPM encountered the following problems building your package:")
     output.should include("There was a problem parsing package.json")
   end
 end

data/spec/cli/push_spec.rb

@@ -16,7 +16,7 @@ describe "bpm push" do
     end
 
     it "registers a gem when sent with the right api key" do
-      bpm "push", "../../spec/fixtures/rake-0.8.7.bpkg"
+      bpm "push", fixtures('gems', 'rake-0.8.7.bpkg').to_s
 
       stdout.read.should include("Successfully registered rake (0.8.7)")
     end
@@ -25,7 +25,7 @@ describe "bpm push" do
   it "shows rejection message if wrong api key is supplied" do
     write_api_key("beefbeef")
 
-    bpm "push", "../../spec/fixtures/rake-0.8.7.bpkg"
+    bpm "push", fixtures('gems', 'rake-0.8.7.bpkg').to_s
 
     stdout.read.should include("One cannot simply walk into Mordor!")
   end
@@ -46,7 +46,7 @@ describe "bpm push without api key" do
   end
 
   it "must push a valid gem" do
-    bpm "push", "../../spec/fixtures/badrake-0.8.7.bpkg"
+    bpm "push", fixtures('gems', 'badrake-0.8.7.bpkg').to_s
 
     stdout.read.should include("There was a problem opening your package.")
   end
@@ -66,7 +66,7 @@ describe "bpm push without api key" do
   end
 
   it "asks for login first if api key does not exist" do
-    bpm "push", "../../spec/fixtures/rake-0.8.7.bpkg"
+    bpm "push", fixtures('gems', 'rake-0.8.7.bpkg').to_s
 
     stdout.read.should include("Please login first with `bpm login`")
   end

data/spec/cli/rebuild_spec.rb

@@ -0,0 +1,181 @@
+require 'spec_helper'
+require 'json'
+
+describe 'bpm compile' do
+  
+  describe 'complex dependencies' do
+
+    before do
+      goto_home
+      set_host
+      start_fake(FakeGemServer.new)
+      FileUtils.cp_r(fixtures('projects', 'hello2'), '.')
+      cd home('hello2')
+    end
+
+    it "should order the packages property with dependencies" do
+      bpm 'rebuild', '--mode=debug' # avoid minification.
+      wait
+    
+      file = File.read home('hello2', 'assets', 'bpm_libs.js')
+      expected = <<EOF
+/* ===========================================================================
+   BPM Combined Asset File
+   MANIFEST: a (1.0.0) b (1.0.0) c (1.0.0)
+   This file is generated automatically by the bpm (http://www.bpmjs.org)    
+   =========================================================================*/
+
+// HELLO C
+
+// HELLO B
+
+// HELLO A
+
+EOF
+
+      file.should == expected
+    end
+  end
+
+  describe 'development dependencies' do
+    
+    before do
+      goto_home
+      set_host
+      start_fake(FakeGemServer.new)
+      FileUtils.cp_r(project_fixture('hello_dev'), '.')
+      cd home('hello_dev')
+
+      bpm 'fetch'
+      wait
+    end
+    
+    def test_include(does_include, build_file, *source_file)
+      contents_path = home('hello_dev', 'assets', build_file)
+      expected_path = home('hello_dev', *source_file)
+
+      if does_include
+        File.read(contents_path).should include(File.read(expected_path))
+      else
+        File.read(contents_path).should_not include(File.read(expected_path))
+      end
+        
+    end
+    
+    def test_development_dependencies(should_include)
+      
+      js_reg = [
+        # fetch regular dependency
+        %w(.bpm packages spade lib main.js)
+      ]
+      
+      js_dev = [
+        # fetched development dependency
+        %w(.bpm packages uglify-js lib parse-js.js),
+        
+        # required dependency of development dependency
+        %w(.bpm packages optparse lib optparse.js)
+      ]
+      
+      css_dev = [
+        # css of a locally installed development dependency
+        %w(packages style_package css some_style.css)
+      ]
+    
+      if should_include
+        expected_manifest = 'optparse (1.0.1) spade (0.5.0) style_package (1.0.0) uglify-js (1.0.4)'
+      else
+        expected_manifest = 'spade (0.5.0)'
+      end
+      
+      # validate manifest
+      expected_manifest = "MANIFEST: #{expected_manifest}"
+      File.read(home('hello_dev', 'assets', 'bpm_libs.js')).should include(expected_manifest)
+      
+      js_reg.each do |path|
+        test_include true, 'bpm_libs.js', *path
+      end
+      
+      js_dev.each do |path|
+        test_include(should_include, 'bpm_libs.js', *path)
+      end
+      
+      css_dev.each do |path|
+        test_include(should_include, 'bpm_styles.css', *path)
+      end
+    end
+    
+    it "building in debug mode" do
+      bpm 'rebuild', '--mode=debug'
+      wait
+      
+      test_development_dependencies true
+    end
+
+    it "building in production mode" do
+      bpm 'rebuild', '--mode=production'
+      wait
+      
+      test_development_dependencies false
+    end
+    
+  end
+  
+  describe "update" do
+    
+    before do
+      goto_home
+      set_host
+      start_fake(FakeGemServer.new)
+      FileUtils.cp_r project_fixture('needs_rake'), '.'
+      cd home('needs_rake')
+    end
+  
+    it "should not update dependencies with no-update if they can be met" do
+      bpm 'fetch', 'rake', '--version=0.8.6' and wait
+      bpm 'rebuild', '--no-update', '--verbose'
+      out = stdout.read
+      out.should_not include('Fetching packages from remote...')
+      out.should include("'rake' (0.8.6)")
+    end
+
+    it "should update dependencies without no-update if they can be met" do
+      bpm 'fetch', 'rake', '--version=0.8.6' and wait
+      bpm 'rebuild', '--update', '--verbose'
+      out = stdout.read
+      out.should include('Fetching packages from remote...')
+      out.should include("'rake' (0.8.7)")
+    end
+
+    it "should update dependencies with no-update if they cannot be met" do
+      bpm 'rebuild', '--no-update', '--verbose'
+      out = stdout.read
+      out.should include('Fetching packages from remote...')
+      out.should include("'rake' (0.8.7)")
+    end
+    
+  end
+  
+  describe "error conditions" do
+    
+    before do
+      goto_home
+      set_host
+      start_fake(FakeGemServer.new)
+      FileUtils.cp_r(project_fixture('hello_dev'), '.')
+      cd home('hello_dev')
+    end
+      
+    it "should automatically recover if packages are damaged" do
+      bpm 'rebuild' and wait 
+      out = stdout.read
+      out.should include('~ Building bpm_libs.js')
+      
+      FileUtils.rm_r home('.bpm') # delete linked directories.
+      bpm 'rebuild', '--verbose', :track_stderr => true
+      err = stderr.read
+      err.should_not include('Could not find eligible')
+    end
+  end
+      
+end

data/spec/cli/remove_spec.rb

@@ -7,15 +7,14 @@ describe 'bpm remove' do
     goto_home
     set_host
     start_fake(FakeGemServer.new)
-    FileUtils.cp_r(fixtures('hello_world'), '.')
+    FileUtils.cp_r(project_fixture('hello_world'), '.')
     cd home('hello_world')
-    bpm 'compile' # make sure existing packages are installed 
+    bpm 'fetch' # make sure existing packages are installed 
     wait
   end
   
   it "should remove direct dependency from project" do
     bpm 'remove', 'spade'
-    wait
     
     output = stdout.read
     output.should include("Removed package 'spade'")
@@ -79,6 +78,6 @@ describe 'bpm remove' do
     File.exists?(home('hello_world', 'packages', 'custom_package', 'package.json')).should be_true
   end
   
-  it "should verify working with config-less projects"
+  it "should remove development dependencies"
   
 end

data/spec/cli/unpack_spec.rb

@@ -6,7 +6,7 @@ describe "bpm unpack" do
   end
 
   it "builds a gem from a given package.json" do
-    FileUtils.cp fixtures("coffee-1.0.1.pre.bpkg"), "."
+    FileUtils.cp fixtures('gems', "coffee-1.0.1.pre.bpkg"), "."
     bpm "unpack", "coffee-1.0.1.pre.bpkg"
 
     exit_status.should be_success
@@ -22,7 +22,7 @@ describe "bpm unpack" do
   end
 
   it "can unpack to a different directory" do
-    FileUtils.cp fixtures("coffee-1.0.1.pre.bpkg"), "."
+    FileUtils.cp fixtures('gems', "coffee-1.0.1.pre.bpkg"), "."
     bpm "unpack", "coffee-1.0.1.pre.bpkg", "--target", "star/bucks"
 
     exit_status.should be_success
@@ -33,8 +33,8 @@ describe "bpm unpack" do
   end
 
   it "can unpack more than one package" do
-    FileUtils.cp fixtures("coffee-1.0.1.pre.bpkg"), "."
-    FileUtils.cp fixtures("jquery-1.4.3.bpkg"), "."
+    FileUtils.cp fixtures('gems', "coffee-1.0.1.pre.bpkg"), "."
+    FileUtils.cp fixtures('gems', "jquery-1.4.3.bpkg"), "."
     bpm "unpack", "coffee-1.0.1.pre.bpkg", "jquery-1.4.3.bpkg"
 
     exit_status.should be_success
@@ -49,7 +49,7 @@ describe "bpm unpack" do
   it "shows a friendly error message if bpm can't write to the given directory" do
     FileUtils.mkdir_p(home("bad"))
     cd(home("bad"))
-    FileUtils.cp fixtures("jquery-1.4.3.bpkg"), "."
+    FileUtils.cp fixtures('gems', "jquery-1.4.3.bpkg"), "."
     FileUtils.chmod 0555, "."
     bpm "unpack", "jquery-1.4.3.bpkg", :track_stderr => true
 
@@ -60,7 +60,7 @@ describe "bpm unpack" do
   end
 
   it "shows a friendly error message if bpm can't read the package" do
-    FileUtils.cp fixtures("jquery-1.4.3.bpkg"), "."
+    FileUtils.cp fixtures('gems', "jquery-1.4.3.bpkg"), "."
     FileUtils.chmod 0000, "jquery-1.4.3.bpkg"
     bpm "unpack", "jquery-1.4.3.bpkg", :track_stderr => true
 

data/spec/fixtures/packages/core-test/extras/extra_file.html

@@ -0,0 +1,3 @@
+<html>
+EXTRA FILE
+</html>

data/spec/fixtures/packages/core-test/index.html

@@ -0,0 +1,3 @@
+<html>
+MAIN INDEX.HTML
+</html>

data/spec/fixtures/{core-test → packages/core-test}/package.json

@@ -22,7 +22,7 @@
 
   "directories": {
     "lib": "./lib",
-    "resources": "./resources",
+    "resources": "resources",
     "tests": "./tests"
   },
 
@@ -37,8 +37,14 @@
     "optparse": "= 1.0.1"
   },
   
-  "pipeline": {
-    "css": ["resources"]
+  "bpm:build": {
+    "bpm_styles.css": {
+      "directories": ["resources"]
+    },
+    
+    "core-test": {
+      "assets": ["index.html", "extras"]
+    }
   }
 }
 

data/spec/fixtures/packages/invalid_json/package.json

@@ -0,0 +1,3 @@
+{
+  "name": 'foo',
+}