bp3-activeadmin 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 635a4a2c2a9466d8e3669f7b4f388564db6b786571a6d84da3ba9de860f6ca78
-  data.tar.gz: 37f8d4b7a21ff7e817b74dc18f217c5330de5adf3c8b35deba7b751828f3d840
+  metadata.gz: 65ba710517022adea3ee5fcda381918ea3bdf46f7b888682b1f3b13ce6d0ef0f
+  data.tar.gz: 21034d1c5ef08a4cf3fe531148c8563fa402cdb3d8126a8cf35142951c307503
 SHA512:
-  metadata.gz: 55fb2da785ddf845ecd3b8e4d29d736d9432b4654de299fa52642d478c920cfb16b921572acbc46a04171b3608f1975be579f332271d961a519d0994b982a2b2
-  data.tar.gz: 425583b554d9cc34728fa37ff7591cb58cb2070962aefc44848a21673488500d975b69f4d2edb8f83a0278ad7b4e403d17ffcea733b330d11c1e53921a78d9f8
+  metadata.gz: c74c7384d5e8c33ee9a24bee1c201c66c3f4dda905a720228da4a6469266dfc9c4e7b3c872f1859a26ed9bb9b5c1247c467200e929b0b27fbb9072d0dee2b977
+  data.tar.gz: 976e099a624f2e5b0697227246bd7b52aa9987146fa3cd2a635b00af129c43e0584e9baa8673ec6ad75e8e767a043ba55b9a049794f7f30f461b362c8869ec91

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.2.1] - 2026-10-30
+
+### Security
+
+- Answer `EXPLORE` through `Bp3::Core::Ransackable` on `ActiveAdmin::Comment`, whose own class methods
+  otherwise allowed every column and association to it
+- Require bp3-core 0.4.0, for `Bp3::Core::Ransackable::EXPLORE`
+
 ## [0.2.0] - 2026-01-12
 
 - Update activeadmin gem dependency to 4.0.0.beta16

data/CLAUDE.md

@@ -0,0 +1,52 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+bp3-activeadmin adapts `activeadmin` (4.x) for BP3 (persuavis/black_phoebe_3), a multi-site multi-tenant
+Rails application. It keeps ActiveAdmin's default filters inside what each model allows ransack to search.
+
+## Commands
+
+The gems run on Ruby 3.4.6 (`.ruby-version`). Prefix commands with `~/.rvm/bin/rvm 3.4.6 do` when the
+shell is not already on it; a missing `rspec` means the wrong Ruby, not a missing bundle.
+
+- `bundle exec rake` - specs and RuboCop (the default task)
+- `bundle exec rspec spec/path/to/file_spec.rb[:LINE]` - one file or example
+- `bundle exec rubocop` / `bundle exec rubocop -a`
+- `bin/setup`, `bin/console`, `rake install`
+
+## Architecture
+
+`lib/bp3/activeadmin/railtie.rb` runs in an `after_initialize` block:
+
+- prepends `PrependResourceExtension` to `ActiveAdmin::Filters::ResourceExtension`, so `default_filters`
+  keeps only the fields in `resource_class.ransackable_fields(auth_object)` (from `Bp3::Core::Ransackable`)
+- `auth_object` is the configured request state class sent the configured method
+- includes `Bp3::Core::Ransackable` in `ActiveAdmin::Comment`
+
+**Configuration** (`lib/bp3/activeadmin.rb`): `Bp3::Activeadmin.global_request_state_class_name` and
+`.global_request_state_method`. The application's `config/initializers/bp3-activeadmin.rb` sets them to
+`'GlobalRequestState'` and `:current_login` (the README's example still shows `:highest_privilege`).
+
+The entry file is `lib/bp3-active_admin.rb`, not `lib/bp3-activeadmin.rb`; Bundler's autorequire finds
+`bp3/activeadmin` instead.
+
+## Testing
+
+The spec only checks the version; the Railtie needs a Rails application with ActiveAdmin to exercise. Try a
+change against the application (black_phoebe_3) by putting this repo's `lib` ahead of the bundled gem.
+
+## Code Style
+
+- RuboCop (`.rubocop.yml`): target Ruby 3.2.2, NewCops, rubocop-rake and rubocop-rspec; AbcSize 26,
+  MethodLength 15, BlockLength 66, ModuleLength 150; `Lint/ConstantDefinitionInBlock` and `Lint/Void`
+  are off for `lib/bp3/**/railtie.rb`, where classes are reopened inside a block
+- Every file starts with `# frozen_string_literal: true`
+- American English; no trailing whitespace on any added or modified line
+
+## Release
+
+Bump `lib/bp3/activeadmin/version.rb` and add a `CHANGELOG.md` entry. `rake release` tags, pushes and
+publishes to rubygems.org; leave releasing and committing to the user.

data/Gemfile.lock

@@ -1,18 +1,18 @@
 PATH
   remote: .
   specs:
-    bp3-activeadmin (0.2.0)
+    bp3-activeadmin (0.2.1)
       activeadmin (>= 4.0.0.beta16)
       activesupport (~> 8.1)
-      bp3-core (>= 0.1.0)
+      bp3-core (>= 0.4.0)
       bp3-request_state (>= 0.1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (8.1.2)
-      actionview (= 8.1.2)
-      activesupport (= 8.1.2)
+    actionpack (8.1.4)
+      actionview (= 8.1.4)
+      activesupport (= 8.1.4)
       nokogiri (>= 1.8.5)
       rack (>= 2.2.4)
       rack-session (>= 1.0.1)
@@ -20,28 +20,28 @@ GEM
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
       useragent (~> 0.16)
-    actionview (8.1.2)
-      activesupport (= 8.1.2)
+    actionview (8.1.4)
+      activesupport (= 8.1.4)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    activeadmin (4.0.0.beta19)
+    activeadmin (4.0.0.beta23)
       arbre (~> 2.0)
       csv
-      formtastic (>= 5.0)
+      formtastic (>= 6.0)
       formtastic_i18n (>= 0.7)
       inherited_resources (~> 2.0)
       kaminari (>= 1.2.1)
-      railties (>= 7.0)
+      railties (>= 7.2)
       ransack (>= 4.0)
-    activemodel (8.1.2)
-      activesupport (= 8.1.2)
-    activerecord (8.1.2)
-      activemodel (= 8.1.2)
-      activesupport (= 8.1.2)
+    activemodel (8.1.4)
+      activesupport (= 8.1.4)
+    activerecord (8.1.4)
+      activemodel (= 8.1.4)
+      activesupport (= 8.1.4)
       timeout (>= 0.4.0)
-    activesupport (8.1.2)
+    activesupport (8.1.4)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
@@ -58,8 +58,8 @@ GEM
       activesupport (>= 7.0)
     ast (2.4.3)
     base64 (0.3.0)
-    bigdecimal (4.0.1)
-    bp3-core (0.2.0)
+    bigdecimal (4.1.3)
+    bp3-core (0.4.0)
       actionview (~> 8.1)
       activesupport (~> 8.1)
       bp3-request_state (~> 0.1)
@@ -68,73 +68,71 @@ GEM
       activesupport (~> 8.1)
       request_store (>= 1.5.1)
     builder (3.3.0)
-    concurrent-ruby (1.3.6)
+    concurrent-ruby (1.3.8)
     connection_pool (3.0.2)
-    crass (1.0.6)
-    csv (3.3.5)
-    date (3.5.1)
+    crass (1.0.8)
+    csv (3.3.7)
     diff-lcs (1.6.2)
     drb (2.2.3)
-    erb (6.0.1)
+    erb (6.0.7)
     erubi (1.13.1)
-    formtastic (5.0.0)
-      actionpack (>= 6.0.0)
+    formtastic (6.0.0)
+      actionpack (>= 7.2.0)
     formtastic_i18n (0.7.0)
     has_scope (0.9.0)
       actionpack (>= 7.0)
       activesupport (>= 7.0)
-    i18n (1.14.8)
+    i18n (1.15.2)
       concurrent-ruby (~> 1.0)
     inherited_resources (2.1.0)
       actionpack (>= 7.0)
       has_scope (>= 0.6)
       railties (>= 7.0)
       responders (>= 2)
-    io-console (0.8.2)
-    irb (1.16.0)
+    io-console (0.9.5)
+    irb (1.18.0)
       pp (>= 0.6.0)
+      prism (>= 1.3.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.18.0)
-    kaminari (1.2.2)
+    json (3.1.0)
+    kaminari (1.3.2)
       activesupport (>= 4.1.0)
-      kaminari-actionview (= 1.2.2)
-      kaminari-activerecord (= 1.2.2)
-      kaminari-core (= 1.2.2)
-    kaminari-actionview (1.2.2)
+      kaminari-actionview (= 1.3.2)
+      kaminari-activerecord (= 1.3.2)
+      kaminari-core (= 1.3.2)
+    kaminari-actionview (1.3.2)
       actionview
-      kaminari-core (= 1.2.2)
-    kaminari-activerecord (1.2.2)
+      kaminari-core (= 1.3.2)
+    kaminari-activerecord (1.3.2)
       activerecord
-      kaminari-core (= 1.2.2)
-    kaminari-core (1.2.2)
-    language_server-protocol (3.17.0.5)
+      kaminari-core (= 1.3.2)
+    kaminari-core (1.3.2)
+    language_server-protocol (3.17.0.6)
     lint_roller (1.1.0)
     logger (1.7.0)
-    loofah (2.25.0)
+    loofah (2.25.2)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
-    minitest (6.0.1)
+    minitest (6.0.6)
+      drb (~> 2.0)
       prism (~> 1.5)
-    nokogiri (1.19.0-x86_64-darwin)
+    nokogiri (1.19.4-x86_64-darwin)
       racc (~> 1.4)
-    parallel (1.27.0)
-    parser (3.3.10.0)
+    parallel (2.3.0)
+    parser (3.3.13.0)
       ast (~> 2.4.1)
       racc
-    pp (0.6.3)
+    pp (0.6.4)
       prettyprint
-    prettyprint (0.2.0)
-    prism (1.7.0)
-    psych (5.3.1)
-      date
-      stringio
+    prettyprint (0.2.1)
+    prism (1.9.0)
     racc (1.8.1)
-    rack (3.2.4)
-    rack-session (2.1.1)
+    rack (3.2.8)
+    rack-session (2.1.2)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
-    rack-test (2.2.0)
+    rack-test (2.3.0)
       rack (>= 1.3)
     rackup (2.3.1)
       rack (>= 3)
@@ -142,12 +140,12 @@ GEM
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.6.2)
-      loofah (~> 2.21)
+    rails-html-sanitizer (1.7.1)
+      loofah (~> 2.25, >= 2.25.2)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    railties (8.1.2)
-      actionpack (= 8.1.2)
-      activesupport (= 8.1.2)
+    railties (8.1.4)
+      actionpack (= 8.1.4)
+      activesupport (= 8.1.4)
       irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
@@ -155,21 +153,26 @@ GEM
       tsort (>= 0.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.3.1)
-    ransack (4.4.1)
+    rake (13.4.2)
+    ransack (6.0.1)
       activerecord (>= 7.2)
       activesupport (>= 7.2)
       i18n
-    rdoc (7.0.3)
+    rbs (4.2.0)
+      logger
+      prism (>= 1.6.0)
+      tsort
+    rdoc (8.1.0)
       erb
-      psych (>= 4.0.0)
+      prism (>= 1.6.0)
+      rbs (>= 4.0.0)
       tsort
-    regexp_parser (2.11.3)
-    reline (0.6.3)
+    regexp_parser (2.13.1)
+    reline (0.7.0)
       io-console (~> 0.5)
     request_store (1.7.0)
       rack (>= 1.4)
-    responders (3.2.0)
+    responders (3.2.1)
       actionpack (>= 7.0)
       railties (>= 7.0)
     rspec (3.13.2)
@@ -181,44 +184,44 @@ GEM
     rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.7)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.6)
-    rubocop (1.82.1)
-      json (~> 2.3)
+    rspec-support (3.13.7)
+    rubocop (1.92.2)
+      json (>= 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
-      parallel (~> 1.10)
+      parallel (>= 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.48.0, < 2.0)
+      regexp_parser (>= 2.11.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.0)
+    rubocop-ast (1.50.0)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-rspec (3.9.0)
+    rubocop-rspec (3.10.2)
       lint_roller (~> 1.1)
-      rubocop (~> 1.81)
+      regexp_parser (>= 2.0)
+      rubocop (~> 1.86, >= 1.86.2)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
-    stringio (3.2.0)
     thor (1.5.0)
-    timeout (0.6.0)
+    timeout (0.6.1)
     tsort (0.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.2.0)
-      unicode-emoji (~> 4.1)
-    unicode-emoji (4.2.0)
-    uri (1.1.1)
+    unicode-display_width (3.3.0)
+      unicode-emoji (~> 4.3)
+    unicode-emoji (4.3.0)
+    uri (1.1.2)
     useragent (0.16.11)
-    zeitwerk (2.7.4)
+    zeitwerk (2.8.3)
 
 PLATFORMS
   x86_64-darwin-22

data/bp3-activeadmin.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'activeadmin', '>= 4.0.0.beta16'
   spec.add_dependency 'activesupport', '~> 8.1'
-  spec.add_dependency 'bp3-core', '>= 0.1.0'
+  spec.add_dependency 'bp3-core', '>= 0.4.0'
   spec.add_dependency 'bp3-request_state', '>= 0.1.0'
 
   # spec.add_development_dependency 'bp3-core' # TODO: make this work

data/lib/bp3/activeadmin/railtie.rb

@@ -32,6 +32,20 @@ module Bp3
 
             class Comment
               include Bp3::Core::Ransackable
+
+              # ActiveAdmin defines these on the class itself, which beats anything included, so its
+              # answers stand only for plain ransack and Ransackable still answers EXPLORE
+              def self.ransackable_attributes(auth_object = nil)
+                return super if auth_object == Bp3::Core::Ransackable::EXPLORE
+
+                authorizable_ransackable_attributes
+              end
+
+              def self.ransackable_associations(auth_object = nil)
+                return super if auth_object == Bp3::Core::Ransackable::EXPLORE
+
+                authorizable_ransackable_associations
+              end
             end
           end
         end

data/lib/bp3/activeadmin/version.rb

@@ -2,6 +2,6 @@
 
 module Bp3
   module Activeadmin
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bp3-activeadmin
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Wim den Braven
@@ -43,14 +43,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: bp3-request_state
   requirement: !ruby/object:Gem::Requirement
@@ -145,6 +145,7 @@ files:
 - ".rubocop.yml"
 - ".yardopts"
 - CHANGELOG.md
+- CLAUDE.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -179,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.4
 specification_version: 4
 summary: bp3-activeadmin adapts activeadmin for BP3 (persuavis/black_phoebe_3).
 test_files: []