boxt_ruby_style_guide 7.9.2 → 8.1.1

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f80925ef4cebf042e32849792ad200553a71646704fba299a502940649b66cd4
4
- data.tar.gz: 672f8b91fc0218521b17f5857235eef8eede17ba4c7812f4e4a9253030df079c
3
+ metadata.gz: d342b30c9d107524c439828930d57a34b29355c0ca9bfce83f1f12ff2d3f08f4
4
+ data.tar.gz: d428132967e63831de2eb5ddda35d873e9e78316b482b76f747a6f622a5eeb7a
5
5
  SHA512:
6
- metadata.gz: efac4d096f3d5772db668628c832a9df08e4e3756d2c62a7915063b9233b0ffa06768da9bebd92bc62053cdeadaae129bbd11d2f15c43c896eb1bd24a3020d55
7
- data.tar.gz: e13776ce69c0bbd8102f41a9259d89dac66dcf5a7728960fbd3686352b14791e61032486680bf3fbc4aaa6372779bec78219a75fdaefa94e065f5d905a748fa0
6
+ metadata.gz: 7487afef0b1259174029e494e7beb8ac161a3cbe028562d849cf304a6481f44a4d6a0e8fa7b693e86ee15739be0ecab5665e50421d61885e0d3000945361fa64
7
+ data.tar.gz: 6a1dd12b5cbc83f2832f5f1fc550eeb882e27f2e3f68b9254e481aa3f2336271a1d51ba7e260bca3534021240f94754fe4af441ff265acc25cc4ee3eceff8612
data/README.md CHANGED
@@ -31,12 +31,13 @@ Add a `.rubocop.yml` file to the root of your project with the following setting
31
31
  inherit_gem:
32
32
  boxt_ruby_style_guide:
33
33
  - default.yml # use default cops
34
- - pending.yml # use pending cops
35
34
  - rails.yml # use Rails cops - see Additional Extensions/Cops
36
- - rails-pending.yml # use pending rails cops
37
- - rspec.yml # use rspec cops
35
+ - rspec.yml # use rspec cops - see Additional Extensions/Cops
38
36
  ```
39
37
 
38
+ ### NewCops
39
+
40
+ `NewCops` is enabled by default.
40
41
  ### Additional Extensions/Cops
41
42
 
42
43
  The following Rubocop gems are also installed with this gem:
data/VERSION CHANGED
@@ -1 +1 @@
1
- 7.9.2
1
+ 8.1.1
data/default.yml CHANGED
@@ -1,11 +1,12 @@
1
1
  AllCops:
2
2
  Exclude:
3
- - "**/*/schema.rb"
4
- - "Gemfile.lock"
5
- - "node_modules/**/*"
6
- - "tmp/**/*"
7
- - "vendor/**/*"
8
- TargetRubyVersion: 2.7.2
3
+ - '**/*/schema.rb'
4
+ - Gemfile.lock
5
+ - node_modules/**/*
6
+ - tmp/**/*
7
+ - vendor/**/*
8
+ NewCops: enable
9
+ TargetRubyVersion: 3.0.1
9
10
  Layout/LineLength:
10
11
  Exclude:
11
12
  - config/routes.rb
@@ -15,7 +16,7 @@ Metrics/AbcSize:
15
16
  - db/migrate/**/*
16
17
  Metrics/BlockLength:
17
18
  Exclude:
18
- - "*.gemspec"
19
+ - '*.gemspec'
19
20
  - Gemfile
20
21
  - config/routes.rb
21
22
  - db/migrate/**/*
@@ -24,9 +24,7 @@ module BoxtRubyStyleGuide
24
24
  #
25
25
  # Returns Array
26
26
  def all
27
- @all ||= begin
28
- git.diff(base).name_status.select { |_, stat| TEST_STATUSES.include?(stat) }.keys
29
- end
27
+ @all ||= git.diff(base).name_status.select { |_, stat| TEST_STATUSES.include?(stat) }.keys
30
28
  end
31
29
 
32
30
  private
data/rails.yml CHANGED
@@ -1,39 +1,15 @@
1
- Rails/ActiveRecordCallbacksOrder:
2
- Enabled: true
3
- Rails/AfterCommitOverride:
4
- Enabled: true
5
1
  Rails/ApplicationController:
6
2
  Exclude:
7
3
  - spec/**/*
8
4
  - test/**/*
9
- Rails/FindById:
10
- Enabled: true
11
- Rails/Inquiry:
12
- Enabled: true
13
- Rails/MailerName:
14
- Enabled: true
15
- Rails/MatchRoute:
16
- Enabled: true
17
- Rails/NegateInclude:
18
- Enabled: true
19
- Rails/Pluck:
20
- Enabled: true
21
- Rails/PluckInWhere:
22
- Enabled: true
23
- Rails/RenderInline:
24
- Enabled: true
25
- Rails/RenderPlainText:
26
- Enabled: true
27
- Rails/ShortI18n:
28
- Enabled: true
5
+ Rails/EnvironmentVariableAccess:
6
+ AllowReads: true # Enabling allow reads so we can use ENV["VAR"]
29
7
  Rails/SkipsModelValidations:
30
8
  Exclude:
31
9
  - db/migrate/**/*
32
10
  - lib/tasks/**/*
33
11
  - spec/**/*
34
12
  - test/**/*
35
- Rails/SquishedSQLHeredocs:
36
- Enabled: true
37
13
  Rails/UnknownEnv:
38
14
  Environments:
39
15
  - cucumber
@@ -42,7 +18,3 @@ Rails/UnknownEnv:
42
18
  - qa
43
19
  - test
44
20
  - uat
45
- Rails/WhereExists:
46
- Enabled: true
47
- Rails/WhereNot:
48
- Enabled: true
data/rspec.yml CHANGED
@@ -1 +1,9 @@
1
- # Rspec specific cops
1
+ # Disabling as we set up the rake specs as 'describe "rake namespace:task", type: :task do' which determines what task
2
+ # is being tested, and this cop doesn't like having a describe block without a class or module name.
3
+ RSpec/DescribeClass:
4
+ Exclude:
5
+ - spec/tasks/**/*
6
+ # This is to prevent Rubocop from bugging on a spec helper that doesn't contain an example, which the tasks ones don't
7
+ RSpec/LeadingSubject:
8
+ Exclude:
9
+ - spec/support
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: boxt_ruby_style_guide
3
3
  version: !ruby/object:Gem::Version
4
- version: 7.9.2
4
+ version: 8.1.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Boxt
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2021-02-16 00:00:00.000000000 Z
11
+ date: 2021-06-15 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: git
@@ -30,14 +30,14 @@ dependencies:
30
30
  requirements:
31
31
  - - '='
32
32
  - !ruby/object:Gem::Version
33
- version: 1.10.0
33
+ version: 1.16.1
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - '='
39
39
  - !ruby/object:Gem::Version
40
- version: 1.10.0
40
+ version: 1.16.1
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rubocop-faker
43
43
  requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
58
58
  requirements:
59
59
  - - '='
60
60
  - !ruby/object:Gem::Version
61
- version: 2.9.1
61
+ version: 2.10.1
62
62
  type: :runtime
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
66
  - - '='
67
67
  - !ruby/object:Gem::Version
68
- version: 2.9.1
68
+ version: 2.10.1
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: rubocop-rake
71
71
  requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
86
86
  requirements:
87
87
  - - '='
88
88
  - !ruby/object:Gem::Version
89
- version: 2.2.0
89
+ version: 2.4.0
90
90
  type: :runtime
91
91
  prerelease: false
92
92
  version_requirements: !ruby/object:Gem::Requirement
93
93
  requirements:
94
94
  - - '='
95
95
  - !ruby/object:Gem::Version
96
- version: 2.2.0
96
+ version: 2.4.0
97
97
  description: Ruby styleguide info for the BOXT projects, as well as config settings
98
98
  for Rubocop
99
99
  email:
@@ -113,8 +113,6 @@ files:
113
113
  - lib/boxt_ruby_style_guide/railtie.rb
114
114
  - lib/boxt_ruby_style_guide/version.rb
115
115
  - lib/tasks/lint.rake
116
- - pending.yml
117
- - rails-pending.yml
118
116
  - rails.yml
119
117
  - rspec.yml
120
118
  homepage: https://github.com/boxt/ruby-style-guide
@@ -129,14 +127,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
129
127
  requirements:
130
128
  - - ">="
131
129
  - !ruby/object:Gem::Version
132
- version: '2.7'
130
+ version: '3.0'
133
131
  required_rubygems_version: !ruby/object:Gem::Requirement
134
132
  requirements:
135
133
  - - ">="
136
134
  - !ruby/object:Gem::Version
137
135
  version: '0'
138
136
  requirements: []
139
- rubygems_version: 3.1.4
137
+ rubygems_version: 3.2.15
140
138
  signing_key:
141
139
  specification_version: 4
142
140
  summary: Ruby styleguide info for the BOXT Ruby projects
data/pending.yml DELETED
@@ -1,103 +0,0 @@
1
- # These cops are currently pending and will be enabled by default at some point, but adding for now to stop Rubocop
2
- # or VSCode complaining...
3
- AllCops:
4
- NewCops: enable
5
- # Layout/BeginEndAlignment: # (new in 0.91)
6
- # Enabled: true
7
- # Layout/EmptyLinesAroundAttributeAccessor: # (new in 0.83)
8
- # Enabled: true
9
- # Layout/SpaceAroundMethodCallOperator: # (new in 0.82)
10
- # Enabled: true
11
- # Lint/BinaryOperatorWithIdenticalOperands: # (new in 0.89)
12
- # Enabled: true
13
- # Lint/ConstantDefinitionInBlock: # (new in 0.91)
14
- # Enabled: true
15
- # Lint/DeprecatedOpenSSLConstant: # (new in 0.84)
16
- # Enabled: true
17
- # Lint/DuplicateElsifCondition: # (new in 0.88)
18
- # Enabled: true
19
- # Lint/DuplicateRequire: # (new in 0.90)
20
- # Enabled: true
21
- # Lint/DuplicateRescueException: # (new in 0.89)
22
- # Enabled: true
23
- # Lint/EmptyConditionalBody: # (new in 0.89)
24
- # Enabled: true
25
- # Lint/EmptyFile: # (new in 0.90)
26
- # Enabled: true
27
- # Lint/FloatComparison: # (new in 0.89)
28
- # Enabled: true
29
- # Lint/IdentityComparison: # (new in 0.91)
30
- # Enabled: true
31
- # Lint/MissingSuper: # (new in 0.89)
32
- # Enabled: true
33
- # Lint/MixedRegexpCaptureTypes: # (new in 0.85)
34
- # Enabled: true
35
- # Lint/OutOfRangeRegexpRef: # (new in 0.89)
36
- # Enabled: true
37
- # Lint/RaiseException: # (new in 0.81)
38
- # Enabled: true
39
- # Lint/SelfAssignment: # (new in 0.89)
40
- # Enabled: true
41
- # Lint/StructNewOverride: # (new in 0.81)
42
- # Enabled: true
43
- # Lint/TopLevelReturnWithArgument: # (new in 0.89)
44
- # Enabled: true
45
- # Lint/TrailingCommaInAttributeDeclaration: # (new in 0.90)
46
- # Enabled: true
47
- # Lint/UnreachableLoop: # (new in 0.89)
48
- # Enabled: true
49
- # Lint/UselessMethodDefinition: # (new in 0.90)
50
- # Enabled: true
51
- # Lint/UselessTimes: # (new in 0.91)
52
- # Enabled: true
53
- # Style/AccessorGrouping: # (new in 0.87)
54
- # Enabled: true
55
- # Style/ArrayCoercion: # (new in 0.88)
56
- # Enabled: true
57
- # Style/BisectedAttrAccessor: # (new in 0.87)
58
- # Enabled: true
59
- # Style/CaseLikeIf: # (new in 0.88)
60
- # Enabled: true
61
- # Style/CombinableLoops: # (new in 0.90)
62
- # Enabled: true
63
- # Style/ExplicitBlockArgument: # (new in 0.89)
64
- # Enabled: true
65
- # Style/ExponentialNotation: # (new in 0.82)
66
- # Enabled: true
67
- # Style/GlobalStdStream: # (new in 0.89)
68
- # Enabled: true
69
- # Style/HashAsLastArrayItem: # (new in 0.88)
70
- # Enabled: true
71
- # Style/HashEachMethods: # (new in 0.80)
72
- # Enabled: true
73
- # Style/HashLikeCase: # (new in 0.88)
74
- # Enabled: true
75
- # Style/HashTransformKeys: # (new in 0.80)
76
- # Enabled: true
77
- # Style/HashTransformValues: # (new in 0.80)
78
- # Enabled: true
79
- # Style/KeywordParametersOrder: # (new in 0.90)
80
- # Enabled: true
81
- # Style/OptionalBooleanParameter: # (new in 0.89)
82
- # Enabled: true
83
- # Style/RedundantAssignment: # (new in 0.87)
84
- # Enabled: true
85
- # Style/RedundantFetchBlock: # (new in 0.86)
86
- # Enabled: true
87
- # Style/RedundantFileExtensionInRequire: # (new in 0.88)
88
- # Enabled: true
89
- # Style/RedundantRegexpCharacterClass: # (new in 0.85)
90
- # Enabled: true
91
- # Style/RedundantRegexpEscape: # (new in 0.85)
92
- # Enabled: true
93
- # Style/RedundantSelfAssignment: # (new in 0.90)
94
- # Enabled: true
95
- # Style/SingleArgumentDig: # (new in 0.89)
96
- # Enabled: true
97
- # Style/SlicingWithRange: # (new in 0.83)
98
- # Enabled: true
99
- # Style/SoleNestedConditional: # (new in 0.89)
100
- # Enabled: true
101
- # Style/StringConcatenation: # (new in 0.89)
102
- # Enabled: true
103
- # For more information: https://docs.rubocop.org/rubocop/versioning.html
data/rails-pending.yml DELETED
@@ -1,32 +0,0 @@
1
- # These cops are currently pending and will be enabled by default at some point, but adding for now to stop Rubocop
2
- # or VSCode complaining...
3
- Rails/ActiveRecordCallbacksOrder:
4
- Enabled: true
5
- Rails/AfterCommitOverride:
6
- Enabled: true
7
- Rails/FindById:
8
- Enabled: true
9
- Rails/Inquiry:
10
- Enabled: true
11
- Rails/MailerName:
12
- Enabled: true
13
- Rails/MatchRoute:
14
- Enabled: true
15
- Rails/NegateInclude:
16
- Enabled: true
17
- Rails/Pluck:
18
- Enabled: true
19
- Rails/PluckInWhere:
20
- Enabled: true
21
- Rails/RenderInline:
22
- Enabled: true
23
- Rails/RenderPlainText:
24
- Enabled: true
25
- Rails/ShortI18n:
26
- Enabled: true
27
- Rails/SquishedSQLHeredocs:
28
- Enabled: true
29
- Rails/WhereExists:
30
- Enabled: true
31
- Rails/WhereNot:
32
- Enabled: true