boxt_ruby_style_guide 7.3.0 → 7.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db37fda2704f058428f66ef3227058dc67c4abd08df1829c5674ff827079bbf6
-  data.tar.gz: 90302060b3ae806b43f4cce6165744e6b5af59566176dffbc878875a876038c9
+  metadata.gz: 00a10b1e139e15aa28f133847e8a102bba235fd15840b8da636cc2658cbbd821
+  data.tar.gz: '0683e861cc45e0177b5e9f96c4ac05e47ae77b99314978463fa9178da217277d'
 SHA512:
-  metadata.gz: 5e2bcb595827b288a7d6f9d068ff46036f25fc93bd3e39f3f481d8e5eb6ddbe94f23f65dd8554383cfc009dc4ff9ecf19d00a6564aa45181af77971660826bf3
-  data.tar.gz: 147a875753ac204afb7b063f00e10047ec7ef1c8a39c28827ded7d2515b0f6076c418a1e11fb9b3c2ab2a93b2220200bc573fa04f96c9523bf545a90b1f4e223
+  metadata.gz: 65c4b44b3a1eb0077bcaf1dc2be3035439fd7b9b0771409f1b02483ac81f5d2b744768f6901206e600f9cbb3fec0743ef585e52f89fabac58250ebcfc44b6891
+  data.tar.gz: 3d3b1cc9df23483d023e55b1029e47d98cfdc62982c366f8992b5ef6ee95077f216f9368498447d478c9ebe7530cd7e2e1fb94c5147702c706409e369a2f8ed1

data/Rakefile

@@ -4,7 +4,7 @@ require "bundler/gem_tasks"
 require "rake/testtask"
 require "rspec/core/rake_task"
 
-import "./tasks/lint.rake"
+import "lib/tasks/lint.rake"
 
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.pattern = Dir.glob("spec/**/*_spec.rb")

data/VERSION

@@ -1 +1 @@
-7.3.0
+7.4.0

data/lib/boxt_ruby_style_guide.rb

@@ -4,17 +4,13 @@ require "boxt_ruby_style_guide/railtie" if defined?(Rails)
 require "boxt_ruby_style_guide/version"
 
 module BoxtRubyStyleGuide
-  class << self
-    def install_tasks
-      Dir[File.join(gem_spec.gem_dir, "tasks/*.rake")].each do |file|
-        load(file)
-      end
-    end
+  module_function
 
-    private
-
-    def gem_spec
-      Gem::Specification.find_by_name("boxt_ruby_style_guide")
-    end
+  ##
+  # Provide a root path helper for the gem root dir
+  #
+  # Returns Pathname
+  def root
+    Pathname.new(File.dirname(__dir__))
   end
 end

data/lib/boxt_ruby_style_guide/railtie.rb

@@ -5,7 +5,7 @@ require "rails"
 module BoxtRubyStyleGuide
   class Railtie < Rails::Railtie
     rake_tasks do
-      files = File.join(File.dirname(__FILE__), "../../tasks/*.rake")
+      files = BoxtRubyStyleGuide.root.join("lib", "tasks", "*.rake")
       Dir[files].each { |file| load(file) }
     end
   end

data/lib/tasks/lint.rake

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+require "boxt_ruby_style_guide"
+require "rubocop"
+
+##
+# The base branch to compare HEAD with for changes
+BASE_BRANCH = "develop"
+
+##
+# Directories containing Ruby files to lint
+RUBY_DIRS = %w[app lib test spec].freeze
+
+##
+# Grep file pattern to make sure we only check files that are Ruby files
+# This pattern matches the following:
+#
+# - Gemfile
+# - Rakefile
+# - *.gemspec
+# - app/**/*.{rb,rake}
+# - lib/**/*.{rb,rake}
+# - test/**/*.{rb,rake}
+# - spec/**/*.{rb,rake}
+#
+GREP_PATTERN = <<~STRING.delete("\n")
+  (
+    (#{RUBY_DIRS.join('|')})\\/.+\\.(rb|rake)
+    |^
+    (Gemfile|Rakefile|.+\\.gemspec)
+  )
+STRING
+
+namespace :lint do
+  desc "Runs rubocop against all files with committed changes different from base branch"
+  task :rubocop do
+    exec("rubocop #{diff_file_paths};")
+  end
+
+  private
+
+  # A list of the local file paths of Ruby files with committed changes.
+  #
+  #   Run a git diff-tree command with the following otions:
+  #     -r recursive
+  #     --name-only Only return the name of the files
+  #     --diff-filter Filter out results that have been deleted on HEAD
+  #
+  #   Pipe the output from this command through grep to match only Ruby files in the
+  #     desired directories
+  #
+  # Returns String
+  def diff_file_paths
+    base_branch = ENV.fetch("RUBOCOP_LINT_BASE", BASE_BRANCH)
+    command = <<~BASH
+      git diff-tree -r --name-only --diff-filter=d #{base_branch} HEAD \
+        | egrep '#{GREP_PATTERN}'
+    BASH
+    file_paths = `#{command}`
+    file_paths.gsub(/\n|\r/, " ")
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: boxt_ruby_style_guide
 version: !ruby/object:Gem::Version
-  version: 7.3.0
+  version: 7.4.0
 platform: ruby
 authors:
 - Boxt
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-28 00:00:00.000000000 Z
+date: 2020-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.92.0
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: rubocop-faker
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.19'
 description: Ruby styleguide info for the BOXT projects, as well as config settings
   for Rubocop
 email:
@@ -152,6 +166,7 @@ files:
 - lib/boxt_ruby_style_guide.rb
 - lib/boxt_ruby_style_guide/railtie.rb
 - lib/boxt_ruby_style_guide/version.rb
+- lib/tasks/lint.rake
 - pending.yml
 - rails-pending.yml
 - rails.yml