boxgrinder-build 0.9.3 → 0.9.4

data/spec/managers/plugin-manager-spec.rb

@@ -17,6 +17,7 @@
 # 02110-1301 USA, or see the FSF site: http://www.fsf.org.
 
 require 'rubygems'
+require 'rspec'
 require 'boxgrinder-build/managers/plugin-manager'
 
 module BoxGrinder

data/spec/plugins/base-plugin-spec.rb

@@ -17,6 +17,7 @@
 # 02110-1301 USA, or see the FSF site: http://www.fsf.org.
 
 require 'rubygems'
+require 'rspec'
 require 'boxgrinder-build/plugins/base-plugin'
 require 'boxgrinder-core/helpers/log-helper'
 require 'yaml'
@@ -99,7 +100,6 @@ module BoxGrinder
 
         File.should_receive(:exists?).once.with(any_args()).and_return(true)
         File.should_receive(:exists?).once.with(any_args()).and_return(false)
-        File.should_not_receive(:exists?)
 
         @plugin.deliverables_exists?.should == false
       end

data/spec/plugins/delivery/ebs/ebs-plugin-spec.rb

@@ -16,11 +16,12 @@
 # Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
 # 02110-1301 USA, or see the FSF site: http://www.fsf.org.
 
+require 'boxgrinder-build/plugins/delivery/ebs/ebs-plugin'
 require 'rubygems'
+require 'rspec'
 require 'ostruct'
 require 'logger'
-require 'boxgrinder-build/plugins/delivery/ebs/ebs-plugin'
-require 'hashery/opencascade'
+require 'set'
 
 module BoxGrinder
 
@@ -37,7 +38,7 @@ module BoxGrinder
       @config = Config.new('plugins' => { 'ebs' => {
         'access_key' => 'access_key',
         'secret_access_key' => 'secret_access_key',
-        'account_number' => '0000-0000-0000'
+        'account_number' => '000000000000'
       }})
 
       @appliance_config = mock('ApplianceConfig')
@@ -58,7 +59,21 @@ module BoxGrinder
           :log => LogHelper.new(:level => :trace, :type => :stdout)
       )
 
+      #Set convenient dummies
+      AWS.config({:access_key_id => '', :secret_access_key => ''})
+      @ec2 = AWS::EC2.new
+      @s3 = AWS::S3.new
+      @s3helper = S3Helper.new(@ec2, @s3)
+      @ec2helper = EC2Helper.new(@ec2)
+
+      @plugin.instance_variable_set(:@ec2, @ec2)
+      @plugin.instance_variable_set(:@s3, @s3)
+      @plugin.instance_variable_set(:@ec2helper, @ec2helper)
+      @plugin.instance_variable_set(:@s3helper, @s3helper)
+
       @plugin_config = @config.plugins['ebs']
+
+      @plugin.instance_variable_set(:@plugin_config, @plugin_config)
     end
 
     it "should register all operating systems with specific versions" do
@@ -69,288 +84,184 @@ module BoxGrinder
       supported_oses = @plugin.instance_variable_get(:@supported_oses)
 
       supported_oses.size.should == 3
-      supported_oses.keys.sort.should == ['fedora', 'rhel', 'centos'].sort
+      Set.new(supported_oses.keys).should == Set.new(['fedora', 'rhel', 'centos'])
       supported_oses['rhel'].should == ['6']
       supported_oses['fedora'].should == ['13', '14', '15']
       supported_oses['centos'].should == ['5']
     end
-
-    describe ".after_init" do
-      it "should set the region" do
-        prepare_plugin do |plugin|
-          plugin.instance_variable_set(:@current_availability_zone, 'us-east-1a')
-        end
-
-        @plugin.instance_variable_get(:@region).should == 'us-east-1'
-      end
-    end
-
-    describe '.ami_info' do
-
-      it "should check if image is already registered and return false if there are no images registered for this account" do
-        prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
-        plugin_config = mock('PluginConfig')
-        plugin_config.should_receive(:[]).with('account_number').and_return('0000-0000-0000')
-
-        @plugin.instance_variable_set(:@plugin_config, plugin_config)
-
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).with(:owner_id => '000000000000')
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-
-        @plugin.ami_info('aname').should == false
-      end
-
-      it "should check if image is already registered and return false if there are no images with name aname_new" do
-        prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
-        plugin_config = mock('PluginConfig')
-        plugin_config.should_receive(:[]).with('account_number').and_return('0000-0000-0000')
-
-        @plugin.instance_variable_set(:@plugin_config, plugin_config)
-
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).with(:owner_id => '000000000000').and_return({'imagesSet' => {'item' => [{'name' => 'abc', 'imageId' => '1'}, {'name' => 'aname', 'imageId' => '2'}]}})
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-
-        @plugin.ami_info('aname_new').should == false
-      end
-
-      it "should return valid AMI information map for a single matching image when a valid imageId exists" do
-        prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
-        plugin_config = mock('PluginConfig')
-        plugin_config.should_receive(:[]).with('account_number').and_return('0000-0000-0000')
-
-        @plugin.instance_variable_set(:@plugin_config, plugin_config)
-
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).with(:owner_id => '000000000000').and_return({'imagesSet' => {'item' => [{'name' => 'abc', 'imageId' => '1'}, {'name' => 'aname', 'imageId' => '2'}]}})
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-
-        @plugin.ami_info('aname').should == {'name' => 'aname', 'imageId' => '2'}
-      end
-
-    end
-
-    describe '.already_registered?' do
-
-      it "should check if image is already registered and return true image is registered" do
-        prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
-        plugin_config = mock('PluginConfig')
-        plugin_config.should_receive(:[]).with('account_number').and_return('0000-0000-0000')
-
-        @plugin.instance_variable_set(:@plugin_config, plugin_config)
-
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).with(:owner_id => '000000000000').and_return({'imagesSet' => {'item' => [{'name' => 'abc', 'imageId' => '1'}, {'name' => 'aname', 'imageId' => '2'}]}})
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-
-        @plugin.already_registered?('aname').should == '2'
-      end
-
-    end
-
+    #
     it "should adjust fstab" do
       prepare_plugin { |plugin| plugin.stub!(:after_init) }
 
       guestfs = mock('GuestFS')
-
       guestfs.should_receive(:sh).with("cat /etc/fstab | grep -v '/mnt' | grep -v '/data' | grep -v 'swap' > /etc/fstab.new")
       guestfs.should_receive(:mv).with("/etc/fstab.new", "/etc/fstab")
 
       @plugin.adjust_fstab(guestfs)
     end
+    #
 
-    it "should get a new free device" do
-      prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
-      File.should_receive(:exists?).with("/dev/sdf").and_return(false)
-      File.should_receive(:exists?).with("/dev/xvdf").and_return(false)
+    describe '.free_device_suffix' do
+      it "should get a new free device" do
+        prepare_plugin { |plugin| plugin.stub!(:after_init) }
 
-      @plugin.free_device_suffix.should == "f"
-    end
+        File.should_receive(:exists?).with("/dev/sdf").and_return(false)
+        File.should_receive(:exists?).with("/dev/xvdf").and_return(false)
 
-    it "should get a new free device next in order" do
-      prepare_plugin { |plugin| plugin.stub!(:after_init) }
+        @plugin.free_device_suffix.should == "f"
+      end
+      #
+      it "should get a new free device next in order" do
+        prepare_plugin { |plugin| plugin.stub!(:after_init) }
 
-      File.should_receive(:exists?).with("/dev/sdf").and_return(false)
-      File.should_receive(:exists?).with("/dev/xvdf").and_return(true)
-      File.should_receive(:exists?).with("/dev/sdg").and_return(false)
-      File.should_receive(:exists?).with("/dev/xvdg").and_return(false)
+        File.should_receive(:exists?).with("/dev/sdf").and_return(false)
+        File.should_receive(:exists?).with("/dev/xvdf").and_return(true)
+        File.should_receive(:exists?).with("/dev/sdg").and_return(false)
+        File.should_receive(:exists?).with("/dev/xvdg").and_return(false)
 
-      @plugin.free_device_suffix.should == "g"
+        @plugin.free_device_suffix.should == "g"
+      end
     end
-
+    #
     describe ".valid_platform?" do
       it "should return true if on EC2" do
         prepare_plugin do |plugin|
           plugin.stub!(:after_init)
-          plugin.stub!(:get_ec2_availability_zone).and_return("eu-west-1a")
-          plugin.stub!(:availability_zone_to_region).and_return("eu-west-1")
+          @plugin.instance_variable_set(:@ec2_endpoints, EC2Helper::endpoints)
+          EC2Helper::stub!(:current_availability_zone).and_return('eu-west-1a')
+          EC2Helper::stub!(:availability_zone_to_region).with('eu-west-1a').and_return('eu-west-1')
         end
         @plugin.valid_platform?.should == true
       end
-
+    #
       it "should return false if NOT on EC2" do
         prepare_plugin do |plugin|
           plugin.stub!(:after_init)
-          plugin.stub!(:get_ec2_availability_zone).and_raise(Timeout::Error)
+          @plugin.instance_variable_set(:@ec2_endpoints, EC2Helper::endpoints)
+          EC2Helper::stub!(:current_availability_zone).and_raise(Timeout::Error)
         end
         @plugin.valid_platform?.should == false
       end
-
-      it "should return false if the EC2 zone returned is not supported" do
-        prepare_plugin do |plugin|
-          plugin.stub!(:after_init)
-          plugin.stub!(:get_ec2_availability_zone).and_return("moon-west-7a")
-          plugin.stub!(:availability_zone_to_region).and_return("moon-west-7")
-        end
-        @plugin.valid_platform?.should == false
-      end
-
+    #
     end
-
+    #
     describe ".ebs_appliance_name" do
       it "should return basic appliance name" do
         prepare_plugin { |plugin| plugin.stub!(:after_init) }
         @plugin.ebs_appliance_name.should == "appliance_name/fedora/14/1.0/x86_64"
       end
-
+    #
       it "should always return basic appliance name when overwrite is enabled, but snapshot is disabled" do
         prepare_plugin { |plugin| plugin.stub!(:after_init) }
         @plugin_config.merge!('overwrite' => true, 'snapshot' => false)
         @plugin.ebs_appliance_name.should == "appliance_name/fedora/14/1.0/x86_64"
       end
-
+    #
       it "should still return a valid _initial_ snapshot appliance name, even if overwrite and snapshot are enabled on first ever run" do
         prepare_plugin { |plugin| plugin.stub!(:after_init) }
-
         @plugin_config.merge!('overwrite' => true, 'snapshot' => true)
 
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).once.with(:owner_id => '000000000000').and_return(nil)#should be nothing
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-
+        @ec2helper.should_receive(:already_registered?).with("appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64")
         @plugin.ebs_appliance_name.should == "appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64"
       end
-
+    #
       it "should return 2nd snapshot of appliance" do
         prepare_plugin { |plugin| plugin.stub!(:after_init) }
 
         @plugin_config.merge!('snapshot' => true)
 
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).twice.with(:owner_id => '000000000000').and_return({'imagesSet' => {'item' => [
-            {'imageId' => '1', 'name' => 'appliance_name/fedora/14/1.0/x86_64'},
-            {'imageId' => '2', 'name' => 'appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64'}
-        ]}})
-
-        @plugin.instance_variable_set(:@ec2, ec2)
+        @ec2helper.should_receive(:already_registered?).with("appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64").and_return(true)
+        @ec2helper.should_receive(:already_registered?).with("appliance_name/fedora/14/1.0-SNAPSHOT-2/x86_64").and_return(false)
 
         @plugin.ebs_appliance_name.should == "appliance_name/fedora/14/1.0-SNAPSHOT-2/x86_64"
       end
-
+    #
       it "should return the last snapshot name again when OVERWRITE is enabled" do
         prepare_plugin { |plugin| plugin.stub!(:after_init) }
 
         @plugin_config.merge!('snapshot' => true, 'overwrite' => true)
 
-        ec2 = mock('EC2')
-        ec2.should_receive(:describe_images).twice.with(:owner_id => '000000000000').and_return({'imagesSet' => {'item' => [
-            {'imageId' => '1', 'name' => 'appliance_name/fedora/14/1.0/x86_64'},
-            {'imageId' => '2', 'name' => 'appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64'}
-        ]}})
-
-        @plugin.instance_variable_set(:@ec2, ec2)
+        @ec2helper.should_receive(:already_registered?).with("appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64").and_return(true)
+        @ec2helper.should_receive(:already_registered?).with("appliance_name/fedora/14/1.0-SNAPSHOT-2/x86_64").and_return(false)
 
         @plugin.ebs_appliance_name.should == "appliance_name/fedora/14/1.0-SNAPSHOT-1/x86_64"
       end
-
+    #
     end
-
+    #
     describe ".stomp_ebs" do
-
       before(:each) do
-        @ami_info =  recursive_ostruct({'imageId' => 'sleepy', 'blockDeviceMapping' => {'item' => [{'deviceName' => '/dev/sda1', 'ebs' => {'snapshotId' => 'bashful'}}]}})
-        @dummy_instances = recursive_ostruct([{'instanceId' => 'grumpy'},
-                             {'instanceId' => 'sneezy'}])
-        @dummy_snapshot = recursive_ostruct({'snapshotId' => 'bashful', 'volumeId' => 'snow-white'})
-        @dummy_volume_attached = recursive_ostruct({'volumeId' => 'snow-white', 'status' => 'attached'})
-        @dummy_volume_detached = recursive_ostruct({'volumeId' => 'snow-white', 'status' => 'detached'})
+        prepare_plugin
+
+        @ami = mock(AWS::EC2::Image)
+        @ami.stub!(:id).and_return('ami-bratwurst')
+        @ami.stub!(:deregister)
+        @ami.stub!(:block_device_mappings).and_return({'/dev/sda1' => OpenStruct.new(
+                {'snapshot_id' => 'snap-hambiscuit', 'volume_size' => 2})}
+        )
+        @ami.stub!(:root_device_name).and_return('/dev/sda1')
+        instance_1 = mock(AWS::EC2::Instance)
+        instance_2 = mock(AWS::EC2::Instance)
+        instance_1.stub!(:id).and_return('i-cake')
+        instance_1.stub!(:status).and_return(:running)
+        instance_2.stub!(:id).and_return('i-bake')
+        instance_2.stub!(:status).and_return(:stopped)
+
+        @instances = [ instance_1, instance_2 ]
+
+        @snap = mock(AWS::EC2::Snapshot)
       end
 
-      it "should return false if there was no block device found" do
-        prepare_plugin do |plugin|
-          plugin.stub!(:after_init)
-          plugin.stub!(:block_device_from_ami).and_return(nil)
-        end
-        @plugin.stomp_ebs(@ami_info).should == false
+      it "destroys the preexisting EBS assets and de-registers the image with default settings" do
+        @ec2helper.stub!(:live_instances)
+        @ec2helper.should_receive(:snapshot_by_id).with('snap-hambiscuit').and_return(@snap)
+        @ami.should_receive(:deregister)
+        @ec2helper.should_receive(:wait_for_image_death).with(@ami)
+        @snap.should_receive(:delete)
+        @plugin.stomp_ebs(@ami)
       end
 
-
-      it "should throw an exception if there is still an EBS instance[s] running when an overwrite is requested" do
-        prepare_plugin do |plugin|
-          plugin.stub!(:after_init)
-          plugin.stub!(:snapshot_info).and_return(@dummy_snapshot)
-          plugin.stub!(:get_instances).and_return(@dummy_instances)
-          plugin.stub!(:get_volume_info).and_return(nil)
+      context "there are live running instances" do
+        before(:each) do
+          @ec2helper.stub!(:snapshot_by_id).and_return(@snap)
+          @ec2helper.stub!(:wait_for_image_death)
+          @ec2helper.stub!(:snapshot_by_id)
+          @ec2helper.stub!(:wait_for_image_death)
+          @ami.stub!(:deregister)
+          @snap.stub!(:delete)
         end
-       lambda { @plugin.stomp_ebs(@ami_info) }.should raise_error(RuntimeError)
-      end
 
-      it "should detach and delete the block store, remove the snapshot and deregister the image" do
-        prepare_plugin do |plugin|
-          plugin.stub!(:after_init)
-          plugin.stub!(:snapshot_info).and_return(@dummy_snapshot)
-          plugin.stub!(:get_instances).and_return(false)
-          plugin.stub!(:get_volume_info).and_return(@dummy_volume_attached, @dummy_volume_detached)
-          plugin.stub!(:wait_for_volume_delete)
-          plugin.stub!(:wait_for_snapshot_status)
-          plugin.stub!(:wait_for_volume_status)
+        context "instance termination is disabled" do
+          it "raise an error to alert the user" do
+            @ec2helper.should_receive(:live_instances).with(@ami).and_return(@instances)
+            lambda { @plugin.stomp_ebs(@ami) }.should raise_error(RuntimeError)
+          end
         end
 
-        ec2 = mock('EC2')
-        ec2.should_receive(:detach_volume).with(:volume_id => 'snow-white', :force => true)
-        ec2.should_receive(:delete_volume).with(:volume_id => 'snow-white')
-        ec2.should_receive(:deregister_image).with(:image_id => 'sleepy')
-        ec2.should_receive(:delete_snapshot).with(:snapshot_id => 'bashful')
-
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-        @plugin.stomp_ebs(@ami_info)
+        context "instance termination is enabled" do
+          it "terminate any running instances" do
+            @plugin_config.merge!('terminate_instances' => true)
+            @ec2helper.should_receive(:live_instances).with(@ami).and_return(@instances)
+            @plugin.should_receive(:terminate_instances).with(@instances)
+            @plugin.stomp_ebs(@ami)
+          end
+        end
       end
 
-      it "should not delete AWS snapshots when preserve_snapshots is set" do
-        prepare_plugin do |plugin|
-          plugin.stub!(:after_init)
-          plugin.stub!(:snapshot_info).and_return(@dummy_snapshot)
-          plugin.stub!(:get_instances).and_return(false)
-          plugin.stub!(:get_volume_info).and_return(@dummy_volume_attached, @dummy_volume_detached)
-          plugin.stub!(:wait_for_volume_delete)
-          plugin.stub!(:wait_for_snapshot_status)
-          plugin.stub!(:wait_for_volume_status)
+      context "snapshot preservation" do
+        before(:each) do
+          @ec2helper.stub!(:live_instances).and_return(false)
         end
 
-        @plugin_config.merge!('preserve_snapshots' => true)
-
-        ec2 = mock('EC2')
-        ec2.should_receive(:detach_volume).with(:volume_id => 'snow-white', :force => true)
-        ec2.should_receive(:delete_volume).with(:volume_id => 'snow-white')
-        ec2.should_receive(:deregister_image).with(:image_id => 'sleepy')
-        ec2.should_not_receive(:delete_snapshot).with(:snapshot_id => 'bashful')
-
-        @plugin.instance_variable_set(:@ec2, ec2)
-        @plugin.stomp_ebs(@ami_info)
+        it "retains the primary snapshot when preserve_snapshots is enabled" do
+          @plugin_config.merge!('preserve_snapshots' => true)
+          @ec2helper.should_receive(:snapshot_by_id).with('snap-hambiscuit').and_return(@snap)
+          @ami.should_receive(:deregister)
+          @ec2helper.should_receive(:wait_for_image_death).with(@ami)
+          @snap.should_not_receive(:delete)
+          @plugin.stomp_ebs(@ami)
+        end
       end
-
     end
 
     #Amazon-EC2 gem uses recursive ostructs, and wont work with opencascade