boxgrinder-build 0.9.2 → 0.9.3

data/spec/plugins/delivery/local/local-plugin-spec.rb

@@ -24,11 +24,7 @@ module BoxGrinder
   describe LocalPlugin do
 
     before(:each) do
-      @config = mock('Config')
-      @config.stub!(:delivery_config).and_return({})
-      plugins = mock('Plugins')
-      plugins.stub!(:[]).with('local').and_return({})
-      @config.stub!(:[]).with(:plugins).and_return(plugins)
+      @config = Config.new('plugins' => {'local' => {'path' => 'a/path'}})
 
       @appliance_config = mock('ApplianceConfig')
 
@@ -40,12 +36,14 @@ module BoxGrinder
       @appliance_config.stub!(:hardware).and_return(OpenCascade.new({:arch => 'x86_64'}))
 
       @plugin = LocalPlugin.new.init(@config, @appliance_config,
-                                     :log => Logger.new('/dev/null'),
-                                     :plugin_info => {:class => BoxGrinder::LocalPlugin, :type => :delivery, :name => :local, :full_name => "Local file system"},
-                                     :previous_deliverables => {:disk => "a_disk.raw", :metadata => 'metadata.xml'}
+                                     {:class => BoxGrinder::LocalPlugin, :type => :delivery, :name => :local, :full_name => "Local file system"},
+                                     :log => LogHelper.new(:level => :trace, :type => :stdout),
+                                     :previous_plugin => OpenCascade.new(:deliverables => {:disk => "a_disk.raw", :metadata => 'metadata.xml'})
       )
 
-      @config = @plugin.instance_variable_get(:@config)
+      @plugin.validate
+
+      @plugin_config = @config.plugins['local']
       @appliance_config = @plugin.instance_variable_get(:@appliance_config)
       @exec_helper = @plugin.instance_variable_get(:@exec_helper)
       @log = @plugin.instance_variable_get(:@log)
@@ -53,32 +51,19 @@ module BoxGrinder
     end
 
     describe ".execute" do
-
       it "should package and deliver the appliance" do
-        @plugin.instance_variable_set(:@plugin_config, {
-            'overwrite' => false,
-            'path' => 'a/path',
-            'package' => true
-        })
-
+        @plugin_config.merge!('package' => true)
+  
         FileUtils.should_receive(:mkdir_p).with('a/path')
         package_helper = mock(PackageHelper)
-        package_helper.should_receive(:package).with('.', "build/path/local-plugin/tmp/appliance-1.0-fedora-13-x86_64-raw.tgz").and_return("deliverable")
-
         PackageHelper.should_receive(:new).with(@config, @appliance_config, :log => @log, :exec_helper => @exec_helper).and_return(package_helper)
-
-        @exec_helper.should_receive(:execute).with("cp 'build/path/local-plugin/tmp/appliance-1.0-fedora-13-x86_64-raw.tgz' 'a/path'")
-        @plugin.should_receive(:deliverables_exists?).and_return(false)
+        package_helper.should_receive(:package).with('.', "a/path/appliance-1.0-fedora-13-x86_64-raw.tgz").and_return("deliverable")
 
         @plugin.execute
       end
 
       it "should not package, but deliver the appliance" do
-        @plugin.instance_variable_set(:@plugin_config, {
-            'overwrite' => true,
-            'path' => 'a/path',
-            'package' => false
-        })
+        @plugin_config.merge!('package' => false) 
 
         FileUtils.should_receive(:mkdir_p).with('a/path')
         PackageHelper.should_not_receive(:new)
@@ -107,10 +92,7 @@ module BoxGrinder
 
     describe ".deliverables_exists?" do
       it "should return true for package" do
-        @plugin.instance_variable_set(:@plugin_config, {
-            'path' => 'a/path',
-            'package' => true
-        })
+        @plugin_config.merge!('package' => true)
 
         File.should_receive(:exists?).with('a/path/appliance-1.0-fedora-13-x86_64-raw.tgz').and_return(true)
 
@@ -118,10 +100,7 @@ module BoxGrinder
       end
 
       it "should return true for non-packaged appliance" do
-        @plugin.instance_variable_set(:@plugin_config, {
-            'path' => 'a/path',
-            'package' => false
-        })
+        @plugin_config.merge!('package' => false)
 
         File.should_receive(:exists?).with('a/path/a_disk.raw').and_return(true)
         File.should_receive(:exists?).with('a/path/metadata.xml').and_return(true)

data/spec/plugins/delivery/s3/s3-plugin-spec.rb

@@ -19,20 +19,24 @@
 require 'rubygems'
 require 'boxgrinder-build/plugins/delivery/s3/s3-plugin'
 require 'hashery/opencascade'
-# TODO remove this when it'll become not necessary
-# quick fix for old active_support require issue in EPEL 5
-require 'active_support/basic_object'
-require 'active_support/duration'
+require 'boxgrinder-core/models/config'
 
 module BoxGrinder
   describe S3Plugin do
 
     before(:each) do
-      @config = mock('Config')
-      @config.stub!(:delivery_config).and_return({})
-      plugins = mock('Plugins')
-      plugins.stub!(:[]).with('s3').and_return({})
-      @config.stub!(:[]).with(:plugins).and_return(plugins)
+      @config = Config.new(
+          'plugins' => {
+              's3' => {
+                  'access_key' => 'access_key',
+                  'secret_access_key' => 'secret_access_key',
+                  'bucket' => 'bucket',
+                  'account_number' => '0000-0000-0000',
+                  'cert_file' => '/path/to/cert/file',
+                  'key_file' => '/path/to/key/file',
+                  'path' => '/'
+              }
+          })
 
       @appliance_config = mock('ApplianceConfig')
 
@@ -43,37 +47,23 @@ module BoxGrinder
       @appliance_config.stub!(:os).and_return(OpenCascade.new({:name => 'fedora', :version => '14'}))
       @appliance_config.stub!(:hardware).and_return(OpenCascade.new({:arch => 'x86_64', :base_arch => 'x86_64'}))
 
-      @plugin = S3Plugin.new.init(@config, @appliance_config, :log => Logger.new('/dev/null'), :plugin_info => {:class => BoxGrinder::S3Plugin, :type => :delivery, :name => :s3, :full_name => "Amazon Simple Storage Service (Amazon S3)", :types => [:s3, :cloudfront, :ami]})
+      @plugin = S3Plugin.new.init(@config, @appliance_config, {:class => BoxGrinder::S3Plugin, :type => :delivery, :name => :s3, :full_name => "Amazon Simple Storage Service (Amazon S3)", :types => [:s3, :cloudfront, :ami]}, :log => LogHelper.new(:level => :trace, :type => :stdout), :type => :s3)
+      @plugin.validate
 
-      @config = @plugin.instance_variable_get(:@config)
       @appliance_config = @plugin.instance_variable_get(:@appliance_config)
       @exec_helper = @plugin.instance_variable_get(:@exec_helper)
       @log = @plugin.instance_variable_get(:@log)
       @dir = @plugin.instance_variable_get(:@dir)
-
-      @plugin_config = @plugin.instance_variable_get(:@plugin_config).merge(
-          {
-              'access_key' => 'access_key',
-              'secret_access_key' => 'secret_access_key',
-              'bucket' => 'bucket',
-              'account_number' => '0000-0000-0000',
-              'cert_file' => '/path/to/cert/file',
-              'key_file' => '/path/to/key/file',
-              'path' => '/'
-          }
-      )
-
-      @plugin.instance_variable_set(:@plugin_config, @plugin_config)
-
     end
 
     it "should register all operating systems with specific versions" do
       supportes_oses = @plugin.instance_variable_get(:@supported_oses)
 
-      supportes_oses.size.should == 3
-      supportes_oses.keys.sort.should == ['centos', 'fedora', 'rhel']
+      supportes_oses.size.should == 4
+      supportes_oses.keys.sort.should == ['centos', 'fedora', 'rhel', 'sl']
       supportes_oses['centos'].should == ['5']
       supportes_oses['rhel'].should == ['5', '6']
+      supportes_oses['sl'].should == ['5', '6']
       supportes_oses['fedora'].should == ['13', '14', '15']
     end
 
@@ -95,7 +85,8 @@ module BoxGrinder
       end
 
       it "should generate valid ami_key with snapshot number two" do
-        @plugin_config.merge!('snapshot' => true)
+        @config.plugins['s3'].merge!('snapshot' => true)
+        
         bucket = mock('Bucket')
         bucket.should_receive(:keys).twice
 
@@ -113,8 +104,27 @@ module BoxGrinder
         @plugin.ami_key("name", "/").should == "name/fedora/14/1.0-SNAPSHOT-2/x86_64"
       end
 
-      it "should generate valid ami_key with snapshot when bucket doesn't exists" do
-        @plugin_config.merge!('snapshot' => true)
+      it "should return valid ami_key with snapshot and overwrite enabled" do
+        @config.plugins['s3'].merge!('snapshot' => true, 'overwrite' => true)
+        bucket = mock('Bucket')
+        bucket.should_receive(:keys).twice
+
+        key = mock('Key')
+        key.should_receive(:exists?).and_return(true)
+
+        key1 = mock('Key')
+        key1.should_receive(:exists?).and_return(false)
+
+        bucket.should_receive(:key).with("name/fedora/14/1.0-SNAPSHOT-1/x86_64/").and_return(key)
+        bucket.should_receive(:key).with("name/fedora/14/1.0-SNAPSHOT-2/x86_64/").and_return(key1)
+
+        @plugin.should_receive(:bucket).twice.with(false).and_return(bucket)
+        # Re-use the last key again
+        @plugin.ami_key("name", "/").should == "name/fedora/14/1.0-SNAPSHOT-1/x86_64"
+      end
+
+      it "should generate valid ami_key with snapshot when bucket doesn't exist" do
+        @config.plugins['s3'].merge!('snapshot' => true)
         @plugin.should_receive(:bucket).with(false).and_raise('ABC')
         @plugin.ami_key("name", "/").should == "name/fedora/14/1.0-SNAPSHOT-1/x86_64"
       end
@@ -144,7 +154,7 @@ module BoxGrinder
       @plugin.instance_variable_set(:@s3, s3)
 
       key = mock('Key')
-      key.should_receive(:exists?).and_return(false)
+      key.should_receive(:exists?).twice.and_return(false)
       key.should_receive(:put).with('abc', 'private', :server => 's3.amazonaws.com')
 
       bucket = mock('Bucket')
@@ -191,7 +201,7 @@ module BoxGrinder
       @plugin.bundle_image(:disk => "a/path/to/disk.ec2")
     end
 
-    it "should bundle the image for centos 5 anf choose right kernel and ramdisk" do
+    it "should bundle the image for centos 5 and choose right kernel and ramdisk" do
       @appliance_config.stub!(:os).and_return(OpenCascade.new({:name => 'centos', :version => '5'}))
 
       File.should_receive(:exists?).with('build/path/s3-plugin/ami').and_return(false)
@@ -210,10 +220,10 @@ module BoxGrinder
 
     describe ".execute" do
       it "should create AMI" do
+        @plugin.instance_variable_set(:@type, :ami)
+
         @plugin.instance_variable_set(:@previous_deliverables, {:disk => 'a/disk'})
 
-        @plugin.should_receive(:validate_plugin_config).with(["bucket", "access_key", "secret_access_key"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
-        @plugin.should_receive(:validate_plugin_config).with(["cert_file", "key_file", "account_number"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
         @plugin.should_receive(:ami_key).with("appliance", "/").and_return('ami/key')
         @plugin.should_receive(:s3_object_exists?).with("ami/key/appliance.ec2.manifest.xml").and_return(false)
         @plugin.should_receive(:bundle_image).with(:disk => 'a/disk')
@@ -221,25 +231,24 @@ module BoxGrinder
         @plugin.should_receive(:upload_image)
         @plugin.should_receive(:register_image)
 
-        @plugin.execute(:ami)
+        @plugin.execute
       end
 
       it "should not upload AMI because it's already there" do
-        @plugin.should_receive(:validate_plugin_config).with(["bucket", "access_key", "secret_access_key"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
-        @plugin.should_receive(:validate_plugin_config).with(["cert_file", "key_file", "account_number"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
+        @plugin.instance_variable_set(:@type, :ami)
+
         @plugin.should_receive(:ami_key).with("appliance", "/").and_return('ami/key')
         @plugin.should_receive(:s3_object_exists?).with("ami/key/appliance.ec2.manifest.xml").and_return(true)
         @plugin.should_not_receive(:upload_image)
         @plugin.should_receive(:register_image)
 
-        @plugin.execute(:ami)
+        @plugin.execute
       end
 
       it "should upload AMI even if it's already there because we want a snapshot" do
-        @plugin_config.merge!('snapshot' => true)
+        @config.plugins['s3'].merge!('snapshot' => true)
 
-        @plugin.should_receive(:validate_plugin_config).with(["bucket", "access_key", "secret_access_key"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
-        @plugin.should_receive(:validate_plugin_config).with(["cert_file", "key_file", "account_number"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
+        @plugin.instance_variable_set(:@type, :ami)
 
         @plugin.should_receive(:ami_key).with("appliance", "/").and_return('ami/key')
         @plugin.should_receive(:s3_object_exists?).with("ami/key/appliance.ec2.manifest.xml").and_return(true)
@@ -248,25 +257,72 @@ module BoxGrinder
         @plugin.should_receive(:upload_image).with("ami/key")
         @plugin.should_receive(:register_image).with("ami/key/appliance.ec2.manifest.xml")
 
-        @plugin.execute(:ami)
+        @plugin.execute
       end
 
       it "should upload image to s3" do
+        @plugin.instance_variable_set(:@type, :s3)
         @plugin.instance_variable_set(:@previous_deliverables, :disk => 'a/disk')
         @plugin.should_receive(:upload_to_bucket).with({:disk => 'a/disk'})
-        @plugin.execute(:s3)
+        @plugin.execute
       end
 
-      it "should upload image to cludfront" do
+      it "should upload image to cloudfront" do
+        @plugin.instance_variable_set(:@type, :cloudfront)
         @plugin.instance_variable_set(:@previous_deliverables, {:disk => 'a/disk'})
         @plugin.should_receive(:upload_to_bucket).with({:disk => 'a/disk'}, 'public-read')
-        @plugin.execute(:cloudfront)
+        @plugin.execute
+      end
+    end
+
+    describe ".validate" do
+
+      it "should validate only basic params" do
+        @plugin.should_receive(:set_default_config_value).with('overwrite', false)
+        @plugin.should_receive(:set_default_config_value).with('path', '/')
+        @plugin.should_receive(:set_default_config_value).with('region', 'us-east-1')
+
+        @plugin.should_receive(:validate_plugin_config).with(['bucket', 'access_key', 'secret_access_key'], 'http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin')
+
+        @plugin.validate
+      end
+
+      it "should validate basic and additional ami params" do
+        @plugin.instance_variable_set(:@type, :ami)
+
+        @plugin.should_receive(:set_default_config_value).with('overwrite', false)
+        @plugin.should_receive(:set_default_config_value).with('path', '/')
+        @plugin.should_receive(:set_default_config_value).with('region', 'us-east-1')
+        @plugin.should_receive(:set_default_config_value).with('snapshot', false)
+
+        @plugin.should_receive(:validate_plugin_config).with(['bucket', 'access_key', 'secret_access_key'], 'http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin')
+        @plugin.should_receive(:validate_plugin_config).with(["cert_file", "key_file", "account_number"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
+
+        @plugin.validate
+      end
+
+      it "should raise an error if an invalid region is specified" do
+        @plugin.instance_variable_set(:@type, :ami)
+
+        @config.plugins['s3']['region'] = 'bolkonski'
+
+        @plugin.should_receive(:set_default_config_value).with('overwrite', false)
+        @plugin.should_receive(:set_default_config_value).with('path', '/')
+        @plugin.should_receive(:set_default_config_value).with('region', 'us-east-1')
+        @plugin.should_receive(:set_default_config_value).with('snapshot', false)
+
+        @plugin.should_receive(:validate_plugin_config).with(['bucket', 'access_key', 'secret_access_key'], 'http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin')
+        @plugin.should_receive(:validate_plugin_config).with(["cert_file", "key_file", "account_number"], "http://boxgrinder.org/tutorials/boxgrinder-build-plugins/#S3_Delivery_Plugin")
+
+        lambda { @plugin.validate }.should raise_error(PluginValidationError)
+
       end
+
     end
 
     describe ".bucket" do
       it "should create the bucket" do
-        @plugin_config.merge!('region' => 'ap-southeast-1')
+        @config.plugins['s3'].merge!('region' => 'ap-southeast-1')
         s3 = mock(Aws::S3)
         Aws::S3.should_receive(:new).with("access_key", "secret_access_key", :connection_mode => :single, :logger => @log, :server=>"s3-ap-southeast-1.amazonaws.com").and_return(s3)
         s3.should_receive(:bucket).with("bucket", true, "private", :location => "ap-southeast-1")
@@ -274,7 +330,8 @@ module BoxGrinder
       end
 
       it "should not create the bucket" do
-        @plugin_config.merge!('region' => 'ap-southeast-1')
+        @config.plugins['s3'].merge!('region' => 'ap-southeast-1')
+
         s3 = mock(Aws::S3)
         Aws::S3.should_receive(:new).with("access_key", "secret_access_key", :connection_mode => :single, :logger => @log, :server=>"s3-ap-southeast-1.amazonaws.com").and_return(s3)
         s3.should_receive(:bucket).with("bucket", false, "private", :location => "ap-southeast-1")
@@ -290,7 +347,7 @@ module BoxGrinder
       end
 
       it "should upload image for us-west-1 region" do
-        @plugin_config.merge!('region' => 'us-west-1')
+        @config.plugins['s3'].merge!('region' => 'us-west-1')
 
         @plugin.should_receive(:bucket)
         @exec_helper.should_receive(:execute).with("euca-upload-bundle -U http://s3-us-west-1.amazonaws.com -b bucket/ami/key -m build/path/s3-plugin/ami/appliance.ec2.manifest.xml -a access_key -s secret_access_key", :redacted=>["access_key", "secret_access_key"])
@@ -320,7 +377,7 @@ module BoxGrinder
           @plugin.register_image("ami/manifest/key")
         end
 
-        it "should report the region where the ami is registed" do
+        it "should report the region where the ami is registered" do
           @plugin.instance_variable_get(:@plugin_config)['region'] = 'a-region'
           @plugin.instance_variable_get(:@log).should_receive(:info).with(/a-region/)
 

data/spec/plugins/os/centos/centos-plugin-spec.rb

@@ -34,7 +34,7 @@ module BoxGrinder
       @appliance_config.stub!(:path).and_return(OpenCascade.new({:build => 'build/path'}))
       @appliance_config.stub!(:name).and_return('full')
 
-      @plugin = CentOSPlugin.new.init(@config, @appliance_config, :log => Logger.new('/dev/null'), :plugin_info => {:class => BoxGrinder::CentOSPlugin, :type => :os, :name => :centos, :full_name => "CentOS", :versions => ["5"]})
+      @plugin = CentOSPlugin.new.init(@config, @appliance_config, {:class => BoxGrinder::CentOSPlugin, :type => :os, :name => :centos, :full_name => "CentOS", :versions => ["5"]}, :log => Logger.new('/dev/null'))
     end
 
     it "should use basearch instead of arch in repository URLs" do

data/spec/plugins/os/fedora/fedora-plugin-spec.rb

@@ -39,25 +39,31 @@ module BoxGrinder
       @appliance_config.stub!(:hardware).and_return(OpenCascade.new({:arch => 'x86_64'}))
       @appliance_config.stub!(:is64bit?).and_return(true)
 
-      @plugin = FedoraPlugin.new.init(@config, @appliance_config, :log => Logger.new('/dev/null'), :plugin_info => {:class => BoxGrinder::FedoraPlugin, :type => :os, :name => :fedora, :full_name => "Fedora", :versions => ["11", "12", "13", "14", "rawhide"]})
+      @plugin = FedoraPlugin.new.init(@config, @appliance_config, {:class => BoxGrinder::FedoraPlugin, :type => :os, :name => :fedora, :full_name => "Fedora", :versions => ["11", "12", "13", "14", "rawhide"]}, :log => LogHelper.new(:level => :trace, :type => :stdout))
 
       @config = @plugin.instance_variable_get(:@config)
       @appliance_config = @plugin.instance_variable_get(:@appliance_config)
       @exec_helper = @plugin.instance_variable_get(:@exec_helper)
       @log = @plugin.instance_variable_get(:@log)
-    end
 
-    it "should normalize packages for 32bit for pae enabled system" do
-      packages = ['abc', 'def', 'kernel']
 
-      @appliance_config.should_receive(:is64bit?).and_return(false)
+      @plugin_config = @plugin.instance_variable_get(:@plugin_config).merge(
+          {
+              'access_key' => 'access_key',
+              'secret_access_key' => 'secret_access_key',
+              'bucket' => 'bucket',
+              'account_number' => '0000-0000-0000',
+              'cert_file' => '/path/to/cert/file',
+              'key_file' => '/path/to/key/file'
+          }
+      )
 
-      @plugin.normalize_packages(packages)
-      packages.should == ["abc", "def", "@core", "system-config-firewall-base", "dhclient", "kernel-PAE"]
+      @plugin.instance_variable_set(:@plugin_config, @plugin_config)
     end
 
     it "should normalize packages for 32bit for pae enabled system" do
-      @appliance_config.stub!(:os).and_return(OpenCascade.new(:name => 'fedora', :version => '13', :pae => false))
+      @appliance_config.stub!(:os).and_return(OpenCascade.new(:name => 'fedora', :version => '13'))
+      @plugin_config.merge!('PAE' => false)
 
       packages = ['abc', 'def', 'kernel']
 

data/spec/plugins/os/rhel/rhel-plugin-spec.rb

@@ -37,7 +37,7 @@ module BoxGrinder
       @appliance_config.stub!(:release).and_return(0)
       @appliance_config.stub!(:os).and_return(OpenCascade.new({:name => 'rhel', :version => '6'}))
 
-      @plugin = RHELPlugin.new.init(@config, @appliance_config, :log => Logger.new('/dev/null'), :plugin_info => {:class => BoxGrinder::RHELPlugin, :type => :os, :name => :rhel, :full_name => "Red Hat Enterprise Linux", :versions => ['5', '6']})
+      @plugin = RHELPlugin.new.init(@config, @appliance_config, {:class => BoxGrinder::RHELPlugin, :type => :os, :name => :rhel, :full_name => "Red Hat Enterprise Linux", :versions => ['5', '6']}, :log => LogHelper.new(:level => :trace, :type => :stdout))
 
       @config = @plugin.instance_variable_get(:@config)
       @appliance_config = @plugin.instance_variable_get(:@appliance_config)

data/spec/plugins/os/rpm-based/kickstart-spec.rb

@@ -66,50 +66,6 @@ module BoxGrinder
             ]
         )
 
-        @appliance_config.should_receive(:default_repos).and_return(true)
-
-        definition = @kickstart.build_definition
-
-        definition['repos'].size.should == 4
-
-        definition['repos'][0].should == "repo --name=fedora-11-base --cost=40 --mirrorlist=http://mirrors.fedoraproject.org/mirrorlist?repo=fedora-11&arch=i386"
-        definition['repos'][1].should == "repo --name=fedora-11-updates --cost=41 --mirrorlist=http://mirrors.fedoraproject.org/mirrorlist?repo=updates-released-f11&arch=i386"
-        definition['repos'][2].should == "repo --name=cirras --cost=42 --baseurl=http://repo.boxgrinder.org/packages/fedora/11/RPMS/i686"
-        definition['repos'][3].should == "repo --name=abc --cost=43 --mirrorlist=http://abc.org/packages/fedora/11/RPMS/i686"
-
-        definition['appliance_config'].packages.size.should == 2
-        definition['appliance_config'].packages.should == ["gcc-c++", "wget"]
-
-        definition['appliance_config'].os.password.should == "boxgrinder"
-        definition['appliance_config'].hardware.partitions.size.should == 2
-        definition['appliance_config'].hardware.partitions['/']['size'].should == 2
-        definition['appliance_config'].hardware.partitions['/home']['size'].should == 3
-      end
-
-      it "should prepare valid definition without default repos" do
-        prepare_kickstart(KICKSTART_FEDORA_REPOS)
-
-        @appliance_config.stub!(:hardware).and_return(
-            OpenCascade.new({
-                                :partitions =>
-                                    {
-                                        '/' => {'size' => 2},
-                                        '/home' => {'size' => 3},
-                                    },
-                                :arch => 'i686',
-                                :base_arch => 'i386'
-                            })
-        )
-
-        @appliance_config.should_receive(:default_repos).and_return(false)
-
-        @appliance_config.should_receive(:repos).and_return(
-            [
-                {'name' => 'cirras', 'baseurl' => "http://repo.boxgrinder.org/packages/fedora/11/RPMS/i686"},
-                {'name' => 'abc', 'baseurl' => 'http://abc', 'mirrorlist' => "http://abc.org/packages/fedora/11/RPMS/i686"},
-            ]
-        )
-
         definition = @kickstart.build_definition
 
         definition['repos'].size.should == 2