box_view 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZWQwZTBhYzY4NTBiMjhmZGM2ZTA5MjM2YzY3YTk3NGU0MmJmNDNkMA==
+    MDNiODM0YTdhMjdiMTk4ODg2ZDQ5ZjgzNjdhZTU2M2FmMWNiOTI5ZA==
   data.tar.gz: !binary |-
-    YTAxMDM1NWQ2ZjIyZWVlZmRiYTVmOTMyOGVmY2MzOWFkYzI1ZDI2Mw==
+    NTRhYWVlNmE1MTEzODM0NmE1N2RkN2RhOWI2MDU3OGVjN2NiYWM4OA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    Zjg5M2EyMWJkMTYyNmE2ZjhhMzNhZjBhMDExOTg1Y2RjNjE2MTM5ZTI2Njdi
-    MjcyNWRkMzg5OTNmY2M0OWZkYjA0NzMxMzA3N2NjMjdlMWM5OWJmNDM5M2E4
-    NjVmMmUwYzVkMWJkOTc1Yjg0OTU2NDAxMzJkOWQzMGI1NjI5Nzk=
+    NTBmZjViZmI4YzQwOTI1OGVmNGRkOGY2NzRkM2JhYzZjYjE2MDRjOTEzMTk3
+    NjJmZjExNzIxYjM0NGM5NWQyYmFiZTQ2YTk2ZjU1YjhhZDg2NmY4ZWI3ZWFi
+    MDE3NDExMTg1NWNlODlhYTczZTgxNDg4ZGZiMDU1Y2JkYzJlMDA=
   data.tar.gz: !binary |-
-    M2UyMGY0MWJlNTEyYTE2YWU0ZmNmZTBiMWMyMGEzY2YzNmZmNzBmZjRjMzU0
-    OGIxYWUxNjc3ODI1ZDVhODUyMzM4YjA5YjU1NjIwMWIwMGY5MDVjYmJjMTY5
-    YTg0MWVmY2NmZjZlZjRlM2ViZDIwMjgwMWMxOGE5YmZlNTc0YmU=
+    YWQ3MDljNjhlMDBlYWE1Y2JjNjg2Y2JlMDE4NGFjMWI3MjljZDA4NjJkMDEz
+    ZmMzNGJkMmY5NmU2MTQ4M2NlMzAyNGM5YWUxZDJmMTI0OTI0MTI0OTBjMzhj
+    Y2I2NGUyM2M5MGYzNzExNDc2NTY5ZjYwNGVhMzA5NzM5NjE5NTQ=

data/box_view.gemspec

@@ -13,6 +13,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/reillyforshaw/box_view"
   spec.license       = "MIT"
 
+  spec.required_ruby_version = '>= 1.9'
+
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
@@ -20,4 +22,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
 end

data/lib/box_view/http.rb

@@ -2,7 +2,19 @@ module BoxView
   module Http
 
     require 'time'
-    
+
+    class Error < BoxView::Error; end
+
+    class BadRequestError < BoxView::Http::Error; end
+    class RetryNeededError < BoxView::Http::Error
+      attr_reader :retry_after
+
+      def initialize(msg, retry_after)
+        @retry_after = retry_after
+        super(msg)
+      end
+    end
+
     def base_uri(path, params = {})
       uri = URI.parse("https://view-api.box.com")
       uri.path = path
@@ -52,17 +64,32 @@ module BoxView
       res = n.start do |http|
         http.request(req)
       end
+      check_for_error(res)
       parse ? parse_response(res) : res.body
     end
 
-    def parse_response(res)
-      begin
-        JSON.parse(res.body)
-      rescue JSON::ParserError
-        nil
+    def check_for_error(res)
+      case res
+      when Net::HTTPAccepted
+        if res['Retry-After']
+          raise BoxView::Http::RetryNeededError.new('Retry Needed', res['Retry-After'])
+        end
+      when Net::HTTPBadRequest
+        msg = 'Bad Request'
+        if err_dets = error_details(res)
+          msg += " (#{err_dets})"
+        end
+
+        raise BoxView::Http::BadRequestError.new(msg)
       end
     end
 
+    def parse_response(res)
+      JSON.parse(res.body)
+    rescue JSON::ParserError
+      nil
+    end
+
     def convert_params(params)
       params.each_pair do |key, val|
         if [Date, Time, DateTime].include?(val.class)
@@ -74,6 +101,16 @@ module BoxView
 
     private
 
+    def error_details(res)
+      if resp_json = parse_response(res)
+        if details = resp_json['details']
+          details.map { |d| [d['field'], d['message']].join(': ') }.join(' ')
+        end
+      end
+    rescue
+      nil
+    end
+
     def api_prefix()
       "/1"
     end

data/lib/box_view/models/base.rb

@@ -1,9 +1,9 @@
 module BoxView
   module Models
 
-    class ReadOnlyAttribute < Exception; end
-    class ResourceNotSaved < Exception; end
-    
+    class ReadOnlyAttribute < BoxView::Error; end
+    class ResourceNotSaved < BoxView::Error; end
+
     class Base
 
       require 'time'
@@ -83,4 +83,4 @@ module BoxView
 
     end
   end
-end
+end

data/lib/box_view/version.rb

@@ -1,3 +1,3 @@
 module BoxView
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/box_view.rb

@@ -4,6 +4,8 @@ require "net/http"
 require "json"
 
 module BoxView
+  class Error < StandardError; end
+
   {
     Session: 'session',
     Http:    'http'

data/spec/http_spec.rb

@@ -5,11 +5,66 @@ describe BoxView::Http do
 
   describe "#parse_response" do
     context "when given ill-formed JSON" do
-      let(:response) { response = double("Net::HTTPResponse", body: "foo") }
-      
+      let(:response) { double("Net::HTTPResponse", body: "foo") }
+
       it "should return nil" do
         expect(http.parse_response(response)).to be_nil
       end
     end
   end
-end
+
+  describe '#check_for_error' do
+    let(:response) { }
+    subject { http.check_for_error(response) }
+
+    context 'given a 202 response' do
+      let(:response) { Net::HTTPAccepted.new('1.1', '202', 'ACCEPTED') }
+
+      context 'that does not have a Retry-After header' do
+        it 'should not raise an error' do
+          expect { subject }.not_to raise_error
+        end
+      end
+
+      context 'that does have a Retry-After header' do
+        let(:response) { super().tap { |r| r['Retry-After'] = '10' } }
+        it 'should raise a BoxView::Http:RetryNeeded' do
+          expect { subject }.to raise_error(BoxView::Http::RetryNeededError) do |error|
+            error.retry_after.should == '10'
+          end
+        end
+      end
+    end
+
+    context 'given a 400 response' do
+      let(:body) { }
+      let(:response) do
+        Net::HTTPBadRequest.new('1.1', '400', 'BAD REQUEST').tap do |r|
+          r.stub(:body).and_return(body)
+        end
+      end
+
+      context 'without a parseable error message' do
+        let(:body) { 'NOT JSON' }
+
+        it 'should raise a BoxView::Http:BadRequest' do
+          expect { subject }.to raise_error(BoxView::Http::BadRequestError)
+        end
+      end
+
+      context 'with a parseable error message' do
+        let(:body) do
+          '{"message": "Bad request",
+            "type": "error",
+            "details": [{"field": "height",
+                         "message": "Ensure this value is less than or equal to 768."}],
+            "request_id": "999605a17b974850baaccbe2ae479c75"}'
+        end
+
+        it 'should raise a BoxView::Http:BadRequest with a message indicating the problem' do
+          expect { subject }.to raise_error(BoxView::Http::BadRequestError, /height/)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: box_view
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Reilly Forshaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-18 00:00:00.000000000 Z
+date: 2014-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: API client for Box View
 email:
 - reilly.forshaw@goclio.com
@@ -88,7 +102,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='