box_view 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzUzNTg4MTQ1MGI3M2RjNmYyMTM4NzYyOTIyMjMwNmU1NGZhOTAyMw==
+    ZWQwZTBhYzY4NTBiMjhmZGM2ZTA5MjM2YzY3YTk3NGU0MmJmNDNkMA==
   data.tar.gz: !binary |-
-    YzE1MWI0MDExZDBkOThjOGM2OTQzNmE3ZjhmMGQ5NTg4ZjRkZjcwMg==
+    YTAxMDM1NWQ2ZjIyZWVlZmRiYTVmOTMyOGVmY2MzOWFkYzI1ZDI2Mw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZDlmODk3MTMwYTk4MTEzODA5ODAwMzExYTkzMmJhZjk0ODc5NjdlN2RhMDIw
-    ZTBlMjdkNWMyMDMxZjE2ODRiMDAyN2RmNjM2YWMyNjVkYTE3ZTc3ZmIzNmVl
-    YWU5MWYzY2M1OTc5NWY2MGYxMDRkYjE2NmJhODE0NTU2MTdlZmQ=
+    Zjg5M2EyMWJkMTYyNmE2ZjhhMzNhZjBhMDExOTg1Y2RjNjE2MTM5ZTI2Njdi
+    MjcyNWRkMzg5OTNmY2M0OWZkYjA0NzMxMzA3N2NjMjdlMWM5OWJmNDM5M2E4
+    NjVmMmUwYzVkMWJkOTc1Yjg0OTU2NDAxMzJkOWQzMGI1NjI5Nzk=
   data.tar.gz: !binary |-
-    MTc4N2U4ZjYzZjljOThlMDQzNzcyMzkyODNjMmZhOGUzZDU0NzVlNGUxYTAw
-    NDUwOGI2NDYwMGI2Y2NlMjliYjc1MWZjNzI1YTFlZTNiNDVkMWQ3YmZjMTFj
-    ZTQwYWU1NzdmNzUyNGNlMzI3MTQ3YzMyZmQ1OTYyNDhlMDk4ZGU=
+    M2UyMGY0MWJlNTEyYTE2YWU0ZmNmZTBiMWMyMGEzY2YzNmZmNzBmZjRjMzU0
+    OGIxYWUxNjc3ODI1ZDVhODUyMzM4YjA5YjU1NjIwMWIwMGY5MDVjYmJjMTY5
+    YTg0MWVmY2NmZjZlZjRlM2ViZDIwMjgwMWMxOGE5YmZlNTc0YmU=

data/lib/box_view/http.rb

@@ -40,7 +40,6 @@ module BoxView
     end
 
     def make_api_request(req, uri, parse=true)
-      puts "BoxView::Http#make_api_request token not availble #{uri}" if self.token.nil? || self.token.empty?
       return if self.token.nil? || self.token.empty?
       req.add_field("Authorization", "Token #{self.token}")
       make_request(req, uri, parse)
@@ -53,12 +52,15 @@ module BoxView
       res = n.start do |http|
         http.request(req)
       end
-      puts "BoxView::Http#make_request #{uri} response: #{res.body}#{" Parsing" if parse}"
-      parse_response(res, parse)
+      parse ? parse_response(res) : res.body
     end
 
-    def parse_response(res, parse=true)
-      parse ? JSON.parse(res.body) : res.body
+    def parse_response(res)
+      begin
+        JSON.parse(res.body)
+      rescue JSON::ParserError
+        nil
+      end
     end
 
     def convert_params(params)

data/lib/box_view/version.rb

@@ -1,3 +1,3 @@
 module BoxView
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/http_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe BoxView::Http do
+  let(:http) { BoxView::Session.new }
+
+  describe "#parse_response" do
+    context "when given ill-formed JSON" do
+      let(:response) { response = double("Net::HTTPResponse", body: "foo") }
+      
+      it "should return nil" do
+        expect(http.parse_response(response)).to be_nil
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: box_view
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Reilly Forshaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-10 00:00:00.000000000 Z
+date: 2014-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -69,6 +69,7 @@ files:
 - spec/api/actions/listable_spec.rb
 - spec/api/base_spec.rb
 - spec/api/document_spec.rb
+- spec/http_spec.rb
 - spec/models/base_spec.rb
 - spec/models/document_spec.rb
 - spec/session_spec.rb
@@ -105,6 +106,7 @@ test_files:
 - spec/api/actions/listable_spec.rb
 - spec/api/base_spec.rb
 - spec/api/document_spec.rb
+- spec/http_spec.rb
 - spec/models/base_spec.rb
 - spec/models/document_spec.rb
 - spec/session_spec.rb