bovem 2.2.2 → 2.3.0

data/lib/bovem/version.rb

@@ -14,10 +14,10 @@ module Bovem
     MAJOR = 2
 
     # The minor version.
-    MINOR = 2
+    MINOR = 3
 
     # The patch version.
-    PATCH = 2
+    PATCH = 0
 
     # The current version number of Bovem.
     STRING = [MAJOR, MINOR, PATCH].compact.join(".")

data/spec/bovem/configuration_spec.rb

@@ -16,7 +16,7 @@ describe Bovem::Configuration do
 
   describe "#parse" do
     it "reads a valid configuration file" do
-      file = ::File.open(test_prefix, "w") {|f| f.write("config.property = 1234") }
+      ::File.open(test_prefix, "w") {|f| f.write("config.property = 1234") }
 
       config = BaseConfiguration.new(test_prefix)
       expect(config.property).to eq(1234)
@@ -24,22 +24,22 @@ describe Bovem::Configuration do
     end
 
     it "reject a missing or unreadable file" do
-      expect { config = BaseConfiguration.new("/non-existing")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("/non-existing")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
     end
 
     it "reject an invalid configuration" do
-      file1 = ::File.open("#{test_prefix}-1", "w") {|f| f.write("config.property = ") }
-      file2 = ::File.open("#{test_prefix}-2", "w") {|f| f.write("config.non_property = 1234") }
+      ::File.open("#{test_prefix}-1", "w") {|f| f.write("config.property = ") }
+      ::File.open("#{test_prefix}-2", "w") {|f| f.write("config.non_property = 1234") }
 
-      expect { config = BaseConfiguration.new("#{test_prefix}-1")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
-      expect { config = BaseConfiguration.new("#{test_prefix}-2")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("#{test_prefix}-1")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
+      expect { BaseConfiguration.new("#{test_prefix}-2")}.to raise_error(::Bovem::Errors::InvalidConfiguration)
 
       File.unlink("#{test_prefix}-1")
       File.unlink("#{test_prefix}-2")
     end
 
     it "allows overrides" do
-      file = ::File.open("#{test_prefix}", "w") {|f| f.write("config.property = 1234") }
+      ::File.open("#{test_prefix}", "w") {|f| f.write("config.property = 1234") }
 
       config = BaseConfiguration.new(test_prefix, {property: 5678, non_property: 1234})
       expect(config.property).to eq(5678)
@@ -47,19 +47,4 @@ describe Bovem::Configuration do
       File.unlink(test_prefix)
     end
   end
-
-  describe ".property" do
-    it "add the property to the object" do
-      subject = BaseConfiguration.new
-
-      expect(subject.respond_to?(:new_property)).to be_false
-      expect(subject.respond_to?(:new_property=)).to be_false
-      BaseConfiguration.property(:new_property, default: "VALUE")
-      expect(subject.respond_to?(:new_property)).to be_true
-      expect(subject.respond_to?(:new_property=)).to be_true
-      expect(subject.new_property).to eq("VALUE")
-      subject.new_property = "NEW VALUE"
-      expect(subject.new_property).to eq("NEW VALUE")
-    end
-  end
 end

data/spec/bovem/console_spec.rb

@@ -184,7 +184,7 @@ describe Bovem::Console do
       console.stub(:line_width).and_return(80)
 
       expect(console.format_right(message)).to eq("\e[A\e[0G\e[#{75}CABCDE")
-      expect(console.format_right(message, 10)).to eq("\e[A\e[0G\e[#{5}CABCDE")
+      expect(console.format_right(message, 10)).to eq("\e[A\e[0G\e[#{-5}CABCDE")
       expect(console.format_right(extended_message)).to eq("\e[A\e[0G\e[#{75}CABC\e[AD\e[3mE")
       expect(console.format_right(message, nil, false)).to eq("\e[0G\e[#{75}CABCDE")
       console.stub(:line_width).and_return(10)

data/spec/bovem/shell_spec.rb

@@ -37,7 +37,7 @@ describe Bovem::Shell do
 
   describe "#run" do
     before(:each) do
-      ::Open4::stub(:popen4) do |_a, _b, _c, _d| OpenStruct.new(exitstatus: 0) end
+      ::Open4::stub(:popen4) do |_, _, _, _| OpenStruct.new(exitstatus: 0) end
     end
 
     it "should show a message" do
@@ -65,7 +65,7 @@ describe Bovem::Shell do
 
     it "should show a exit message" do
       i = -1
-      ::Open4::stub(:popen4) do |_a, _b, _c, _d|
+      ::Open4::stub(:popen4) do |_, _, _, _|
         i += 1
         OpenStruct.new(exitstatus: i)
       end
@@ -87,8 +87,8 @@ describe Bovem::Shell do
     end
 
     it "should raise a exception for failures" do
-      ::Open4::stub(:popen4) {|_a, _b, _c, _d| OpenStruct.new(exitstatus: 1) }
-      expect { shell.run("echo1 OK", nil, true, false, false, false, false) }.to_not raise_error(SystemExit)
+      ::Open4::stub(:popen4) {|_, _, _, _| OpenStruct.new(exitstatus: 1) }
+      expect { shell.run("echo1 OK", nil, true, false, false, false, false) }.not_to raise_error
       expect { shell.run("echo1 OK", nil, true, false, false) }.to raise_error(SystemExit)
     end
   end
@@ -333,7 +333,6 @@ describe Bovem::Shell do
     let(:target){ File.expand_path("~") }
 
     it "should execute block in other directory and return true" do
-      owd = Dir.pwd
       dir = ""
 
       shell.within_directory(target) do
@@ -341,7 +340,7 @@ describe Bovem::Shell do
         dir = "OK"
       end
 
-      expect(shell.within_directory(target) { dir = "OK" }).to be_true
+      expect(dir).to eq("OK")
     end
 
     it "should change and restore directory" do
@@ -357,11 +356,11 @@ describe Bovem::Shell do
     it "should change but not restore directory" do
       owd = Dir.pwd
 
-      shell.within_directory(target) do
+      shell.within_directory(target, false) do
         expect(Dir.pwd).to eq(target)
       end
 
-      expect(Dir.pwd).not_to eq(target)
+      expect(Dir.pwd).not_to eq(owd)
     end
 
     it "should show messages" do
@@ -376,11 +375,11 @@ describe Bovem::Shell do
       expect(dir).to eq("")
 
       Dir.stub(:chdir).and_raise(ArgumentError)
-      expect(shell.within_directory("/") { dir = "OK" }).to be_false
+      expect(shell.within_directory("/") { true }).to be_false
 
       Dir.unstub(:chdir)
       Dir.stub(:pwd).and_return("/invalid")
-      expect(shell.within_directory("/") { dir = "OK" }).to be_false
+      expect(shell.within_directory("/") { true }).to be_false
     end
   end
 

data/spec/coverage_helper.rb

@@ -6,6 +6,9 @@
 
 require "pathname"
 require "simplecov"
+require "coveralls"
+
+Coveralls.wear!
 
 SimpleCov.start do
   root = Pathname.new(File.dirname(__FILE__)) + ".."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bovem
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-13 00:00:00.000000000 Z
+date: 2013-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lazier
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 3.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.1
+        version: 3.2.2
 - !ruby/object:Gem::Dependency
   name: open4
   requirement: !ruby/object:Gem::Requirement
@@ -130,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4341278524255618315
+      hash: -290835472069004173
 requirements: []
 rubyforge_project: bovem
 rubygems_version: 1.8.25