bounce_fetcher 0.0.5 → 0.0.6

data/bounce_fetcher.gemspec

@@ -22,5 +22,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'tmail', '~> 1.2'
   s.add_dependency 'bounce-email', '~> 0.0.1'
 
+  s.add_development_dependency 'minitest'
   s.add_development_dependency 'eventmachine'
 end

data/lib/bounce_fetcher.rb

@@ -19,13 +19,15 @@ module BounceFetcher
       @detector = detector
     end
 
-    def each
+    def each(options = {})
+      options = { :delete => true }.merge(options)
+
       @fetcher.each do |e|
         if @detector.permanent_bounce?(e)
           @extractor.extract_emails(e.body).each do |email|
             yield email
           end
-          e.delete
+          e.delete if options[:delete]
         end
       end
     end

data/lib/bounce_fetcher/version.rb

@@ -1,3 +1,3 @@
 module BounceFetcher
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/test/test_bounce_fetcher.rb

@@ -35,22 +35,36 @@ class TestBounceFetcher < MiniTest::Unit::TestCase
     end
   end
 
+  def setup
+    @permanent_bounce = Email.new('foo@bar.com', true)
+    @temporary_bounce = Email.new('bar@baz.com', false)
+    @pop_fetcher = FakePopFetcher.new(@permanent_bounce, @temporary_bounce)
+    @extractor = FakeExtractor.new
+    @detector = FakeBounceDetector.new
+    @fetcher = BounceFetcher.new(@pop_fetcher, @extractor, @detector)
+  end
+
   def test_each_only_returns_emails_for_permanent_bounces
-    permanent_bounce = Email.new('foo@bar.com', true)
-    temporary_bounce = Email.new('bar@baz.com', false)
-    pop_fetcher = FakePopFetcher.new(permanent_bounce, temporary_bounce)
-    extractor = FakeExtractor.new
-    detector = FakeBounceDetector.new
-    fetcher = BounceFetcher.new(pop_fetcher, extractor, detector)
+    emails = []
+    @fetcher.each do |email|
+      emails << email
+    end
 
+    assert_equal ['foo@bar.com'], emails
+    assert @permanent_bounce.deleted?
+    assert !@temporary_bounce.deleted?
+  end
+
+  def test_each_with_no_delete_option
     emails = []
-    fetcher.each do |email|
+
+    @fetcher.each(:delete => false) do |email|
       emails << email
     end
 
     assert_equal ['foo@bar.com'], emails
-    assert permanent_bounce.deleted?
-    assert !temporary_bounce.deleted?
+    assert !@permanent_bounce.deleted?
+    assert !@temporary_bounce.deleted?
   end
 
 end

data/test/test_integration.rb

@@ -5,12 +5,12 @@ require 'net/smtp'
 class TestIntegration < MiniTest::Unit::TestCase
 
   def start_server
-    child_pid = fork do
+    fork do
       STDIN.reopen('/dev/null')
       STDOUT.reopen('/dev/null', 'a')
       STDERR.reopen(STDOUT)
       Dir.chdir(File.dirname(__FILE__) + "/support/localpost")
-      system("ruby -I. localpost.rb")
+      exec("ruby -I. localpost.rb")
     end
   end
 
@@ -19,8 +19,8 @@ class TestIntegration < MiniTest::Unit::TestCase
 
     mail.to      = options[:to] || 'blah@blah.com'
     mail.from    = options[:from] || 'postmaster@blah.com'
-    mail.subject = options[:subject] || 'mail delivery failed'
-    mail.body    = options[:body] || 'foo@bar.com mailbox unavailable'
+    mail.subject = options[:subject] || 'subject'
+    mail.body    = options[:body] || 'body'
     mail.date    = options[:date] || Time.now
 
     begin
@@ -33,10 +33,19 @@ class TestIntegration < MiniTest::Unit::TestCase
     end
   end
 
+  def send_permanent_bounce(options = {})
+    options = {
+      :subject => 'mail delivery failed',
+      :body => 'foo@bar.com mailbox unavailable',
+    }.merge(options)
+
+    send_email(options)
+  end
+
   def setup
     start_server
-    send_email # bounce
-    send_email(:subject => 'hi', :body => 'there') # not bounce
+    send_permanent_bounce
+    send_email
   end
 
   def test_bounce_fetcher

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bounce_fetcher
 version: !ruby/object:Gem::Version 
-  hash: 21
-  prerelease: 
+  hash: 19
+  prerelease: false
   segments: 
   - 0
   - 0
-  - 5
-  version: 0.0.5
+  - 6
+  version: 0.0.6
 platform: ruby
 authors: 
 - Michael Guterl
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-07 00:00:00 -04:00
+date: 2011-04-20 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -50,7 +50,7 @@ dependencies:
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: eventmachine
+  name: minitest
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
@@ -63,6 +63,20 @@ dependencies:
         version: "0"
   type: :development
   version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: eventmachine
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id004
 description: A set of tools for processing email bounces in a flexible way.
 email: 
 - michael@diminishing.org
@@ -118,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: bounce_fetcher
-rubygems_version: 1.5.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: A set of tools for processing email bounces in a flexible way.