boty 0.1.0 → 0.1.1

data/spec/script/i18n_spec.rb

@@ -5,24 +5,32 @@ RSpec.describe "I18n on default scripts", :session do
 
   it "describes scripts in :en locale (default)" do
     session = Boty::Session.new
-    _know_how = nil
-    session.start do |bot|
-      _know_how = know_how
+    know_how = nil
+    session.start do
+      know_how = self.know_how
     end
 
-    expect(_know_how["knows"]).
-      to eq "List all the commands known by this bot."
+    actions = know_how.reduce({}) { |hsh, action|
+      hsh[action.desc.command] = action.desc.description
+      hsh
+    }
+
+    expect(actions["knows"]).to eq "List all the commands known by this bot."
   end
 
   it "describes scripts in :pt-br local when forced" do
     Boty.locale = :"pt-br"
     session = Boty::Session.new
-    _know_how = nil
-    session.start do |bot|
-      _know_how = know_how
+    know_how = nil
+    session.start do
+      know_how = self.know_how
     end
 
-    expect(_know_how["knows"]).
-      to eq "Lista os comandos conhecidos por esse bot."
+    actions = know_how.reduce({}) { |hsh, action|
+      hsh[action.desc.command] = action.desc.description
+      hsh
+    }
+
+    expect(actions["knows"]).to eq "Lista os comandos conhecidos por esse bot."
   end
 end

data/spec/script/knows_spec.rb

@@ -2,17 +2,18 @@ RSpec.describe "script/knows", :session do
   before do
     start_session
 
-    extra_to_remove = bot.know_how.keys - ['knows', 'pug me']
-    extra_to_remove.each do |command_desc|
-      bot.no command_desc
-    end
+    bot.know_how.each { |action|
+      next if action.desc.command == "knows" ||
+                action.desc.command == "pug me"
+      bot.no action.desc.command
+    }
   end
 
   it "formats the output indenting by the command name size" do
-    expect(bot).to receive(:im).
-      with %{```\n knows: List all the commands known by this bot.
+    expect(bot).to receive(:im)
+      .with %(```\n knows: List all the commands known by this bot.
 pug me: Send some nice pug in the channel.
-```}
+```)
     faye.message "<@jeeba>: knows"
   end
 end

data/spec/script/pug_spec.rb

@@ -7,11 +7,11 @@ RSpec.describe "script/pug", :session do
 
   describe "pug me", :faraday do
     before do
-      requests.get("/random") { |env|
+      requests.get("/random") do
         [200,
-         {"Content-Type" => "application/json;charset=utf-8"},
-         {pug: "some_pug"}.to_json]
-      }
+         { "Content-Type" => "application/json;charset=utf-8" },
+         { pug: "some_pug" }.to_json]
+      end
     end
 
     it "displays a pug" do
@@ -23,12 +23,13 @@ RSpec.describe "script/pug", :session do
 
   describe "pug bomb x", :faraday do
     it "displays x pugs" do
-      requests.get("/bomb") { |env|
+      requests.get("/bomb") do |env|
         expect(env.params).to eq "count" => "3"
         [200,
          { "Content-Type" => "application/json;charset=utf-8" },
-         { pugs: ["1", "2", "3"] }.to_json]
-      }
+         { pugs: %w(1 2 3) }.to_json]
+      end
+
       (1..3).each do |num|
         expect(bot).to receive(:say).with("<#{num}>")
       end
@@ -37,17 +38,33 @@ RSpec.describe "script/pug", :session do
     end
 
     it "defaults to 5 pugs when no count is given" do
-      requests.get("/bomb") { |env|
+      requests.get("/bomb") do |env|
         expect(env.params).to eq "count" => "5"
         [200,
          { "Content-Type" => "application/json;charset=utf-8" },
-         { pugs: ["1", "2", "3", "4", "5"] }.to_json]
-      }
+         { pugs: %w(1 2 3 4 5) }.to_json]
+      end
+
       (1..5).each do |num|
         expect(bot).to receive(:say).with("<#{num}>")
       end
 
       faye.message "<@jeeba>: pug bomb"
     end
+
+    it "forbbidens more than 5 pugs" do
+      requests.get("/bomb") do |env|
+        expect(env.params).to eq "count" => "5"
+        [200,
+         { "Content-Type" => "application/json;charset=utf-8" },
+         { pugs: %w(1 2 3 4 5) }.to_json]
+      end
+      expect(bot).to receive(:say).with("wow! so many pugs! sendind 5 instead.")
+      (1..5).each do |num|
+        expect(bot).to receive(:say).with("<#{num}>")
+      end
+
+      faye.message "<@jeeba>: pug bomb 20"
+    end
   end
 end

data/spec/script/remember_spec.rb

@@ -1,43 +1,49 @@
 RSpec.describe "script/brain", :session do
-  before do
-    allow(::Boty::Slack.users).to receive(:info).with("U9876").and_return(
-      ::Boty::Slack::User.new({
-        "id" => "U9876",
-        "name" => "valeriano"
-      })
+  let(:julian) {
+    ::Boty::Slack::User.new(
+      "id" => "U7777",
+      "name" => "julian"
     )
+  }
 
-    allow(::Boty::Slack.users).to receive(:info).with("U7777").and_return(
-      ::Boty::Slack::User.new({
-        "id" => "U7777",
-        "name" => "julian"
-      })
+  let(:valeriano) {
+    ::Boty::Slack::User.new(
+      "id" => "U9876",
+      "name" => "valeriano"
     )
+  }
+
+  before do
+    allow(::Boty::Slack.users).to receive(:info).with("U9876")
+      .and_return(valeriano)
+    allow(::Boty::Slack.users).to receive(:info).with("U7777")
+      .and_return julian
 
     start_session
   end
 
   it "stores something about the user issuing the command" do
-    expect(bot).to receive(:im).
-      with "No worries, your secrets aren't safe with me... oh wait..."
+    expect(bot).to receive(:im)
+      .with "No worries, your secrets aren't safe with me... oh wait..."
 
     faye.message "<@#{bot.name}>: remember I'm at the dentist until 12pm",
-      user: "U9876"
+                 user: "U9876"
 
-    expect(bot.brain[:user]["valeriano"].first).to eq "I'm at the dentist until 12pm"
+    expect(bot.brain[:user]["valeriano"].first)
+      .to eq "I'm at the dentist until 12pm"
   end
 
   it "recovers information from the brain" do
     allow(bot).to receive(:im)
     faye.message "<@#{bot.name}>: remember I'm at the dentist until 12pm",
-      user: "U9876"
+                 user: "U9876"
 
-    expect(bot).to receive(:im).
-      with("julian, I'm searching my user database for valeriano:\n")
-    expect(bot).to receive(:im).
-      with("```\n - I'm at the dentist until 12pm\n```")
+    expect(bot).to receive(:im)
+      .with("julian, I'm searching my user database for valeriano:\n")
+    expect(bot).to receive(:im)
+      .with("```\n - I'm at the dentist until 12pm\n```")
 
     faye.message "<@#{bot.name}>: about user valeriano",
-      user: "U7777"
+                 user: "U7777"
   end
 end

data/spec/spec_helper.rb

@@ -1,14 +1,15 @@
-$:.unshift File.expand_path("..", __FILE__)
-$:.unshift File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.unshift File.expand_path("..", __FILE__)
+$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
 
 begin
   require "byebug"
   require "rubinius/debugger"
 rescue LoadError
 end
+
 require "boty"
 
-Dir['./spec/support/**/*.rb'].each { |f| require f }
+Dir["./spec/support/**/*.rb"].each do |f| require f end
 
 RSpec.configure do |config|
   config.include EMSupport, em: true

data/spec/support/em_support.rb

@@ -5,9 +5,7 @@ module EMSupport
         allow(EM).to receive(:run).and_yield
       end
 
-      around do |example|
-        example.run
-      end
+      around(&:run)
     end
   end
 end

data/spec/support/faraday_support.rb

@@ -1,7 +1,6 @@
 module FaradaySupport
   def self.included(base)
     base.instance_eval do
-
       let(:requests) { Faraday::Adapter::Test::Stubs.new }
 
       around do |example|

data/spec/support/faye_support.rb

@@ -11,9 +11,14 @@ module FayeSupport
     end
 
     def message(message, extra_args = {})
-      send_event(:message, OpenStruct.new(data: {
-        "type" => "message",
-        "text" => message }.merge(extra_args).to_json)
+      send_event(
+        :message,
+        OpenStruct.new(
+          data: {
+            "type" => "message",
+            "text" => message
+          }.merge(extra_args).to_json
+        )
       )
     end
   end
@@ -26,9 +31,7 @@ module FayeSupport
         allow(Faye::WebSocket::Client).to receive(:new).and_return faye
       end
 
-      around do |example|
-        example.run
-      end
+      around(&:run)
     end
   end
 end

data/spec/support/file_system_matchers.rb

@@ -1,8 +1,8 @@
 RSpec::Matchers.define :create_directory do |dir_name|
   match do |block|
-    return false if Dir.exists? dir_name # change this to use a proper message
+    return false if Dir.exist? dir_name # change this to use a proper message
     block.call
-    Dir.exists? dir_name
+    Dir.exist? dir_name
   end
 
   supports_block_expectations
@@ -10,9 +10,9 @@ end
 
 RSpec::Matchers.define :create_file do |file_name|
   match do |block|
-    return false if File.exists? file_name # change this to use a proper message
+    return false if File.exist? file_name # change this to use a proper message
     block.call
-    File.exists? file_name
+    File.exist? file_name
   end
 
   supports_block_expectations

data/spec/support/logger_support.rb

@@ -2,19 +2,16 @@ module LoggerSupport
   def self.included(base)
     base.instance_eval do
       let(:logger) { Boty::Logger.adapter }
+      before do change_to_memory_adapter end
+      around(&:run)
+      after do Boty::Logger.adapter = @adapter end
+    end
+  end
 
-      before do
-        @adapter = Boty::Logger.adapter
-        Boty::Logger.adapter = Boty::Logger::Memory.new
-      end
-
-      around do |example|
-        example.run
-      end
+  private
 
-      after do
-        Boty::Logger.adapter = @adapter
-      end
-    end
+  def change_to_memory_adapter
+    @adapter = Boty::Logger.adapter
+    Boty::Logger.adapter = Boty::Logger::Memory.new
   end
 end

data/spec/support/session_support.rb

@@ -1,31 +1,42 @@
 module SessionSupport
   def self.included(base)
-    def start_session(only_knows:nil)
-      @session = Boty::Session.new
-      @session.start do |_| end
-    end
+    memoize = ->(rspec_suite) { create_local_memoized_values_on(rspec_suite) }
 
     base.instance_eval do
       include EMSupport
       include FayeSupport
       include SlackSupport::Users
 
+      memoize[base]
+
+      before do
+        allow(Boty::Slack.rtm).to receive(:start).and_return parsed_response
+      end
+    end
+  end
+
+  def self.create_local_memoized_values_on(base)
+    base.instance_eval do
       let(:dsl) { ::Boty::DSL.new @session.bot }
       let(:bot) { dsl.bot }
       let(:bot_name) { "jeeba" }
       let(:bot_id) { "U1234" }
       let(:rtm_ws_url) { "ws://example.org/slack/sse/url" }
-
-      before do
-        allow(Boty::Slack.rtm).to receive(:start).
-          and_return JSON.parse '{
-            "url": "'+ rtm_ws_url + '",
-            "self": {
-              "id": "'+ bot_id + '",
-              "name": "'+ bot_name + '"
-            }
-          }'
-      end
     end
   end
+
+  def start_session
+    @session = Boty::Session.new
+    @session.start do |_| end
+  end
+
+  def parsed_response
+    JSON.parse '{
+      "url": "' + rtm_ws_url + '",
+      "self": {
+        "id": "' + bot_id + '",
+        "name": "' + bot_name + '"
+      }
+    }'
+  end
 end

data/spec/support/slack_support.rb

@@ -1,17 +1,20 @@
 module SlackSupport
   module Users
+    def new_user(id, name)
+      ::Boty::Slack::User.new(
+        "id"    => id,
+        "name"  => name
+      )
+    end
+
     def self.included(base)
       base.instance_eval do
         let(:user_name) { "julian" }
         let(:user_id) { "U023BECGF" }
 
         before do
-          allow(::Boty::Slack.users).to receive(:info).and_return(
-            ::Boty::Slack::User.new({
-              "id" => user_id,
-              "name" => user_name
-            })
-          )
+          allow(::Boty::Slack.users).to receive(:info)
+            .and_return(new_user(user_id, user_name))
         end
       end
     end

data/spec/support/template_project_support.rb

@@ -4,36 +4,38 @@ require "boty/cli"
 module TemplateProjectSupport
   include ThorSupport
 
-  def self.included(base)
-    def dry_run
-      allow(cli).to receive(:run)
-    end
+  def dry_run
+    allow(cli).to receive(:run)
+  end
 
-    def create_bot(name = nil, company:, api_key:)
-      allow(cli).to receive(:ask).and_return company, api_key
-      cli.new name || bot_name
-    end
+  def create_bot(name = nil, company:, api_key:)
+    allow(cli).to receive(:ask).and_return company, api_key
+    cli.new name || bot_name
+  end
 
+  def self.included(base)
     base.instance_eval do
-      before(:all) do
-        @original_dir = FileUtils.pwd
-        FileUtils.mkdir_p "tpl_project_tmp" if !Dir.exists? "tpl_project_tmp"
-        FileUtils.chdir "tpl_project_tmp"
-      end
-
-      before do
-        FileUtils.rm_rf bot_name if Dir.exists? bot_name
-      end
-
-      after(:all) do
-        FileUtils.chdir @original_dir
-        FileUtils.rm_rf "tpl_project_tmp"
-      end
+      before(:all)  do go_to_tmp_project_dir end
+      before        do FileUtils.rm_rf bot_name if Dir.exist? bot_name end
+      after(:all)   do remove_tmp_project_dir end
 
       subject(:cli) { Boty::CLI.new }
       let(:bot_name) { "jeeba" }
     end
   end
+
+  private
+
+  def go_to_tmp_project_dir
+    @original_dir = FileUtils.pwd
+    FileUtils.mkdir_p "tpl_project_tmp" unless Dir.exist? "tpl_project_tmp"
+    FileUtils.chdir "tpl_project_tmp"
+  end
+
+  def remove_tmp_project_dir
+    FileUtils.chdir @original_dir
+    FileUtils.rm_rf "tpl_project_tmp"
+  end
 end
 
 RSpec::Matchers.define :run do |command|
@@ -41,4 +43,3 @@ RSpec::Matchers.define :run do |command|
     expect(bot).to receive(:run).with command
   end
 end
-