boss_queue 0.2.3 → 0.2.4

data/VERSION

@@ -1 +1 @@
-0.2.3
+0.2.4

data/boss_queue.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "boss_queue"
-  s.version = "0.2.3"
+  s.version = "0.2.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Daniel Nelson"]

data/lib/boss_queue/boss_queue.rb

@@ -34,10 +34,11 @@ class BossQueue
 
   def create_queue
     # small message size because we are only sending id
-    # 5 second delay so that we can use eventually consistent reads in DynamoDB
+    # minimum 1 second delay so that we don't even try to pick it up until it is likely that the
+    # message is ready (or else we waste time just waiting for the saved data to become available)
     AWS::SQS::QueueCollection.new.create(queue_name, :visibility_timeout => 180,
                                                      :maximum_message_size => 1024,
-                                                     :delay_seconds => 5,
+                                                     :delay_seconds => 1,
                                                      :message_retention_period => 1209600)
   end
 
@@ -47,7 +48,7 @@ class BossQueue
       job_dequeued = true
       # When a block is given, each message is yielded to the block and then deleted as long as the block exits normally - http://docs.aws.amazon.com/AWSRubySDK/latest/frames.html
       begin
-        job = BossQueue::Job.shard(table_name).find(job_id.body)
+        job = BossQueue::Job.find_by_id(job_id.body, :shard => table_name, :consistent_read => true)
         job.sqs_queue = sqs_queue
         job.work
       rescue AWS::Record::RecordNotFound

data/lib/boss_queue/job.rb

@@ -21,6 +21,34 @@ class BossQueue
 
     timestamps
 
+    class << self
+      # We need consistent reads, so override @find_by_id
+      #
+      # @param [String] id The id of the record to load.
+      # @param [Hash] options
+      # @option options [String] :shard Specifies what shard (i.e. table)
+      #   should be searched.
+      # @raise [RecordNotFound] Raises a record not found exception if there
+      #   was no data found for the given id.
+      # @return [Record::HashModel] Returns the record with the given id.
+      def find_by_id id, options = {}
+
+        table = dynamo_db_table(options[:shard])
+
+        data = table.items[id].attributes.to_h(:consistent_read => options[:consistent_read])
+
+        raise RecordNotFound, "no data found for id: #{id}" if data.empty?
+
+        obj = self.new(:shard => table)
+        obj.send(:hydrate, id, data)
+        obj
+
+      end
+      alias_method :[], :find_by_id
+    end
+
+
+
     def enqueue
       sqs_queue.send_message(id.to_s)
     end

data/spec/boss_queue_spec.rb

@@ -230,7 +230,7 @@ describe "BossQueue module" do
       @job = double('job')
       @job.stub(:work)
       @job.stub(:sqs_queue=)
-      BossQueue::Job.stub_chain(:shard, :find).and_return(@job)
+      BossQueue::Job.stub(:find_by_id).and_return(@job)
     end
 
     it "should dequeue from SQS using the value of sqs_queue_url" do
@@ -245,14 +245,13 @@ describe "BossQueue module" do
 
       it "should use the dequeued id to retrieve a BossQueue::Job object" do
         shard = double('shard')
-        BossQueue::Job.should_receive(:shard).with(BossQueue.new.table_name).and_return(shard)
-        shard.should_receive(:find).with('ijk').and_return(@job)
+        BossQueue::Job.should_receive(:find_by_id).with('ijk', :shard => BossQueue.new.table_name, :consistent_read => true).and_return(@job)
         BossQueue.new.work
       end
 
       context "when the dequeued id does not match a BossQueue::Job object" do
         it "should not raise an exception" do
-          BossQueue::Job.stub_chain(:shard, :find).and_raise(AWS::Record::RecordNotFound.new)
+          BossQueue::Job.stub(:find_by_id).and_raise(AWS::Record::RecordNotFound.new)
           lambda {
             BossQueue.new.work
           }.should_not raise_error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: boss_queue
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -160,7 +160,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -141027132593834665
+      hash: 2592417147040776871
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: