bosh_vsphere_cpi 0.6.0 → 1.5.0.pre.1100

metadata

@@ -1,89 +1,89 @@
 --- !ruby/object:Gem::Specification
 name: bosh_vsphere_cpi
 version: !ruby/object:Gem::Version
-  version: 0.6.0
-  prerelease: 
+  version: 1.5.0.pre.1100
+  prerelease: 6
 platform: ruby
 authors:
 - VMware
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-05 00:00:00.000000000 Z
+date: 2013-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bosh_common
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0.pre.1100
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0.pre.1100
 - !ruby/object:Gem::Dependency
   name: bosh_cpi
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 1.5.0.pre.1100
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 1.5.0.pre.1100
 - !ruby/object:Gem::Dependency
   name: membrane
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.2
 - !ruby/object:Gem::Dependency
-  name: ruby_vim_sdk
+  name: sequel
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 3.43.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 3.43.0
 - !ruby/object:Gem::Dependency
-  name: sequel
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -92,14 +92,14 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: uuidtools
+  name: rspec-fire
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -107,9 +107,12 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: BOSH VSphere CPI
-email: support@vmware.com
-executables: []
+description: ! 'BOSH VSphere CPI
+
+  a5984f'
+email: support@cloudfoundry.com
+executables:
+- vsphere_cpi_console
 extensions: []
 extra_rdoc_files: []
 files:
@@ -121,6 +124,7 @@ files:
 - lib/cloud/vsphere/config.rb
 - lib/cloud/vsphere/lease_updater.rb
 - lib/cloud/vsphere/models/disk.rb
+- lib/cloud/vsphere/path_finder.rb
 - lib/cloud/vsphere/resources.rb
 - lib/cloud/vsphere/resources/cluster.rb
 - lib/cloud/vsphere/resources/datacenter.rb
@@ -130,19 +134,37 @@ files:
 - lib/cloud/vsphere/resources/scorer.rb
 - lib/cloud/vsphere/resources/util.rb
 - lib/cloud/vsphere/version.rb
+- lib/ruby_vim_sdk.rb
+- lib/ruby_vim_sdk/base_type.rb
+- lib/ruby_vim_sdk/const.rb
+- lib/ruby_vim_sdk/core_types.rb
+- lib/ruby_vim_sdk/data_type.rb
+- lib/ruby_vim_sdk/enum_type.rb
+- lib/ruby_vim_sdk/ext.rb
+- lib/ruby_vim_sdk/managed_type.rb
+- lib/ruby_vim_sdk/method.rb
+- lib/ruby_vim_sdk/missing_types.rb
+- lib/ruby_vim_sdk/property.rb
+- lib/ruby_vim_sdk/server_objects.rb
+- lib/ruby_vim_sdk/soap/deserializer.rb
+- lib/ruby_vim_sdk/soap/serializer.rb
+- lib/ruby_vim_sdk/soap/stub_adapter.rb
+- lib/ruby_vim_sdk/soap_exception.rb
+- lib/ruby_vim_sdk/typed_array.rb
+- lib/ruby_vim_sdk/types.rb
+- lib/ruby_vim_sdk/version.rb
+- lib/ruby_vim_sdk/vmodl/data_object.rb
+- lib/ruby_vim_sdk/vmodl/managed_object.rb
+- lib/ruby_vim_sdk/vmodl/method_name.rb
+- lib/ruby_vim_sdk/vmodl/property_path.rb
+- lib/ruby_vim_sdk/vmodl/type_name.rb
+- lib/ruby_vim_sdk/vmodl_helper.rb
+- lib/ruby_vim_sdk/vmomi_support.rb
 - README
-- Rakefile
-- spec/spec_helper.rb
-- spec/unit/cloud/vsphere/resources/cluster_spec.rb
-- spec/unit/cloud/vsphere/resources/datacenter_spec.rb
-- spec/unit/cloud/vsphere/resources/datastore_spec.rb
-- spec/unit/cloud/vsphere/resources/folder_spec.rb
-- spec/unit/cloud/vsphere/resources/resource_pool_spec.rb
-- spec/unit/cloud/vsphere/resources/scorer_spec.rb
-- spec/unit/cloud/vsphere/resources/util_spec.rb
-- spec/unit/cloud/vsphere/resources_spec.rb
-homepage: http://www.vmware.com
-licenses: []
+- bin/vsphere_cpi_console
+homepage: https://github.com/cloudfoundry/bosh
+licenses:
+- Apache 2.0
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -152,27 +174,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: BOSH VSphere CPI
-test_files:
-- spec/spec_helper.rb
-- spec/unit/cloud/vsphere/resources/cluster_spec.rb
-- spec/unit/cloud/vsphere/resources/datacenter_spec.rb
-- spec/unit/cloud/vsphere/resources/datastore_spec.rb
-- spec/unit/cloud/vsphere/resources/folder_spec.rb
-- spec/unit/cloud/vsphere/resources/resource_pool_spec.rb
-- spec/unit/cloud/vsphere/resources/scorer_spec.rb
-- spec/unit/cloud/vsphere/resources/util_spec.rb
-- spec/unit/cloud/vsphere/resources_spec.rb
-has_rdoc: 
+test_files: []

data/Rakefile

@@ -1,50 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-$:.unshift(File.expand_path("../../rake", __FILE__))
-
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __FILE__)
-
-require "rubygems"
-require "bundler"
-Bundler.setup(:default, :test)
-
-require "rake"
-begin
-  require "rspec/core/rake_task"
-rescue LoadError
-end
-
-require "bundler_task"
-require "ci_task"
-
-gem_helper = Bundler::GemHelper.new(Dir.pwd)
-
-desc "Build VSphere CPI gem into the pkg directory"
-task "build" do
-  gem_helper.build_gem
-end
-
-desc "Build and install VSphere CPI into system gems"
-task "install" do
-  Rake::Task["bundler:install"].invoke
-  gem_helper.install_gem
-end
-
-BundlerTask.new
-
-if defined?(RSpec)
-  namespace :spec do
-    desc "Run Unit Tests"
-    rspec_task = RSpec::Core::RakeTask.new(:unit) do |t|
-      t.pattern = "spec/unit/**/*_spec.rb"
-      t.rspec_opts = %w(--format progress --colour)
-    end
-
-    CiTask.new do |task|
-      task.rspec_task = rspec_task
-    end
-  end
-
-  desc "Run tests"
-  task :spec => %w(spec:unit)
-end

data/spec/spec_helper.rb

@@ -1,33 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
-
-require "rubygems"
-require "bundler"
-Bundler.setup(:default, :test)
-
-require "rspec"
-
-require "sequel"
-require "sequel/adapters/sqlite"
-
-Sequel.extension :migration
-db = Sequel.sqlite(':memory:')
-migration = File.expand_path("../../db/migrations/vsphere_cpi", __FILE__)
-Sequel::TimestampMigrator.new(db, migration, :table => "vsphere_cpi_schema").run
-
-require 'cloud'
-require 'cloud/vsphere'
-
-class VSphereSpecConfig
-  attr_accessor :db, :logger, :uuid
-end
-
-config = VSphereSpecConfig.new
-config.db = db
-config.logger = Logger.new(STDOUT)
-config.logger.level = Logger::ERROR
-config.uuid = "123"
-
-Bosh::Clouds::Config.configure(config)
-VSphereCloud::Config.logger = config.logger

data/spec/unit/cloud/vsphere/resources/cluster_spec.rb

@@ -1,383 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../../../../spec_helper", __FILE__)
-
-describe VSphereCloud::Resources::Cluster do
-  before(:each) do
-    @client = mock(:client)
-    VSphereCloud::Config.client = @client
-    VSphereCloud::Config.mem_overcommit = 1.0
-    @dc = mock(:datacenter)
-    @dc_config = mock(:datacenter_config)
-    @dc.stub!(:config).and_return(@dc_config)
-  end
-
-  describe :initialize do
-    it "should create a cluster" do
-      cluster_mob = mock(:cluster_mob)
-
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          :obj => cluster_mob,
-          "datastore" => []
-      })
-
-      cluster.name.should == "foo"
-      cluster.mob.should == cluster_mob
-      cluster.ephemeral_datastores.should be_empty
-      cluster.persistent_datastores.should be_empty
-      cluster.shared_datastores.should be_empty
-    end
-
-    it "should create a cluster with dedicated datastores" do
-      datastore_config = mock(:datastore_config)
-      datastore_config.stub!(:ephemeral_pattern).and_return(/a/)
-      datastore_config.stub!(:persistent_pattern).and_return(/b/)
-      datastore_config.stub!(:allow_mixed).and_return(false)
-      @dc_config.stub!(:datastores).and_return(datastore_config)
-
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:name).and_return("a")
-      datastore_a_mob = mock(:datastore_a_mob)
-      datastore_a_properties = {
-          "name" => "a",
-          "summary.capacity" => 128 * 1024 * 1024 * 1024,
-          "summary.freeSpace" => 32 * 1024 * 1024 * 1024
-      }
-      VSphereCloud::Resources::Datastore.stub!(:new).
-          with(datastore_a_properties).and_return(datastore_a)
-
-      datastore_b = mock(:datastore_b)
-      datastore_b.stub(:name).and_return("b")
-      datastore_b_mob = mock(:datastore_b_mob)
-      datastore_b_properties = {
-          "name" => "b",
-          "summary.capacity" => 64 * 1024 * 1024 * 1024,
-          "summary.freeSpace" => 8 * 1024 * 1024 * 1024
-      }
-      VSphereCloud::Resources::Datastore.stub!(:new).
-          with(datastore_b_properties).and_return(datastore_b)
-
-      @client.should_receive(:get_properties).with(
-          [datastore_a_mob, datastore_b_mob], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {"a" => datastore_a_properties, "b" => datastore_b_properties})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => [datastore_a_mob, datastore_b_mob]
-      })
-
-      cluster.ephemeral_datastores.should == {"a" => datastore_a}
-      cluster.persistent_datastores.should == {"b" => datastore_b}
-      cluster.shared_datastores.should be_empty
-    end
-
-    it "should fail to create a cluster with overlapped dedicated datastores" do
-      datastore_config = mock(:datastore_config)
-      datastore_config.stub!(:ephemeral_pattern).and_return(/[ab]/)
-      datastore_config.stub!(:persistent_pattern).and_return(/b/)
-      datastore_config.stub!(:allow_mixed).and_return(false)
-      @dc_config.stub!(:datastores).and_return(datastore_config)
-
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:name).and_return("a")
-      datastore_a_mob = mock(:datastore_a_mob)
-      datastore_a_properties = {
-          "name" => "a"
-      }
-      VSphereCloud::Resources::Datastore.stub!(:new).
-          with(datastore_a_properties).and_return(datastore_a)
-
-      datastore_b = mock(:datastore_b)
-      datastore_b.stub(:name).and_return("b")
-      datastore_b_mob = mock(:datastore_b_mob)
-      datastore_b_properties = {
-          "name" => "b"
-      }
-      VSphereCloud::Resources::Datastore.stub!(:new).
-          with(datastore_b_properties).and_return(datastore_b)
-
-      @client.should_receive(:get_properties).with(
-          [datastore_a_mob, datastore_b_mob], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {"a" => datastore_a_properties, "b" => datastore_b_properties})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      expect {
-        VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-            "datastore" => [datastore_a_mob, datastore_b_mob]
-        })
-      }.to raise_error /Datastore patterns are not mutually exclusive/
-    end
-
-    it "should create a cluster with shared datastores" do
-      datastore_config = mock(:datastore_config)
-      datastore_config.stub!(:ephemeral_pattern).and_return(/a/)
-      datastore_config.stub!(:persistent_pattern).and_return(/a/)
-      datastore_config.stub!(:allow_mixed).and_return(true)
-      @dc_config.stub!(:datastores).and_return(datastore_config)
-
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:name).and_return("a")
-      datastore_a_mob = mock(:datastore_a_mob)
-      datastore_a_properties = {
-          "name" => "a",
-          "summary.capacity" => 128 * 1024 * 1024 * 1024,
-          "summary.freeSpace" => 32 * 1024 * 1024 * 1024
-      }
-      VSphereCloud::Resources::Datastore.stub!(:new).
-          with(datastore_a_properties).and_return(datastore_a)
-
-      @client.should_receive(:get_properties).with(
-          [datastore_a_mob], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {"a" => datastore_a_properties})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => [datastore_a_mob]
-      })
-
-      cluster.ephemeral_datastores.should be_empty
-      cluster.persistent_datastores.should be_empty
-      cluster.shared_datastores.should == {"a" => datastore_a}
-    end
-
-    it "should create a cluster without a resource pool" do
-      host = mock(:host)
-      host_properties = {
-          :obj => host,
-          "runtime.inMaintenanceMode" => "false",
-          "hardware.memorySize" => 64 * 1024 * 1024 * 1024
-      }
-      host_counters = {
-          "cpu.usage.average" => "1000",
-          "mem.usage.average" => "5000"
-      }
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-      @client.should_receive(:get_properties).with(
-          [host], VimSdk::Vim::HostSystem,
-          %w(hardware.memorySize runtime.inMaintenanceMode),
-          {:ensure_all => true}).and_return(
-          {"foo" => host_properties})
-      @client.should_receive(:get_perf_counters).with(
-          [host], %w(cpu.usage.average mem.usage.average), {:max_sample => 5}).
-          and_return({"foo" => host_counters})
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => [],
-          "host" => [host]
-      })
-
-      cluster.free_memory.should == 32768
-      cluster.total_memory.should == 65536
-      cluster.idle_cpu.should == 0.9
-    end
-
-    it "should create a cluster with a resource pool" do
-      resource_pool = mock(:resource_pool)
-      resource_pool_mob = mock(:resource_pool_mob)
-      resource_pool.stub(:mob).and_return(resource_pool_mob)
-      VSphereCloud::Resources::ResourcePool.stub!(:new).
-          with(an_instance_of(VSphereCloud::Resources::Cluster), nil).
-          and_return(resource_pool)
-
-      summary = mock(:summary)
-      runtime = mock(:runtime)
-      runtime.stub(:overall_status).and_return("green")
-      cpu = mock(:cpu)
-      cpu.stub(:overall_usage).and_return(5)
-      cpu.stub(:max_usage).and_return(10)
-      runtime.stub(:cpu).and_return(cpu)
-      memory = mock(:memory)
-      memory.stub(:overall_usage).and_return(32 * 1024 * 1024 * 1024)
-      memory.stub(:max_usage).and_return(64 * 1024 * 1024 * 1024)
-      runtime.stub(:memory).and_return(memory)
-      summary.stub(:runtime).and_return(runtime)
-
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-      @client.should_receive(:get_properties).with(
-          resource_pool_mob,  VimSdk::Vim::ResourcePool, %w(summary)).
-          and_return({"summary" => summary})
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return("baz")
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => []
-      })
-
-      cluster.free_memory.should == 32768
-      cluster.total_memory.should == 65536
-      cluster.idle_cpu.should == 0.5
-    end
-
-    it "should create a cluster with an unhealthy resource pool" do
-      resource_pool = mock(:resource_pool)
-      resource_pool_mob = mock(:resource_pool_mob)
-      resource_pool.stub(:mob).and_return(resource_pool_mob)
-      VSphereCloud::Resources::ResourcePool.stub!(:new).
-          with(an_instance_of(VSphereCloud::Resources::Cluster), nil).
-          and_return(resource_pool)
-
-      summary = mock(:summary)
-      runtime = mock(:runtime)
-      runtime.stub(:overall_status).and_return("gray")
-      summary.stub(:runtime).and_return(runtime)
-
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-      @client.should_receive(:get_properties).with(
-          resource_pool_mob,  VimSdk::Vim::ResourcePool, %w(summary)).
-          and_return({"summary" => summary})
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return("baz")
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => []
-      })
-
-      cluster.free_memory.should == 0
-      cluster.total_memory.should == 0
-      cluster.idle_cpu.should == 0.0
-    end
-  end
-
-  describe :allocate do
-    it "should record the allocation against the cached utilization" do
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => []
-      })
-      cluster.instance_eval { @synced_free_memory = 2048 }
-      cluster.allocate(1024)
-      cluster.free_memory.should == 1024
-    end
-  end
-
-  describe :pick_persistent do
-    before(:each) do
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      @cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => []
-      })
-    end
-
-    it "should only use persistent datastores if possible" do
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:free_space).and_return(4096)
-      datastore_b = mock(:datastore_b)
-
-      @cluster.persistent_datastores["foo"] = datastore_a
-      @cluster.shared_datastores["bar"] = datastore_b
-
-      VSphereCloud::Resources::Util.should_receive(:weighted_random).
-          with([[datastore_a, 4096]]).and_return(datastore_a)
-
-      datastore = @cluster.pick_persistent(1024)
-      datastore.should == datastore_a
-    end
-
-    it "should filter out datastores that are low on free space" do
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:free_space).and_return(2000)
-      datastore_b = mock(:datastore_b)
-      datastore_b.stub(:free_space).and_return(4096)
-
-      @cluster.persistent_datastores["foo"] = datastore_a
-      @cluster.shared_datastores["bar"] = datastore_b
-
-      VSphereCloud::Resources::Util.should_receive(:weighted_random).
-          with([[datastore_b, 4096]]).and_return(datastore_b)
-
-      datastore = @cluster.pick_persistent(1024)
-      datastore.should == datastore_b
-    end
-  end
-
-  describe :pick_ephemeral do
-    it "should only use ephemeral datastores if possible" do
-      @client.should_receive(:get_properties).with(
-          [], VimSdk::Vim::Datastore,
-          %w(summary.freeSpace summary.capacity name)).and_return(
-          {})
-
-      VSphereCloud::Resources::Cluster.any_instance.stub(
-          :fetch_cluster_utilization)
-
-      cluster_config = mock(:cluster_config)
-      cluster_config.stub!(:name).and_return("foo")
-      cluster_config.stub!(:resource_pool).and_return(nil)
-      @cluster = VSphereCloud::Resources::Cluster.new(@dc, cluster_config, {
-          "datastore" => []
-      })
-      datastore_a = mock(:datastore_a)
-      datastore_a.stub(:free_space).and_return(4096)
-      datastore_b = mock(:datastore_b)
-
-      @cluster.ephemeral_datastores["foo"] = datastore_a
-      @cluster.shared_datastores["bar"] = datastore_b
-
-      VSphereCloud::Resources::Util.should_receive(:weighted_random).
-          with([[datastore_a, 4096]]).and_return(datastore_a)
-
-      datastore = @cluster.pick_ephemeral(1024)
-      datastore.should == datastore_a
-    end
-  end
-end