bosh_aws_cpi 0.7.0 → 1.5.0.pre.1113

data/spec/unit/create_stemcell_spec.rb

@@ -1,113 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require "spec_helper"
-
-describe Bosh::AwsCloud::Cloud do
-
-  before :each do
-    @tmp_dir = Dir.mktmpdir
-  end
-
-  after(:each) do
-    FileUtils.rm_rf(@tmp_dir)
-  end
-
-  describe "EBS-volume based flow" do
-
-    it "creates stemcell by copying an image to a new EBS volume" do
-      volume = double("volume", :id => "v-foo")
-      current_instance = double("instance",
-                                :id => "i-current",
-                                :availability_zone => "us-nowhere-2b")
-      attachment = double("attachment",
-                          :device => "/dev/sdh",
-                          :volume => volume)
-
-      snapshot = double("snapshot", :id => "s-baz", :delete => nil)
-      image = double("image", :id => "i-bar")
-
-      unique_name = UUIDTools::UUID.random_create.to_s
-
-      image_params = {
-        :name => "BOSH-#{unique_name}",
-        :architecture => "x86_64",
-        :kernel_id => "aki-b4aa75dd",
-        :root_device_name => "/dev/sda1",
-        :description => "bosh-stemcell 1.2.3",
-        :block_device_mappings => {
-          "/dev/sda" => { :snapshot_id => "s-baz" },
-          "/dev/sdb" => "ephemeral0"
-        }
-      }
-
-
-      image.should_receive(:add_tag).with("Name", {:value=>"bosh-stemcell 1.2.3"})
-
-      cloud = mock_cloud do |ec2|
-        ec2.volumes.stub(:[]).with("v-foo").and_return(volume)
-        ec2.instances.stub(:[]).with("i-current").and_return(current_instance)
-        ec2.images.should_receive(:create).with(image_params).and_return(image)
-      end
-
-      cloud.should_receive(:find_aki).with("x86_64", "/dev/sda1")
-        .and_return("aki-b4aa75dd")
-
-      cloud.stub(:generate_unique_name).and_return(unique_name)
-      cloud.stub(:current_instance_id).and_return("i-current")
-
-      old_mappings = {
-        "/dev/sdf" => double("attachment",
-                             :volume => double("volume",
-                                               :id => "v-zb")),
-        "/dev/sdg" => double("attachment",
-                             :volume => double("volume",
-                                               :id => "v-ppc"))
-      }
-
-      extra_mapping = {
-        "/dev/sdh" => attachment
-      }
-
-      new_mappings = old_mappings.merge(extra_mapping)
-
-      current_instance.stub(:block_device_mappings).
-        and_return(old_mappings, new_mappings)
-
-      cloud.should_receive(:create_disk).with(2048, "i-current").
-        and_return("v-foo")
-
-      volume.should_receive(:attach_to).with(current_instance, "/dev/sdh").
-        and_return(attachment)
-
-      cloud.should_receive(:wait_resource).with(attachment, :attached)
-
-      cloud.stub(:sleep)
-
-      File.stub(:blockdev?).with("/dev/sdh").and_return(false, false, false)
-      File.stub(:blockdev?).with("/dev/xvdh").and_return(false, false, true)
-
-      cloud.should_receive(:copy_root_image).with("/tmp/foo", "/dev/xvdh")
-
-      volume.should_receive(:create_snapshot).and_return(snapshot)
-      cloud.should_receive(:wait_resource).with(snapshot, :completed)
-
-      cloud.should_receive(:wait_resource).with(image, :available, :state)
-
-      volume.should_receive(:detach_from).with(current_instance, "/dev/sdh").
-        and_return(attachment)
-
-      cloud.should_receive(:wait_resource).with(attachment, :detached)
-
-      cloud.should_receive(:delete_disk).with("v-foo")
-
-      cloud_properties = {
-          "root_device_name" => "/dev/sda1",
-          "architecture" => "x86_64",
-          "name" => "bosh-stemcell",
-          "version" => "1.2.3"
-      }
-      cloud.create_stemcell("/tmp/foo", cloud_properties).should == "i-bar"
-    end
-
-  end
-end

data/spec/unit/create_vm_spec.rb

@@ -1,249 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require "spec_helper"
-
-describe Bosh::AwsCloud::Cloud, "create_vm" do
-
-  def agent_settings(unique_name, network_spec=dynamic_network_spec)
-    {
-      "vm" => {
-        "name" => "vm-#{unique_name}"
-      },
-      "agent_id" => "agent-id",
-      "networks" => { "network_a" => network_spec },
-      "disks" => {
-        "system" => "/dev/sda1",
-        "ephemeral" => "/dev/sdb",
-        "persistent" => {}
-      },
-      "env" => {
-        "test_env" => "value"
-      },
-      "foo" => "bar", # Agent env
-      "baz" => "zaz"
-    }
-  end
-
-  def fake_image_set
-    image = double("image", :root_device_name => "/dev/sda1")
-    double("images_set", :images_set => [image])
-  end
-
-  def ec2_params(user_data, security_groups=[])
-    {
-      :image_id => "sc-id",
-      :count => 1,
-      :key_name => "test_key",
-      :security_groups => security_groups,
-      :instance_type => "m3.zb",
-      :user_data => Yajl::Encoder.encode(user_data),
-      :availability_zone => "foobar-1a"
-    }
-  end
-
-  before(:each) do
-    @registry = mock_registry
-  end
-
-  it "creates EC2 instance and polls until it's ready" do
-    unique_name = UUIDTools::UUID.random_create.to_s
-
-    user_data = {
-      "registry" => {
-        "endpoint" => "http://registry:3333"
-      }
-    }
-
-    sec_grp = double("security_group", :name => "default")
-    instance = double("instance",
-                      :id => "i-test",
-                      :elastic_ip => nil,
-                      :security_groups => [sec_grp])
-    client = double("client", :describe_images => fake_image_set)
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.should_receive(:create).
-        with(ec2_params(user_data, %w[default])).
-        and_return(instance)
-      ec2.should_receive(:client).and_return(client)
-    end
-
-    cloud.should_receive(:generate_unique_name).and_return(unique_name)
-    cloud.should_receive(:wait_resource).with(instance, :running)
-    @registry.should_receive(:update_settings)
-      .with("i-test", agent_settings(unique_name))
-
-    vm_id = cloud.create_vm("agent-id", "sc-id",
-                            resource_pool_spec,
-                            { "network_a" => dynamic_network_spec },
-                            nil, { "test_env" => "value" })
-
-    vm_id.should == "i-test"
-  end
-
-  it "passes dns servers in ec2 user data when present" do
-    unique_name = UUIDTools::UUID.random_create.to_s
-
-    user_data = {
-        "registry" => {
-            "endpoint" => "http://registry:3333"
-        },
-        "dns" => { "nameserver" => ["1.2.3.4"] }
-    }
-
-    sec_grp = double("security_group", :name => "default")
-    instance = double("instance",
-                      :id => "i-test",
-                      :elastic_ip => nil,
-                      :security_groups => sec_grp)
-    client = double("client", :describe_images => fake_image_set)
-
-    network_spec = dynamic_network_spec
-    network_spec["dns"] = ["1.2.3.4"]
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.should_receive(:create).
-          with(ec2_params(user_data, %w[default])).
-          and_return(instance)
-      ec2.should_receive(:client).and_return(client)
-    end
-
-    cloud.should_receive(:generate_unique_name).and_return(unique_name)
-    cloud.should_receive(:wait_resource).with(instance, :running)
-    @registry.should_receive(:update_settings)
-      .with("i-test", agent_settings(unique_name, network_spec))
-
-    vm_id = cloud.create_vm("agent-id", "sc-id",
-                            resource_pool_spec,
-                            { "network_a" => network_spec },
-                            nil, { "test_env" => "value" })
-
-    vm_id.should == "i-test"
-  end
-
-  it "creates EC2 instance with security group" do
-    unique_name = UUIDTools::UUID.random_create.to_s
-
-    user_data = {
-      "registry" => {
-        "endpoint" => "http://registry:3333"
-      }
-    }
-
-    instance = double("instance",
-                      :id => "i-test",
-                      :elastic_ip => nil,
-                      :security_groups => [])
-    client = double("client", :describe_images => fake_image_set)
-
-    security_groups = %w[bar foo]
-    network_spec = dynamic_network_spec
-    network_spec["cloud_properties"] = {
-      "security_groups" => security_groups
-    }
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.should_receive(:create).
-        with(ec2_params(user_data, security_groups)).
-        and_return(instance)
-      ec2.should_receive(:client).and_return(client)
-    end
-
-    cloud.should_receive(:generate_unique_name).and_return(unique_name)
-    cloud.should_receive(:wait_resource).with(instance, :running)
-    @registry.should_receive(:update_settings)
-      .with("i-test", agent_settings(unique_name, network_spec))
-
-    vm_id = cloud.create_vm("agent-id", "sc-id",
-                            resource_pool_spec,
-                            { "network_a" => network_spec },
-                            nil, { "test_env" => "value" })
-
-    vm_id.should == "i-test"
-  end
-
-  it "associates instance with elastic ip if vip network is provided" do
-    sec_grp = double("security_group", :name => "default")
-    instance = double("instance",
-                      :id => "i-test",
-                      :elastic_ip => nil,
-                      :security_groups => [sec_grp])
-    client = double("client", :describe_images => fake_image_set)
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.should_receive(:create).and_return(instance)
-      image = double("image")
-      image.should_receive(:root_device_name).and_return("/dev/sda1")
-
-      result = double("result")
-      result.should_receive(:images_set).and_return([image])
-
-      client = double("client")
-      client.should_receive(:describe_images).with({:image_ids=>["sc-id"]}).
-          and_return(result)
-
-      ec2.should_receive(:client).and_return(client)
-    end
-
-    instance.should_receive(:associate_elastic_ip).with("10.0.0.1")
-    cloud.should_receive(:wait_resource).with(instance, :running)
-    @registry.should_receive(:update_settings)
-
-    vm_id = cloud.create_vm("agent-id", "sc-id",
-                            resource_pool_spec,
-                            combined_network_spec)
-  end
-
-  def volume(zone)
-    vol = double("volume")
-    vol.stub(:availability_zone).and_return(zone)
-    vol
-  end
-
-  describe "#select_availability_zone" do
-
-    it "should select the default availability_zone when all values are nil" do
-      cloud = mock_cloud
-      cloud.select_availability_zone(nil, nil).should ==
-        Bosh::AwsCloud::Cloud::DEFAULT_AVAILABILITY_ZONE
-    end
-
-    it "should select the zone from a list of disks" do
-      cloud = mock_cloud do |ec2|
-        ec2.volumes.stub(:[]).and_return(volume("foo"), volume("foo"))
-      end
-      cloud.select_availability_zone(%w[cid1 cid2], nil).should == "foo"
-    end
-
-    it "should select the zone from a list of disks and a default" do
-      cloud = mock_cloud do |ec2|
-        ec2.volumes.stub(:[]).and_return(volume("foo"), volume("foo"))
-      end
-      cloud.select_availability_zone(%w[cid1 cid2], "foo").should == "foo"
-    end
-  end
-
-  describe "#ensure_same_availability_zone" do
-    it "should raise an error when the zones differ" do
-      cloud = mock_cloud
-      lambda {
-        cloud.ensure_same_availability_zone([volume("foo"), volume("bar")], nil)
-      }.should raise_error Bosh::Clouds::CloudError
-    end
-
-    it "should raise an error when the zones differ" do
-      cloud = mock_cloud
-      lambda {
-        cloud.ensure_same_availability_zone([volume("foo"), volume("bar")], "foo")
-      }.should raise_error Bosh::Clouds::CloudError
-    end
-
-    it "should raise an error when the zones differ" do
-      cloud = mock_cloud
-      lambda {
-        cloud.ensure_same_availability_zone([volume("foo"), volume("foo")], "bar")
-      }.should raise_error Bosh::Clouds::CloudError
-    end
-  end
-
-end

data/spec/unit/delete_disk_spec.rb

@@ -1,34 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Cloud do
-
-  it "deletes an EC2 volume" do
-    volume = double("volume", :id => "v-foo")
-
-    cloud = mock_cloud do |ec2|
-      ec2.volumes.stub(:[]).with("v-foo").and_return(volume)
-    end
-
-    volume.should_receive(:state).and_return(:available)
-    volume.should_receive(:delete)
-    cloud.should_receive(:wait_resource).with(volume, :deleted)
-
-    cloud.delete_disk("v-foo")
-  end
-
-  it "doesn't delete volume unless it's state is `available'" do
-    volume = double("volume", :id => "v-foo", :state => :busy)
-
-    cloud = mock_cloud do |ec2|
-      ec2.volumes.stub(:[]).with("v-foo").and_return(volume)
-    end
-
-    expect {
-      cloud.delete_disk("v-foo")
-    }.to raise_error(Bosh::Clouds::CloudError,
-                     "Cannot delete volume `v-foo', state is busy")
-  end
-
-end

data/spec/unit/delete_stemcell_spec.rb

@@ -1,29 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Cloud do
-
-  it "deregisters EC2 image" do
-    image = double("image", :id => "i-foo")
-
-    snapshot = double("snapshot")
-    snapshot.should_receive(:delete)
-
-    snapshots = double("snapshots")
-    snapshots.should_receive(:[]).with("snap-123").and_return(snapshot)
-
-    cloud = mock_cloud do |ec2|
-      ec2.images.stub(:[]).with("i-foo").and_return(image)
-      ec2.should_receive(:snapshots).and_return(snapshots)
-    end
-
-    image.should_receive(:deregister)
-
-    map = { "/dev/sda" => {:snapshot_id => "snap-123"} }
-    image.should_receive(:block_device_mappings).and_return(map)
-
-    cloud.delete_stemcell("i-foo")
-  end
-
-end

data/spec/unit/delete_vm_spec.rb

@@ -1,25 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Cloud do
-
-  before(:each) do
-    @registry = mock_registry
-  end
-
-  it "deletes an EC2 instance" do
-    instance = double("instance", :id => "i-foobar")
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.stub(:[]).with("i-foobar").and_return(instance)
-    end
-
-    instance.should_receive(:terminate)
-    cloud.should_receive(:wait_resource).with(instance, :terminated)
-
-    @registry.should_receive(:delete_settings).with("i-foobar")
-
-    cloud.delete_vm("i-foobar")
-  end
-end

data/spec/unit/detach_disk_spec.rb

@@ -1,63 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Cloud do
-
-  before(:each) do
-    @registry = mock_registry
-  end
-
-  it "detaches EC2 volume from an instance" do
-    instance = double("instance", :id => "i-test")
-    volume = double("volume", :id => "v-foobar")
-    attachment = double("attachment", :device => "/dev/sdf")
-
-    cloud = mock_cloud do |ec2|
-      ec2.instances.should_receive(:[]).with("i-test").and_return(instance)
-      ec2.volumes.should_receive(:[]).with("v-foobar").and_return(volume)
-    end
-
-    mappings = {
-      "/dev/sdf" => mock("attachment",
-                         :volume => mock("volume", :id => "v-foobar")),
-      "/dev/sdg" => mock("attachment",
-                         :volume => mock("volume", :id => "v-deadbeef")),
-    }
-
-    instance.should_receive(:block_device_mappings).and_return(mappings)
-
-    volume.should_receive(:detach_from).
-      with(instance, "/dev/sdf").and_return(attachment)
-
-    cloud.should_receive(:wait_resource).with(attachment, :detached)
-
-    old_settings = {
-      "foo" => "bar",
-      "disks" => {
-        "persistent" => {
-          "v-foobar" => "/dev/sdf",
-          "v-deadbeef" => "/dev/sdg"
-        }
-      }
-    }
-
-    new_settings = {
-      "foo" => "bar",
-      "disks" => {
-        "persistent" => {
-          "v-deadbeef" => "/dev/sdg"
-        }
-      }
-    }
-
-    @registry.should_receive(:read_settings).
-      with("i-test").
-      and_return(old_settings)
-
-    @registry.should_receive(:update_settings).with("i-test", new_settings)
-
-    cloud.detach_disk("i-test", "v-foobar")
-  end
-
-end

data/spec/unit/helpers_spec.rb

@@ -1,64 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Helpers do
-  it "should time out" do
-    Bosh::Clouds::Config.stub(:task_checkpoint)
-    cloud = mock_cloud
-
-    resource = double("resource")
-    resource.stub(:status).and_return(:start)
-    cloud.stub(:sleep)
-
-    expect {
-      cloud.wait_resource(resource, :stop, :status, 0.1)
-    }.to raise_error Bosh::Clouds::CloudError, /Timed out/
-  end
-
-  it "should not time out" do
-    cloud = mock_cloud
-
-    resource = double("resource")
-    resource.stub(:status).and_return(:start, :stopping, :stopping, :stop)
-    cloud.stub(:sleep)
-
-    lambda {
-      cloud.wait_resource(resource, :stop, :status, 0.1)
-    }.should_not raise_error Bosh::Clouds::CloudError
-  end
-
-  it "should raise error when target state is wrong" do
-    Bosh::Clouds::Config.stub(:task_checkpoint)
-    cloud = mock_cloud
-
-    resource = double("resource")
-    resource.stub(:status).and_return(:started, :failed)
-    cloud.stub(:sleep)
-
-    expect {
-      cloud.wait_resource(resource, :stopped, :status, 0.1)
-    }.to raise_error Bosh::Clouds::CloudError, /is failed, expected stopped/
-  end
-
-  it "should swallow AWS::EC2::Errors::InvalidInstanceID::NotFound" do
-    Bosh::Clouds::Config.stub(:task_checkpoint)
-    cloud = mock_cloud
-
-    resource = double("resource")
-    return_values = [:raise, :raise, :raise, :start, :start, :stop]
-    i = 0
-    resource.stub(:status) do
-      i += 1
-      if return_values[i] == :raise
-        raise AWS::EC2::Errors::InvalidInstanceID::NotFound
-      end
-      return_values[i]
-    end
-    cloud.stub(:sleep)
-
-    #lambda {
-      cloud.wait_resource(resource, :stop, :status, 0.1)
-    #}.should_not raise_error AWS::EC2::Errors::InvalidInstanceID::NotFound
-  end
-end

data/spec/unit/network_configurator_spec.rb

@@ -1,57 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::NetworkConfigurator do
-
-  def set_security_groups(spec, security_groups)
-    spec["cloud_properties"] = {
-      "security_groups" => security_groups
-    }
-  end
-
-  it "should raise an error if the spec isn't a hash" do
-    lambda {
-      Bosh::AwsCloud::NetworkConfigurator.new("foo")
-    }.should raise_error ArgumentError
-  end
-
-  describe "security groups" do
-    it "should be extracted from both dynamic and vip network" do
-      spec = {}
-      spec["network_a"] = dynamic_network_spec
-      set_security_groups(spec["network_a"], %w[foo])
-      spec["network_b"] = vip_network_spec
-      set_security_groups(spec["network_b"], %w[bar])
-
-      nc = Bosh::AwsCloud::NetworkConfigurator.new(spec)
-      nc.security_groups(nil).should == %w[bar foo]
-    end
-
-    it "should return the default groups if none are extracted" do
-      spec = {}
-      spec["network_a"] = {"type" => "dynamic"}
-
-      nc = Bosh::AwsCloud::NetworkConfigurator.new(spec)
-      nc.security_groups(%w[foo]).should == %w[foo]
-    end
-
-    it "should return an empty list if no default group is set" do
-      spec = {}
-      spec["network_a"] = {"type" => "dynamic"}
-
-      nc = Bosh::AwsCloud::NetworkConfigurator.new(spec)
-      nc.security_groups(nil).should == []
-    end
-
-    it "should raise an error when it isn't an array" do
-      spec = {}
-      spec["network_a"] = dynamic_network_spec
-      set_security_groups(spec["network_a"], "foo")
-
-      lambda {
-        Bosh::AwsCloud::NetworkConfigurator.new(spec)
-      }.should raise_error ArgumentError, "security groups must be an Array"
-    end
-  end
-end

data/spec/unit/reboot_vm_spec.rb

@@ -1,38 +0,0 @@
-# Copyright (c) 2009-2012 VMware, Inc.
-
-require File.expand_path("../../spec_helper", __FILE__)
-
-describe Bosh::AwsCloud::Cloud do
-
-  before :each do
-    @instance = double("instance", :id => "i-foobar")
-
-    @cloud = mock_cloud(mock_cloud_options) do |ec2|
-      ec2.instances.stub(:[]).with("i-foobar").and_return(@instance)
-    end
-  end
-
-  it "reboots an EC2 instance (CPI call picks soft reboot)" do
-    @cloud.should_receive(:soft_reboot).with(@instance)
-    @cloud.reboot_vm("i-foobar")
-  end
-
-  it "soft reboots an EC2 instance" do
-    @instance.should_receive(:reboot)
-    @cloud.send(:soft_reboot, @instance)
-  end
-
-  it "hard reboots an EC2 instance" do
-    # N.B. This requires ebs-store instance
-    @instance.should_receive(:stop).ordered
-    @cloud.should_receive(:wait_resource).
-      with(@instance, :stopped).ordered
-
-    @instance.should_receive(:start)
-    @cloud.should_receive(:wait_resource).ordered.
-      with(@instance, :running)
-
-    @cloud.send(:hard_reboot, @instance)
-  end
-
-end