bosh-verifyconnections 1.0.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 820df08ec6e4f8bb911adf3b77010afeaa429a7f
+  data.tar.gz: fa25cf1b90e232c949752801ff3c48f61763acc3
+SHA512:
+  metadata.gz: 7a3bdfe381d651ef8df6a21234cde13ea895dcc7c1b425db01e82d6915d0a559a73dbd583d8106ecf45624ee427e348ec7fcfb2575f97105ce2195a62a5106f7
+  data.tar.gz: c7e8be56bdf4e734b52651d41a388953d692b0925d9f1b32a669db97e4e33a7fe031049df27b97e30387acdcc4eeb68812b8af56118736971ec26089ce42c120

data/.gitignore

@@ -0,0 +1,22 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+*.bundle
+*.so
+*.o
+*.a
+mkmf.log

data/.rspec

@@ -0,0 +1,3 @@
+--format progress
+--color
+--require spec_helper

data/ChangeLog.md

@@ -0,0 +1,5 @@
+# Change Log
+
+## v1.0
+
+* Released May 3rd 2014

data/Gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in bosh-verifyconnections.gemspec
+gemspec
+
+gem "guard-rspec"

data/Guardfile

@@ -0,0 +1,8 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+guard :rspec do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/bosh/verifyconnections/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+end

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2014 Dr Nic Williams
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,69 @@
+# bosh verify connections
+
+BOSH CLI plugin that performs job interconnection verifications upon the target deployment
+
+  1. Show jobs with static IPs that aren't referenced elsewhere in the deployment properties
+  2. Show IPs in the deployment properties that aren't specified as static IPs by jobs
+  3. What internal DNS hostnames are specified but don't map to a job
+
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```
+gem 'bosh-verifyconnections'
+```
+
+## Usage
+
+```
+bosh verify connections
+```
+
+To see demonstration deployment manifests:
+
+```
+bosh deployment without verification spec/fixtures/job_with_static_ips_but_not_referenced.yml && bosh verify connections
+```
+
+![v1](https://www.evernote.com/shard/s3/sh/41947f58-90fc-4f62-b0d8-ad3fae84c0a9/5bede6c17dacef652a8758037c223642/deep/0/drnic@drnic----gems-bosh-verifyconnections---zsh---204-48.png)
+
+From this example, perhaps `service.host` should be changed to `10.244.0.6`.
+
+Others to try:
+
+```
+bosh deployment without verification spec/fixtures/property_is_bosh_dns_but_not_for_bosh_job.yml && bosh verify connections
+bosh deployment without verification spec/fixtures/property_is_static_ip_but_not_assigned_to_job.yml && bosh verify connections
+```
+
+### Example
+
+You can see that deploying Cloud Foundry on bosh-lite includes two static IPs that aren't referenced properties:
+
+```
+$ bosh verify connections
+
+Current deployment is /Users/drnic/Projects/ruby/gems/cloudfoundry/bosh-lite/manifests/cf-manifest.yml
+
+Job static IPs that are not being referenced by any properties:
++----------------------------------+--------------------------------+
+| static ip                        | job/index                      |
++----------------------------------+--------------------------------+
+| 10.244.0.34                      | ha_proxy_z1/0                  |
+| 10.244.0.26                      | runner_z1/0                    |
++----------------------------------+--------------------------------+
+```
+
+The `ha_proxy_z1/0` static IP is used for the public access via `10.244.0.34.xip.io`, but theoretically the `runner_z1/0` job has no reason for a static IP.
+
+From the [history of cf-release](https://github.com/cloudfoundry/cf-release/commit/858d1b7e1f0544fb9fd4d9a7a1608e542da6bcdd), the static IP was assigned to ease integration testing.
+
+## Contributing
+
+1. Fork it ( https://github.com/cloudfoundry-community/bosh-verifyconnections/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request

data/Rakefile

@@ -0,0 +1,2 @@
+require "bundler/gem_tasks"
+

data/bosh-verifyconnections.gemspec

@@ -0,0 +1,27 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'bosh/verifyconnections/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "bosh-verifyconnections"
+  spec.version       = Bosh::VerifyConnections::VERSION
+  spec.authors       = ["Dr Nic Williams"]
+  spec.email         = ["drnicwilliams@gmail.com"]
+  spec.summary       = %q{Performs job interconnection verifications upon the target BOSH deployment manifest file.}
+  spec.description   = %q{Performs job interconnection verifications upon the target BOSH deployment manifest file.}
+  spec.homepage      = ""
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files -z`.split("\x0")
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  spec.add_runtime_dependency "bosh_cli", "~> 1.2200.0"
+
+  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec", "~> 2.14"
+  spec.add_development_dependency "rspec-fire"
+end

data/lib/bosh/cli/commands/set_deployment_without_verification.rb

@@ -0,0 +1,41 @@
+module Bosh::Cli::Command
+  class SetDeploymentWithoutVerification < Base
+    include Bosh::Cli::Validation
+
+    usage "deployment without verification"
+    desc "Ignore the director_uuid being incorrect and set the new deployment anyway"
+    def set_current_without_verification(filename = nil)
+      if filename.nil?
+        show_current
+        return
+      end
+
+      manifest_filename = find_deployment(filename)
+
+      unless File.exists?(manifest_filename)
+        err("Missing manifest for `#{filename}'")
+      end
+
+      manifest = load_yaml_file(manifest_filename)
+
+      unless manifest.is_a?(Hash)
+        err("Invalid manifest format")
+      end
+
+      manifest["director_uuid"] = director.uuid
+
+      tmp_manifest_filename = File.join("/tmp/", "#{manifest["name"]}.yml")
+      File.open(tmp_manifest_filename, "w") do |f|
+        f.puts(manifest.to_yaml)
+      end
+
+      # change director_uuid
+      # store manifest to tmp file
+      # set_deployment
+
+      say("Deployment set to `#{tmp_manifest_filename.make_yellow}'")
+      config.set_deployment(tmp_manifest_filename)
+      config.save
+    end
+  end
+end

data/lib/bosh/cli/commands/verifyconnections.rb

@@ -0,0 +1,66 @@
+require "core-ext/hash_to_dotted_notation"
+
+module Bosh::Cli::Command
+  # Performs job interconnection verifications upon the target deployment
+  # 1. Show jobs with static IPs that aren't referenced elsewhere in the deployment properties
+  # 2. Show IPs in the deployment properties that aren't specified as static IPs by jobs
+  # 3. What .*bosh hostnames are specified but don't map to a job
+  # 4. Hostnames that don't resolve to any IP
+  class VerifyConnections < Base
+    include Bosh::Cli::Validation
+    include BoshExtensions
+
+    usage "verify connections"
+    desc "Performs job interconnection verifications upon the target deployment"
+    def verify_connections
+      require "bosh/verifyconnections"
+
+      show_deployment
+      director_model = Bosh::VerifyConnections::Director.new(director.get_status)
+      deployment_model = Bosh::VerifyConnections::Deployment.new(deployment, director_model.domain_name)
+
+      errors = false
+      warnings = false
+
+      items = deployment_model.unreferenced_static_ips_with_job_index
+      if items.size > 0
+        warnings = true
+        nl
+        say "Job static IPs that are not being referenced by any properties:".make_yellow
+        view = table(items) do |t|
+          t.headings = ["static ip", "job/index"]
+          items.each { |item| t << item }
+        end
+        say(view)
+      end
+
+      items = deployment_model.property_static_ips_not_assigned_to_job
+      if items.size > 0
+        errors = true
+        nl
+        say "Properties referencing static IPs that do not belong to any job:".make_red
+        view = table(items) do |t|
+          t.headings = ["property", "static ip", "job name"]
+          items.each { |item| t << item }
+        end
+        say(view)
+      end
+
+      items = deployment_model.property_hostnames_not_mapping_to_job
+      if items.size > 0
+        errors = true
+        nl
+        say "Internal hostnames not mapping to any job:".make_red
+        view = table(items) do |t|
+          t.headings = ["property", "hostname", "job name"]
+          items.each { |item| t << item }
+        end
+        say(view)
+      end
+
+      nl
+      err("Please review errors above") if errors
+      warning("Please review warnings above") if warnings
+    end
+  end
+end

data/lib/bosh/verifyconnections/models/deployment.rb

@@ -0,0 +1,122 @@
+require "common/deep_copy"
+require "core-ext/hash_deep_merge"
+require "core-ext/hash_to_dotted_notation"
+
+module Bosh::VerifyConnections
+  class Deployment
+    include BoshExtensions
+
+    attr_reader :deployment, :jobs, :domain_name
+
+    def initialize(deployment_file, domain_name)
+      parse_deployment_file(deployment_file)
+      @domain_name = domain_name
+    end
+
+    def deployment_name
+      @deployment["name"]
+    end
+
+    def hostnames_offered
+      jobs.inject([]) do |dns, job|
+        dns.push(*job.hostnames_offered(deployment_name, domain_name))
+        dns
+      end
+    end
+
+    def static_ips_assigned
+      jobs.inject([]) do |ips, job|
+        ips.push(*job.static_ips_assigned)
+        ips
+      end
+    end
+
+    def static_ips_with_job_index
+      jobs.inject([]) do |ips, job|
+        job.static_ips_assigned.each_with_index do |ip, index|
+          job_index = "#{job.job_name}/#{index}"
+          ips << [ip, job_index]
+        end
+        ips
+      end
+    end
+
+    # @return Array [ip, job_index]
+    def unreferenced_static_ips_with_job_index
+      static_ips_with_job_index.reject do |ip, _|
+        all_property_values.include?(ip)
+      end
+    end
+
+    def all_properties_by_job
+      @all_properties_by_job ||= begin
+        all = { "global" => global_properties }
+        jobs.each do |job|
+          all[job.job_name] = job.job_properties
+        end
+        all
+      end
+    end
+
+    def all_property_values
+      @all_property_values ||=
+        all_properties_by_job.values.map(&:to_dotted_hash).map(&:values).flatten
+    end
+
+    # @return Array [ip, job_name, property_name]
+    def property_static_ips_not_assigned_to_job
+      result = []
+      all_properties_by_job.each do |job_name, properties|
+        properties.to_dotted_hash.each do |key, value|
+          result << [key, value, job_name] if invalid_static_ip?(value)
+        end
+      end
+      result
+    end
+
+    # @return Array [hostname, job_name, property_name]
+    def property_hostnames_not_mapping_to_job
+      result = []
+      all_properties_by_job.each do |job_name, properties|
+        properties.to_dotted_hash.each do |key, value|
+          result << [key, value, job_name] if invalid_internal_hostname?(value)
+        end
+      end
+      result
+    end
+
+    def job(job_name)
+      jobs.find { |job| job.job_name == job_name }
+    end
+
+    def global_properties
+      @deployment["properties"]
+    end
+
+    private
+    def parse_deployment_file(deployment_file)
+      @deployment_file = deployment_file
+      @deployment = load_yaml_file(@deployment_file)
+      @jobs = @deployment["jobs"].map do |manifest_job|
+        DeploymentJob.new(manifest_job)
+      end
+    end
+
+    def invalid_static_ip?(value)
+      return false unless value.is_a? String
+      parts = value.split(".")
+      return false if parts.size != 4
+      parts.each do |part|
+        return false if part.to_i.to_s != part
+      end
+      return !static_ips_assigned.include?(value)
+    end
+
+    def invalid_internal_hostname?(value)
+      return false unless value.is_a? String
+      return false unless (value =~ /\.#{domain_name}$/)
+      return !hostnames_offered.include?(value)
+    end
+
+  end
+end

data/lib/bosh/verifyconnections/models/deployment_job.rb

@@ -0,0 +1,64 @@
+class Bosh::VerifyConnections::DeploymentJob
+  class DnsInvalidCanonicalName < StandardError; end
+
+  def initialize(job_from_manifest)
+    @from_manifest = job_from_manifest
+  end
+
+  def job_name
+    @from_manifest["name"]
+  end
+
+  def instances
+    @from_manifest["instances"]
+  end
+
+  def networks
+    @from_manifest["networks"]
+  end
+
+  def static_ips_assigned
+    networks.inject([]) do |ips, network|
+      if network["static_ips"]
+        ips.push(*network["static_ips"])
+      end
+      ips
+    end
+  end
+
+  def hostnames_offered(deployment_name, dns_suffix)
+    deployment_name = dns_canonical(deployment_name)
+    dns_suffix = dns_canonical(dns_suffix)
+    job_name = dns_canonical(self.job_name)
+    networks.inject([]) do |hostnames, network|
+      network_name = dns_canonical(network["name"])
+      0.upto(instances-1) do |n|
+        hostnames << [n, job_name, network_name, deployment_name, dns_suffix].join(".")
+      end
+      hostnames
+    end
+  end
+
+  def job_properties
+    @from_manifest["properties"] || {}
+  end
+
+  private
+    def dns_canonical(string)
+      unless string
+        raise DnsInvalidCanonicalName, "Must provide a string"
+      end
+      # a-z, 0-9, -, case insensitive, and must start with a letter
+      string = string.downcase.gsub(/_/, "-").gsub(/[^a-z0-9-]/, "")
+      if string =~ /^(\d|-)/
+        raise DnsInvalidCanonicalName,
+              "Invalid DNS canonical name `#{string}', must begin with a letter"
+      end
+      if string =~ /-$/
+        raise DnsInvalidCanonicalName,
+              "Invalid DNS canonical name `#{string}', can't end with a hyphen"
+      end
+      string
+    end
+
+end

data/lib/bosh/verifyconnections/models/director.rb

@@ -0,0 +1,15 @@
+module Bosh::VerifyConnections
+  class Director
+    def initialize(status)
+      @status = status
+    end
+
+    def dns?
+      @status["features"]["dns"] && @status["features"]["dns"]["status"]
+    end
+
+    def domain_name
+      @status["features"]["dns"]["extras"]["domain_name"]
+    end
+  end
+end

data/lib/bosh/verifyconnections/models.rb

@@ -0,0 +1,3 @@
+require "bosh/verifyconnections/models/deployment_job"
+require "bosh/verifyconnections/models/deployment"
+require "bosh/verifyconnections/models/director"

data/lib/bosh/verifyconnections/version.rb

@@ -0,0 +1,5 @@
+module Bosh
+  module VerifyConnections
+    VERSION = "1.0.1"
+  end
+end

data/lib/bosh/verifyconnections.rb

@@ -0,0 +1,7 @@
+module Bosh
+  module VerifyConnections
+    # Your code goes here...
+  end
+end
+
+require "bosh/verifyconnections/models"

data/lib/core-ext/hash_deep_merge.rb

@@ -0,0 +1,34 @@
+# https://github.com/Offirmo/hash-deep-merge/blob/master/lib/hash_deep_merge.rb
+class Hash
+
+	def deep_merge!(specialized_hash)
+		return internal_deep_merge!(self, specialized_hash)
+	end
+
+
+	def deep_merge(specialized_hash)
+		return internal_deep_merge!(Hash.new.replace(self), specialized_hash)
+	end
+
+	protected
+
+		# better, recursive, preserving method
+		# OK OK this is not the most efficient algorithm,
+		# but at last it's *perfectly clear and understandable*
+		# so fork and improve if you need 5% more speed, ok ?
+		def internal_deep_merge!(source_hash, specialized_hash)
+			specialized_hash.each_pair do |rkey, rval|
+				if source_hash.has_key?(rkey) then
+					if rval.is_a?(Hash) and source_hash[rkey].is_a?(Hash) then
+						internal_deep_merge!(source_hash[rkey], rval)
+					elsif rval == source_hash[rkey] then
+					else
+						source_hash[rkey] = rval
+					end
+				else
+					source_hash[rkey] = rval
+				end
+			end
+			source_hash
+		end
+end

data/lib/core-ext/hash_to_dotted_notation.rb

@@ -0,0 +1,13 @@
+# From http://raycoding.net/2013/08/26/nested-hash-to-dotted-notation-hash-in-ruby/
+class Hash
+  def to_dotted_hash(recursive_key = "")
+    self.each_with_object({}) do |(k, v), ret|
+      key = recursive_key + k.to_s
+      if v.is_a? Hash
+        ret.merge!(v.to_dotted_hash(key + "."))
+      else
+        ret[key] = v
+      end
+    end
+  end
+end

data/spec/fixtures/job_with_static_ips_but_not_referenced.yml

@@ -0,0 +1,77 @@
+---
+name: job_with_static_ips_but_not_referenced
+releases:
+  - name: cf
+    version: latest
+
+networks:
+- name: cf1
+  subnets:
+  # static
+  - cloud_properties:
+      name: random
+    range: 10.244.0.0/30
+    reserved:
+    - 10.244.0.1
+    static:
+    - 10.244.0.2
+  - cloud_properties:
+      name: random
+    range: 10.244.0.4/30
+    reserved:
+    - 10.244.0.5
+    static:
+    - 10.244.0.6
+  - cloud_properties:
+      name: random
+    range: 10.244.0.8/30
+    reserved:
+    - 10.244.0.9
+    static:
+    - 10.244.0.10
+
+  # dynamic
+  - cloud_properties:
+      name: random
+    range: 10.244.0.128/30
+    reserved:
+    - 10.244.0.129
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.132/30
+    reserved:
+    - 10.244.0.133
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.136/30
+    reserved:
+    - 10.244.0.137
+
+jobs:
+- name: ephemeral
+  instances: 2
+  templates:
+    - name: cloud_controller_ng
+  networks:
+  - name: cf1
+- name: service
+  instances: 1
+  templates:
+    - name: postgres
+  networks:
+  - name: cf1
+    default: [dns, gateway]
+  - name: floating
+    static_ips:
+    - 10.244.0.6
+  properties:
+    service:
+      port: 4444
+    extra: property
+
+properties:
+  service:
+    host: 10.244.0.10
+    port: 3333

data/spec/fixtures/property_is_bosh_dns_but_not_for_bosh_job.yml

@@ -0,0 +1,78 @@
+---
+name: job_with_static_ips_but_not_referenced
+releases:
+  - name: cf
+    version: latest
+
+networks:
+- name: cf1
+  subnets:
+  # static
+  - cloud_properties:
+      name: random
+    range: 10.244.0.0/30
+    reserved:
+    - 10.244.0.1
+    static:
+    - 10.244.0.2
+  - cloud_properties:
+      name: random
+    range: 10.244.0.4/30
+    reserved:
+    - 10.244.0.5
+    static:
+    - 10.244.0.6
+  - cloud_properties:
+      name: random
+    range: 10.244.0.8/30
+    reserved:
+    - 10.244.0.9
+    static:
+    - 10.244.0.10
+
+  # dynamic
+  - cloud_properties:
+      name: random
+    range: 10.244.0.128/30
+    reserved:
+    - 10.244.0.129
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.132/30
+    reserved:
+    - 10.244.0.133
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.136/30
+    reserved:
+    - 10.244.0.137
+
+jobs:
+- name: ephemeral
+  instances: 2
+  templates:
+    - name: cloud_controller_ng
+  networks:
+  - name: cf1
+- name: service
+  instances: 1
+  templates:
+    - name: postgres
+  networks:
+  - name: cf1
+    default: [dns, gateway]
+  - name: floating
+    static_ips:
+    - 10.244.0.6
+  properties:
+    service:
+      port: 4444
+      host: 0.service.floating.job-with-static-ips-but-not-referenced.microbosh
+    extra: property
+
+properties:
+  service:
+    host: 0.some-service.cf1.job-with-static-ips-but-not-referenced.microbosh
+    port: 3333

data/spec/fixtures/property_is_static_ip_but_not_assigned_to_job.yml

@@ -0,0 +1,76 @@
+---
+name: job_with_static_ips_but_not_referenced
+releases:
+  - name: cf
+    version: latest
+
+networks:
+- name: cf1
+  subnets:
+  # static
+  - cloud_properties:
+      name: random
+    range: 10.244.0.0/30
+    reserved:
+    - 10.244.0.1
+    static:
+    - 10.244.0.2
+  - cloud_properties:
+      name: random
+    range: 10.244.0.4/30
+    reserved:
+    - 10.244.0.5
+    static:
+    - 10.244.0.6
+  - cloud_properties:
+      name: random
+    range: 10.244.0.8/30
+    reserved:
+    - 10.244.0.9
+    static:
+    - 10.244.0.10
+
+  # dynamic
+  - cloud_properties:
+      name: random
+    range: 10.244.0.128/30
+    reserved:
+    - 10.244.0.129
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.132/30
+    reserved:
+    - 10.244.0.133
+    static: []
+  - cloud_properties:
+      name: random
+    range: 10.244.0.136/30
+    reserved:
+    - 10.244.0.137
+
+jobs:
+- name: ephemeral
+  instances: 2
+  templates:
+    - name: cloud_controller_ng
+  networks:
+  - name: cf1
+  properties:
+    service:
+      host: 10.244.0.6
+- name: service
+  instances: 1
+  templates:
+    - name: postgres
+  networks:
+  - name: cf1
+    default: [dns, gateway]
+  - name: floating
+    static_ips:
+    - 10.244.0.6
+
+properties:
+  service:
+    host: 10.244.0.10
+    port: 3333

data/spec/models/deployment_job_spec.rb

@@ -0,0 +1,37 @@
+describe Bosh::VerifyConnections::DeploymentJob do
+  context "static_ips" do
+    subject do
+      Bosh::VerifyConnections::DeploymentJob.new({
+        "name" => "service_name",
+        "instances" => 1,
+        "templates" => [{
+          "name" => "postgres"
+        }],
+        "networks" => [
+          {
+            "name" => "internal_network",
+            "default" => ["dns", "gateway"]
+          },
+          {
+            "name" => "floating",
+            "static_ips" => ["10.244.0.6"]
+          }
+        ],
+        "properties" => {
+          "port" => 3333,
+          "nested" => {
+            "key" => "value"
+          }
+        }
+      })
+    end
+    it { expect(subject.instances).to eq(1) }
+    it { expect(subject.static_ips_assigned).to eq(["10.244.0.6"])}
+    it { expect(subject.hostnames_offered("my_deployment", "suffix")).to eq([
+      "0.service-name.internal-network.my-deployment.suffix",
+      "0.service-name.floating.my-deployment.suffix"
+    ])}
+    it { expect(subject.job_properties).to eq({"port" => 3333, "nested" => {"key" => "value"}}) }
+
+  end
+end

data/spec/models/deployment_spec.rb

@@ -0,0 +1,48 @@
+describe Bosh::VerifyConnections::Deployment do
+  context "job_with_static_ips_but_not_referenced" do
+    let(:manifest) { spec_fixture("job_with_static_ips_but_not_referenced.yml") }
+    subject { Bosh::VerifyConnections::Deployment.new(manifest, "microbosh") }
+
+    it { expect(subject.jobs.size).to eq(2) }
+    it { expect(subject.hostnames_offered).to eq([
+      "0.ephemeral.cf1.job-with-static-ips-but-not-referenced.microbosh",
+      "1.ephemeral.cf1.job-with-static-ips-but-not-referenced.microbosh",
+      "0.service.cf1.job-with-static-ips-but-not-referenced.microbosh",
+      "0.service.floating.job-with-static-ips-but-not-referenced.microbosh"
+    ])}
+
+    it { expect(subject.static_ips_assigned).to eq(["10.244.0.6"])}
+    it { expect(subject.global_properties).to eq({
+      "service" => {
+        "host" => "10.244.0.10",
+        "port" => 3333
+      }
+    })}
+
+    it { expect(subject.unreferenced_static_ips_with_job_index).to eq([["10.244.0.6", "service/0"]]) }
+    it { expect(subject.property_static_ips_not_assigned_to_job).to eq([["service.host", "10.244.0.10", "global"]]) }
+    it { expect(subject.property_hostnames_not_mapping_to_job).to eq([]) }
+  end
+
+  context "property_is_bosh_dns_but_not_for_bosh_job" do
+    let(:manifest) { spec_fixture("property_is_bosh_dns_but_not_for_bosh_job.yml") }
+    subject { Bosh::VerifyConnections::Deployment.new(manifest, "microbosh") }
+
+    it { expect(subject.unreferenced_static_ips_with_job_index).to eq([["10.244.0.6", "service/0"]]) }
+    it { expect(subject.property_static_ips_not_assigned_to_job).to eq([]) }
+    it { expect(subject.property_hostnames_not_mapping_to_job).to eq([
+      ["service.host", "0.some-service.cf1.job-with-static-ips-but-not-referenced.microbosh", "global"]
+    ]) }
+  end
+
+  context "property_is_static_ip_but_not_assigned_to_job" do
+    let(:manifest) { spec_fixture("property_is_static_ip_but_not_assigned_to_job.yml") }
+    subject { Bosh::VerifyConnections::Deployment.new(manifest, "microbosh") }
+
+    it { expect(subject.unreferenced_static_ips_with_job_index).to eq([]) }
+    it { expect(subject.property_static_ips_not_assigned_to_job).to eq([["service.host", "10.244.0.10", "global"]]) }
+    it { expect(subject.property_hostnames_not_mapping_to_job).to eq([]) }
+  end
+
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,59 @@
+# Copyright (c) 2012-2013 Stark & Wayne, LLC
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
+
+require "rubygems"
+require "bundler"
+Bundler.setup(:default, :test)
+
+$:.unshift(File.expand_path("../../lib", __FILE__))
+
+require "rspec/core"
+require 'rspec/fire'
+
+# for the #sh helper
+require "rake"
+require "rake/file_utils"
+
+# bosh_cli
+require "cli"
+
+require "bosh/verifyconnections"
+
+RSpec.configure do |config|
+  config.include(RSpec::Fire)
+end
+
+# load all files in spec/support/* (but not lower down)
+Dir[File.dirname(__FILE__) + '/support/*'].each do |path|
+  require path unless File.directory?(path)
+end
+
+def spec_fixture(filename)
+  File.expand_path("../fixtures/#{filename}", __FILE__)
+end
+
+def setup_home_dir
+  home_dir = File.expand_path("../../tmp/home", __FILE__)
+  FileUtils.rm_rf(home_dir)
+  FileUtils.mkdir_p(home_dir)
+  ENV['HOME'] = home_dir
+end
+
+# returns the file path to a file
+# in the fake $HOME folder
+def home_file(*path)
+  File.join(ENV['HOME'], *path)
+end
+
+def in_home_dir(&block)
+  FileUtils.chdir(home_file, &block)
+end
+
+def get_tmp_file_path(content)
+  tmp_file = File.open(File.join(Dir.mktmpdir, "tmp"), "w")
+  tmp_file.write(content)
+  tmp_file.close
+
+  tmp_file.path
+end

metadata

@@ -0,0 +1,149 @@
+--- !ruby/object:Gem::Specification
+name: bosh-verifyconnections
+version: !ruby/object:Gem::Version
+  version: 1.0.1
+platform: ruby
+authors:
+- Dr Nic Williams
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2014-05-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: bosh_cli
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2200.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2200.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: rspec-fire
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Performs job interconnection verifications upon the target BOSH deployment
+  manifest file.
+email:
+- drnicwilliams@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- .rspec
+- ChangeLog.md
+- Gemfile
+- Guardfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- bosh-verifyconnections.gemspec
+- lib/bosh/cli/commands/set_deployment_without_verification.rb
+- lib/bosh/cli/commands/verifyconnections.rb
+- lib/bosh/verifyconnections.rb
+- lib/bosh/verifyconnections/models.rb
+- lib/bosh/verifyconnections/models/deployment.rb
+- lib/bosh/verifyconnections/models/deployment_job.rb
+- lib/bosh/verifyconnections/models/director.rb
+- lib/bosh/verifyconnections/version.rb
+- lib/core-ext/hash_deep_merge.rb
+- lib/core-ext/hash_to_dotted_notation.rb
+- spec/fixtures/combination_of_correct_dns_and_static_ip_connections.yml
+- spec/fixtures/job_with_static_ips_but_not_referenced.yml
+- spec/fixtures/property_is_bosh_dns_but_not_for_bosh_job.yml
+- spec/fixtures/property_is_static_ip_but_not_assigned_to_job.yml
+- spec/models/deployment_job_spec.rb
+- spec/models/deployment_spec.rb
+- spec/spec_helper.rb
+homepage: ''
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.2.2
+signing_key: 
+specification_version: 4
+summary: Performs job interconnection verifications upon the target BOSH deployment
+  manifest file.
+test_files:
+- spec/fixtures/combination_of_correct_dns_and_static_ip_connections.yml
+- spec/fixtures/job_with_static_ips_but_not_referenced.yml
+- spec/fixtures/property_is_bosh_dns_but_not_for_bosh_job.yml
+- spec/fixtures/property_is_static_ip_but_not_assigned_to_job.yml
+- spec/models/deployment_job_spec.rb
+- spec/models/deployment_spec.rb
+- spec/spec_helper.rb