bosh-gen 0.17.1 → 0.18.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    N2JjZDA3YzU4NWRmYmE2YmNlZjYxZDU5YzZjNWU5NzQwODRlOWIxNA==
-  data.tar.gz: !binary |-
-    MjU1MGQzNDJjYTRkYjYzNjc5OTYwYTg5NGJhZTRjYjgzMDMxZGMwZQ==
+SHA1:
+  metadata.gz: eb772775c13bd207fa2e58169dad496f87bcdbf2
+  data.tar.gz: 5a37c67880e8e463654d35da2e260580d6b2757f
 SHA512:
-  metadata.gz: !binary |-
-    MTZmMDA4OTQxYWMxYjk0MDk1NzIzZDViNTUxNDQxYTI1ODI2ZWUyZTBmZTNm
-    ZTRiYTliNWVlY2IxNDlhNWJkOWZjMWY1Y2U2YjAzN2E2NTJiZWRhNTZkNGJj
-    ZWZmYWY0ZjUzZDJjZGQxOTRmNTMwMTM0ODhlN2MxMTg1OTE4ZWI=
-  data.tar.gz: !binary |-
-    MWFhMjE5ZDZjYTMwYzkyMWQ2MDQ3ZmQ4NjAwZGIwZGZjZmJlMmM2MTRkOWVk
-    ZDY4ZjJkYTZmMTIyOTA2NWRjNWIxZWFkOTFjMGU2NGJjOTNiY2VlZTczOTdj
-    NmE0ZmYxZDU5MmJhMTRkZWI1OGNhNjdkNWU5OTY4ZDkyOTQ3ZjI=
+  metadata.gz: b0b968b05d80a09a1dd75bd245a6874ab08943705176e4112e0a3515ed3c74bbd255db38da3f45e5362c77507416c7eae55b127b94155427e4e68b598ae19a57
+  data.tar.gz: 730fe6855982b1b5b4cab1b8bac3376aefde3402ecfe6c5a9204a0ff5e74694f1a796f5274da8baf63d44617efcdd8f19b74b9f6146cff6712c961ac3fe8324a

data/ChangeLog.md

@@ -1,6 +1,11 @@
 Change Log
 ==========
 
+v0.18.0
+
+- `errand` - generates an errand-style job template
+- `copy_property` helper now in bosh-templates gem
+
 v0.17.0
 -------
 

data/Gemfile

@@ -8,6 +8,5 @@ if File.directory?("../cyoi")
 end
 
 gem 'bosh_cli', '~> 1.1750'
-gem 'bosh_common', '~> 1.1750'
 
 gem 'guard-rspec'

data/README.md

@@ -14,7 +14,9 @@ Installation
 
 This application requires Ruby 1.9 or 2.0 and is installed via RubyGems:
 
+```
 $ gem install bosh-gen
+```
 
 Usage
 -----
@@ -241,6 +243,8 @@ $ bosh upload release https://my-project-boshrelease.s3.amazonaws.com/boshreleas
 
 They no longer require your BOSH release repo to access the BOSH release.
 
+![share-http-tarball](http://f.cl.ly/items/0R3A1w3k2E3h3a2d1g2U/bosh-gen-share-release.gif)
+
 ### BOSH community facilities
 
 You are welcome to re-use the BOSH user community facilities:

data/bosh-gen.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency "thor"
   gem.add_dependency "bosh_cli"
-  gem.add_dependency "bosh_common"
+  gem.add_dependency "bosh-template"
   gem.add_dependency "progressbar"
 
   gem.add_dependency "cyoi", "~> 0.10"

data/lib/bosh/cli/commands/share_release.rb

@@ -30,7 +30,9 @@ module Bosh::Cli::Command
       bucket_name = raw_blobstore_client.instance_variable_get("@bucket_name")
 
       fog = fog_storage(raw_blobstore_client)
-      dir = fog.directories.get(bucket_name)
+      unless dir = fog.directories.get(bucket_name)
+        err("S3 bucket #{bucket_name} is missing")
+      end
 
       say("\nUploading release...")
       if file = dir.files.new(key: upload_name, body: f)

data/lib/bosh/gen/cli.rb

@@ -72,6 +72,15 @@ module Bosh
         Bosh::Gen::Generators::JobGenerator.start([name, dependencies, 'simple'])
       end
 
+      desc "errand NAME", "Create a new errand"
+      method_option :dependencies, :aliases => ['-d'], :type => :array,
+        :desc => "List of package dependencies"
+      def errand(name)
+        dependencies = options[:dependencies] || []
+        require 'bosh/gen/generators/errand_generator'
+        Bosh::Gen::Generators::ErrandGenerator.start([name, dependencies])
+      end
+
       desc "micro [JOB]", "Create a micro job - a collection of all jobs and packages"
       method_option :jobs, :aliases => ['-j'], :type => :array,
         :desc => "Ordered list of jobs to include"

data/lib/bosh/gen/generators/deployment_manifest_generator.rb

@@ -1,12 +1,12 @@
 require 'yaml'
 require 'thor/group'
-require 'common/properties/property_helper' # bosh_common
+require 'bosh/template/property_helper'
 
 module Bosh::Gen
   module Generators
     class DeploymentManifestGenerator < Thor::Group
       include Thor::Actions
-      include Bosh::Common::PropertyHelper
+      include Bosh::Template::PropertyHelper
 
       argument :name
       argument :release_path
@@ -33,8 +33,8 @@ module Bosh::Gen
 
       # Create a deployment manifest (initially for AWS only)
       def create_deployment_manifest
-        cloud_properties = { 
-          "instance_type" => "m1.small", 
+        cloud_properties = {
+          "instance_type" => "m1.small",
         }
         cloud_properties["persistent_disk"] = flags[:disk] if flags[:disk]
         cloud_properties["static_ips"] = ip_addresses
@@ -54,12 +54,12 @@ module Bosh::Gen
       def release_detector
         @release_detector ||= Bosh::Gen::Models::ReleaseDetection.new(release_path)
       end
-      
+
       # Whether +name+ contains .yml suffix or nor, returns a .yml filename for manifest to be generated
       def manifest_file_name
         basename = "#{name}.yml"
       end
-      
+
       def job_manifests
         jobs.map do |job_name|
           {
@@ -67,7 +67,7 @@ module Bosh::Gen
           }
         end
       end
-      
+
       # Return list of job names
       def detect_jobs
         release_detector.latest_dev_release_job_names

data/lib/bosh/gen/generators/errand_generator.rb

@@ -0,0 +1,94 @@
+require 'yaml'
+require 'thor/group'
+
+module Bosh::Gen
+  module Generators
+    class ErrandGenerator < Thor::Group
+      include Thor::Actions
+
+      argument :job_name
+      argument :dependencies, :type => :array
+
+      def self.source_root
+        File.join(File.dirname(__FILE__), "errand_generator", "templates")
+      end
+
+      def check_root_is_release
+        unless File.exist?("jobs") && File.exist?("packages")
+          raise Thor::Error.new("run inside a BOSH release project")
+        end
+      end
+
+      def check_name
+        raise Thor::Error.new("'#{job_name}' is not a valid BOSH id") unless job_name.bosh_valid_id?
+      end
+
+      def warn_missing_dependencies
+        dependencies.each do |d|
+          raise Thor::Error.new("dependency '#{d}' is not a valid BOSH id") unless d.bosh_valid_id?
+          unless File.exist?(File.join("packages", d))
+            say_status "warning", "missing dependency '#{d}'", :yellow
+          end
+        end
+      end
+
+      # copy the thor template files into the bosh release to be bosh templates
+      # that's right, templates (.tt) can become templates (.erb)
+      def template_files
+        generator_job_templates_path = File.join(self.class.source_root, "jobs/%job_name%")
+        directory "jobs/%job_name%", "jobs/#{job_name}"
+
+        # build a hash of { 'bin/webapp_ctl.erb' => 'bin/webapp_ctl', ...} used in spec
+        @template_files = {}
+        FileUtils.chdir(File.join(generator_job_templates_path, "templates")) do
+          `ls */*`.split("\n").each do |template_file|
+            # clean up thor name convention
+            template_file.gsub!("%job_name%", job_name)
+            template_file.gsub!(".tt", "")
+            # strip erb from target file
+            target_template_file = template_file.gsub(/.erb/, '')
+
+            @template_files[template_file] = target_template_file
+          end
+        end
+      end
+
+      def job_specification
+        config = { "name" => job_name, "packages" => dependencies, "templates" => @template_files }
+        create_file job_dir("spec"), YAML.dump(config)
+      end
+
+      def readme
+        say_status "readme", "Add job to deploymemt manifest with lifecycle: errand"
+        
+      end
+
+      private
+      def filenames
+        files.map {|f| File.basename(f) }
+      end
+
+      def job_dir(path)
+        File.join("jobs", job_name, path)
+      end
+
+      # Run a command in git.
+      #
+      # ==== Examples
+      #
+      #   git :init
+      #   git :add => "this.file that.rb"
+      #   git :add => "onefile.rb", :rm => "badfile.cxx"
+      #
+      def git(commands={})
+        if commands.is_a?(Symbol)
+          run "git #{commands}"
+        else
+          commands.each do |cmd, options|
+            run "git #{cmd} #{options}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/bin/run

@@ -0,0 +1,12 @@
+#!/bin/bash
+
+set -e # exit immediately if a simple command exits with a non-zero status
+set -u # report the usage of uninitialized variables
+
+# Setup env vars and folders for the webapp_ctl script
+source /var/vcap/jobs/<%= job_name %>/helpers/ctl_setup.sh '<%= job_name %>'
+
+EXITSTATUS=0
+
+echo "Errand <%= job_name %> is complete; exit status $EXITSTATUS"
+exit $EXITSTATUS

data/lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/helpers/ctl_setup.sh

@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
+
+# Setup env vars and folders for the ctl script
+# This helps keep the ctl script as readable
+# as possible
+
+# Usage options:
+# source /var/vcap/jobs/foobar/helpers/ctl_setup.sh JOB_NAME OUTPUT_LABEL
+# source /var/vcap/jobs/foobar/helpers/ctl_setup.sh foobar
+# source /var/vcap/jobs/foobar/helpers/ctl_setup.sh foobar foobar
+# source /var/vcap/jobs/foobar/helpers/ctl_setup.sh foobar nginx
+
+set -e # exit immediately if a simple command exits with a non-zero status
+set -u # report the usage of uninitialized variables
+
+JOB_NAME=$1
+output_label=${2:-${JOB_NAME}}
+
+export JOB_DIR=/var/vcap/jobs/$JOB_NAME
+chmod 755 $JOB_DIR # to access file via symlink
+
+# Load some bosh deployment properties into env vars
+# Try to put all ERb into data/properties.sh.erb
+# incl $NAME, $JOB_INDEX, $WEBAPP_DIR
+source $JOB_DIR/data/properties.sh
+
+source $JOB_DIR/helpers/ctl_utils.sh
+redirect_output ${output_label}
+
+export HOME=${HOME:-/home/vcap}
+
+# Add all packages' /bin & /sbin into $PATH
+for package_bin_dir in $(ls -d /var/vcap/packages/*/*bin)
+do
+  export PATH=${package_bin_dir}:$PATH
+done
+
+export LD_LIBRARY_PATH=${LD_LIBRARY_PATH:-''} # default to empty
+for package_bin_dir in $(ls -d /var/vcap/packages/*/lib)
+do
+  export LD_LIBRARY_PATH=${package_bin_dir}:$LD_LIBRARY_PATH
+done
+
+# Setup log, run and tmp folders
+
+export RUN_DIR=/var/vcap/sys/run/$JOB_NAME
+export LOG_DIR=/var/vcap/sys/log/$JOB_NAME
+export TMP_DIR=/var/vcap/sys/tmp/$JOB_NAME
+export STORE_DIR=/var/vcap/store/$JOB_NAME
+for dir in $RUN_DIR $LOG_DIR $TMP_DIR $STORE_DIR
+do
+  mkdir -p ${dir}
+  chown vcap:vcap ${dir}
+  chmod 775 ${dir}
+done
+export TMPDIR=$TMP_DIR
+
+export C_INCLUDE_PATH=/var/vcap/packages/mysqlclient/include/mysql:/var/vcap/packages/sqlite/include:/var/vcap/packages/libpq/include
+export LIBRARY_PATH=/var/vcap/packages/mysqlclient/lib/mysql:/var/vcap/packages/sqlite/lib:/var/vcap/packages/libpq/lib
+
+echo '$PATH' $PATH

data/lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/helpers/ctl_utils.sh

@@ -0,0 +1,156 @@
+# Helper functions used by ctl scripts
+
+# links a job file (probably a config file) into a package
+# Example usage:
+# link_job_file_to_package config/redis.yml [config/redis.yml]
+# link_job_file_to_package config/wp-config.php wp-config.php
+link_job_file_to_package() {
+  source_job_file=$1
+  target_package_file=${2:-$source_job_file}
+  full_package_file=$WEBAPP_DIR/${target_package_file}
+
+  link_job_file ${source_job_file} ${full_package_file}
+}
+
+# links a job file (probably a config file) somewhere
+# Example usage:
+# link_job_file config/bashrc /home/vcap/.bashrc
+link_job_file() {
+  source_job_file=$1
+  target_file=$2
+  full_job_file=$JOB_DIR/${source_job_file}
+
+  echo link_job_file ${full_job_file} ${target_file}
+  if [[ ! -f ${full_job_file} ]]
+  then
+    echo "file to link ${full_job_file} does not exist"
+  else
+    # Create/recreate the symlink to current job file
+    # If another process is using the file, it won't be
+    # deleted, so don't attempt to create the symlink
+    mkdir -p $(dirname ${target_file})
+    ln -nfs ${full_job_file} ${target_file}
+  fi
+}
+
+# If loaded within monit ctl scripts then pipe output
+# If loaded from 'source ../utils.sh' then normal STDOUT
+redirect_output() {
+  SCRIPT=$1
+  mkdir -p /var/vcap/sys/log/monit
+  exec 1>> /var/vcap/sys/log/monit/$SCRIPT.log
+  exec 2>> /var/vcap/sys/log/monit/$SCRIPT.err.log
+}
+
+pid_guard() {
+  pidfile=$1
+  name=$2
+
+  if [ -f "$pidfile" ]; then
+    pid=$(head -1 "$pidfile")
+
+    if [ -n "$pid" ] && [ -e /proc/$pid ]; then
+      echo "$name is already running, please stop it first"
+      exit 1
+    fi
+
+    echo "Removing stale pidfile..."
+    rm $pidfile
+  fi
+}
+
+wait_pid() {
+  pid=$1
+  try_kill=$2
+  timeout=${3:-0}
+  force=${4:-0}
+  countdown=$(( $timeout * 10 ))
+
+  echo wait_pid $pid $try_kill $timeout $force $countdown
+  if [ -e /proc/$pid ]; then
+    if [ "$try_kill" = "1" ]; then
+      echo "Killing $pidfile: $pid "
+      kill $pid
+    fi
+    while [ -e /proc/$pid ]; do
+      sleep 0.1
+      [ "$countdown" != '0' -a $(( $countdown % 10 )) = '0' ] && echo -n .
+      if [ $timeout -gt 0 ]; then
+        if [ $countdown -eq 0 ]; then
+          if [ "$force" = "1" ]; then
+            echo -ne "\nKill timed out, using kill -9 on $pid... "
+            kill -9 $pid
+            sleep 0.5
+          fi
+          break
+        else
+          countdown=$(( $countdown - 1 ))
+        fi
+      fi
+    done
+    if [ -e /proc/$pid ]; then
+      echo "Timed Out"
+    else
+      echo "Stopped"
+    fi
+  else
+    echo "Process $pid is not running"
+    echo "Attempting to kill pid anyway..."
+    kill $pid
+  fi
+}
+
+wait_pidfile() {
+  pidfile=$1
+  try_kill=$2
+  timeout=${3:-0}
+  force=${4:-0}
+  countdown=$(( $timeout * 10 ))
+
+  if [ -f "$pidfile" ]; then
+    pid=$(head -1 "$pidfile")
+    if [ -z "$pid" ]; then
+      echo "Unable to get pid from $pidfile"
+      exit 1
+    fi
+
+    wait_pid $pid $try_kill $timeout $force
+
+    rm -f $pidfile
+  else
+    echo "Pidfile $pidfile doesn't exist"
+  fi
+}
+
+kill_and_wait() {
+  pidfile=$1
+  # Monit default timeout for start/stop is 30s
+  # Append 'with timeout {n} seconds' to monit start/stop program configs
+  timeout=${2:-25}
+  force=${3:-1}
+  if [[ -f ${pidfile} ]]
+  then
+    wait_pidfile $pidfile 1 $timeout $force
+  else
+    # TODO assume $1 is something to grep from 'ps ax'
+    pid="$(ps auwwx | grep "$1" | awk '{print $2}')"
+    wait_pid $pid 1 $timeout $force
+  fi
+}
+
+check_nfs_mount() {
+  opts=$1
+  exports=$2
+  mount_point=$3
+
+  if grep -qs $mount_point /proc/mounts; then
+    echo "Found NFS mount $mount_point"
+  else
+    echo "Mounting NFS..."
+    mount $opts $exports $mount_point
+    if [ $? != 0 ]; then
+      echo "Cannot mount NFS from $exports to $mount_point, exiting..."
+      exit 1
+    fi
+  fi
+}

data/lib/bosh/gen/generators/new_release_generator/templates/templates/jobs.yml.tt

@@ -15,7 +15,7 @@ jobs:
     resource_pool: small_z1
     networks: (( merge ))
     persistent_disk: 0
-    properties: ~
+    properties: {}
   - name: <%= project_name_underscored %>_z1
     template: <%= project_name_hyphenated %>
     instances: 0

data/lib/bosh/gen/version.rb

@@ -1,5 +1,5 @@
 module Bosh
   module Gen
-    VERSION = "0.17.1"
+    VERSION = "0.18.0"
   end
 end

metadata

@@ -1,139 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: bosh-gen
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.18.0
 platform: ruby
 authors:
 - Dr Nic Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-30 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bosh_cli
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bosh_common
+  name: bosh-template
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: progressbar
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: cyoi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
 - !ruby/object:Gem::Dependency
   name: fog
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
 - !ruby/object:Gem::Dependency
   name: readwritesettings
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-fire
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Generators for creating BOSH releases
@@ -144,9 +144,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - ChangeLog.md
 - Gemfile
 - Guardfile
@@ -159,6 +159,13 @@ files:
 - lib/bosh/gen.rb
 - lib/bosh/gen/cli.rb
 - lib/bosh/gen/generators/deployment_manifest_generator.rb
+- lib/bosh/gen/generators/errand_generator.rb
+- lib/bosh/gen/generators/errand_generator/templates/.gitkeep
+- lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/monit.tt
+- lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/bin/run
+- lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/config/.gitkeep
+- lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/helpers/ctl_setup.sh
+- lib/bosh/gen/generators/errand_generator/templates/jobs/%job_name%/templates/helpers/ctl_utils.sh
 - lib/bosh/gen/generators/extract_job_generator.rb
 - lib/bosh/gen/generators/extract_package_generator.rb
 - lib/bosh/gen/generators/job_generator.rb
@@ -311,17 +318,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: ''