borrow_direct 0.10.0 → 0.11.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2U0ZTMyZDhmZDA4ZTE3YWNjNDk0MTYwMDEzNTM4MTQ5MDY2NzQwOQ==
+    Yzk3ZWE5NmVjYjkwZWY5M2IxZTc2NmIyZmIxNGIwYjllYjMxNGY1OA==
   data.tar.gz: !binary |-
-    YzQ0MDdjMGIyMjYzNmU1NmZkY2Q5MzRkNTcxNWRhNjkyZTE3ZDQ3ZA==
+    ZGYyZTVjODFjMjlhNTQ4Nzk5ZmVkN2UzNzAwMTkzNTQ4MzRlNGIwYw==
 SHA512:
   metadata.gz: !binary |-
-    MThiMzE1MWJmNmQ3YzZiNjczYTY5MjU0OGIxYmRlOWQ5MTc5ZmQ2NzM5OTY4
-    MjRmMWQ5M2RjYzEzNGFjZGVlYjkwOWU2N2M3ZWFjMTM5OTFkOTk1YjEzZGM2
-    ZjQ5M2MwMTM4YzFlZGNjOTdmMzBlZGZjM2IwOGNjNDg5NzJhMjA=
+    ODE0NTkyNTkwZWMxZWM4MjMwNjJhMjhiMjM4MjM1MzNiNDU4ZmZkYWExZmFl
+    ZTYzM2ZkNTc2ODc3OTNlNDNkOWFmNmY0MjZmY2I3YmNhNmU1ZGY3MmYzZjVh
+    OTJhNGZkYjZjNzM1ZTFmZWY1Mzg4ODYxMGQxYjY5OTFmZjc3YWE=
   data.tar.gz: !binary |-
-    MmZhNzUyNTk5ODhiYWI5ZjdiNjVhZThhZTdlMTgyZDM3MzdhODhlOThkZjE4
-    ZWNmNzg4NzkwYzFmNmQ1OTA4MDk5MTY5N2IyODAwNWJhYjg4ZDY5NjY1YzVl
-    NGQ1YjllODU3M2Q0M2E0MjczN2VlMzUxZTVhYmU2ZjJhODcxYTg=
+    MGU1MTFjNThkNjZiNTM3NWE1MTYzMTJjMTc0YmYzMzk1YzQzYWFiOWIxOGM5
+    ZDNiNzJlNDMxYWMzMTBhYmVhMjg5MDgxNGJjODhmN2VhMjNmYWY3MzZhNDk2
+    OTY5MzgwN2RmOTQ5NTQ4NWFlOWI1NWY1OWQxM2U4NGJiYWQwYzY=

data/README.md

@@ -1,3 +1,4 @@
+[![Gem Version](https://badge.fury.io/rb/borrow_direct.svg)](http://badge.fury.io/rb/borrow_direct)
 [![Build Status](https://travis-ci.org/jrochkind/borrow_direct.svg)](https://travis-ci.org/jrochkind/borrow_direct)
 
 # BorrowDirect

data/lib/borrow_direct/generate_query.rb

@@ -66,8 +66,9 @@ module BorrowDirect
       title           = options[:title].dup  if options[:title]
       author          = options[:author].dup if options[:author]
 
-      # We don't do any normalization to author at present. 
-      title = normalized_title(title, :max_title_words => options[:max_title_words])
+      
+      title  = normalized_title(title, :max_title_words => options[:max_title_words])
+      author = normalized_author(author)
 
       results = {}
       results[:title] = title if title && ! title.empty?
@@ -117,6 +118,20 @@ module BorrowDirect
       return title
     end
 
+    # Lowercase, and try to get just the last name out of something
+    # that looks like a cataloging authorized heading. 
+    def normalized_author(author)
+      return "" if author.nil? || author.empty?
+
+      author = author.downcase
+      # Just take everything before the comma if we have one
+      if author =~ /\A(.*),/
+        author = $1
+      end
+
+      return author
+    end
+
     
 
     # Escape a query value. 

data/lib/borrow_direct/version.rb

@@ -1,3 +1,3 @@
 module BorrowDirect
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/test/generate_query_test.rb

@@ -91,7 +91,7 @@ describe "GenerateQuery" do
     it "passes through simple author and title" do
       author ="John Smith"
       title = "Some Book"
-      assert_equal( {:title => "some book", :author => author}, @generator.normalized_author_title_params(:author => author, :title => title))
+      assert_equal( {:title => "some book", :author => 'john smith'}, @generator.normalized_author_title_params(:author => author, :title => title))
     end
 
     it "works with just a title" do
@@ -121,11 +121,17 @@ describe "GenerateQuery" do
       assert_equal({:title => "el revolución"}, @generator.normalized_author_title_params(:title => "El   Revolución!: Cuban poster art"))
     end
 
+    it "normalizes author to what looks like last name" do
+      assert_equal({:title => "book", :author => "scott"}, @generator.normalized_author_title_params(:title => "Book", :author => "Scott, James C"))
+    end
+
     it "full normalized_author_title_query" do
       url = @generator.normalized_author_title_query(:title => "A Book: Subtitle", :author => "Smith, John" )
       query = assert_bd_query_url(url)
     end
 
+
+
   end
 
   def assert_bd_query_url(url)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: borrow_direct
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Jonathan Rochkind
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2015-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient