bootsnap 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: fc93ed69fb2f50721ee3edbd37bf5f44a617db15ad1d77cf3a675197d7b420e6
-  data.tar.gz: 370a02dfb9fcb85d3c38ffa26c5ac89720e6ac493f9cb90262da2b096e2f0457
+SHA1:
+  metadata.gz: 2479c73ad1318763b74c7091415a87025021cd23
+  data.tar.gz: 98730e7d7e4719040c59a8d5bf60f0618b44d878
 SHA512:
-  metadata.gz: 14aee751c568fa870b4c8f694274108460a99605b32e355dfa73d25070609c06a0a9531a00f0fe66ea261428c9c0379ff39813168ffa233a5209c39e72f92779
-  data.tar.gz: e6d2bd977b56bdc5b46d7a335f3f4fef729747527dce035233f2f590c22bb88fe35d79dae68de191ff83cb98fcb7b8a0275639b3a6bc44697c26a3bed5af1b85
+  metadata.gz: 85bd04d9117856b2e5615fde67066cbef2b9323b29cf3cd39938cdc3bc1759b0b5903eac9ca91b99e63bd2d3262013064ad5fb551267fd29d77c0dffb348d41d
+  data.tar.gz: 44884f5e8d9a003d10cb99270ed4f2101730a1ab9692c6626150da345dcb6b2e7c83c429a3145e784ee13b712b6a4c38d14fa9abe9063e019aafb05f55d011d6

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.3.2
+
+* Fix Spring + Bootsnap incompatibility when there are files with similar names.
+* Fix `YAML.load_file` monkey patch to keep accepting File objects as arguments.
+* Fix the API for `ActiveSupport::Dependencies#autoloadable_module?`.
+* Some performance improvements.
+
 # 1.3.1
 
 * Change load path scanning to more correctly follow symlinks.

data/ext/bootsnap/bootsnap.c

@@ -269,6 +269,8 @@ cache_key_equal(struct bs_cache_key * k1, struct bs_cache_key * k2)
 static VALUE
 bs_rb_fetch(VALUE self, VALUE cachedir_v, VALUE path_v, VALUE handler)
 {
+  FilePathValue(path_v);
+
   Check_Type(cachedir_v, T_STRING);
   Check_Type(path_v, T_STRING);
 

data/lib/bootsnap.rb

@@ -36,7 +36,7 @@ module Bootsnap
 
   def self.setup_disable_trace
     if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.5.0')
-      warn("This method is not allowed with this Ruby version. current: #{RUBY_VERSION}, allowed version: < 2.5.0")
+      warn("from #{caller_locations(1, 1)[0]}: The 'disable_trace' method is not allowed with this Ruby version. current: #{RUBY_VERSION}, allowed version: < 2.5.0")
     else
       RubyVM::InstructionSequence.compile_option = { trace_instruction: false }
     end

data/lib/bootsnap/bundler.rb

@@ -2,11 +2,13 @@ module Bootsnap
   module_function
 
   def bundler?
+    return false unless defined?(::Bundler)
+
     # Bundler environment variable
     ['BUNDLE_BIN_PATH', 'BUNDLE_GEMFILE'].each do |current|
       return true if ENV.key?(current)
     end
-    
+
     false
   end
 end

data/lib/bootsnap/compile_cache/yaml.rb

@@ -48,7 +48,7 @@ module Bootsnap
         klass.send(:define_method, :load_file) do |path|
           Bootsnap::CompileCache::Native.fetch(
             cache_dir,
-            path.to_s,
+            path,
             Bootsnap::CompileCache::YAML
           )
         end

data/lib/bootsnap/load_path_cache/cache.rb

@@ -14,10 +14,10 @@ module Bootsnap
         reinitialize
       end
 
-      # Does this directory exist as a child of one of the path items?
-      # e.g. given "/a/b/c/d" exists, and the path is ["/a/b"], has_dir?("c/d")
-      # is true.
-      def has_dir?(dir)
+      # What is the path item that contains the dir as child?
+      # e.g. given "/a/b/c/d" exists, and the path is ["/a/b"], load_dir("c/d")
+      # is "/a/b".
+      def load_dir(dir)
         reinitialize if stale?
         @mutex.synchronize { @dirs[dir] }
       end
@@ -108,7 +108,7 @@ module Bootsnap
           @path_obj = path_obj
           ChangeObserver.register(self, @path_obj)
           @index = {}
-          @dirs = Hash.new(false)
+          @dirs = {}
           @generated_at = now
           push_paths_locked(*@path_obj)
         end
@@ -132,10 +132,11 @@ module Bootsnap
             p = Path.new(path)
             @has_relative_paths = true if p.relative?
             next if p.non_directory?
+            expanded_path = p.expanded_path
             entries, dirs = p.entries_and_dirs(@store)
             # push -> low precedence -> set only if unset
-            dirs.each    { |dir| @dirs[dir]  ||= true }
-            entries.each { |rel| @index[rel] ||= p.expanded_path }
+            dirs.each    { |dir| @dirs[dir]  ||= path }
+            entries.each { |rel| @index[rel] ||= expanded_path }
           end
         end
       end
@@ -145,10 +146,11 @@ module Bootsnap
           paths.map(&:to_s).reverse_each do |path|
             p = Path.new(path)
             next if p.non_directory?
+            expanded_path = p.expanded_path
             entries, dirs = p.entries_and_dirs(@store)
             # unshift -> high precedence -> unconditional set
-            dirs.each    { |dir| @dirs[dir]  = true }
-            entries.each { |rel| @index[rel] = p.expanded_path }
+            dirs.each    { |dir| @dirs[dir]  = path }
+            entries.each { |rel| @index[rel] = expanded_path }
           end
         end
       end

data/lib/bootsnap/load_path_cache/change_observer.rb

@@ -25,6 +25,14 @@ module Bootsnap
           super
         end
 
+        # uniq! keeps the first occurance of each path, otherwise preserving
+        # order, preserving the effective load path
+        def uniq!(*args)
+          ret = super
+          @lpc_observer.reinitialize if block_given? || !args.empty?
+          ret
+        end
+
         # For each method that modifies the array more aggressively, override
         # the method to also have the observer completely reconstruct its state
         # after the modification. Many of these could be made to modify the
@@ -34,7 +42,7 @@ module Bootsnap
         %i(
           []= clear collect! compact! delete delete_at delete_if fill flatten!
           insert keep_if map! pop reject! replace reverse! rotate! select!
-          shift shuffle! slice! sort! sort_by! uniq!
+          shift shuffle! slice! sort! sort_by!
         ).each do |method_name|
           define_method(method_name) do |*args, &block|
             ret = super(*args, &block)

data/lib/bootsnap/load_path_cache/core_ext/active_support.rb

@@ -10,6 +10,14 @@ module Bootsnap
           Thread.current[:without_bootsnap_cache] = prev
         end
 
+        def self.allow_bootsnap_retry(allowed)
+          prev = Thread.current[:without_bootsnap_retry] || false
+          Thread.current[:without_bootsnap_retry] = !allowed
+          yield
+        ensure
+          Thread.current[:without_bootsnap_retry] = prev
+        end
+
         module ClassMethods
           def autoload_paths=(o)
             super
@@ -26,13 +34,19 @@ module Bootsnap
           end
 
           def autoloadable_module?(path_suffix)
-            Bootsnap::LoadPathCache.autoload_paths_cache.has_dir?(path_suffix)
+            Bootsnap::LoadPathCache.autoload_paths_cache.load_dir(path_suffix)
           end
 
           def remove_constant(const)
             CoreExt::ActiveSupport.without_bootsnap_cache { super }
           end
 
+          def require_or_load(*)
+            CoreExt::ActiveSupport.allow_bootsnap_retry(true) do
+              super
+            end
+          end
+
           # If we can't find a constant using the patched implementation of
           # search_for_file, try again with the default implementation.
           #
@@ -40,8 +54,15 @@ module Bootsnap
           # behaviour.  The gymnastics here are a bit awkward, but it prevents
           # 200+ lines of monkeypatches.
           def load_missing_constant(from_mod, const_name)
-            super
+            CoreExt::ActiveSupport.allow_bootsnap_retry(false) do
+              super
+            end
           rescue NameError => e
+            # This function can end up called recursively, we only want to
+            # retry at the top-level.
+            raise if Thread.current[:without_bootsnap_retry]
+            # If we already had cache disabled, there's no use retrying
+            raise if Thread.current[:without_bootsnap_cache]
             # NoMethodError is a NameError, but we only want to handle actual
             # NameError instances.
             raise unless e.class == NameError
@@ -58,6 +79,8 @@ module Bootsnap
           def depend_on(*)
             super
           rescue LoadError
+            # If we already had cache disabled, there's no use retrying
+            raise if Thread.current[:without_bootsnap_cache]
             CoreExt::ActiveSupport.without_bootsnap_cache { super }
           end
         end

data/lib/bootsnap/load_path_cache/loaded_features_index.rb

@@ -84,7 +84,7 @@ module Bootsnap
 
       private
 
-      STRIP_EXTENSION = /\..*?$/
+      STRIP_EXTENSION = /\.[^.]*?$/
       private_constant :STRIP_EXTENSION
 
       def strip_extension(f)

data/lib/bootsnap/version.rb

@@ -1,3 +1,3 @@
 module Bootsnap
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bootsnap
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Burke Libbey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-11 00:00:00.000000000 Z
+date: 2018-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -160,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Boot large ruby/rails apps faster