bootsnap 1.24.0 → 1.24.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9680e880d828e4c61704db75e793e97b4bcaa9142e37335b697d28a14c1d7f9c
-  data.tar.gz: 876136914c8d89c771304fffc2d8587b3b15b0eb6abbf684ad5d4adb39b98550
+  metadata.gz: 24c756fe8c17824d00469a5e8e444e6ed9f2710566e623ea8dbd569deb425c83
+  data.tar.gz: aefe758480d38080ff1b0ffd45954dbe7aa992cab3b6f3e6cea7966c2af97696
 SHA512:
-  metadata.gz: 84bd60feda93f48dfeb2c8149c72a72a619050eb163decf83bf14d78173a3aa52adff84dc6a22f7821ee7d1c937a0449f96686f6199c77e53ff990f123c30359
-  data.tar.gz: 41d345dee52323ba80df2c8165bad4a4ea6c04780d8eb7e459a5e766973b797f68267ac63fbad38a3add47e59041aa8d7786ddb43b5ed0cfb7ac98743cd70ca5
+  metadata.gz: 614ff9e0eaac288fb4a890e3ca0926e720c06fdc68de3ce33d015d1ad477b4172126614c321fb1da1bb6e4c8539ba80c774b8f9a619c7475b0469c9001a0eca2
+  data.tar.gz: e85e9357079e541270b659f0b11c71b3e286099d590aaba4fc90ac1462a2bf916e5e7752fa87d5f6d760598e9a0ea3e66c6e99f55f3085345516e28a17fa4caa

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Unreleased
 
+# 1.24.2
+
+* Workaround two Ruby bugs in `RubyVM::InstructionSequence.compile_file`, that were causing
+  files to be loaded with the old Ruby parser instead of Prism, causing issues with some pattern matching syntax.
+  Ref: https://bugs.ruby-lang.org/issues/22023
+
+# 1.24.1
+
+* Fix encoding of Ruby source files loaded when `BOOTSNAP_READONLY` is set.
+  Files would incorectly be loaded in `ASCII-8BIT` causing literal strings outside
+  the pure ASCII range to have `ASCII-8BIT` encoding instead of `UTF-8`.
+  This bug was introduced in `1.24.0`.
+
 # 1.24.0
 
 * Added a hook API to customize Ruby compilation.

data/lib/bootsnap/compile_cache/iseq.rb

@@ -36,19 +36,47 @@ module Bootsnap
           true
         end
 
+        has_ruby_bug_22023 = if defined?(RubyVM::InstructionSequence) && RubyVM::InstructionSequence.respond_to?(:compile_file_prism)
+          begin
+            RubyVM::InstructionSequence.compile_file(File.expand_path("../ruby_bug_22023_canary.rb", __FILE__))
+            false
+          rescue SyntaxError
+            true
+          end
+        end
+
+        if has_ruby_bug_22023 && RUBY_DESCRIPTION.include?("+PRISM")
+          module PatchRubyBug22023
+            def compile_file(path, options = nil)
+              compile_file_prism(path, options)
+            end
+
+            has_ruby_bug_22023_bis = !RubyVM::InstructionSequence.compile_file_prism(
+              File.expand_path("../ruby_bug_22023_canary.rb", __FILE__),
+              {frozen_string_literal: true},
+            ).eval.frozen?
+
+            if has_ruby_bug_22023_bis
+              def compile_file_prism(path, options = nil)
+                compile_prism(::File.read(path), path, path, nil, options)
+              end
+            end
+          end
+          RubyVM::InstructionSequence.singleton_class.prepend(PatchRubyBug22023)
+        end
+
         if has_ruby_bug_18250
           def input_to_storage(_, path)
             iseq = RubyVM::InstructionSequence.compile_file(path, @compile_options)
-
-            begin
-              iseq.to_binary
-            rescue TypeError
-              UNCOMPILABLE # ruby bug #18250
-            end
+            iseq.to_binary
+          rescue TypeError, SyntaxError # Ruby [Bug #18250] & [Bug #22023]
+            UNCOMPILABLE
           end
         else
           def input_to_storage(_, path)
             RubyVM::InstructionSequence.compile_file(path, @compile_options).to_binary
+          rescue SyntaxError # Ruby [Bug #22023]
+            UNCOMPILABLE
           end
         end
 
@@ -66,7 +94,13 @@ module Bootsnap
         end
 
         def input_to_output(source, path, _kwargs)
-          RubyVM::InstructionSequence.compile(source, path, path, nil, @compile_options)
+          RubyVM::InstructionSequence.compile(
+            source.force_encoding(Encoding.default_external),
+            path,
+            path,
+            nil,
+            @compile_options,
+          )
         end
       end
 

data/lib/bootsnap/compile_cache/ruby_bug_22023_canary.rb

@@ -0,0 +1,10 @@
+# rubocop:disable Style/FrozenStringLiteralComment
+def foo(bars)
+  case bars
+  in [one, "a" | "b" => two]
+    puts "#{one} - #{two}"
+  end
+end
+
+_ = "test"
+# rubocop:enable Style/FrozenStringLiteralComment

data/lib/bootsnap/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bootsnap
-  VERSION = "1.24.0"
+  VERSION = "1.24.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bootsnap
 version: !ruby/object:Gem::Version
-  version: 1.24.0
+  version: 1.24.2
 platform: ruby
 authors:
 - Burke Libbey
@@ -44,6 +44,7 @@ files:
 - lib/bootsnap/cli/worker_pool.rb
 - lib/bootsnap/compile_cache.rb
 - lib/bootsnap/compile_cache/iseq.rb
+- lib/bootsnap/compile_cache/ruby_bug_22023_canary.rb
 - lib/bootsnap/compile_cache/yaml.rb
 - lib/bootsnap/explicit_require.rb
 - lib/bootsnap/load_path_cache.rb