bootic_client 0.0.14 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7bd5c38b36abf80f522f33986103d5d2d94c2ba0
-  data.tar.gz: 5f11c6edb651d08e49cbbf1e8bd2a89037cfd3e8
+  metadata.gz: 108342ffa36bdaa0249839395c81134746d41cbb
+  data.tar.gz: 65e2f9a55e7f6b8066164a9237d29a6b9a61fc96
 SHA512:
-  metadata.gz: 8afbb75506aa39f78af563d6aa7b926f4fe9993554f9a79288d606af3bf11002423bc9bcfd1a66d633006ee37c8b69a3bb9987d1551d12b41f6c14941f7b77cc
-  data.tar.gz: fda4d8271434e14c7502329f8b3448f95a570628fed0ac6afb8dd6b380927a95fc4a39b26a77d77ae8d95c33b01a32523af784798c5e37507c03ccc1d7daa04d
+  metadata.gz: cf0a58fe90751a1f8bb9a50a6ad226f0e0e5131812a7ee9dedc1222c4410aa5797ecf1ce2789c18087362f091180b736c19f0ba71c63873790afe5cc9e4af60b
+  data.tar.gz: 5330b361a1a03701db99f4a05be166544cd829348f42cea28af6c8e92cabb2f3b9b7307ce16f8234d3b8daa1d7af7d6870e55b2e0a0a080d9c83cac7599c07d9

data/.travis.yml

@@ -1,3 +1,3 @@
 language: ruby
 rvm:
-  - 2.0.0
+  - 2.2.2

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## [v0.0.14](https://github.com/bootic/bootic_client.rb/tree/v0.0.14) (2016-04-26)
+[Full Changelog](https://github.com/bootic/bootic_client.rb/compare/v0.0.13...v0.0.14)
+
+**Merged pull requests:**
+
+- Base64-encode IO instances before POST|PUT|PATH [\#6](https://github.com/bootic/bootic_client.rb/pull/6) ([ismasan](https://github.com/ismasan))
+
 ## [v0.0.13](https://github.com/bootic/bootic_client.rb/tree/v0.0.13) (2016-01-12)
 [Full Changelog](https://github.com/bootic/bootic_client.rb/compare/v0.0.12...v0.0.13)
 

data/Gemfile

@@ -6,5 +6,5 @@ gemspec
 group :test do
   gem 'byebug' if RUBY_VERSION.to_i >= 2
   gem 'vcr', '~> 2.4'
-  gem 'webmock', '>= 1.20'
+  gem 'webmock', '1.22.3'
 end

data/README.md

@@ -167,7 +167,7 @@ end
 
 ### Working with Files and IO instances
 
-Instances of `File` and other readable `IO` objects will be base64-encoded internally before JSON-encoding payloads for `POST`, `PUT` and `PATCH` requests.
+Instances of `File`, other readable `IO` objects (and in fact anything that responds to `#read`) will be base64-encoded internally before JSON-encoding payloads for `POST`, `PUT` and `PATCH` requests.
 
 ```ruby
 asset = product.create_product_asset(
@@ -176,6 +176,32 @@ asset = product.create_product_asset(
 )
 ```
 
+Because anything that responds to `#read` will be interpreted as file data and base64-encoded, you can also pass instances of `open-uri`.
+
+```ruby
+require "open-uri"
+
+asset = product.create_product_asset(
+  filename: 'foo.jpg',
+  data: open("https://some.server.com/some/image.jpg") # this will base64-encode the file data in the `data` field.
+)
+```
+
+.. or even your own readers
+
+```ruby
+class MyReader
+  def read
+    "some data here"
+  end
+end
+
+asset = product.create_product_asset(
+  filename: 'foo.jpg',
+  data: MyReader.new # this will base64-encode the file data in the `data` field.
+)
+```
+
 ## Relation docs
 
 All resource link relations include a "docs" URL so you can learn more about that particular resource.

data/lib/bootic_client/client.rb

@@ -16,7 +16,8 @@ module BooticClient
 
     def initialize(options = {}, &block)
       @options = {
-        logging: false
+        logging: false,
+        faraday_adapter: [:net_http_persistent],
       }.merge(options.dup)
 
       @options[:cache_store] = @options[:cache_store] || Faraday::HttpCache::MemoryStore.new
@@ -69,7 +70,7 @@ module BooticClient
         f.response :logger, options[:logger] if options[:logging]
         f.response :json
         yield f if block_given?
-        f.adapter :net_http_persistent
+        f.adapter *Array(options[:faraday_adapter])
       end
     end
 
@@ -102,11 +103,10 @@ module BooticClient
     def sanitized(payload)
       return payload unless payload.kind_of?(Hash)
       payload.each_with_object({}) do |(k, v), memo|
-        memo[k] = case v
-        when IO
-          Base64.encode64 v.read
-        when Hash
+        memo[k] = if v.kind_of?(Hash)
           sanitized v
+        elsif v.respond_to?(:read)
+          Base64.encode64 v.read
         else
           v
         end

data/lib/bootic_client/version.rb

@@ -1,3 +1,3 @@
 module BooticClient
-  VERSION = "0.0.14"
+  VERSION = "0.0.15"
 end

data/spec/client_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'json'
+require "open-uri"
 
 describe BooticClient::Client do
   require 'webmock/rspec'
@@ -204,6 +205,16 @@ describe BooticClient::Client do
         it 'POSTs request with base64-encoded file and parses response' do
           expect(client.post(root_url, {foo: 'bar', data: file}, request_headers).body['message']).to eql('Hello!')
         end
+
+        it "works with anything that responds to #read" do
+          reader = double("reader", read: File.read(fixture_path("file.gif")))
+          expect(client.post(root_url, {foo: 'bar', data: reader}, request_headers).body['message']).to eql('Hello!')
+        end
+
+        it "works with open-uri" do
+          reader = open(fixture_path("file.gif"))
+          expect(client.post(root_url, {foo: 'bar', data: reader}, request_headers).body['message']).to eql('Hello!')
+        end
       end
 
       [:put, :patch].each do |verb|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bootic_client
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Ismael Celis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-26 00:00:00.000000000 Z
+date: 2016-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday