bookingsync-engine 5.0.0 → 5.1.0

data/spec/lib/bookingsync/engine/retryable_spec.rb

@@ -0,0 +1,81 @@
+require "spec_helper"
+
+RSpec.describe BookingSync::Engine::Retryable do
+  describe ".perform" do
+    let(:before_retry) do
+      Class.new do
+        attr_reader :called, :errors
+
+        def initialize
+          @called = 0
+          @errors = []
+        end
+
+        def call(error)
+          @called += 1
+          @errors << error
+        end
+      end.new
+    end
+
+    it "retries logic for given amount of times for given errors
+    and raises original error if the number is exceeded" do
+      times_executed = 0
+
+      expect {
+        BookingSync::Engine::Retryable.perform(times: 3, errors: [NotImplementedError]) do
+          times_executed += 1
+          raise NotImplementedError
+        end
+      }.to raise_error NotImplementedError
+
+      expect(times_executed).to eq 3
+    end
+
+    it "calls before_retry callback before every retry" do
+      expect {
+        BookingSync::Engine::Retryable.perform(times: 3, errors: [NotImplementedError], before_retry: before_retry) do
+          raise NotImplementedError
+        end
+      }.to raise_error NotImplementedError
+
+      expect(before_retry.called).to eq 2
+      expect(before_retry.errors.count).to eq 2
+      expect(before_retry.errors.uniq.first).to be_a NotImplementedError
+    end
+
+    it "does not retry for given amount of times if it succeeds before exceeding given number" do
+      times_executed = 0
+
+      BookingSync::Engine::Retryable.perform(times: 3, errors: [NotImplementedError]) do
+        times_executed += 1
+        raise NotImplementedError if times_executed < 2
+      end
+
+      expect(times_executed).to eq 2
+    end
+
+    it "does not retry if no error is raised" do
+      times_executed = 0
+
+      BookingSync::Engine::Retryable.perform(times: 3, errors: [NotImplementedError]) do
+        times_executed += 1
+      end
+
+      expect(times_executed).to eq 1
+    end
+
+    it "does not retry not whitelisted errors" do
+      times_executed = 0
+
+      expect {
+        BookingSync::Engine::Retryable.perform(times: 3, errors: [LocalJumpError]) do
+          times_executed += 1
+          raise NotImplementedError
+        end
+      }.to raise_error NotImplementedError
+
+      expect(times_executed).to eq 1
+    end
+  end
+end

data/spec/models/account_spec.rb

@@ -131,6 +131,40 @@ RSpec.describe Account, type: :model do
         expect(account.token).to be_a OAuth2::AccessToken
         expect(account.token.token).to eq "refreshed_token"
       end
+
+      context "with refresh failing with timeout" do
+        before do
+          call_count = 0
+          allow_any_instance_of(OAuth2::Client).to receive(:get_token).and_wrap_original do |m, *args|
+            call_count += 1
+            call_count < 3 ? raise(Faraday::TimeoutError) : m.call(*args)
+          end
+        end
+
+        context "and retry works" do
+          before do
+            BookingSyncEngine.setup do |setup|
+              setup.token_refresh_timeout_retry_count = 2
+            end
+          end
+
+          it "retries as passed in config" do
+            expect(account.token.token).to eq "refreshed_token"
+          end
+        end
+
+        context "and retry doesn't help" do
+          before do
+            BookingSyncEngine.setup do |setup|
+              setup.token_refresh_timeout_retry_count = 1
+            end
+          end
+
+          it "raises error" do
+            expect { account.token.token }.to raise_error(Faraday::TimeoutError)
+          end
+        end
+      end
     end
   end
 
@@ -157,6 +191,40 @@ RSpec.describe Account, type: :model do
     it "returns a client credential token setup without default params" do
       expect(account.application_token.token).to eq "the_access_token"
     end
+
+    context "with refresh failing with timeout" do
+      before do
+        call_count = 0
+        allow_any_instance_of(OAuth2::Client).to receive(:get_token).and_wrap_original do |m, *args|
+          call_count += 1
+          call_count < 3 ? raise(Faraday::TimeoutError) : m.call(*args)
+        end
+      end
+
+      context "and retry works" do
+        before do
+          BookingSyncEngine.setup do |setup|
+            setup.token_refresh_timeout_retry_count = 2
+          end
+        end
+
+        it "retries as passed in config" do
+          expect(account.application_token.token).to eq "the_access_token"
+        end
+      end
+
+      context "and retry doesn't help" do
+        before do
+          BookingSyncEngine.setup do |setup|
+            setup.token_refresh_timeout_retry_count = 1
+          end
+        end
+
+        it "raises error" do
+          expect { account.application_token.token }.to raise_error(Faraday::TimeoutError)
+        end
+      end
+    end
   end
 
   describe "#oauth_client" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bookingsync-engine
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.1.0
 platform: ruby
 authors:
 - Sebastien Grosjean
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-01 00:00:00.000000000 Z
+date: 2020-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -205,6 +205,7 @@ files:
 - lib/bookingsync/engine/models/application.rb
 - lib/bookingsync/engine/models/base_account.rb
 - lib/bookingsync/engine/models/multi_applications_account.rb
+- lib/bookingsync/engine/retryable.rb
 - lib/bookingsync/engine/session_helpers.rb
 - lib/bookingsync/engine/version.rb
 - lib/generators/bookingsync/install/install_generator.rb
@@ -265,6 +266,7 @@ files:
 - spec/helpers/auth_helpers_spec.rb
 - spec/lib/bookingsync/engine/application_credentials_spec.rb
 - spec/lib/bookingsync/engine/credentials_resolver_spec.rb
+- spec/lib/bookingsync/engine/retryable_spec.rb
 - spec/models/account_spec.rb
 - spec/models/application_spec.rb
 - spec/models/multi_application_account_spec.rb
@@ -352,6 +354,7 @@ test_files:
 - spec/support/omniauth.rb
 - spec/lib/bookingsync/engine/credentials_resolver_spec.rb
 - spec/lib/bookingsync/engine/application_credentials_spec.rb
+- spec/lib/bookingsync/engine/retryable_spec.rb
 - spec/fixtures/accounts.yml
 - spec/routing/oauth_routing_spec.rb
 - spec/controllers/authenticated_controller_spec.rb