bookingsync-api 0.1.3 → 0.1.4

data/spec/bookingsync/api/client/rates_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::Rates do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rates", :vcr do
     it "returns rates" do
       expect(client.rates).not_to be_empty
@@ -11,9 +13,13 @@ describe BookingSync::API::Client::Rates do
   end
 
   describe ".rate", :vcr do
+    let(:prefetched_rate_id) {
+      find_resource("#{@casette_base_path}_rates/returns_rates.yml", "rates")[:id]
+    }
+
     it "returns a single rate" do
-      rate = client.rate(18577)
-      expect(rate.id).to eq 18577
+      rate = client.rate(prefetched_rate_id)
+      expect(rate.id).to eq prefetched_rate_id
     end
   end
 end

data/spec/bookingsync/api/client/rates_tables_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::RatesTables do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rates_tables", :vcr do
     it "returns rates tables" do
       expect(client.rates_tables).not_to be_empty
@@ -11,15 +13,19 @@ describe BookingSync::API::Client::RatesTables do
   end
 
   describe ".rates_table", :vcr do
+    let(:prefetched_rates_table_id) {
+      find_resource("#{@casette_base_path}_rates_tables/returns_rates_tables.yml", "rates_tables")[:id]
+    }
+
     it "returns a single rates_table" do
-      rates_table = client.rates_table(274)
-      expect(rates_table.id).to eq 274
+      rates_table = client.rates_table(prefetched_rates_table_id)
+      expect(rates_table.id).to eq prefetched_rates_table_id
     end
   end
 
   describe ".create_rates_table", :vcr do
     let(:attributes) {
-      { name: "New rate table" }
+      { name: "New test rate table" }
     }
 
     it "creates a new rates_table" do
@@ -31,7 +37,7 @@ describe BookingSync::API::Client::RatesTables do
     it "returns newly created rates_table" do
       VCR.use_cassette("BookingSync_API_Client_RatesTables/_create_rates_table/creates_a_new_rates_table") do
         rates_table = client.create_rates_table(attributes)
-        expect(rates_table.name).to eql(attributes[:name])
+        expect(rates_table.name).to eq(attributes[:name])
       end
     end
   end
@@ -40,26 +46,33 @@ describe BookingSync::API::Client::RatesTables do
     let(:attributes) {
       { name: "Updated rate table" }
     }
+    let(:created_rates_table_id) {
+      find_resource("#{@casette_base_path}_create_rates_table/creates_a_new_rates_table.yml", "rates_tables")[:id]
+    }
 
     it "updates given rates_table by ID" do
-      client.edit_rates_table(11, attributes)
-      assert_requested :put, bs_url("rates_tables/11"),
+      client.edit_rates_table(created_rates_table_id, attributes)
+      assert_requested :put, bs_url("rates_tables/#{created_rates_table_id}"),
         body: { rates_tables: [attributes] }.to_json
     end
 
     it "returns updated rates_table" do
       VCR.use_cassette("BookingSync_API_Client_RatesTables/_edit_rates_table/updates_given_rates_table_by_ID") do
-        rates_table = client.edit_rates_table(11, attributes)
+        rates_table = client.edit_rates_table(created_rates_table_id, attributes)
         expect(rates_table).to be_kind_of(BookingSync::API::Resource)
-        expect(rates_table.name).to eql(attributes[:name])
+        expect(rates_table.name).to eq(attributes[:name])
       end
     end
   end
 
   describe ".delete_rates_table", :vcr do
+    let(:created_rates_table_id) {
+      find_resource("#{@casette_base_path}_create_rates_table/creates_a_new_rates_table.yml", "rates_tables")[:id]
+    }
+
     it "deletes given rates_table" do
-      client.delete_rates_table(7)
-      assert_requested :delete, bs_url("rates_tables/7")
+      client.delete_rates_table(created_rates_table_id)
+      assert_requested :delete, bs_url("rates_tables/#{created_rates_table_id}")
     end
   end
 end

data/spec/bookingsync/api/client/rental_agreements_spec.rb

@@ -6,6 +6,8 @@ describe BookingSync::API::Client::RentalAgreements do
     { body: "Lorem ipsum" }
   }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rental_agreements", :vcr do
     it "returns rental agreements" do
       expect(client.rental_agreements).not_to be_empty
@@ -14,9 +16,13 @@ describe BookingSync::API::Client::RentalAgreements do
   end
 
   describe ".rental_agreement", :vcr do
+    let(:prefetched_rental_agreement_id) {
+      find_resource("#{@casette_base_path}_rental_agreements/returns_rental_agreements.yml", "rental_agreements")[:id]
+    }
+
     it "returns a single rental_agreement" do
-      rental_agreement = client.rental_agreement(6905)
-      expect(rental_agreement.id).to eq 6905
+      rental_agreement = client.rental_agreement(prefetched_rental_agreement_id)
+      expect(rental_agreement.id).to eq prefetched_rental_agreement_id
     end
   end
 
@@ -30,13 +36,15 @@ describe BookingSync::API::Client::RentalAgreements do
     it "returns newly created rental agreement" do
       VCR.use_cassette("BookingSync_API_Client_RentalAgreements/_create_rental_agreement/creates_a_new_rental_agreement") do
         rental_agreement = client.create_rental_agreement(attributes)
-        expect(rental_agreement.body).to eql(attributes[:body])
+        expect(rental_agreement.body).to eq(attributes[:body])
       end
     end
   end
 
   describe ".create_rental_agreement_for_booking", :vcr do
-    let(:booking) { BookingSync::API::Resource.new(client, id: 2) }
+    let(:booking) do
+      find_resource("#{casette_dir}/BookingSync_API_Client_Bookings/_booking/returns_a_single_booking.yml", "bookings")
+    end
 
     it "creates a new rental agreement" do
       client.create_rental_agreement_for_booking(booking, attributes)
@@ -47,24 +55,26 @@ describe BookingSync::API::Client::RentalAgreements do
     it "returns newly created rental agreement" do
       VCR.use_cassette("BookingSync_API_Client_RentalAgreements/_create_rental_agreement_for_booking/creates_a_new_rental_agreement") do
         rental_agreement = client.create_rental_agreement_for_booking(booking, attributes)
-        expect(rental_agreement.body).to eql(attributes[:body])
+        expect(rental_agreement.body).to eq(attributes[:body])
       end
     end
   end
 
   describe ".create_rental_agreement_for_rental", :vcr do
-    let(:rental) { BookingSync::API::Resource.new(client, id: 20) }
+    let(:rental) do
+      find_resource("#{casette_dir}/BookingSync_API_Client_Rentals/_rental/returns_a_single_rental.yml", "rentals")
+    end
 
     it "creates a new rental agreement" do
       client.create_rental_agreement_for_rental(rental, attributes)
-      assert_requested :post, bs_url("rentals/20/rental_agreements"),
+      assert_requested :post, bs_url("rentals/#{rental}/rental_agreements"),
         body: { rental_agreements: [attributes] }.to_json
     end
 
     it "returns newly created rental agreement" do
       VCR.use_cassette("BookingSync_API_Client_RentalAgreements/_create_rental_agreement_for_rental/creates_a_new_rental_agreement") do
         rental_agreement = client.create_rental_agreement_for_rental(rental, attributes)
-        expect(rental_agreement.body).to eql(attributes[:body])
+        expect(rental_agreement.body).to eq(attributes[:body])
       end
     end
   end

data/spec/bookingsync/api/client/rental_cancelation_policies_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::RentalCancelationPolicies do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rental_cancelation_policies", :vcr do
     it "returns rental cancelation policies" do
       expect(client.rental_cancelation_policies).not_to be_empty
@@ -11,8 +13,13 @@ describe BookingSync::API::Client::RentalCancelationPolicies do
   end
 
   describe ".rental_cancelation_policy", :vcr do
+    let(:prefetched_rental_cancelation_policy_id) {
+      find_resource("#{@casette_base_path}_rental_cancelation_policies/returns_rental_cancelation_policies.yml",
+        "rental_cancelation_policies")[:id]
+    }
+
     it "returns a single rental cancelation policy" do
-      expect(client.rental_cancelation_policy(13).body).to eq "``` body ``` "
+      expect(client.rental_cancelation_policy(prefetched_rental_cancelation_policy_id).body).to eq "```body```"
     end
   end
 end

data/spec/bookingsync/api/client/rental_cancelation_policy_items_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::RentalCancelationPolicyItems do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rental_cancelation_policy_items", :vcr do
     it "returns rental cancelation policy items" do
       expect(client.rental_cancelation_policy_items).not_to be_empty
@@ -11,8 +13,13 @@ describe BookingSync::API::Client::RentalCancelationPolicyItems do
   end
 
   describe ".rental_cancelation_policy_item", :vcr do
+    let(:prefetched_rental_cancelation_policy_item_id) {
+      find_resource("#{@casette_base_path}_rental_cancelation_policy_items/returns_rental_cancelation_policy_items.yml",
+        "rental_cancelation_policy_items")[:id]
+    }
+
     it "returns a single rental cancelation policy item" do
-      expect(client.rental_cancelation_policy_item(13).penalty_percentage).to eq "20.0"
+      expect(client.rental_cancelation_policy_item(prefetched_rental_cancelation_policy_item_id).penalty_percentage).to eq "20.0"
     end
   end
 end

data/spec/bookingsync/api/client/rentals_amenities_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::RentalsAmenities do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rentals_amenities", :vcr do
     it "returns rentals amenities" do
       expect(client.rentals_amenities).not_to be_empty
@@ -23,19 +25,23 @@ describe BookingSync::API::Client::RentalsAmenities do
   end
 
   describe ".rentals_amenity", :vcr do
+    let(:prefetched_rentals_amenity_id) {
+      find_resource("#{@casette_base_path}_rentals_amenities/returns_rentals_amenities.yml", "rentals_amenities")[:id]
+    }
+
     it "returns rentals_amenity" do
-      amenity = client.rentals_amenity(1)
-      assert_requested :get, bs_url("rentals_amenities/1")
+      amenity = client.rentals_amenity(prefetched_rentals_amenity_id)
+      assert_requested :get, bs_url("rentals_amenities/#{prefetched_rentals_amenity_id}")
     end
   end
 
   describe ".create_rentals_amenity", :vcr do
-    let(:attributes) { { amenity_id: 44, details_en: "Details" } }
+    let(:attributes) { { amenity_id: 48, details_en: "Details" } }
     let(:rental) { BookingSync::API::Resource.new(client, id: 5116) }
 
     it "creates a new rentals_amenity" do
       client.create_rentals_amenity(rental, attributes)
-      assert_requested :post, bs_url("rentals/5116/rentals_amenities"),
+      assert_requested :post, bs_url("rentals/#{rental}/rentals_amenities"),
         body: { rentals_amenities: [attributes] }.to_json
     end
 
@@ -49,16 +55,19 @@ describe BookingSync::API::Client::RentalsAmenities do
 
   describe ".edit_rentals_amenity", :vcr do
     let(:attributes) { { details_en: "New Details" } }
+    let(:created_rentals_amenity_id) {
+      find_resource("#{@casette_base_path}_create_rentals_amenity/creates_a_new_rentals_amenity.yml", "rentals_amenities")[:id]
+    }
 
     it "updates given rentals_amenity by ID" do
-      client.edit_rentals_amenity(6159, attributes)
-      assert_requested :put, bs_url("rentals_amenities/6159"),
+      client.edit_rentals_amenity(created_rentals_amenity_id, attributes)
+      assert_requested :put, bs_url("rentals_amenities/#{created_rentals_amenity_id}"),
         body: { rentals_amenities: [attributes] }.to_json
     end
 
     it "returns updated rentals_amenity" do
       VCR.use_cassette("BookingSync_API_Client_RentalsAmenities/_edit_rentals_amenity/updates_given_rentals_amenity_by_ID") do
-        rentals_amenity = client.edit_rentals_amenity(6159, attributes)
+        rentals_amenity = client.edit_rentals_amenity(created_rentals_amenity_id, attributes)
         expect(rentals_amenity).to be_kind_of(BookingSync::API::Resource)
         expect(rentals_amenity.details).to eq(en: "New Details")
       end
@@ -66,9 +75,13 @@ describe BookingSync::API::Client::RentalsAmenities do
   end
 
   describe ".delete_rentals_amenity", :vcr do
+    let(:created_rentals_amenity_id) {
+      find_resource("#{@casette_base_path}_create_rentals_amenity/creates_a_new_rentals_amenity.yml", "rentals_amenities")[:id]
+    }
+
     it "deletes given rentals_amenity" do
-      client.delete_rentals_amenity(32833)
-      assert_requested :delete, bs_url("rentals_amenities/32833")
+      client.delete_rentals_amenity(created_rentals_amenity_id)
+      assert_requested :delete, bs_url("rentals_amenities/#{created_rentals_amenity_id}")
     end
   end
 end

data/spec/bookingsync/api/client/rentals_fees_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::RentalsFees do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rentals_fees", :vcr do
     it "returns rentals fees" do
       expect(client.rentals_fees).not_to be_empty
@@ -11,16 +13,23 @@ describe BookingSync::API::Client::RentalsFees do
   end
 
   describe ".rentals_fee", :vcr do
+    let(:prefetched_rentals_fee_id) {
+      find_resource("#{@casette_base_path}_rentals_fees/returns_rentals_fees.yml", "rentals_fees")[:id]
+    }
+
     it "returns a single rentals_fee" do
-      rentals_fee = client.rentals_fee(3306)
-      expect(rentals_fee.id).to eq 3306
+      rentals_fee = client.rentals_fee(prefetched_rentals_fee_id)
+      expect(rentals_fee.id).to eq prefetched_rentals_fee_id
     end
   end
 
   describe ".create_rentals_fee", :vcr do
+    let(:fee_id) {
+      find_resource("#{casette_dir}/BookingSync_API_Client_Fees/_fees/returns_fees.yml", "fees")[:id]
+    }
     let(:attributes) do
       {
-        fee_id: 659,
+        fee_id: fee_id,
         maximum_bookable: 10,
         always_applied: true
       }
@@ -29,14 +38,14 @@ describe BookingSync::API::Client::RentalsFees do
 
     it "creates a new rentals_fee" do
       client.create_rentals_fee(rental, attributes)
-      assert_requested :post, bs_url("rentals/5116/rentals_fees"),
+      assert_requested :post, bs_url("rentals/#{rental}/rentals_fees"),
         body: { rentals_fees: [attributes] }.to_json
     end
 
     it "returns newly created rentals_fee" do
       VCR.use_cassette("BookingSync_API_Client_RentalsFees/_create_rentals_fee/creates_a_new_rentals_fee") do
         rentals_fee = client.create_rentals_fee(rental, attributes)
-        expect(rentals_fee.links.fee).to eq 659
+        expect(rentals_fee.links.fee).to eq fee_id
         expect(rentals_fee.maximum_bookable).to eq 10
         expect(rentals_fee.always_applied).to eq true
       end

data/spec/bookingsync/api/client/rentals_spec.rb

@@ -3,6 +3,8 @@ require "spec_helper"
 describe BookingSync::API::Client::Rentals do
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
+  before { |ex| @casette_base_path = casette_path(casette_dir, ex.metadata) }
+
   describe ".rentals", :vcr do
     it "returns rentals" do
       expect(client.rentals).not_to be_empty
@@ -10,9 +12,11 @@ describe BookingSync::API::Client::Rentals do
     end
 
     it "returns rentals by ids" do
-      rentals = client.rentals(ids: [26, 28])
-      expect(rentals.size).to eql(2)
-      assert_requested :get, bs_url("rentals/26,28")
+      rental_ids = find_resources("#{@casette_base_path}_rentals/returns_rentals.yml", "rentals").map { |r| r["id"] }[0..1]
+
+      rentals = client.rentals(ids: rental_ids)
+      expect(rentals.size).to eq(2)
+      assert_requested :get, bs_url("rentals/#{rental_ids.join(',')}")
     end
 
     describe "links" do
@@ -25,17 +29,21 @@ describe BookingSync::API::Client::Rentals do
 
   describe ".rentals_search", :vcr do
     it "returns rentals" do
-      expect(client.rentals_search(start_at: "2016-06-15", end_at: "2016-06-30")).not_to be_empty
+      expect(client.rentals_search(start_at: "2016-12-15", end_at: "2016-12-22")).not_to be_empty
       assert_requested :post, bs_url("rentals/search"),
-        body: { start_at: "2016-06-15", end_at: "2016-06-30" }.to_json
+        body: { start_at: "2016-12-15", end_at: "2016-12-22" }.to_json
     end
 
     context "rentals ids given" do
+      let(:rental_ids) {
+        find_resources("#{@casette_base_path}_rentals/returns_rentals.yml", "rentals").map { |r| r["id"] }[0..1]
+      }
+
       it "makes a search within given rentals" do
-        rentals = client.rentals_search(ids: [1, 5], start_at: "2016-06-15", end_at: "2016-06-30")
+        rentals = client.rentals_search(ids: rental_ids, start_at: "2016-12-15", end_at: "2016-12-22")
         expect(rentals.size).to eq(1)
-        assert_requested :post, bs_url("rentals/1,5/search"),
-          body: { start_at: "2016-06-15", end_at: "2016-06-30" }.to_json
+        assert_requested :post, bs_url("rentals/#{rental_ids.join(',')}/search"),
+          body: { start_at: "2016-12-15", end_at: "2016-12-22" }.to_json
       end
     end
 
@@ -50,9 +58,23 @@ describe BookingSync::API::Client::Rentals do
   end
 
   describe ".rental", :vcr do
+    let(:prefetched_rental) {
+      find_resource("#{@casette_base_path}_rentals/returns_rentals.yml", "rentals")
+    }
+
     it "returns a single rental" do
-      rental = client.rental(2)
-      expect(rental.name).to eql("0 est")
+      rental = client.rental(prefetched_rental[:id])
+      expect(rental.name).to eq(prefetched_rental[:name])
+      expect(rental).to_not have_key(:availability)
+    end
+
+    context "with additional query params" do
+      it "returns a single rental with defined params" do
+        rental = client.rental(prefetched_rental[:id], include: [:availability, :change_over])
+        expect(rental.name).to eq(prefetched_rental[:name])
+        expect(rental).to have_key(:availability)
+        expect(rental).to have_key(:change_over)
+      end
     end
   end
 
@@ -68,22 +90,26 @@ describe BookingSync::API::Client::Rentals do
     it "returns newly created rental" do
       VCR.use_cassette("BookingSync_API_Client_Rentals/_create_rental/creates_a_new_rental") do
         rental = client.create_rental(attributes)
-        expect(rental.name).to eql("New rental")
-        expect(rental.sleeps).to eql(2)
+        expect(rental.name).to eq("New rental")
+        expect(rental.sleeps).to eq(2)
       end
     end
   end
 
   describe ".edit_rental", :vcr do
+    let(:created_rental_id) {
+      find_resource("#{casette_dir}/BookingSync_API_Client_Rentals/_create_rental/creates_a_new_rental.yml", "rentals")[:id]
+    }
+
     it "updates given rental by ID" do
-      client.edit_rental(2, name: "Updated Rental name")
-      assert_requested :put, bs_url("rentals/2"),
+      client.edit_rental(created_rental_id, name: "Updated Rental name")
+      assert_requested :put, bs_url("rentals/#{created_rental_id}"),
         body: { rentals: [{ name: "Updated Rental name" }] }.to_json
     end
 
     it "returns updated rental" do
       VCR.use_cassette("BookingSync_API_Client_Rentals/_edit_rental/updates_given_rental_by_ID") do
-        rental = client.edit_rental(2, name: "Updated Rental name")
+        rental = client.edit_rental(created_rental_id, name: "Updated Rental name")
         expect(rental).to be_kind_of(BookingSync::API::Resource)
         expect(rental.name).to eq("Updated Rental name")
       end
@@ -91,16 +117,24 @@ describe BookingSync::API::Client::Rentals do
   end
 
   describe ".delete_rental", :vcr do
+    let(:created_rental_id) {
+      find_resource("#{casette_dir}/BookingSync_API_Client_Rentals/_create_rental/creates_a_new_rental.yml", "rentals")[:id]
+    }
+
     it "deletes given rental" do
-      client.delete_rental(4)
-      assert_requested :delete, bs_url("rentals/4")
+      client.delete_rental(created_rental_id)
+      assert_requested :delete, bs_url("rentals/#{created_rental_id}")
     end
   end
 
   describe ".rentals_meta", :vcr do
+    let(:rental_ids) {
+      find_resources("#{@casette_base_path}_rentals/returns_rentals.yml", "rentals").map { |r| r["id"] }
+    }
+
     it "returns meta information about requested rentals" do
-      client.rentals_meta([67, 68])
-      assert_requested :get, bs_url("rentals/67,68/meta")
+      client.rentals_meta(rental_ids)
+      assert_requested :get, bs_url("rentals/#{rental_ids.join(',')}/meta")
     end
 
     it "returns meta information about all rentals" do