bookingsync-api 0.1.2 → 0.1.3

data/spec/bookingsync/api/client/rentals_fees_spec.rb

@@ -34,7 +34,7 @@ describe BookingSync::API::Client::RentalsFees do
     end
 
     it "returns newly created rentals_fee" do
-      VCR.use_cassette('BookingSync_API_Client_RentalsFees/_create_rentals_fee/creates_a_new_rentals_fee') do
+      VCR.use_cassette("BookingSync_API_Client_RentalsFees/_create_rentals_fee/creates_a_new_rentals_fee") do
         rentals_fee = client.create_rentals_fee(rental, attributes)
         expect(rentals_fee.links.fee).to eq 659
         expect(rentals_fee.maximum_bookable).to eq 10

data/spec/bookingsync/api/client/rentals_spec.rb

@@ -57,10 +57,7 @@ describe BookingSync::API::Client::Rentals do
   end
 
   describe ".create_rental", :vcr do
-    let(:attributes) { {
-      name: "New rental",
-      sleeps: 2
-    } }
+    let(:attributes) { { name: "New rental", sleeps: 2 } }
 
     it "creates a new rental" do
       client.create_rental(attributes)
@@ -69,7 +66,7 @@ describe BookingSync::API::Client::Rentals do
     end
 
     it "returns newly created rental" do
-      VCR.use_cassette('BookingSync_API_Client_Rentals/_create_rental/creates_a_new_rental') do
+      VCR.use_cassette("BookingSync_API_Client_Rentals/_create_rental/creates_a_new_rental") do
         rental = client.create_rental(attributes)
         expect(rental.name).to eql("New rental")
         expect(rental.sleeps).to eql(2)
@@ -79,16 +76,16 @@ describe BookingSync::API::Client::Rentals do
 
   describe ".edit_rental", :vcr do
     it "updates given rental by ID" do
-      client.edit_rental(2, name: 'Updated Rental name')
+      client.edit_rental(2, name: "Updated Rental name")
       assert_requested :put, bs_url("rentals/2"),
-        body: { rentals: [{ name: 'Updated Rental name' }] }.to_json
+        body: { rentals: [{ name: "Updated Rental name" }] }.to_json
     end
 
     it "returns updated rental" do
-      VCR.use_cassette('BookingSync_API_Client_Rentals/_edit_rental/updates_given_rental_by_ID') do
-        rental = client.edit_rental(2, name: 'Updated Rental name')
+      VCR.use_cassette("BookingSync_API_Client_Rentals/_edit_rental/updates_given_rental_by_ID") do
+        rental = client.edit_rental(2, name: "Updated Rental name")
         expect(rental).to be_kind_of(BookingSync::API::Resource)
-        expect(rental.name).to eq('Updated Rental name')
+        expect(rental.name).to eq("Updated Rental name")
       end
     end
   end

data/spec/bookingsync/api/client/reviews_spec.rb

@@ -18,20 +18,17 @@ describe BookingSync::API::Client::Reviews do
   end
 
   describe ".create_review", :vcr do
-    let(:attributes) {{
-      comment: "Awesome place",
-      rating: 5
-    }}
+    let(:attributes) { { comment: "Awesome place", rating: 5 } }
     let(:booking) { BookingSync::API::Resource.new(client, id: 1) }
 
     it "creates a new review" do
       client.create_review(booking, attributes)
       assert_requested :post, bs_url("bookings/1/reviews"),
-        body: {reviews: [attributes]}.to_json
+        body: { reviews: [attributes] }.to_json
     end
 
     it "returns newly created review" do
-      VCR.use_cassette('BookingSync_API_Client_Reviews/_create_review/creates_a_new_review') do
+      VCR.use_cassette("BookingSync_API_Client_Reviews/_create_review/creates_a_new_review") do
         review = client.create_review(booking, attributes)
         expect(review.comment).to eql(attributes[:comment])
         expect(review.rating).to eql(attributes[:rating])

data/spec/bookingsync/api/client/seasons_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe BookingSync::API::Client::Seasons do
-
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
   describe ".seasons", :vcr do
@@ -19,21 +18,17 @@ describe BookingSync::API::Client::Seasons do
   end
 
   describe ".create_season", :vcr do
-    let(:attributes) {{
-      name: "New season",
-      ratio: 0.2,
-      minimum_stay: 4
-    }}
+    let(:attributes) { { name: "New season", ratio: 0.2, minimum_stay: 4 } }
     let(:rates_table) { BookingSync::API::Resource.new(client, id: 13) }
 
     it "creates a new season" do
       client.create_season(rates_table, attributes)
       assert_requested :post, bs_url("rates_tables/13/seasons"),
-        body: {seasons: [attributes]}.to_json
+        body: { seasons: [attributes] }.to_json
     end
 
     it "returns newly created season" do
-      VCR.use_cassette('BookingSync_API_Client_Seasons/_create_season/creates_a_new_season') do
+      VCR.use_cassette("BookingSync_API_Client_Seasons/_create_season/creates_a_new_season") do
         season = client.create_season(rates_table, attributes)
         expect(season.name).to eql(attributes[:name])
         expect(season.minimum_stay).to eql(attributes[:minimum_stay])
@@ -52,7 +47,7 @@ describe BookingSync::API::Client::Seasons do
     end
 
     it "returns updated season" do
-      VCR.use_cassette('BookingSync_API_Client_Seasons/_edit_season/updates_given_season_by_ID') do
+      VCR.use_cassette("BookingSync_API_Client_Seasons/_edit_season/updates_given_season_by_ID") do
         season = client.edit_season(6, attributes)
         expect(season).to be_kind_of(BookingSync::API::Resource)
         expect(season.name).to eq(attributes[:name])

data/spec/bookingsync/api/client/sources_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe BookingSync::API::Client::Sources do
-
   let(:client) { BookingSync::API::Client.new(test_access_token) }
 
   describe ".sources", :vcr do
@@ -20,7 +19,7 @@ describe BookingSync::API::Client::Sources do
 
   describe ".create_source", :vcr do
     let(:attributes) {
-      { name: 'New source' }
+      { name: "New source" }
     }
 
     it "creates a new source" do
@@ -30,7 +29,7 @@ describe BookingSync::API::Client::Sources do
     end
 
     it "returns newly created source" do
-      VCR.use_cassette('BookingSync_API_Client_Sources/_create_source/creates_a_new_source') do
+      VCR.use_cassette("BookingSync_API_Client_Sources/_create_source/creates_a_new_source") do
         source = client.create_source(attributes)
         expect(source.name).to eql(attributes[:name])
       end
@@ -39,7 +38,7 @@ describe BookingSync::API::Client::Sources do
 
   describe ".edit_source", :vcr do
     let(:attributes) {
-      { name: 'HomeAway.com' }
+      { name: "HomeAway.com" }
     }
 
     it "updates given source by ID" do
@@ -49,7 +48,7 @@ describe BookingSync::API::Client::Sources do
     end
 
     it "returns updated source" do
-      VCR.use_cassette('BookingSync_API_Client_Sources/_edit_source/updates_given_source_by_ID') do
+      VCR.use_cassette("BookingSync_API_Client_Sources/_edit_source/updates_given_source_by_ID") do
         source = client.edit_source(4, attributes)
         expect(source).to be_kind_of(BookingSync::API::Resource)
         expect(source.name).to eql(attributes[:name])

data/spec/bookingsync/api/client/special_offers_spec.rb

@@ -21,8 +21,8 @@ describe BookingSync::API::Client::SpecialOffers do
     let(:attributes) {
       {
         name: "New special offer",
-        start_at: '2014-04-28',
-        end_at: '2014-05-28',
+        start_at: "2014-04-28",
+        end_at: "2014-05-28",
         discount: 5
       }
     }
@@ -31,11 +31,11 @@ describe BookingSync::API::Client::SpecialOffers do
     it "creates a new special_offer" do
       client.create_special_offer(rental, attributes)
       assert_requested :post, bs_url("rentals/12/special_offers"),
-        body: {special_offers: [attributes]}.to_json
+        body: { special_offers: [attributes] }.to_json
     end
 
     it "returns newly created special_offer" do
-      VCR.use_cassette('BookingSync_API_Client_SpecialOffers/_create_special_offer/creates_a_new_special_offer') do
+      VCR.use_cassette("BookingSync_API_Client_SpecialOffers/_create_special_offer/creates_a_new_special_offer") do
         special_offer = client.create_special_offer(rental, attributes)
         expect(special_offer.name).to eql(attributes[:name])
       end
@@ -44,7 +44,7 @@ describe BookingSync::API::Client::SpecialOffers do
 
   describe ".edit_special_offer", :vcr do
     let(:attributes) {
-      { name: 'Updated special offer' }
+      { name: "Updated special offer" }
     }
 
     it "updates given special_offer by ID" do
@@ -54,7 +54,7 @@ describe BookingSync::API::Client::SpecialOffers do
     end
 
     it "returns updated special_offer" do
-      VCR.use_cassette('BookingSync_API_Client_SpecialOffers/_edit_special_offer/updates_given_special_offer_by_ID') do
+      VCR.use_cassette("BookingSync_API_Client_SpecialOffers/_edit_special_offer/updates_given_special_offer_by_ID") do
         special_offer = client.edit_special_offer(3, attributes)
         expect(special_offer).to be_kind_of(BookingSync::API::Resource)
         expect(special_offer.name).to eq(attributes[:name])

data/spec/bookingsync/api/client/strict_bookings_spec.rb

@@ -35,15 +35,15 @@ describe BookingSync::API::Client::StrictBookings do
     it "creates a booking" do
       client.create_strict_booking(params)
       assert_requested :post, bs_url("strict_bookings"),
-        body: {bookings: [params]}.to_json
+        body: { bookings: [params] }.to_json
     end
 
-     it "returns newly created booking" do
-      VCR.use_cassette('BookingSync_API_Client_StrictBookings/_create_strict_booking/creates_a_booking') do
-        booking = client.create_strict_booking(params)
-        expect(booking.start_at).to eql(Time.parse("2016-01-15 16:00:00 UTC"))
-        expect(booking.end_at).to eql(Time.parse("2016-01-23 10:00:00 UTC"))
-      end
-    end
+    it "returns newly created booking" do
+     VCR.use_cassette("BookingSync_API_Client_StrictBookings/_create_strict_booking/creates_a_booking") do
+       booking = client.create_strict_booking(params)
+       expect(booking.start_at).to eql(Time.parse("2016-01-15 16:00:00 UTC"))
+       expect(booking.end_at).to eql(Time.parse("2016-01-23 10:00:00 UTC"))
+     end
+   end
   end
 end

data/spec/bookingsync/api/client_spec.rb

@@ -29,7 +29,7 @@ describe BookingSync::API::Client do
     before { VCR.turn_off! }
     it "makes a HTTP POST request with body" do
       stub_post("resource")
-      client.post("resource", {key: :value})
+      client.post("resource", key: :value)
       assert_requested :post, bs_url("resource"), body: '{"key":"value"}'
     end
 
@@ -38,7 +38,7 @@ describe BookingSync::API::Client do
         stub_post("resource", status: 422, body: { errors: { country_code:
           ["is required"] } }.to_json)
         expect {
-          client.post("resource", { key: :value })
+          client.post("resource", key: :value)
         }.to raise_error(BookingSync::API::UnprocessableEntity) { |error|
           expect(error.message).to include '{"errors":{"country_code":["is required"]}}'
         }
@@ -50,7 +50,7 @@ describe BookingSync::API::Client do
     before { VCR.turn_off! }
     it "makes a HTTP PUT request with body" do
       stub_put("resource")
-      client.put("resource", {key: :value})
+      client.put("resource", key: :value)
       assert_requested :put, bs_url("resource"), body: '{"key":"value"}'
     end
   end
@@ -67,7 +67,7 @@ describe BookingSync::API::Client do
   describe "#request" do
     context "on response which responds to :resources" do
       it "returns an array of resources" do
-        stub_get("resource", body: {resources: [{name: "Megan"}]}.to_json)
+        stub_get("resource", body: { resources: [{ name: "Megan" }] }.to_json)
         resources = client.request(:get, "resource")
         expect(resources).to be_kind_of(Array)
         expect(resources.first.name).to eq("Megan")
@@ -92,25 +92,25 @@ describe BookingSync::API::Client do
       stub_get("resource")
       client.call(:get, "resource")
       assert_requested :get, bs_url("resource"),
-        headers: {"Authorization" => "Bearer fake-access-token"}
+        headers: { "Authorization" => "Bearer fake-access-token" }
     end
 
     it "requests proper accept header for JSON API" do
       stub_get("resource")
       client.call(:get, "resource")
       assert_requested :get, bs_url("resource"),
-        headers: {"Accept" => "application/vnd.api+json"}
+        headers: { "Accept" => "application/vnd.api+json" }
     end
 
     it "requests sends data with JSON API content type" do
       stub_post("resource")
       client.call(:post, "resource")
       assert_requested :post, bs_url("resource"),
-        headers: {"Content-Type" => "application/vnd.api+json"}
+        headers: { "Content-Type" => "application/vnd.api+json" }
     end
 
     it "returns an Response object of resources" do
-      attributes = {resources: [{name: "Megan"}]}
+      attributes = { resources: [{ name: "Megan" }] }
       stub_post("resource", body: attributes.to_json)
       response = client.call(:post, "resource", attributes)
       expect(response).to be_kind_of(BookingSync::API::Response)
@@ -120,8 +120,8 @@ describe BookingSync::API::Client do
       stub_get("resource", body: {}.to_json)
       response = client.call(:get, "resource")
       assert_requested :get, bs_url("resource"),
-        headers: {"User-Agent" =>
-          "BookingSync API gem v#{BookingSync::API::VERSION}"}
+        headers: { "User-Agent" =>
+          "BookingSync API gem v#{BookingSync::API::VERSION}" }
     end
 
     context "API returns 401" do
@@ -168,7 +168,7 @@ describe BookingSync::API::Client do
           client.get("resource")
         }.to raise_error(BookingSync::API::UnsupportedResponse) { |error|
           expect(error.status).to eql(405)
-          expect(error.headers).to eq({ "content-type" => "application/vnd.api+json" })
+          expect(error.headers).to eq("content-type" => "application/vnd.api+json")
           expect(error.body).to eq("Whoops!")
           expect(error.message).to include("Received unsupported response from BookingSync API")
         }
@@ -207,7 +207,7 @@ describe BookingSync::API::Client do
     context "user passes additional query options" do
       it "constructs url with query options" do
         stub_get("resource?months=12&status=booked,unavailable")
-        client.get("resource", status: [:booked, :unavailable], months: '12')
+        client.get("resource", status: [:booked, :unavailable], months: "12")
         assert_requested :get, bs_url("resource?months=12&status=booked,unavailable")
       end
     end
@@ -241,7 +241,7 @@ describe BookingSync::API::Client do
 
     it "uses logger provided by user" do
       client = BookingSync::API::Client.new(test_access_token, logger: logger)
-      stub_get("resources", body: {"resources" => [{id: 1}, {id: 2}]}.to_json)
+      stub_get("resources", body: { "resources" => [{ id: 1 }, { id: 2 }] }.to_json)
       client.get("resources")
       messages = log.rewind && log.read
       expect(messages).to include("GET https://www.bookingsync.com/api/v3/resources")
@@ -263,7 +263,7 @@ describe BookingSync::API::Client do
     it "logs X-Request-Id from headers" do
       client = BookingSync::API::Client.new(test_access_token, logger: logger)
       stub_get("resources", body: {}.to_json,
-        headers: {'X-Request-Id' => "021bfb82"})
+        headers: { "X-Request-Id" => "021bfb82" })
       client.get("resources")
 
       messages = log.rewind && log.read
@@ -273,9 +273,23 @@ describe BookingSync::API::Client do
 
   describe "#last_response" do
     it "returns last response" do
-      stub_get("resources", body: {meta: {count: 10}, resources: []}.to_json)
+      stub_get("resources", body: { meta: { count: 10 }, resources: [] }.to_json)
       client.get("resources")
       expect(client.last_response.meta).to eql(count: 10)
     end
   end
+
+  context "pagination" do
+    before do
+      stub_get("resources", headers: { "Link" => '<resources?page=2>; rel="next"' }, body: { meta: { text: "first request" }, resources: [] }.to_json)
+      stub_get("resources?page=2", body: { meta: { text: "second request" }, resources: [] }.to_json)
+    end
+
+    describe "#pagination_first_response" do
+      it "returns first response of a paginated call" do
+        client.paginate("resources", auto_paginate: true)
+        expect(client.pagination_first_response.meta).to eql(text: "first request")
+      end
+    end
+  end
 end

data/spec/bookingsync/api/error_spec.rb

@@ -27,8 +27,8 @@ describe BookingSync::API::Error do
   describe "#headers" do
     it "returns response headers" do
       expect { request }.to raise_error(BookingSync::API::Error) { |exception|
-        expect(exception.headers).to eq({"content-type" =>
-          "application/vnd.api+json"})
+        expect(exception.headers).to eq("content-type" =>
+          "application/vnd.api+json")
       }
     end
   end
@@ -36,7 +36,7 @@ describe BookingSync::API::Error do
   describe "#message" do
     it "returns standard exception message" do
       expect { request }.to raise_error(BookingSync::API::Error) { |exception|
-        expect(exception.message).to eq(%Q{BookingSync::API::UnprocessableEntity
+        expect(exception.message).to eq(%{BookingSync::API::UnprocessableEntity
 HTTP status code : 422
 Headers          : {"content-type"=>"application/vnd.api+json"}
 Body             : {"errors":{"name":["can't be blank"]}}})

data/spec/bookingsync/api/relation_spec.rb

@@ -1,12 +1,14 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe BookingSync::API::Relation do
   before { VCR.turn_off! }
   let(:client) { BookingSync::API::Client.new(test_access_token,
-    base_url: "http://example.com") }
-  let(:links) { {"foo.photos" => "http://example.com/photos/{foo.photos}"} }
+    base_url: "http://example.com")
+  }
+  let(:links) { { "foo.photos" => "http://example.com/photos/{foo.photos}" } }
   let(:relation) { BookingSync::API::Relation.new(client, :"foo.photos",
-    "http://example.com/photos/{foo.photos}") }
+    "http://example.com/photos/{foo.photos}")
+  }
 
   describe ".from_links" do
     it "returns a hash of relations" do
@@ -28,7 +30,7 @@ describe BookingSync::API::Relation do
   describe "#get" do
     it "makes a HTTP GET request using call on client" do
       url_template = ::Addressable::Template.new("http://example.com/photos/{foo.photos}")
-      expect(client).to receive(:call).with(:get, url_template, {fields: [:name, :description]}, {})
+      expect(client).to receive(:call).with(:get, url_template, { fields: [:name, :description] }, {})
       relation.get(fields: [:name, :description])
     end
   end
@@ -36,7 +38,7 @@ describe BookingSync::API::Relation do
   describe "#post" do
     it "makes a HTTP POST request using call on client" do
       url_template = ::Addressable::Template.new("http://example.com/photos/{foo.photos}")
-      expect(client).to receive(:call).with(:post, url_template, {fields: [:name, :description]}, {})
+      expect(client).to receive(:call).with(:post, url_template, { fields: [:name, :description] }, {})
       relation.post(fields: [:name, :description])
     end
   end

data/spec/bookingsync/api/resource_spec.rb

@@ -1,22 +1,25 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe BookingSync::API::Resource do
-  let(:links) { {photos: [9, 10]} }
+  let(:links) { { photos: [9, 10] } }
   let(:relation) {
-    BookingSync::API::Relation.from_links(client, {
-      :"foo.photos" => "http://foo.com/photos/{foo.photos}",
-      :"foo.category" => "http://foo.com/categories/{foo.category}",
-      :"foo.article" => "http://foo.com/articles/{foo.taggable.id}"
-    })
+    BookingSync::API::Relation.from_links(client,
+      :"foo.photos" => "http://foo.com/photos/{foo.photos}", # rubocop:disable Style/HashSyntax
+      :"foo.category" => "http://foo.com/categories/{foo.category}", # rubocop:disable Style/HashSyntax
+      :"foo.article" => "http://foo.com/articles/{foo.taggable.id}") # rubocop:disable Style/HashSyntax
   }
   let(:client) { BookingSync::API::Client.new(test_access_token,
-      base_url: "http://foo.com") }
-  let(:data) { {
-    name: "foo", width: 700,
-    links: links,
-    details: {count: 1},
-    id: 10
-  } }
+    base_url: "http://foo.com")
+  }
+  let(:data) do
+    {
+      name: "foo",
+      width: 700,
+      links: links,
+      details: { count: 1 },
+      id: 10
+    }
+  end
   let(:resource) {
     BookingSync::API::Resource.new(client, data, relation, "foo")
   }
@@ -50,35 +53,35 @@ describe BookingSync::API::Resource do
     context "has_many (ids given as an array)" do
       it "fetches an association based on links" do
         stub_request(:get, "http://foo.com/photos/9,10")
-          .to_return(body: {photos: [{file: 'a.jpg'}]}.to_json)
-        expect(resource.photos).to eql([{:file => "a.jpg"}])
+          .to_return(body: { photos: [{ file: "a.jpg" }] }.to_json)
+        expect(resource.photos).to eql([{ file: "a.jpg" }])
       end
     end
 
     context "has_one (id given as a single integer)" do
-      let(:links) { {category: 15} }
+      let(:links) { { category: 15 } }
       it "fetches an association based on links" do
         stub_request(:get, "http://foo.com/categories/15")
-          .to_return(body: {categories: [{name: "Secret one"}]}.to_json)
-        expect(resource.category).to eql([{name: "Secret one"}])
+          .to_return(body: { categories: [{ name: "Secret one" }] }.to_json)
+        expect(resource.category).to eql([{ name: "Secret one" }])
       end
     end
 
     context "polymorphic association" do
       let(:links) do
-       { taggable: { "type" => "Article", "id" => "15" },
+        { taggable: { "type" => "Article", "id" => "15" },
           other_polymorphable: { "type" => "Other", "id" => "15" },
           category: 15  }
       end
       it "fetches association based on links and type" do
         stub_request(:get, "http://foo.com/articles/15")
-          .to_return(body: {articles: [{name: "Secret one"}]}.to_json)
-        expect(resource.taggable).to eql([{name: "Secret one"}])
+          .to_return(body: { articles: [{ name: "Secret one" }] }.to_json)
+        expect(resource.taggable).to eql([{ name: "Secret one" }])
       end
     end
 
     context "when there are not associated ids" do
-      let(:links) { {photos: []} }
+      let(:links) { { photos: [] } }
       it "returns an empty array" do
         expect(resource.photos).to eql([])
       end
@@ -92,12 +95,12 @@ describe BookingSync::API::Resource do
 
     it "passes query option to request" do
       stub_request(:get, "http://foo.com/photos/9,10?fields=description")
-        .to_return(body: {photos: [{file: 'a.jpg'}]}.to_json)
+        .to_return(body: { photos: [{ file: "a.jpg" }] }.to_json)
       resource.photos(fields: :description)
     end
 
     context "when association loaded by eager loading" do
-      let(:data) { {links: links, photos: [{file: 'b.jpg'}]} }
+      let(:data) { { links: links, photos: [{ file: "b.jpg" }] } }
 
       it "doesn't fetch it again" do
         resource.photos
@@ -105,7 +108,7 @@ describe BookingSync::API::Resource do
       end
 
       it "returns previously loaded data" do
-        expect(resource.photos).to eq([{file: 'b.jpg'}])
+        expect(resource.photos).to eq([{ file: "b.jpg" }])
       end
     end
   end