bookingsync-api 0.0.18 → 0.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c4e6cd8678c43838cd16404afda232617573958
-  data.tar.gz: 4bef59232d6e3937eb82633008fe4c659e58a5a8
+  metadata.gz: d3d23970ddeff09666633feb1b63444bdcbfcf0d
+  data.tar.gz: fe419d0219da0c64ef63646603eb485574b88c9a
 SHA512:
-  metadata.gz: 1997f3fcebc513384f814f11971d263e7e502bcd109960ec430687f39203e1d79c1c7e21130a861dee06b29508d4e74340850408fe6d0636bd0e2f0ca927f4ba
-  data.tar.gz: 78a07d18490c529546f4e43c03bf7092599a19838fa47482e524e5043105f3a33b3238718fc305339d159bd3ef97bdaf6e481ccafea377c621f3e87a3a8af456
+  metadata.gz: 3037d88848cf496cf6890bba67386110e518b6cbdc579e078c3280b2b6433befe36b099b0a09a727087eb7b660eee784a181e78688e0bf74f3d19bcad415c6fa
+  data.tar.gz: 0113e5eeccf400446ef71c0722cd6cf40e7b3385963d743c04f61eac6e94f7826eb57f7c16b950174fd05ee62e866ee9fce364a0127e556141a25efb5819a340

data/lib/bookingsync/api/client.rb

@@ -287,9 +287,9 @@ module BookingSync::API
       case response.status
       when 204; nil # destroy/cancel
       when 200..299; response
-      when 401; raise Unauthorized.new
-      when 404; raise NotFound.new
-      when 422; raise UnprocessableEntity.new
+      when 401; raise Unauthorized.new(response)
+      when 404; raise NotFound.new(response)
+      when 422; raise UnprocessableEntity.new(response)
       else raise UnsupportedResponse.new(response)
       end
     end

data/lib/bookingsync/api/error.rb

@@ -1,11 +1,6 @@
 module BookingSync::API
   # Class for rescuing all BS API errors
-  class Error < StandardError; end
-  class Unauthorized < Error; end
-  class UnprocessableEntity < Error; end
-  class NotFound < Error; end
-
-  class UnsupportedResponse < Error
+  class Error < StandardError
     attr_reader :status, :headers, :body
 
     def initialize(response)
@@ -14,11 +9,20 @@ module BookingSync::API
       @body    = response.body
     end
 
-    def message
-      %Q{Received unsupported response from BookingSync API
+    def message(message = self.class)
+      %Q{#{message}
 HTTP status code : #{status}
 Headers          : #{headers}
 Body             : #{body}}
     end
   end
+
+  class Unauthorized < Error; end
+  class UnprocessableEntity < Error; end
+  class NotFound < Error; end
+  class UnsupportedResponse < Error
+    def message
+      super("Received unsupported response from BookingSync API")
+    end
+  end
 end

data/lib/bookingsync/api/version.rb

@@ -1,5 +1,5 @@
 module BookingSync
   module API
-    VERSION = "0.0.18"
+    VERSION = "0.0.19"
   end
 end

data/spec/bookingsync/api/client_spec.rb

@@ -35,10 +35,13 @@ describe BookingSync::API::Client do
 
     context "on 422 response" do
       it "raises UnprocessableEntity exception" do
-        stub_post("resource", status: 422)
+        stub_post("resource", status: 422, body: { errors: { country_code:
+          ["is required"] } }.to_json)
         expect {
-          client.post("resource", {key: :value})
-        }.to raise_error(BookingSync::API::UnprocessableEntity)
+          client.post("resource", { key: :value })
+        }.to raise_error(BookingSync::API::UnprocessableEntity) { |error|
+          expect(error.message).to include '{"errors":{"country_code":["is required"]}}'
+        }
       end
     end
   end
@@ -134,13 +137,14 @@ describe BookingSync::API::Client do
     context "API returns unsupported status code outside 200..299 range" do
       it "raises UnsupportedResponse exception" do
         stub_get("resource", status: 405, body: "Whoops!",
-          headers: {"content-type"=>"application/vnd.api+json"})
+          headers: { "content-type" => "application/vnd.api+json" })
         expect {
           client.get("resource")
         }.to raise_error(BookingSync::API::UnsupportedResponse) { |error|
           expect(error.status).to eql(405)
-          expect(error.headers).to eq({"content-type"=>"application/vnd.api+json"})
+          expect(error.headers).to eq({ "content-type" => "application/vnd.api+json" })
           expect(error.body).to eq("Whoops!")
+          expect(error.message).to include("Received unsupported response from BookingSync API")
         }
       end
     end

data/spec/bookingsync/api/error_spec.rb

@@ -0,0 +1,46 @@
+require "spec_helper"
+
+describe BookingSync::API::Error do
+  let(:client) { BookingSync::API::Client.new(test_access_token) }
+  before do
+    stub_get("resource", status: 422, body:
+      { errors: { name: ["can't be blank"] } }.to_json)
+  end
+  let(:request) { client.get("resource") }
+
+  describe "#status" do
+    it "returns HTTP status of the response" do
+      expect { request }.to raise_error(BookingSync::API::Error) { |exception|
+        expect(exception.status).to eq 422
+      }
+    end
+  end
+
+  describe "#body" do
+    it "returns response body" do
+      expect { request }.to raise_error(BookingSync::API::Error) { |exception|
+        expect(exception.body).to eq '{"errors":{"name":["can\'t be blank"]}}'
+      }
+    end
+  end
+
+  describe "#headers" do
+    it "returns response headers" do
+      expect { request }.to raise_error(BookingSync::API::Error) { |exception|
+        expect(exception.headers).to eq({"content-type" =>
+          "application/vnd.api+json"})
+      }
+    end
+  end
+
+  describe "#message" do
+    it "returns standard exception message" do
+      expect { request }.to raise_error(BookingSync::API::Error) { |exception|
+        expect(exception.message).to eq(%Q{BookingSync::API::UnprocessableEntity
+HTTP status code : 422
+Headers          : {"content-type"=>"application/vnd.api+json"}
+Body             : {"errors":{"name":["can't be blank"]}}})
+      }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bookingsync-api
 version: !ruby/object:Gem::Version
-  version: 0.0.18
+  version: 0.0.19
 platform: ruby
 authors:
 - Sébastien Grosjean
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-23 00:00:00.000000000 Z
+date: 2014-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -148,6 +148,7 @@ files:
 - spec/bookingsync/api/client/seasons_spec.rb
 - spec/bookingsync/api/client/special_offers_spec.rb
 - spec/bookingsync/api/client_spec.rb
+- spec/bookingsync/api/error_spec.rb
 - spec/bookingsync/api/relation_spec.rb
 - spec/bookingsync/api/resource_spec.rb
 - spec/bookingsync/api/response_spec.rb
@@ -271,6 +272,7 @@ test_files:
 - spec/bookingsync/api/client/seasons_spec.rb
 - spec/bookingsync/api/client/special_offers_spec.rb
 - spec/bookingsync/api/client_spec.rb
+- spec/bookingsync/api/error_spec.rb
 - spec/bookingsync/api/relation_spec.rb
 - spec/bookingsync/api/resource_spec.rb
 - spec/bookingsync/api/response_spec.rb